[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

This revision was automatically updated to reflect the committed changes. Closed by commit rG672ed5386024: [codeview] Put !heapallocsite on calls to operator new (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://rev

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

thakis added a comment. Hi, this broke check-clang on mac: http://45.33.8.238/mac/14998/step_7.txt Please take a look, and if it takes a while to fix please revert while you investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80805/new/ ht

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

bader marked an inline comment as done. bader added a comment. In D80932#2074792 , @Anastasia wrote: > I think my biggest problem is that I don't understand how you can just run > C++ libraries on OpenCL devices. If we were able to compile plain C++ for

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/asan-globals.cpp:14 int blacklisted_global; +int __attribute__((section(".foo.bar"))) sectioned_global; /Users/thakis/src/llvm-project/clang/test/CodeGen/asan-globals.cpp:14:28: error: argu

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

thakis added inline comments. Comment at: clang/test/CodeGen/asan-globals.cpp:14 int blacklisted_global; +int __attribute__((section(".foo.bar"))) sectioned_global; nickdesaulniers wrote: > /Users/thakis/src/llvm-project/clang/test/CodeGen/asan-globals.cpp:14:

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul added a comment. This is ready for review. The 2 Clang hip related failure are not caused by this change, and the offending change has been reverted now (http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20200601/323475.html) Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul updated this revision to Diff 268929. jurahul added a comment. Remove {} in ScalarEvolution.cpp to match existing style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 Files: clang/include/clang/A

[PATCH] D81304: [llvm][SveEmitter] Emit the bfloat version of `svld1ro`.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma, stuij, ctetreau. Herald added subscribers: cfe-commits, tschuett. Herald added a reviewer: shafik. Herald added a reviewer: rengolin. Herald added a project: clang. The new SVE builtin type __SVBFloat16_t` is used

[PATCH] D81306: [ASan][Test] Fix globals test for Mach-O

melver created this revision. melver added reviewers: nickdesaulniers, thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use a portable section name, as for the test's purpose any name will do. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81306 F

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

efriedma added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:666 +FirstNonOverlappingEmptyFieldHandled + } FirstNonOverlappingEmptyFieldStatus; + Instead of specifically tracking whether you've found an OverlappingEmpty field, could you

[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

melver added a comment. In D80805#2077396 , @thakis wrote: > Hi, this broke check-clang on mac: http://45.33.8.238/mac/14998/step_7.txt > > Please take a look, and if it takes a while to fix please revert while you > investigate. Sent https://reviews.ll

[PATCH] D81306: [ASan][Test] Fix globals test for Mach-O

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. I patched this in and verified that it fixes the test on a mac I have access to. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81306/new/ https:

[clang] 2dd83a9 - [ASan][Test] Fix globals test for Mach-O

Author: Marco Elver Date: 2020-06-05T23:08:11+02:00 New Revision: 2dd83a923046a5cd9585dbf9f90daeab6c37265c URL: https://github.com/llvm/llvm-project/commit/2dd83a923046a5cd9585dbf9f90daeab6c37265c DIFF: https://github.com/llvm/llvm-project/commit/2dd83a923046a5cd9585dbf9f90daeab6c37265c.diff L

[clang] 0d4e243 - [WebAssembly] Improve clang diagnostics for wasm attributes

Author: Dan Gohman Date: 2020-06-05T14:32:51-07:00 New Revision: 0d4e243456809eabd6914669753eda242b5da4cb URL: https://github.com/llvm/llvm-project/commit/0d4e243456809eabd6914669753eda242b5da4cb DIFF: https://github.com/llvm/llvm-project/commit/0d4e243456809eabd6914669753eda242b5da4cb.diff LO

[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall added a comment. Can we do this conservatively only if something is changed within the function definition, and otherwise respect the global settings? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D8046

[PATCH] D81306: [ASan][Test] Fix globals test for Mach-O

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dd83a923046: [ASan][Test] Fix globals test for Mach-O (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81306/new/ https://reviews.llvm.o

[PATCH] D81178: [FPEnv] Initialization of C++ globals not strictfp aware

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:4348 + /// Query for the use of constrained floating point math + bool isStrictFP() { return Builder.getIsFPConstrained(); } + How is this set that we don't end up also setting it a

[PATCH] D81203: clang-cl: accept -f[no-]data-sections and -f[no-]function-sections

inglorion abandoned this revision. inglorion added a comment. Ok, thanks for clarifying. The benefit this would get us is not having to spell the flags differently depending on whether the frontend is clang or clang-cl. I figured this would fit in with all the -f options we already take and not

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

arsenm created this revision. arsenm added reviewers: rjmccall, jdoerfert, efriedma, t-tye, yaxunl, scott.linder, rnk, spatel, lebedev.ri, nlopes, fhahn, hfinkel, Anastasia. Herald added subscribers: tpr, wdng. Herald added a project: LLVM. This allows tracking the in-memory type of a pointer arg

[PATCH] D81313: Fix handling of constinit thread_locals with a forward-declared type.

jyknight created this revision. jyknight added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. ItaniumCXXABI::usesThreadWrapperFunction calls VarDecl::needsDestruction, which calls QualType::isDestructedType, which checks CXXRecordDecl::hasTrivialDestruct

[clang] ebcbd5b - Set the captures on a CXXRecordDecl representing a lambda closure type

Author: Richard Smith Date: 2020-06-05T16:05:32-07:00 New Revision: ebcbd5ba39c017bb621eefa3175a224aae85ddc8 URL: https://github.com/llvm/llvm-project/commit/ebcbd5ba39c017bb621eefa3175a224aae85ddc8 DIFF: https://github.com/llvm/llvm-project/commit/ebcbd5ba39c017bb621eefa3175a224aae85ddc8.diff

[clang] 825e3bb - PR46209: properly determine whether a copy assignment operator is

Author: Richard Smith Date: 2020-06-05T16:05:32-07:00 New Revision: 825e3bb58082eafa8db87a9034379b88f892ce9d URL: https://github.com/llvm/llvm-project/commit/825e3bb58082eafa8db87a9034379b88f892ce9d DIFF: https://github.com/llvm/llvm-project/commit/825e3bb58082eafa8db87a9034379b88f892ce9d.diff

Re: [clang] c13dd74 - Set the captures on a CXXRecordDecl representing a lambda closure type

On Thu, 4 Jun 2020 at 23:45, Jonas Devlieghere via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hey Richard, > > It appears this broke the lldb bots: > > http://lab.llvm.org:8011/builders/lldb-x86_64-debian > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20549/ > That's not cause

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale added a comment. In D80462#2077569 , @rjmccall wrote: > Can we do this conservatively only if something is changed within the > function definition, and otherwise respect the global settings? I'm not sure I understand what you mean. The

[PATCH] D81315: [Draft] [Prototype] warning for default constructed unique pointer dereferences

vrnithinkumar created this revision. vrnithinkumar added reviewers: vsavchenko, xazax.hun, NoQ. Herald added subscribers: cfe-commits, martong, Charusso, rnkovacs. Herald added a project: clang. This is just a prototype review for my changes since I thought it will be easier to ask code related d

[clang] 1c44ace - Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds after ebcbd5ba39c017bb621eefa3175a224aae85ddc8

Author: Fangrui Song Date: 2020-06-05T16:16:49-07:00 New Revision: 1c44ace1e517f8c852fd2bd1d92c6443b525b2e2 URL: https://github.com/llvm/llvm-project/commit/1c44ace1e517f8c852fd2bd1d92c6443b525b2e2 DIFF: https://github.com/llvm/llvm-project/commit/1c44ace1e517f8c852fd2bd1d92c6443b525b2e2.diff

[PATCH] D81313: Fix handling of constinit thread_locals with a forward-declared type.

rsmith added a comment. Your FIXME is a concern. I think it would be preferable for this function to require as a precondition that the type is complete. If the only call where that isn't true is the call from `ItaniumCXXABI::usesThreadWrapperFunction`, it seems reasonable to perform a complete

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen updated this revision to Diff 268958. ychen added a comment. - Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80944/new/ https://reviews.llvm.org/D80944 Files: clang/lib/Parse/ParsePragma.cpp clang/lib/Parse/ParseStmt.cpp

[PATCH] D80944: Add begin source location for the attributed statement created from PragmaLoopHint decorated loop

ychen marked 4 inline comments as done. ychen added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2941 LoopHintTok.setKind(tok::annot_pragma_loop_hint); -LoopHintTok.setLocation(PragmaName.getLocation()); +LoopHintTok.setLocation(Introducer.Loc);

[PATCH] D80462: Fix floating point math function attributes definition.

rjmccall added a comment. We have a very similar problem with the constrained FP intrinsics where the use of the intrinsics anywhere in a function requires (1) an attribute to be set on the function and (2) all the other code in the function to be emitted with intrinsics. What I've been treati

[clang] 61cd264 - [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

Author: stevewan Date: 2020-06-05T19:55:28-04:00 New Revision: 61cd264068ee77ae4e7a503ecd93f0d9fc6120c8 URL: https://github.com/llvm/llvm-project/commit/61cd264068ee77ae4e7a503ecd93f0d9fc6120c8 DIFF: https://github.com/llvm/llvm-project/commit/61cd264068ee77ae4e7a503ecd93f0d9fc6120c8.diff LOG:

[clang] f39e12a - PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

Author: Richard Smith Date: 2020-06-05T17:13:43-07:00 New Revision: f39e12a06b6018db195848ca1f7bd01bf0240fac URL: https://github.com/llvm/llvm-project/commit/f39e12a06b6018db195848ca1f7bd01bf0240fac DIFF: https://github.com/llvm/llvm-project/commit/f39e12a06b6018db195848ca1f7bd01bf0240fac.diff

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

stevewan added a comment. The unit test failure (`instrprof-gcov-multithread_fork.test`) in pre merge checks is caused by another commit. See http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2205. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

stevewan added a comment. Looks like this has broken the build bot? (see http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2205) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://reviews.llvm.org/D80966

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf39e12a06b60: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under… (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D79378?vs=261963&id=268971#toc Re

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG61cd264068ee: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

efriedma added a comment. On a normal, stack-based machine, there are two ways to pass an aggregate to a function: directly, or indirectly. Directly means something like "byval" or "preallocated": the value of the pointer is not a value the caller can control, but instead refers to some fixed

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

rjmccall added a comment. Most of the generalized optimization properties of this attribute seem to be redundant with existing attributes. What are the properties you're trying to convey exactly? The argument is a pointer to memory of a certain size and alignment, and that memory is known to

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. The recommit again broke tests on mac and windows: http://45.33.8.238/win/17004/step_7.txt http://45.33.8.238/mac/15014/step_7.txt This is like the 8th distinct build break today (most not yours, of course). Let's revert and call it a weekend, and try again next week. R

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

efriedma added a comment. I think the important bit here is that we need to distinguish between the C function types `void f(A)` and `void f(A*)`. If they're both lowered to pointers with the same type, we need an attribute to distinguish them. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks created this revision. aeubanks added reviewers: leonardchan, vitalybuka. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes pr33372.cpp under the new pass manager. ASan adds padding to globals. For example, it will change a {i32, i32, i32} to a {{i32, i32

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. Even fails on some linux bots: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/49595/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Ahip-host-cpu-macros.cu Re-reverted in 2920348063221a0603ee96909536bc480f43a7ac

[PATCH] D81176: [HIP] Add default header and include path

yaxunl added a comment. In D81176#2077333 , @yaxunl wrote: > In D81176#2077319 , @thakis wrote: > > > Still broken: http://45.33.8.238/win/16976/summary.html > > > reverted. > > The difficulty for fixing these failu

[PATCH] D81176: [HIP] Add default header and include path

thakis added a comment. One more example failure: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/16333 (Note I had re-reverted your reland, see the 2 comments above your comment.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8117

[PATCH] D81311: [RFC] LangRef: Define inmem parameter attribute

arsenm added a comment. In D81311#2077868 , @rjmccall wrote: > Most of the generalized optimization properties of this attribute seem to be > redundant with existing attributes. What are the properties you're trying to > convey exactly? The argument is

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks added a comment. This is causing some tests under check-clang to fail, taking a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81323/new/ https://reviews.llvm.org/D81323 ___ cfe-commits m

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

mehdi_amini added a comment. In D81223#2076420 , @rcorcs wrote: > This patch standardizes the use of OptimizationLevel across PassBuilder, > PassManagerBuilder, LTO configuration, and LTO code generators. Even with > this patch, further work is still nee

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid updated this revision to Diff 268991. Tridacnid added a comment. Add (Limit) -= 1 test cases to bugprone-infinite-loop tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 Files: clang-tools-extra/test/clang-tidy/checkers/bugprone-i

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks updated this revision to Diff 268993. aeubanks added a comment. Update some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81323/new/ https://reviews.llvm.org/D81323 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/asa

[PATCH] D81323: Move *San module passes later in the NPM pipeline

aeubanks added a comment. Could you take a look again at the test changes? LTO + sanitizers doesn't work under NPM because [1] never ends up calling the passes registered via registerOptimizerLastEPCallback(). [1] https://github.com/llvm/llvm-project/blob/e429cffd4f228f70c1d9df0e5d77c08590dd976

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

yonghong-song updated this revision to Diff 268995. yonghong-song edited the summary of this revision. yonghong-song added a comment. Herald added subscribers: llvm-commits, hiraditya, aprantl. Herald added a project: LLVM. instead of skipping generating debuginfo for "extern void var_name", do g

<    1   2