[clang-tools-extra] b752a27 - [clangd] Log use of heuristic go-to-def. NFC

Author: Sam McCall Date: 2020-05-25T10:19:34+02:00 New Revision: b752a2743ab0d24d8da5d97c07fbdb996df78b1f URL: https://github.com/llvm/llvm-project/commit/b752a2743ab0d24d8da5d97c07fbdb996df78b1f DIFF: https://github.com/llvm/llvm-project/commit/b752a2743ab0d24d8da5d97c07fbdb996df78b1f.diff LO

[clang-tools-extra] 72c5ea1 - [clangd] Enable cross-file-rename by default.

Author: Haojian Wu Date: 2020-05-25T10:46:57+02:00 New Revision: 72c5ea1d73bb89af6f82c14ddb0b7f4c2510bab7 URL: https://github.com/llvm/llvm-project/commit/72c5ea1d73bb89af6f82c14ddb0b7f4c2510bab7 DIFF: https://github.com/llvm/llvm-project/commit/72c5ea1d73bb89af6f82c14ddb0b7f4c2510bab7.diff LO

[PATCH] D80507: [clangd] Enable cross-file-rename by default.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I suspect we're going to get some complaints from people whose index is perpetually behind and missing files, but this is the tradeoff of the design, we have to accept that or refine (e.

[clang] 447ea9b - [AST] default implementation is possible for non-member functions in C++20.

Author: mydeveloperday Date: 2020-05-25T10:45:12+02:00 New Revision: 447ea9b4f5f562c8fab7d11ecbb10ecd33155d5b URL: https://github.com/llvm/llvm-project/commit/447ea9b4f5f562c8fab7d11ecbb10ecd33155d5b DIFF: https://github.com/llvm/llvm-project/commit/447ea9b4f5f562c8fab7d11ecbb10ecd33155d5b.diff

[PATCH] D80472: [clangd] Add access specifier information to hover contents

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. thanks! LGTM with some minor comments. let me know if you don't have commit access so that i can land this for you. Comment at

[PATCH] D80508: [AST] Fix the source range for TagDecl if there is no matched } brace.

hokein created this revision. hokein added reviewers: sammccall, akyrtzi. Herald added subscribers: usaxena95, kadircet, arphaman, dexonsmith, jkorous, ilya-biryukov. Herald added a project: clang. The AST is preserved when the TagDecl misses a } brace, but the source range seems incorrect (just

[PATCH] D80507: [clangd] Enable cross-file-rename by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG72c5ea1d73bb: [clangd] Enable cross-file-rename by default. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80507/new/ https://reviews.l

[PATCH] D80288: [AST] default implementation is possible for non-member functions in C++2a.

hokein updated this revision to Diff 265978. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80288/new/ https://reviews.llvm.org/D80288 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/Recur

[PATCH] D80509: buildkite test 2

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. goncharov removed subscribers: jkorous, arphaman, kadircet, usaxena95, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80509

[PATCH] D80288: [AST] default implementation is possible for non-member functions in C++2a.

This revision was automatically updated to reflect the committed changes. Closed by commit rG447ea9b4f5f5: [AST] default implementation is possible for non-member functions in C++20. (authored by MyDeveloperDay, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 265985. stuij marked 14 inline comments as done. stuij added a comment. addressed review comments and some related general changes: - renamed IsSoftFloatABI -> IsFloatABISoftFP - split bfloat tests out of arm-mangle-16bit-float.cpp - bfloat shouldn't be checkin

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 265988. stuij added a comment. replanted arg passing test from other patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td

[PATCH] D79711: [ARM][BFloat] Add poly64_t on AArch32.

stuij updated this revision to Diff 265987. stuij added a comment. added testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79711/new/ https://reviews.llvm.org/D79711 Files: clang/include/clang/Basic/TargetBuiltins.h clang/lib/AST/ItaniumMa

[PATCH] D79992: [clangd] Patch PP directives to use stale preambles while building ASTs

kadircet updated this revision to Diff 265995. kadircet marked 5 inline comments as done. kadircet added a comment. - Assert on patch contents, using regexes for main file match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79992/new/ https://revi

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber marked 3 inline comments as done. bernhardmgruber added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:285-302 +SourceLocation End = +expandIfMacroId(ReturnLoc.getSourceRange().getEnd(), SM); +So

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8111 "pointer cannot be cast to type %0">; +def err_cast_to_bfloat : Error<"cannot type-cast to __bf16">; +def err_cast_from_bfloat : Error<"cannot type-cast from __bf16">; --

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

sepavloff updated this revision to Diff 265990. sepavloff edited the summary of this revision. sepavloff added a comment. Updated patch - Removed support for lowering to library call at all. Now it is NFC patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber updated this revision to Diff 265993. bernhardmgruber edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 Files: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp clang-tools

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

adamcz added a comment. Correct me if I'm wrong, but this might lead to a file never being updated in the index, even after edit, right? Let's say you have file a.cpp that includes a.h. a.h has namespace foo { #define EXPAND(foo) whatever #include "b.h" } all nodes from b.h will be inside t

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber created this revision. bernhardmgruber added reviewers: aaron.ballman, JonasToth, Eugene.Zelenko, lebedev.ri. bernhardmgruber added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. bernhardmgruber updated this revision t

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

sammccall added a comment. In D80079#2049459 , @MyDeveloperDay wrote: > I feel like there might something of a concencus forming.. If I take the time > to redo following the suggestions @sammccall do you think you could live with > it? Yeah, LGTM. The

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

klimek added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. MyDeveloperDay wrote: > aaron.ballman wrote: > > MyDeveloperDay wrote: > > > klimek wrote: > > >

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. Foo> P; // This is needed to trigger the above 'const const' bug above: #if 0 #else #endif produces Foo const const> P; This bug is caused by the way clang-format re-parses the code for each conditional that the preprocessor caused (I actually di

[PATCH] D79426: [clangd] Change PreambleOnlyAction with content truncation

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:125 auto ContentsBuffer = llvm::MemoryBuffer::getMemBuffer(Contents); + auto Bounds = + ComputePreambleBo

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:399 - return true; + return; } Non needed. See readability-redundant-control-flow. Comment at: clang-tools-extra/docs

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2024 + if (!ChecksEnabled[CK_MallocChecker] && !ChecksEnabled[CK_NewDeleteChecker]) { +C.a

[PATCH] D78099: [analyzer][RetainCount] Tie diagnostics to osx.cocoa.RetainCount rather then RetainCountBase, for the most part

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LG! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78099/new/ https://reviews.llvm.org/D78099 ___ cfe-commits mailing list cfe-commits@

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 266015. vsavchenko added a comment. Fix a couple more names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py Index: clang/ut

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

krasimir added a comment. I'm happy with this patch! We found a couple of rough edges: - alignment after `?:` and - new formatting of `_ ? _ ? _ : _ : _` patterns is bad These are illustrated as examples D and E below (A, B and C look good to me). `test.cc` is how I'd expect clang-format to be

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 266014. vsavchenko added a comment. Replace deprecated method call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py Index: c

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 266016. vsavchenko added a comment. Fix SATestBuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py clang/utils/analyzer/S

[PATCH] D79961: [PGO] Fix computation of fuction Hash

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:107 + /// This value applies to all error states in ErrorState except FEOF. + /// An EOF+indeterminate state is the same as EOF state. +

[clang] 3c6c2ec - [AMDGPU] Added 'A' constraint for inline assembler

Author: Dmitry Preobrazhensky Date: 2020-05-25T17:47:06+03:00 New Revision: 3c6c2ecd6efa393e7a8422d88e5d4ada0970e47e URL: https://github.com/llvm/llvm-project/commit/3c6c2ecd6efa393e7a8422d88e5d4ada0970e47e DIFF: https://github.com/llvm/llvm-project/commit/3c6c2ecd6efa393e7a8422d88e5d4ada0970e4

[PATCH] D79493: [AMDGPU] Added 'A' constraint for inline assembler

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c6c2ecd6efa: [AMDGPU] Added 'A' constraint for inline assembler (authored by dp). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D79961: [PGO] Fix computation of fuction Hash

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c298c104bfe: [PGO] Fix computation of function Hash (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://revie

[PATCH] D80521: [clangd] Make use of SourceOrder to find first initializer in DefineOutline

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Constructors can have implicit initializers, this was crashing define outline. Make sure we find the fi

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus, martong, balazske. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xaza

[clang] 7c298c1 - [PGO] Fix computation of function Hash

Author: serge-sans-paille Date: 2020-05-25T17:17:29+02:00 New Revision: 7c298c104bfe725d4315926a656263e8a5ac3054 URL: https://github.com/llvm/llvm-project/commit/7c298c104bfe725d4315926a656263e8a5ac3054 DIFF: https://github.com/llvm/llvm-project/commit/7c298c104bfe725d4315926a656263e8a5ac3054.d

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware added a comment. This is an alternative approach to D79704 . The advantage is that we must not duplicate code everywhere where `VarRegion` (and sometimes also `DeclRegion`) is used. The drawback is that after we implement handling of parameter

[clang] ba92b27 - [analyzer] Improved RangeSet::Negate support of unsigned ranges

Author: Denys Petrov Date: 2020-05-25T18:52:22+03:00 New Revision: ba92b274225fc78dc15e8dc0076f71e7a8b5d084 URL: https://github.com/llvm/llvm-project/commit/ba92b274225fc78dc15e8dc0076f71e7a8b5d084 DIFF: https://github.com/llvm/llvm-project/commit/ba92b274225fc78dc15e8dc0076f71e7a8b5d084.diff

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware added a comment. Alternative approach is D80522 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

krasimir added a comment. Unfortunately this introduced a bad regression with ObjC method expressions in `if` bodies: if (argc > 5) [obj func:arg]; is now formatted as: if (argc > 5)[obj func:arg] ; It seems that at this stage of processing it would be non-trivial to distinguish betw

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:399 - return true; + return; } Eugene.Zelenko wrote: > Non needed. See readability-redundant-control-flow. Thx! Comme

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rGba92b274225f: [analyzer] Improved RangeSet::Negate support of unsigned ranges (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7780

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber updated this revision to Diff 266034. bernhardmgruber marked 2 inline comments as done and 2 inline comments as done. bernhardmgruber added a comment. - split code tables in documentation - removed unnecessary return statement CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 3873d0b - Re-commit "[cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake"

Author: Sergej Jaskiewicz Date: 2020-05-25T19:14:54+03:00 New Revision: 3873d0b3d899bb84a5983450dd2d98006c4527e2 URL: https://github.com/llvm/llvm-project/commit/3873d0b3d899bb84a5983450dd2d98006c4527e2 DIFF: https://github.com/llvm/llvm-project/commit/3873d0b3d899bb84a5983450dd2d98006c4527e2.d

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. When preamble contains #undef, indexing code finds the matching #define and uses that during inde

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:435 + /// If the call returns a C++ record type then the region of its return value + // can be retrieved from its construction context. + Optional getReturnValueUnder

[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

baloghadamsoftware updated this revision to Diff 266036. baloghadamsoftware added a comment. `SVal` explanation changed to //Xth parameter// format. Unit test changed: there is redeclaration after the definition now, all test code in raw string. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:550 + +#if __cplusplus > 201703L /* C++2a and later */ + bernhardmgruber wrote: > How do you want to handle these tests which require C+

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

MyDeveloperDay added a comment. > I know that we didn't have a test for this in ObjC land, but the regression > seems severe enough to revert this Sure go ahead, that's the process. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80144/new/ https

[PATCH] D80144: [clang-format] @lefticus just taught the world how to use [[unlikely]] but we forgot to teach clang-format

MyDeveloperDay added a comment. maybe for now we just do if (FormatTok->is(tok::l_square) && !Style.isObjC()) parseSquare(); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80144/new/ https://reviews.llvm.org/D80144 __

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266046. MyDeveloperDay added a comment. Handle more cases, Currently on this case is failing, the preprocess lines are causing multiple replacements which means const gets move more than once. verifyFormat("Foo> P;\n#if 0\n#else\n#endif", "Foo con

[PATCH] D79961: [PGO] Fix computation of fuction Hash

ormris added a comment. There's a few test failures related to this change on the PS4 bot. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68111 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

fpallares added a comment. I've added a couple more inline comments. I've also noticed that we aren't emitting the aliases for unmasked instructions, for instance: (input → output) vnot.v v8, v4, v0.t → vnot.v v8, v4, v0.t ​vnot.v v8, v4 → vxor.vi v8, v4, -1 AFAICT RISC-V doesn'

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

kadircet updated this revision to Diff 266047. kadircet marked 3 inline comments as done. kadircet added a comment. Instead of re-lexing at use time, put macro identifier on correct column while patching and make use of presumed locations at use time. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

aaron.ballman added inline comments. Comment at: clang/lib/AST/Decl.cpp:3169-3175 } else { -if (!getIdentifier()) +const auto *Attr = getAttr(); + +if (!Attr) return 0; +BuiltinID = Attr->getID(); I think this is a bit more clear: ```

[clang] 5bf2409 - [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

Author: stevewan Date: 2020-05-25T13:44:15-04:00 New Revision: 5bf2409a4e4d23018ecffe4eff39988a957e76f7 URL: https://github.com/llvm/llvm-project/commit/5bf2409a4e4d23018ecffe4eff39988a957e76f7 DIFF: https://github.com/llvm/llvm-project/commit/5bf2409a4e4d23018ecffe4eff39988a957e76f7.diff LOG:

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

ldionne added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-atomic-ops.cu:26 + // CHECK: atomicrmw fsub double* {{.*}} monotonic + return __atomic_fetch_sub(p, 1.0, memory_order_relaxed); +} Nitpick, but this should be `1.0L` to be consistent. CH

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

melver updated this revision to Diff 266048. melver added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Address failing tests: - Set -triple for test. - Some existing tests now pass under TSAN, and can be enabled. Repository: rG LLVM Github Monorepo CH

[clang] 2b8d6fa - Revert "[PGO] Fix computation of function Hash"

Author: Benjamin Kramer Date: 2020-05-25T20:14:28+02:00 New Revision: 2b8d6fa0acacba4dee31ed618a5596414b2279d5 URL: https://github.com/llvm/llvm-project/commit/2b8d6fa0acacba4dee31ed618a5596414b2279d5 DIFF: https://github.com/llvm/llvm-project/commit/2b8d6fa0acacba4dee31ed618a5596414b2279d5.dif

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

melver updated this revision to Diff 266054. melver added a comment. -triple -> -target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 Files: clang/lib/Driver/SanitizerArgs.cpp clang/test/CodeGen/sanit

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bf2409a4e4d: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

sammccall updated this revision to Diff 266059. sammccall marked an inline comment as done. sammccall added a comment. Tweak names, style, comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80296/new/ https://reviews.llvm.org/D80296 Files: c

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/test/symbols-modules.test:1 +# Verify that we do not crash and correctly find the definition of a macro that +# was imported from a module and then #undef-ed in preamble. Generally, we prefer t

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

sammccall marked 5 inline comments as done. sammccall added a comment. In D80296#2053189 , @adamcz wrote: > Correct me if I'm wrong, but this might lead to a file never being updated in > the index, even after edit, right? > Let's say you have file a.cpp

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:123 +// Spells directive in \p DirectiveRange while prepending it with \p Prefix. +// Returned string can be used with a #line directive on line \p DirectiveLine > Spells directi

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

melver updated this revision to Diff 266057. melver added a comment. Add missing -target to sanitize-coverage-bounds test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 Files: clang/lib/Driver/Sanitizer

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber updated this revision to Diff 266060. bernhardmgruber added a comment. moved C++20 tests to a new file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 Files: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp

[PATCH] D80198: [clangd] locateMacroAt handles patched macros

sammccall added a comment. (BTW this looks miles better to me, thanks for persistence!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80198/new/ https://reviews.llvm.org/D80198 ___ cfe-commits mailing

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber marked 2 inline comments as done. bernhardmgruber added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:550 + +#if __cplusplus > 201703L /* C++2a and later */ + njames93 wrote: > bern

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille reopened this revision. serge-sans-paille added a subscriber: bkramer. serge-sans-paille added a comment. This revision is now accepted and ready to land. @bkramer rightfully reverted this, faster than I could patch it :-) Here is the patch though, with the updated test case. @h

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266064. serge-sans-paille added a comment. Update profile data hash entries due to hash function update, unless the version used is V1, in which case we keep the buggy behavior for backward compatibility. CHANGES SINCE LAST ACTION https://r

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79322/new/ https://reviews.llvm.org/D79322 ___

[PATCH] D80528: [clang-format][WIP] Run more stability FormatTests

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I think this is a noble effort, assuming all the tests pass as far as I'm concerned this LGTM. How about committing all the ones that pass, then work on the others that don't

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon updated this revision to Diff 266066. Fznamznon added a comment. Herald added a subscriber: sstefan1. Re-implemented diagnostic itself, now only usages of declarations with unsupported types are diagnosed. Generalized approach between OpenMP and SYCL. Repository: rG LLVM Github Monor

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This check finds macro expansions of `DISALLOW_COPY_AND_ASSIGN(Type)` and replaces them with a deleted copy constructor and a deleted assignment operator. Before the `delete` keywor

[PATCH] D80499: Remove obsolete ignore*() matcher uses

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This is *great*, thank you for working on the cleanup! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80499/new/ https://revie

[PATCH] D79961: [PGO] Fix computation of fuction Hash

MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAssignMacroCheck.h:46 + bool isLanguageVersionSupported(const LangOptions &LangOpts) const override { +return LangOpts.CPlusPlus; + } I think che

[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

adamcz marked an inline comment as done. adamcz added a comment. I have no objections to landing this as-is, even if it represents a regression for some evil codebases. A possible solution is to iterate through all the includes in a given file (SourceManager knows that already) and if any of th

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. @hans/ @MaskRay I'm starting to wonder if I should bump the version number of the hash function, so that clang could still read profile data generated before that patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.or

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin updated this revision to Diff 266071. BRevzin marked 2 inline comments as done. BRevzin added a comment. - Explaining the cryptic parentheses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 Files:

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:339 if (!(ArchDefs & ArchDefinePwr9) && (ArchDefs & ArchDefinePpcgr) && llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) { NeHuang wrote: > I think we also need to check

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 266072. serge-sans-paille added a comment. Bump the version number to be compatible with existing profdata, in a similar fashion to v1/v2 transition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7996

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei updated this revision to Diff 266073. lei marked 7 inline comments as done. lei added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 Files: clang/lib/Basic/Targets/

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

stevewan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stevewan added reviewers: ZarkoCA, hubert.reinterpretcast, daltenty. stevewan edited the summary of this revision. Based on comments received in D80415 pertinen

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

stevewan updated this revision to Diff 266070. stevewan added a comment. Fix misalignment caused by tab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532 Files: clang/test/Driver/aix-ld.c Index: clang/tes

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin added inline comments. Comment at: llvm/include/llvm/ADT/DirectedGraph.h:97 + } + friend bool operator!=(const NodeType &M, const NodeType &N) { !(M == N); } jfb wrote: > davidstone wrote: > > Missing `return` > 😱 > > Did this not trigger a diagnosti

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

NeHuang marked an inline comment as done. NeHuang added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:339 if (!(ArchDefs & ArchDefinePwr9) && (ArchDefs & ArchDefinePpcgr) && llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) { l

[PATCH] D80404: [OPENMP50]Initial support for use_device_addr clause.

ABataev updated this revision to Diff 266076. ABataev added a comment. Rebase + cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80404/new/ https://reviews.llvm.org/D80404 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/

[PATCH] D79121: Add nomerge statement attribute to clang

zequanwu closed this revision. zequanwu added a comment. landed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79121/new/ https://reviews.llvm.org/D79121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

stevewan updated this revision to Diff 266081. stevewan added a comment. Pass 'clang-format' checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80532/new/ https://reviews.llvm.org/D80532 Files: clang/test/Driver/aix-ld.c Index: clang/test/

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu updated this revision to Diff 266082. zequanwu retitled this revision from "[MS ABI] Add mangled type for template integer argument" to "[MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral ". zequanwu edited the summary of this revision. zequanwu added

[PATCH] D80532: [NFC] Fix formatting for the 'aix-ld.c' test case.

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added a comment. LGTM with minor comment. Comment at: clang/test/Driver/aix-ld.c:8 -// RUN: --sysroot %S/Inputs/aix_ppc_tree \ -// RUN: | FileCheck --check-prefix=CHECK-LD32 %s // CHECK-L

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre updated this revision to Diff 266083. mgehre marked an inline comment as done. mgehre added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https://reviews.llvm.org/D77572 Files: clang-tools-extra/clang-ti

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre marked 5 inline comments as done. mgehre added a comment. Aaron, thank you very much for taking the time to review this PR. Comment at: clang-tools-extra/clang-tidy/readability/UseAnyOfAllOfCheck.cpp:61 + hasBody(allOf(hasDescendant(returns(true)), +

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 266085. stuij added a comment. add bfloat header test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td clang/include/clang

<    1   2   3   >