[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4827aa4e4a: [ARM][MachineOutliner] Add Machine Outliner support for ARM. (authored by yroux). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ htt

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. ping @tnorth are you planning on fixing this as its currently reverted. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing

[clang] 854f5f3 - [Sema] Teach -Wcast-align to compute an accurate alignment using the

Author: Akira Hatanaka Date: 2020-05-15T00:59:03-07:00 New Revision: 854f5f332af4640d9425e9a94442629e4f5a3f98 URL: https://github.com/llvm/llvm-project/commit/854f5f332af4640d9425e9a94442629e4f5a3f98 DIFF: https://github.com/llvm/llvm-project/commit/854f5f332af4640d9425e9a94442629e4f5a3f98.diff

[clang] 170ac4b - [CSInfo][ISEL] Call site info generation support for Mips

Author: Djordje Todorovic Date: 2020-05-15T10:13:15+02:00 New Revision: 170ac4be3392201d5f5e124e8a1b7d78de3f82c8 URL: https://github.com/llvm/llvm-project/commit/170ac4be3392201d5f5e124e8a1b7d78de3f82c8 DIFF: https://github.com/llvm/llvm-project/commit/170ac4be3392201d5f5e124e8a1b7d78de3f82c8.d

[PATCH] D78105: [CSInfo][ISEL] Call site info generation support for Mips

This revision was automatically updated to reflect the committed changes. Closed by commit rG170ac4be3392: [CSInfo][ISEL] Call site info generation support for Mips (authored by djtodoro). Herald added subscribers: cfe-commits, jrtc27. Herald added a project: clang. Repository: rG LLVM Github M

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG854f5f332af4: [Sema] Teach -Wcast-align to compute an accurate alignment using the alignment… (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D79921: [OpenMP] Fix omp and clang pragmas

hishiguro added a comment. Thank you for your comments. I will check those comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79921/new/ https://reviews.llvm.org/D79921 ___ cfe-commits mailing lis

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

whisperity added inline comments. Comment at: clang/test/Analysis/vla-overflow.c:8 + if (x == BIGINDEX) { +// We expect here that size_t is a 64 bit value. +// Size of this array should be the first to overflow. While it's generally true nowadays, instea

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

sepavloff updated this revision to Diff 264184. sepavloff added a comment. Updated patch - rebased, - corrected documentation, - fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79322/new/ https://reviews.llvm.org/D79322 Files: c

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 264187. DavidSpickett added a comment. Update from arc to hopefully run harbormaster builds again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files: clang/

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

whisperity added a comment. In D79330#2035850 , @balazske wrote: > I was looking at CERT ARR32-C > > "Ensure size arguments for

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264190. kbobyrev marked an inline comment as done. kbobyrev added a comment. Herald added a subscriber: mgorny. Add tests for Protobuf (de)serialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

saiislam updated this revision to Diff 264192. saiislam added a comment. Moved isGPU() from llvm's Triple.h to clang's TargetInfo. Renamed it to isOpenMPGPU() to represent target's compatibility with OpenMP offloading and reduce its scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D79693: [test][ARM][CMSE] Use clang_cc1 in arm_cmse.h tests

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79693/new/ https://reviews.llvm.org/D79693 _

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, owenpan, sylvestre.ledru. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay retitled this revision from "[clang-format] Incorrectly indents [[nodiscard]] attribute fu

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

DmitryPolukhin added a comment. @alexfh and @gribozavr2 friendly ping could you please take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79285/new/ https://reviews.llvm.org/D79285 ___ cfe-commi

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

Abpostelnicu added a comment. @MyDeveloperDay thanks for the patch, I'm gonna run it agains mozilla to see if there is any fallout. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79990/new/ https://reviews.llvm.org/D79990 ___ cfe-commits ma

[PATCH] D79673: Allow 32-bit pointer extensions to be used without -fms-extensions

davezarzycki abandoned this revision. davezarzycki added a comment. I'm going to abandon this change for now. The problem is that the MS extensions are not as pervasive through the language as I wanted. For example, I'd really like them to work on aggregate types. This would allow all of the poi

[PATCH] D79992: [WIP][clangd] Patch PP directives to use stale preambles while building ASTs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet retitled this revision from "[clangd] Patch PP directives to use stale preambles while buildin

[clang-tools-extra] aef778d - [clang-tidy] Fix assertion in RenamerClangTidyChecks

Author: Nathan James Date: 2020-05-15T12:15:35+01:00 New Revision: aef778d4d38e45fd413e7e95919fbb72cde42488 URL: https://github.com/llvm/llvm-project/commit/aef778d4d38e45fd413e7e95919fbb72cde42488 DIFF: https://github.com/llvm/llvm-project/commit/aef778d4d38e45fd413e7e95919fbb72cde42488.diff

[clang] 1a3b801 - [analyzer] SATestBuild.py: Fix handling invalid plists after 2to3 conversion.

Author: Artem Dergachev Date: 2020-05-15T14:27:30+03:00 New Revision: 1a3b801db5afe98718b31ba9a760e06557daccb1 URL: https://github.com/llvm/llvm-project/commit/1a3b801db5afe98718b31ba9a760e06557daccb1 DIFF: https://github.com/llvm/llvm-project/commit/1a3b801db5afe98718b31ba9a760e06557daccb1.dif

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

phosek added a comment. Herald added a reviewer: MaskRay. @scott.linder is actually correct, the reason we write the file is precisely as he described in https://reviews.llvm.org/D79400#2021255. When you use tools like `repo` which branchless checkout, `.git/logs/HEAD` won't exist on initial ch

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added a comment. I understand that `.git/logs/HEAD` acts as a dependency for `vcs_revision_h` target. However, problem here is that cmake fails when it tries to create `.git/logs/HEAD` in read-only filesystem. I had following ideas for solving above issue, 1. Skip creating `.git/logs

[PATCH] D79993: Place control block after AST block in PCM files

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a reviewer: jdoerfert. Herald added a project: clang. dang edited the summary of this revision. This places the control block after the AST block in PCMs so that the AST bl

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 264201. DavidSpickett added a comment. Added target triple as a substitution so the tests don't have to grep for it. (which I didn't manage to verify on Windows in any case) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:72 +// -gcc has lowest priority +// RUN: default_triple=$(%t/clang --version | grep -oP "(?<=Target:\s).*") +// RUN: touch %t/${default_tripl

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

lenary added inline comments. Comment at: llvm/test/CodeGen/RISCV/flt-rounds.ll:23 +; RV64I-NEXT:sd ra, 8(sp) +; RV64I-NEXT:call __flt_rounds +; RV64I-NEXT:ld ra, 8(sp) I'm interested to understand how this function is provided. Is it part of `compil

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

Szelethus added a comment. Alright, I'm up to speed I think, cheers! In D79704#2037100 , @NoQ wrote: > > The code changes make me feel like we're doing a lot of chore (and make it > > super easy to forget checking for parameters explicitly). > > I wouldn

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev updated this revision to Diff 264205. kbobyrev added a comment. Simplify test setup and rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79862/new/ https://reviews.llvm.org/D79862 Files: clang-tools-extra/clangd/in

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

MyDeveloperDay planned changes to this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. let me try that.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79325/new/ https://reviews.llvm.org/D79325

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

MyDeveloperDay added a comment. In D79990#2038207 , @Abpostelnicu wrote: > @MyDeveloperDay thanks for the patch, I'm gonna run it agains mozilla to see > if there is any fallout. I wonder is there a documented way to run clang-format over the gekco sou

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

NoQ added a comment. In D79704#2038257 , @Szelethus wrote: > In D79704#2037100 , @NoQ wrote: > > > > The code changes make me feel like we're doing a lot of chore (and make > > > it super easy to forget checking fo

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. This lets users of PCM get a clean hash of the AST for uniquing based on that. This required looking up implicit modules in the module offset map to be lo

[PATCH] D73037: Add a way to set traversal mode in clang-query

aaron.ballman added a comment. In D73037#1839391 , @aaron.ballman wrote: > There should also be a mention of this in the release notes (especially if > the default behavior winds up changing). It looks like none of the comments in the review have not b

[PATCH] D72531: Set traversal explicitly where needed in tests

aaron.ballman added a comment. In D72531#1845686 , @shafik wrote: > I was looking at the changes to `ASTImporterTest.cpp` and it not obvious to > me how you determined where it was needed. Some of the changes were reasonably obvious to me because they i

[PATCH] D79935: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly

curdeius added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:129 + // } // namespace + // // verylongnamespacenamethatdidnotfitonthepreviouscommenline + if (!(Comment->Next && Comment->Next->is(TT_LineComment))) Nit: typo commen

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.h:1 //===--- TestTU.h - Scratch source files for testing -*- C++-*-===// // This header provides a widely used abstraction and has a clear scope, please don't d

[PATCH] D80001: [RFC/WIP][clang] Fix printing of names of inherited constructors

labath created this revision. labath added reviewers: rsmith, dblaikie. Herald added a subscriber: aprantl. Herald added a project: clang. This is a fairly hacky fix to the following problem: Debug information entries for inherited constructors are emitted with the name of the base class, instead

[clang] 8fa743a - [clang-format] C# property formatting can be controlled by config options

Author: Jonathan Coe Date: 2020-05-15T14:08:40+01:00 New Revision: 8fa743ab82027da443bac050e86b70bcdb78cbee URL: https://github.com/llvm/llvm-project/commit/8fa743ab82027da443bac050e86b70bcdb78cbee DIFF: https://github.com/llvm/llvm-project/commit/8fa743ab82027da443bac050e86b70bcdb78cbee.diff

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

dang added a comment. Should I add the test here or in the clang-scan-deps patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79998/new/ https://reviews.llvm.org/D79998 ___ cfe-commits mailing list c

[PATCH] D72532: Make the ExprMutationAnalyzer explicit about how it traverses the AST

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, assuming that this causes existing tests cover the changes so we don't need new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

jbcoe closed this revision. jbcoe added a comment. Submitted as 8fa743ab82027da443bac050e86b70bcdb78cbee Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79000/new/ https://reviews

[PATCH] D80003: [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, tschuett, dexonsmith. Herald added a project: clang. Adds a command line option "--metrics" that computes and outputs this information at the end of a run. This identifies modules duplicated due to

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:906 // trailing semicolons from other constructs split to several lines. -static bool tokenCanStartNewLine(const clang::Token &Tok) { +static bool tokenCanStartNewLine(const FormatToken *Tok) {

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some documentation nits. Comment at: clang/docs/ReleaseNotes.rst:255 + This means that many uses of the ``ignoringImplicit()`` and similar matc

[clang] 8c24f33 - [IR][BFloat] Add BFloat IR type

Author: Ties Stuij Date: 2020-05-15T14:43:43+01:00 New Revision: 8c24f33158d81d5f4b0c5d27c2f07396f0f1484b URL: https://github.com/llvm/llvm-project/commit/8c24f33158d81d5f4b0c5d27c2f07396f0f1484b DIFF: https://github.com/llvm/llvm-project/commit/8c24f33158d81d5f4b0c5d27c2f07396f0f1484b.diff LO

[PATCH] D80009: [Analyzer][StreamChecker] Changed representation of stream error state - NFC.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. State of error

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

aaron.ballman added a comment. The changes here look reasonable, but can some of this code be simplified to use the default behavior and less complex matchers that don't have to carefully ignore implicit nodes? This would demonstrate that the feature really is an improvement over the status quo

[PATCH] D80008: [clang-format] [PR45942] [[nodiscard]] causes && to be miss interpreted as BinaryOperators

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, JakeMerdichAMD, mitchell-stellar, sylvestre.ledru, Abpostelnicu. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=45942 With Chromium style (although that is not important) it

[PATCH] D78190: Add Bfloat IR type

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8c24f33158d8: [IR][BFloat] Add BFloat IR type (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

MyDeveloperDay updated this revision to Diff 264231. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Change to const & CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79990/new/ https://reviews.llvm.org/D79990 Files: clang/lib/Format/UnwrappedLineParser

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. In D79704#2038280 , @NoQ wrote: > In D79704#2038257 , @Szelethus wrote: > > > In D79704#2037100

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

MyDeveloperDay updated this revision to Diff 264235. MyDeveloperDay added a comment. Use BeforeWhile and not IndentBraces to wrap the line Update the release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79325/new/ https://reviews.llvm.org/D79325 Files: clang/docs/ClangFormatSt

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264236. Tyker marked 12 inline comments as done. Tyker added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/lib/AST/Expr.cpp

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz updated this revision to Diff 264234. Typz added a comment. Fix random crash on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 Files: clang/lib/Format/ContinuationIndenter.cpp clang/lib/Fo

[PATCH] D79990: [clang-format] [PR45614] Incorrectly indents [[nodiscard]] attribute funtions after a macro without semicolon

Abpostelnicu added a comment. Please see https://firefox-source-docs.mozilla.org/code-quality/coding-style/format_cpp_code_with_clang-format.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79990/new/ https://reviews.llvm.org/D79990 ___

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264237. Tyker added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/lib/AST/Expr.cpp clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGBlo

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:6807-6808 +llvm::SaveAndRestore InConstantContext(Info.InConstantContext, true); return StmtVisitorTy::Visit(E->getSubExpr()); } rsmith wrote: > I don't think this is really rig

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264238. Tyker added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/lib/AST/Expr.cpp clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CG

[clang] 4db9409 - clang-format: support aligned nested conditionals formatting

Author: Francois Ferrand Date: 2020-05-15T16:38:25+02:00 New Revision: 4db94094b469b4715d08ef37f1799bf3ea7ca8ea URL: https://github.com/llvm/llvm-project/commit/4db94094b469b4715d08ef37f1799bf3ea7ca8ea DIFF: https://github.com/llvm/llvm-project/commit/4db94094b469b4715d08ef37f1799bf3ea7ca8ea.di

[clang] 0ee04e6 - [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Author: Francois Ferrand Date: 2020-05-15T16:40:31+02:00 New Revision: 0ee04e6e0d0e1c808dc6c70ff7b92b35f960b627 URL: https://github.com/llvm/llvm-project/commit/0ee04e6e0d0e1c808dc6c70ff7b92b35f960b627 DIFF: https://github.com/llvm/llvm-project/commit/0ee04e6e0d0e1c808dc6c70ff7b92b35f960b627.di

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked an inline comment as done. mibintc added a subscriber: Anastasia. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6C

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc updated this revision to Diff 264241. mibintc marked an inline comment as done. mibintc added a comment. This is the same as the previous patch, except I removed the fix for pragma push-pop that John said should be committed separately Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D80003: [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds (Patch series 3/3)

dang updated this revision to Diff 264243. dang added a comment. Updating D80003 : [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds (Patch series 3/3) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc added a subscriber: arsenm. mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat); -

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rG4db94094b469: clang-format: support aligned nested conditionals formatting (authored by Typz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ http

[PATCH] D80014: Turn -Wmax-tokens off by default

hans created this revision. hans added a reviewer: thakis. Herald added a project: clang. On the one hand, one might interpret the use of the max-token pragmas or -fmax-tokens flag as an opt-in to the warning. However, in Chromium we've found it useful to only opt in selected build configuration

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b01b465388b: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id() (authored by yonghong-song). Changed prior to commit: https://reviews.llvm.org/D74572?vs=262140&id=264256#toc Repositor

[PATCH] D80015: [Analyzer][StreamChecker] Added support for 'fread' and 'fwrite'.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Stream function

[PATCH] D80016: [analyzer] StdLibraryFunctionsChecker: Add support to lookup types

martong created this revision. martong added reviewers: xazax.hun, NoQ, Szelethus, balazske. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a projec

[PATCH] D79895: Fix warning about using uninitialized variable as function const reference parameter

aeubanks added a comment. The summary of this change should be "add warning..." not "fix warning..." Could you add more detail into the commit description? About newly introduced diagnostic groups, etc. Also, I thought I saw tests in a previous revision but now they seem to be gone? CHANGES S

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

JakeMerdichAMD updated this revision to Diff 264259. JakeMerdichAMD added a comment. Add a comment explaining why checking IsInsideToken is needed here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79465/new/ https://reviews.llvm.org/D79465 Files

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

amccarth added a comment. I'll re-iterate my opinion that the casts currently required to bypass the warnings are useful (e.g., if you ever want to port the code to 64-bit). There are lots of places where the Windows API essentially required uncomfortable conversions, and we can't paper over a

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

sameerds added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1261 + /// Currently only supports NVPTX and AMDGCN + static bool isOpenMPGPU(llvm::Triple &T) { +return T.isNVPTX() || T.isAMDGCN(); How is "OpenMP-compatible GPU" defined?

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: llvm/test/CodeGen/RISCV/flt-rounds.ll:23 +; RV64I-NEXT:sd ra, 8(sp) +; RV64I-NEXT:call __flt_rounds +; RV64I-NEXT:ld ra, 8(sp) lenary wrote: > I'm interested to u

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

aaron.ballman added a comment. In D78508#2038793 , @amccarth wrote: > I'll re-iterate my opinion that the casts currently required to bypass the > warnings are useful (e.g., if you ever want to port the code to 64-bit). > There are lots of places where

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. According to th

[clang] 072cde0 - [Clang][BPF] implement __builtin_btf_type_id() builtin function

Author: Yonghong Song Date: 2020-05-15T09:44:54-07:00 New Revision: 072cde03aaa13a2c57acf62d79876bf79aa1919f URL: https://github.com/llvm/llvm-project/commit/072cde03aaa13a2c57acf62d79876bf79aa1919f DIFF: https://github.com/llvm/llvm-project/commit/072cde03aaa13a2c57acf62d79876bf79aa1919f.diff

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 264266. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/OpenMPClause.cpp c

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske added a comment. Created new revisions for parts of this change and a bit improved: D80009 and others in "Stack". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78374/new/ https://reviews.llvm.org/D78374

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

This revision was automatically updated to reflect the committed changes. Closed by commit rG072cde03aaa1: [Clang][BPF] implement __builtin_btf_type_id() builtin function (authored by yonghong-song). Changed prior to commit: https://reviews.llvm.org/D74668?vs=261976&id=264273#toc Repository:

[clang] f89f7da - [IR] Convert null-pointer-is-valid into an enum attribute

Author: Nikita Popov Date: 2020-05-15T19:41:07+02:00 New Revision: f89f7da999f362e4213c69923328dd1033276e59 URL: https://github.com/llvm/llvm-project/commit/f89f7da999f362e4213c69923328dd1033276e59 DIFF: https://github.com/llvm/llvm-project/commit/f89f7da999f362e4213c69923328dd1033276e59.diff

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

hans added a comment. > clang issues a warning, leaving no good way to print SIZE_T (other than > disabling warnings or adding useless casts) I also don't think Clang should change here though. The warning is legit for code that cares about portability, and inserting a cast is probably the best

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in the front end

lei created this revision. lei added reviewers: stefanp, nemanjai, amyk, hfinkel, power-llvm-team. Herald added subscribers: shchenz, wuzish. Herald added a project: clang. jsji added a reviewer: PowerPC. jsji added a project: PowerPC. This patch simply adds support for the new CPU in anticipation

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mstorsjo added a reviewer: rnk. mstorsjo added a subscriber: rnk. mstorsjo added a comment. So, using `-l:libunwind.dll.a` is definitely more correct than `-l:libunwind.so` on this platform, so in that sense this is good. In my toolchains I don't use this option at all so far, because I have li

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGf89f7da999f3: [IR] Convert null-pointer-is-valid into an enum attribute (authored by nikic). Changed prior to commit: https://reviews.llvm.org/D78862?vs=261375&id=264285#toc Repository: rG LLVM Githu

[clang] c702d4b - [WebAssembly] Update latest implemented SIMD instructions

Author: Thomas Lively Date: 2020-05-15T10:53:02-07:00 New Revision: c702d4bf4110b65ba7a00daf3af3353ea5b74787 URL: https://github.com/llvm/llvm-project/commit/c702d4bf4110b65ba7a00daf3af3353ea5b74787 DIFF: https://github.com/llvm/llvm-project/commit/c702d4bf4110b65ba7a00daf3af3353ea5b74787.diff

[PATCH] D79973: [WebAssembly] Update latest implemented SIMD instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc702d4bf4110: [WebAssembly] Update latest implemented SIMD instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79973/new/ http

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

scott.linder added a comment. I'd be interested in the answer concerning why we need to avoid `git rev-parse HEAD`; it seems like the cleanest solution is to just always check if `git rev-parse HEAD` changes to determine whether to regenerate the header. If that is not feasible for some reason,

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

tdl-g created this revision. tdl-g added a reviewer: ymandel. Herald added subscribers: cfe-commits, phosek, Charusso, mgorny. Herald added a project: clang. Eugene.Zelenko edited reviewers, added: alexfh, hokein, aaron.ballman, njames93; removed: ymandel. Eugene.Zelenko added a project: clang-too

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mati865 updated this revision to Diff 264292. mati865 added a comment. Applied review comment and formatted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://reviews.llvm.org/D79995 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp Index: clang/lib/Driver/ToolChains

[PATCH] D80001: [RFC/WIP][clang] Fix printing of names of inherited constructors

dblaikie added a comment. @rsmith - this changes printing the name of inherited constructors in general, not just for debug info - could you take a gander and make sure that's probably OK for other callers trying to print the name of an inheriting constructor? Repository: rG LLVM Github Mono

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

JakeMerdichAMD updated this revision to Diff 264294. JakeMerdichAMD added a comment. Rebase to fix merge conflict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79465/new/ https://reviews.llvm.org/D79465 Files: clang/lib/Format/WhitespaceManager.

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

loic-joly-sonarsource created this revision. loic-joly-sonarsource added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. In ASTMatcher, when we have `has(...)` and `hasParent(...)` called with the same internal matcher on the same node, the memoization p

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:18 +#include "clang/Tooling/Transformer/Stencil.h" +#include + asserts are not used. Comment at: clang-tools-extra/clang-tid

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu updated this revision to Diff 264300. zequanwu added a comment. Since the new warning is controlled by `-Wuninitialized`, I disabled it in existing test case and added a separate test case for `-Wuninitialized-const-reference`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D798

[PATCH] D79967: Fix debug info for NoDebug attr

dblaikie added a subscriber: vsk. dblaikie added a comment. Could you check the commit history for this feature and rope in some folks who added the function declaration work (it's for debug call sites) - maybe @vsk is the right person, or knows who is, to check this is the right fix for it/doe

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei updated this revision to Diff 264301. lei added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Add support in llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei updated this revision to Diff 264303. lei retitled this revision from " [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm" to "[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm". lei added a comment. missed a file Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 18a855d - [clang][slh] Add test for SLH feature checking macro

Author: Zola Bridges Date: 2020-05-15T12:23:31-07:00 New Revision: 18a855da431e74499695ce43a8db23a1755ba632 URL: https://github.com/llvm/llvm-project/commit/18a855da431e74499695ce43a8db23a1755ba632 DIFF: https://github.com/llvm/llvm-project/commit/18a855da431e74499695ce43a8db23a1755ba632.diff

  1   2   >