[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___

[PATCH] D79411: [VE] Clang toolchain for VE

simoll updated this revision to Diff 263638. simoll added a comment. - Simplified: stripped down to a basic C GNU Linux toolchain hard-float, no C++ stdlib. - rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.o

[PATCH] D79830: Add support of __builtin_expect_with_probability

lebedev.ri added a reviewer: erichkeane. lebedev.ri added a comment. Thanks for working on this. Please upload patch with full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 263647. hokein added a comment. rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clan

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:72 +// -gcc has lowest priority +// RUN: default_triple=$(%t/clang --version | grep -oP "(?<=Target:\s).*") +// RUN: touch %t/${default_tripl

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett created this revision. DavidSpickett added reviewers: rogfer01, ddunbar, chandlerc. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at:

[PATCH] D79843: [analyzer] Fix crash for non-pointers annotated as nonnull

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Nonnull attribut

[clang] 855f0ce - [analyzer] Fix crash for non-pointers annotated as nonnull

Author: Valeriy Savchenko Date: 2020-05-13T13:36:49+03:00 New Revision: 855f0ce79bf3bdf34a390d1f5fd842a6aa79d5ef URL: https://github.com/llvm/llvm-project/commit/855f0ce79bf3bdf34a390d1f5fd842a6aa79d5ef DIFF: https://github.com/llvm/llvm-project/commit/855f0ce79bf3bdf34a390d1f5fd842a6aa79d5ef.d

[PATCH] D79843: [analyzer] Fix crash for non-pointers annotated as nonnull

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Perfect, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79843/new/ https://reviews.llvm.org/D79843 _

[PATCH] D79843: [analyzer] Fix crash for non-pointers annotated as nonnull

This revision was automatically updated to reflect the committed changes. Closed by commit rG855f0ce79bf3: [analyzer] Fix crash for non-pointers annotated as nonnull (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79843/new/

[clang] 8cbd3f4 - [analyzer] SATestBuild.py: Be defensive against corrupt plist files.

Author: Artem Dergachev Date: 2020-05-13T14:13:00+03:00 New Revision: 8cbd3f431a919e3398683bb5b72fdd781798bcc8 URL: https://github.com/llvm/llvm-project/commit/8cbd3f431a919e3398683bb5b72fdd781798bcc8 DIFF: https://github.com/llvm/llvm-project/commit/8cbd3f431a919e3398683bb5b72fdd781798bcc8.dif

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. I'm sorry for the late review -- please know that this isn't the first time me taking a look, this is a complex issue. I find navigating your phabricator comments a bit difficu

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Yeah, this patch should definitely have unit tests. All similar patches should. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D7970

[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

speidy created this revision. speidy added a reviewer: miyuki. speidy added a project: libunwind. Herald added subscribers: libcxx-commits, llvm-commits, kristof.beyls. Herald added a project: LLVM. Herald added a reviewer: libunwind. speidy edited the summary of this revision. speidy edited the su

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 263686. DavidSpickett added a comment. - Fix spelling - Rework explanatory comments to be a bit clearer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files: clang/lib/Driver/Driver.cpp clang/tes

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:435-442 + const VarDecl *VD; + if (const auto *VR = + dyn_cast(cast(Sym)->getRegion())) { +VD = cast(VR->getDecl()); + } else if (const auto *

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware added a comment. In D79704#2033669 , @Szelethus wrote: > Yeah, this patch should definitely have unit tests. All similar patches > should. I wonder how I could make unit tests for this. I already looked up the unit tests and found no

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. Type checking/value checking for this should happen during Sema, not codegen. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2049 +ConstantFP *Confidence_f = dyn_cast(Confidence); +if (!Confidence_f) { + CGM.Error(E->getArg(2)->getLocStart(

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked 2 inline comments as done. stuij added a comment. @asmith: Thanks for reviewing :) Fixed your suggestions in the coming revision. Comment at: clang/include/clang/AST/ASTContext.h:965 CanQualType HalfTy; // [OpenCL 6.1.1.1], ARM NEON + CanQualType BFloat16Ty; //

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov updated this revision to Diff 263689. ASDenysPetrov added a comment. Updated due to @xazax.hun comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked 9 inline comments as done. baloghadamsoftware added a comment. Than you for your reviews, @NoQ and @Szelethus. In D79704#2032271 , @NoQ wrote: > Blanket reply! `ParamRegion` is not a `DeclRegion` because it does not > necessaril

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. Forgot to ask/add: can you commit this, do you have commit rights? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits

[PATCH] D79856: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

rdwampler created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdwampler abandoned this revision. This allows for suppressing warnings about the conversion function never being called if it overrides a virtual function in a base class. Repository: rG L

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. Joel will help me to commit it. Thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 263696. DavidSpickett added a comment. - Updated test to look for forward or backslash in expected file paths. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79842/new/ https://reviews.llvm.org/D79842 Files: clang/lib/Driver/Driver.cpp cla

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske added a comment. I think this is a expected way of how it works, failure of a stream operation does not necessarily depend on result of a previous operation. So any operation can fail or not, independent of the previous error state (the "ferror" may happen because a temporary disk erro

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

Szelethus added inline comments. Comment at: clang/test/Analysis/vla-overflow.c:10 +// Size of this array should be the first to overflow. +size_t s = sizeof(char[x][x][x][x]); // expected-warning{{Declared variable-length array (VLA) has too large size}} +return s;

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:90 + + TriState GetCmpOpState(size_t CurrentOPIndex, size_t QueriedOPIndex) const { +assert(CurrentOPIndex < CmpOpCount && QueriedOPIndex <= CmpOpCount); I

[PATCH] D67405: Make FormatToken::Type private.

klimek updated this revision to Diff 263707. klimek added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67405/new/ https://reviews.llvm.org/D67405 Files: clang/lib/Format/Format.cpp clang/lib/Format/FormatToken.cpp clang/l

[PATCH] D67405: Make FormatToken::Type private.

klimek updated this revision to Diff 263712. klimek added a comment. Update docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67405/new/ https://reviews.llvm.org/D67405 Files: clang/lib/Format/Format.cpp clang/lib/Format/FormatToken.cpp cl

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. In D79072#2025120 , @martong wrote: > I'd split this patch into two as well. > > 1. [NFC] Refactoring parts > 2. The actual extra additions about

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

fpetrogalli added a comment. Hi @stuij , thank you for working on this. Would it make sense to add a test that includes the header file you have created? Regards, Francesco Comment at: clang/include/clang/Basic/arm_neon_incl.td:293 + + string CartesianProductWith = ""; }

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. YAML serialization was used in the Proof of Concept for simplicity. This patch replaces imple

[clang] 4b53495 - Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

Author: Ronald Wampler Date: 2020-05-13T10:34:19-04:00 New Revision: 4b53495c4ba2ba410f6383f9c57593e838ec0d57 URL: https://github.com/llvm/llvm-project/commit/4b53495c4ba2ba410f6383f9c57593e838ec0d57 DIFF: https://github.com/llvm/llvm-project/commit/4b53495c4ba2ba410f6383f9c57593e838ec0d57.diff

[clang] 53cc90f - Make FormatToken::Type private.

Author: Manuel Klimek Date: 2020-05-13T16:37:58+02:00 New Revision: 53cc90f789996d1e1edc6a9233a85ce8d658aadd URL: https://github.com/llvm/llvm-project/commit/53cc90f789996d1e1edc6a9233a85ce8d658aadd DIFF: https://github.com/llvm/llvm-project/commit/53cc90f789996d1e1edc6a9233a85ce8d658aadd.diff

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1735-1736 + const Stmt *CallSite = SFC->getCallSite(); + if (!CallSite) +return std::make_pair(nullptr, UINT_MAX); + --

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-bf16-getset-intrinsics.c:119-120 +// CHECK-LABEL: test_vduph_laneq_bf16 +// CHECK64: %vgetq_lane = extractelement <8 x bfloat> %v, i32 7 +// CHECK32: %vget_lane = extractelement <8 x bfloat> %v, i32 7 -

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

Xiangling_L added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1300 OPT_maix_struct_return, OPT_msvr4_struct_return)) { +// TODO: We might want to consider enabling these options on AIX in the +// future. --

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 263719. stuij added a comment. changes: - addressed asmith's comments - Bfloat doesn't depend on half cmdline options and correct code is generation for AArch32 hard and softfp CC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. > Variable-length array (VLA) should have a size that fits into a size_t value. > At least if the size is queried with sizeof, but it is better (and more > simple) to check it

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 263720. baloghadamsoftware added a comment. Updated according to the comments from @NoQ. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 Files: clang/include/clang/StaticAnalyzer/Checkers/SValEx

[PATCH] D78444: Perform ActOnConversionDeclarator after looking for any virtual functions it overrides

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b53495c4ba2: Perform ActOnConversionDeclarator after looking for any virtual functions it… (authored by rdwampler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] a1fd188 - [FileCheck] Support comment directives

Author: Joel E. Denny Date: 2020-05-13T11:29:48-04:00 New Revision: a1fd188223d9c9b404dccd3511fe8b63ef022a13 URL: https://github.com/llvm/llvm-project/commit/a1fd188223d9c9b404dccd3511fe8b63ef022a13 DIFF: https://github.com/llvm/llvm-project/commit/a1fd188223d9c9b404dccd3511fe8b63ef022a13.diff

[clang] cf2fb13 - Add -print-targets to print the registered targets

Author: Yaxun (Sam) Liu Date: 2020-05-13T11:34:22-04:00 New Revision: cf2fb139321ca06b5200a88847fabec93ee92d80 URL: https://github.com/llvm/llvm-project/commit/cf2fb139321ca06b5200a88847fabec93ee92d80 DIFF: https://github.com/llvm/llvm-project/commit/cf2fb139321ca06b5200a88847fabec93ee92d80.dif

[PATCH] D79866: [CUDA][HIP] Do not emit debug info for stub function

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Herald added a subscriber: aprantl. Herald added a reviewer: aaron.ballman. The stub function is generated by compiler and its instructions have nothing to do with the kernel source code. Currently clang generates debug info for

[PATCH] D79869: [clangd][BFloat] Add reinterpret cast intrinsics

stuij created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, kristof.beyls. Herald added a project: clang. This patch is part of a series implementing the Bfloat16 extension of the Armv8.6-a architecture, as detailed here: ht

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7899 +if (FpPragmaCurrentLocation.isInvalid()) { + assert(*FpPragmaCurrentValue == SemaObj->FpPragmaStack.DefaultValue && + "Expected a

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov updated this revision to Diff 263739. ASDenysPetrov added a comment. Updated. @xazax.hun you were right. Now it looks more readable. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 Files: clang/lib/StaticAnalyzer/Core/Ra

[PATCH] D79565: Add -print-targets to print the registered targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf2fb139321c: Add -print-targets to print the registered targets (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske marked 2 inline comments as done. balazske added a comment. The intent is to model the fread-fwrite function failure by returning the error value and set the stream into error state. The error state is a composite of **ferror** and **feof**. The questions are now, at what case do these

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/deprecated-copy.cpp:7 +#ifdef NO_USER_PROVIDED +// expected-no-diagnostics +#endif xbolva00 wrote: > xbolva00 wrote: > > Quuxplusone wrote: > > > I'm fairly confident this should just be two differ

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

nikic added a comment. In D75936#2032090 , @craig.topper wrote: > In D75936#2032078 , @sconstab wrote: > > > In D75936#2032027 , @nikic wrote: > > > > > This change causes a

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: clang/test/Frontend/aix-unsupported.c:10 +// RUN: -c %s 2>&1 | FileCheck %s +// CHECK: unsupported option Xiangling_L wrote: > One thing I am not so sure about is that for th

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma, david-arm. Herald added subscribers: cfe-commits, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. fpetrogalli added a parent revision: D79639: [SveEmitter] Builtins for SV

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 263748. baloghadamsoftware added a comment. Herald added a subscriber: mgorny. Unit test added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 Files: clang/include/clang/StaticAnalyzer/Checkers

[PATCH] D79879: [clangd] Change getSymbolID to accept macro location instead of macro info

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a child revision: D79881: [clangd] locateMacroAt returns definition range instead of MacroInfo. Repository: rG LLVM Github

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

SjoerdMeijer added inline comments. Comment at: clang/include/clang/Basic/arm_bf16.td:1 +//===--- arm_fp16.td - ARM FP16 compiler interface ===// +// typo: fp16 - > bf16? Here, and a few more places, or is it intentional? If so, I guess t

[PATCH] D79881: [clangd] locateMacroAt returns definition range instead of MacroInfo

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D79879 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79881 Files: clang

[PATCH] D79869: [clang][BFloat] Add reinterpret cast intrinsics

LukeGeeson added a comment. As I was an author of this patch (among others) please could you add a list of authors to the commit message. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79869/new/ https://reviews.llvm.org/D79869 _

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

ahatanak updated this revision to Diff 263753. ahatanak marked 6 inline comments as done. ahatanak added a comment. Address review comments. Handle derived-to-base cast expressions and array subscript expressions that don't have constant indices. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

LukeGeeson added a comment. I was an author for part of this patch. Please add all authors as a list of authors to this commit message. Thanks! As an aside, it would be worth doing this for all the patches in this series Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

tambre updated this revision to Diff 263759. tambre added a comment. Simplify code, improve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79800/new/ https://reviews.llvm.org/D79800 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

yaxunl added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7899 +if (FpPragmaCurrentLocation.isInvalid()) { + assert(*FpPragmaCurrentValue == SemaObj->FpPragmaStack.DefaultValue && + "Expected a default pragma float_control value"); -

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

martong accepted this revision. martong added a comment. Herald added a subscriber: rnkovacs. In D79072#2026553 , @balazske wrote: > This change is relatively small and the refactoring like part (introduction > of `checkVLA` if I think correct?) is connec

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

Szelethus added a comment. In D78374#2033826 , @balazske wrote: > I think this is a expected way of how it works, failure of a stream operation > does not necessarily depend on result of a previous operation. So any > operation can fail or not, independe

[PATCH] D79830: Add support of __builtin_expect_with_probability

RKSimon added a comment. Add a description in our documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

martong added a comment. In D79330#2026564 , @balazske wrote: > I do not know if it would me **much** cleaner. > > - First part: Move calculation of `ArraySize` into `checkVLA` and rename > `checkVLASize` to `checkVLAIndexSize`. > - Second part: Add the c

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson added a comment. I authored some of the code for this patch, please update the commit message with my name on the list :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 __

[PATCH] D79862: [clangd-remote] Replace YAML serialization with proper Protobuf messages

sammccall added a comment. It's tedious, but we really should have tests for this now. Comment at: clang-tools-extra/clangd/index/remote/Index.proto:68 -// FIXME(kirillbobyrev): Properly serialize symbols and refs instead of passing -// YAML. -message Ref { string yaml_serial

[PATCH] D79830: Add support of __builtin_expect_with_probability

davidxl added a comment. Is it possible to overload __builtin_expect(..)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list cfe-commi

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

martong accepted this revision. martong added a comment. In D79330#2033990 , @Szelethus wrote: > > Variable-length array (VLA) should have a size that fits into a size_t > > value. At least if the size is queried with sizeof, but it is better (and > > mo

[PATCH] D78120: [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

Szelethus added a comment. In D78120#1983756 , @balazske wrote: > LGTM > But a better approach can be to make a new kind of dependency. (Or split the > StreamChecker.) Definitely the latter, I just didn't wanna mess with your project :) But I'd be hap

[clang] b2eb439 - [clang-format] Fix AlignConsecutive on PP blocks

Author: mydeveloperday Date: 2020-05-13T18:31:51+01:00 New Revision: b2eb439317576ce718193763c12bff9fccdfc166 URL: https://github.com/llvm/llvm-project/commit/b2eb439317576ce718193763c12bff9fccdfc166 DIFF: https://github.com/llvm/llvm-project/commit/b2eb439317576ce718193763c12bff9fccdfc166.diff

[clang] c82243d - [clang-format] : Fix additional pointer alignment for overloaded operators

Author: mydeveloperday Date: 2020-05-13T18:33:57+01:00 New Revision: c82243d0675bad130d22a9301d3dc1e7cfb05c2f URL: https://github.com/llvm/llvm-project/commit/c82243d0675bad130d22a9301d3dc1e7cfb05c2f DIFF: https://github.com/llvm/llvm-project/commit/c82243d0675bad130d22a9301d3dc1e7cfb05c2f.diff

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. In D79830#2034400 , @davidxl wrote: > Is it possible to overload __builtin_expect(..)? No OP, but... First, Overloading builtins is a bit of a pain. You end up having to do custom type checking. Second, GCC already made the

[PATCH] D79866: [CUDA][HIP] Do not emit debug info for stub function

tra added a comment. I do not see the behavior the patch is supposed to fix in CUDA. If I compile a simple program, host-side debugger does not see the `kernel`, sees `__device_stub_kernel` and, if the breakpoint is set on `kernel`, it treats it as a yet-to-be-loaded one and does end up breaking

[PATCH] D78120: [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

Szelethus added a comment. In D78120#2034455 , @Szelethus wrote: > In D78120#1983756 , @balazske wrote: > > > LGTM > > But a better approach can be to make a new kind of dependency. (Or split > > the StreamChecker

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13122 +if (Base->isVirtual()) { + BaseAlignment = Ctx.getTypeAlignInChars(Base->getType()); + Offset = CharUnits::Zero(); Oh, this — and all the other places that do presume

[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79852/new/ https://reviews.llvm.org/D79852 ___

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

NoQ added a comment. In D79704#2032947 , @Szelethus wrote: > In D79704#2032271 , @NoQ wrote: > > > Blanket reply! `ParamRegion` is not a `DeclRegion` because it does not > > necessarily have a corresponding `Decl`.

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese added a comment. I mostly just need to rebase this patch now. I'll try to get to that soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351 ___ cfe-co

[PATCH] D79830: Add support of __builtin_expect_with_probability

xbolva00 added a comment. In D79830#2034380 , @RKSimon wrote: > Add a description in our documentation? And Ideally add a note to release notes too.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new

[clang] 7a8edcb - [Clang] Restore replace_path_prefix instead of startswith

Author: Sylvain Audi Date: 2020-05-13T13:49:14-04:00 New Revision: 7a8edcb2124b60941ef6ea4bb4b38a9eb0d70137 URL: https://github.com/llvm/llvm-project/commit/7a8edcb2124b60941ef6ea4bb4b38a9eb0d70137 DIFF: https://github.com/llvm/llvm-project/commit/7a8edcb2124b60941ef6ea4bb4b38a9eb0d70137.diff

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman updated this revision to Diff 263781. arphaman added a comment. fix assertion in the unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79834/new/ https://reviews.llvm.org/D79834 Files: clang/include/clang/Basic/SourceManager.h clang/lib/Basic/SourceManager.cpp cla

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2eb43931757: [clang-format] Fix AlignConsecutive on PP blocks (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https:

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

This revision was automatically updated to reflect the committed changes. Closed by commit rGc82243d0675b: [clang-format] : Fix additional pointer alignment for overloaded operators (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 2a12acd - [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

Author: Kirstóf Umann Date: 2020-05-13T20:05:11+02:00 New Revision: 2a12acda4c9fad4d69dce7a43e99690df357648c URL: https://github.com/llvm/llvm-project/commit/2a12acda4c9fad4d69dce7a43e99690df357648c DIFF: https://github.com/llvm/llvm-project/commit/2a12acda4c9fad4d69dce7a43e99690df357648c.diff

[PATCH] D78190: Add Bfloat IR type

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. Nothing much has changed here: there was already broad consensus on this change and direction, and the last few weeks we have only seen a few rounds of minor comments and nits, so still LGTM. Please wait a day with committing to

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

JakeMerdichAMD added a comment. Thanks for the commit and review @MyDeveloperDay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https://reviews.llvm.org/D79388 ___ cfe-commits mailing list c

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth marked 2 inline comments as done. amccarth added a comment. Made the requested changes after an in-person conversation to clear up my earlier confusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

amccarth updated this revision to Diff 263790. amccarth added a comment. Addressed feedback, specifically: - Distinction is now on CodeView generation rather than -fms-compatibility. - Tests two --std= levels plus the default one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. In D79330#2034414 , @martong wrote: > I am not sure if I can follow your concern here. > `sizeof(size_t)` is typically 8, so that is not a bug, n

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

jkorous added a comment. IIUC the issue is that `SourceManager::translateFile()` basically consists of two blocks of code: // First, check the main file ID, since it is common to look for a // location in the main file. if (MainFileID.isValid()) { bool Invalid = false; const SLocEn

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 263795. dang added a comment. Rebase on top of llvm/master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Frontend/CompilerInvocation.h cla

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with one small comment. Comment at: clang/include/clang/Basic/arm_sve.td:1249 +def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone, "aarch64_s

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 263796. dang added a comment. Upload the right patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td clang/include/clan

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

ahatanak updated this revision to Diff 263792. ahatanak marked an inline comment as done. ahatanak added a comment. Check function types in `DefaultLvalueConversion`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78134/new/ https://reviews.llvm.org

[PATCH] D78120: [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker for the time being

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a12acda4c9f: [analyzer][StreamChecker] Don't make StreamTestChecker depend on StreamChecker… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D79866: [CUDA][HIP] Do not emit debug info for stub function

yaxunl added a comment. In D79866#2034460 , @tra wrote: > I do not see the behavior the patch is supposed to fix in CUDA. > If I compile a simple program, host-side debugger does not see the `kernel`, > sees `__device_stub_kernel` and, if the breakpoint

[PATCH] D79796: [DO NOT REVIEW] Sketch support for generating CC1 command line from CompilerInvocation

dexonsmith added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:162 // The option identifier name. -OS << ", "<< getOptionName(R); +OS << ", " << getOptionName(R); This whitespace fixup LGTM, but you should commit it separat

  1   2   >