[PATCH] D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:878 + [this, VDInit, OriginalAddr, VD, ThisFirstprivateIsLastprivate, + OrigVD, &Lastprivates, IRef, &OMPBuilder]() { // Emit private VarDecl with copy init

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

jdoerfert added a comment. Generally you copied the existing Clang logic, correct? Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:803 - OrigVD); -else - (void)CGM.getOpenMPRuntime().registerTa

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

Szelethus added a comment. In D79704#2032271 , @NoQ wrote: > Blanket reply! `ParamRegion` is not a `DeclRegion` because it does not > necessarily have a corresponding `Decl`. For instance, when calling a > function through an unknown function pointer, yo

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 263582. wxz2020 added a comment. Correct the wrong version of llvm/unittests/Support/TargetParserTest.cpp which causes the test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea updated this revision to Diff 263590. asbirlea marked 3 inline comments as done. asbirlea added a comment. Address comments. Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72893/new/ https://reviews.llvm.org/D72893

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman created this revision. arphaman added a reviewer: jkorous. Herald added subscribers: ributzka, dexonsmith. Herald added a project: clang. [clang][Preprocessor] Replace the slow translateFile call by a new, faster isMainFile check The commit 3c28a2dc6bdc331e5a0d8097a5fa59d06682b9d0

[PATCH] D79835: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

mcgrathr created this revision. mcgrathr added a reviewer: phosek. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Follow the model used on Linux, where the clang driver passes the linker a `-u` switch to force the profile runtime to be linked in

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

kousikk added a comment. @Bigcheese wondering if there are things with respect to testing we can do, to help the patch move forward :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351

[PATCH] D79511: [ObjC] Add compatibility mode for type checking of qualified id block parameters.

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. It looks like you didn't squash your two commits before uploading, so the diff for review now only includes the changes for the comment, not the complete patch. Other than needing to squas

[clang] ad60ff7 - [NFC] Code cleanup in TargetInfo.cpp

Author: Shengchen Kan Date: 2020-05-13T14:48:46+08:00 New Revision: ad60ff70eb56a7d198e613152f9974d5d4baabd4 URL: https://github.com/llvm/llvm-project/commit/ad60ff70eb56a7d198e613152f9974d5d4baabd4 DIFF: https://github.com/llvm/llvm-project/commit/ad60ff70eb56a7d198e613152f9974d5d4baabd4.diff

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

chandlerc added inline comments. Comment at: clang/test/Misc/loop-opt-setup.c:12 +// Check br i1 to make sure that the loop is fully unrolled // CHECK-NOT: br i1 This is dead now that you have different prefixes... Comment at: clang/test/Mis

<    1   2