[PATCH] D68049: Propeller: Clang options for basic block sections

2020-05-05 Thread Han Shen via Phabricator via cfe-commits
shenhan added inline comments. Comment at: lld/ELF/LTO.cpp:80 // Check if basic block sections must be used. // Allowed values for --lto-basicblock-sections are "all", "labels", // "", or none. This is the equivalent Maybe "--lto-basicblock-sections" sh

[PATCH] D78655: [HIP] Add -fhip-lambda-host-device

2020-05-05 Thread Paul Fultz II via Phabricator via cfe-commits
pfultz2 added a comment. > A slight variation on that, that might be better: lambdas with no > lambda-capture are implicitly HD; lambdas with any lambda-capture (which must > therefore have an enclosing function) inherit the enclosing function's HDness. Lambdas should already inherit the enclos

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

2020-05-05 Thread Alex Borcan via Phabricator via cfe-commits
alexbdv updated this revision to Diff 262272. alexbdv marked an inline comment as done. alexbdv edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 Files: clang/lib/AST/Mang

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added reviewers: eugenis, glider. vitalybuka added a comment. This revision now requires changes to proceed. In D79445#2021502 , @aeubanks wrote: > In D79445#2021311

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

2020-05-05 Thread Steve Canon via Phabricator via cfe-commits
scanon accepted this revision. scanon added a comment. This revision is now accepted and ready to land. My concerns have been addressed. Thanks for bearing with me, Melanie! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new/ https://reviews.l

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

2020-05-05 Thread Steve Canon via Phabricator via cfe-commits
scanon added a comment. (Please get one additional sign off before committing; I'm mainly signing off on the numerics model aspect). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new/ https://reviews.llvm.org/D78827 __

[PATCH] D79465: Fix line lengths w/ comments in align

2020-05-05 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. JakeMerdichAMD added a project: clang-format. JakeMerdichAMD added reviewers: MyDeveloperDay, krasimir, VelocityRa, sylvestre.ledru, sammccall, enyquist. JakeMerdichAMD added a comment. Th

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

2020-05-05 Thread Alex Borcan via Phabricator via cfe-commits
alexbdv updated this revision to Diff 262281. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 Files: clang/lib/AST/Mangle.cpp clang/test/CXX/expr/expr.prim/expr.prim.lambda/blocks-irgen.mm clang/test/CodeGen/block-with-perdefinedexpr.cpp c

[PATCH] D79465: Fix line lengths w/ comments in align

2020-05-05 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD added a project: clang-format. JakeMerdichAMD added reviewers: MyDeveloperDay, krasimir, VelocityRa, sylvestre.ledru, sammccall, enyquist. JakeMerdichAMD added a comment. The failing case in this commit looks like the following after formatting (with alignconsecutiveassignments an

[clang] 0fac1c1 - [X86] Allow Yz inline assembly constraint to choose ymm0 or zmm0 when avx/avx512 are enabled and type is 256 or 512 bits

2020-05-05 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-05-05T21:12:30-07:00 New Revision: 0fac1c19128106b6d65d349a5ed22fedacab520c URL: https://github.com/llvm/llvm-project/commit/0fac1c19128106b6d65d349a5ed22fedacab520c DIFF: https://github.com/llvm/llvm-project/commit/0fac1c19128106b6d65d349a5ed22fedacab520c.diff

[clang] 02b3033 - [libclang] Remove duplicate dependency on LLVMSupport

2020-05-05 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-05-05T21:31:07-07:00 New Revision: 02b303321d3f0d3b2c69f68aa25560848dd61f98 URL: https://github.com/llvm/llvm-project/commit/02b303321d3f0d3b2c69f68aa25560848dd61f98 DIFF: https://github.com/llvm/llvm-project/commit/02b303321d3f0d3b2c69f68aa25560848dd61f98.diff LO

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

2020-05-05 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added a comment. Wooot about finally having a test case! (Sorry for nit picking it a bit ) Comment at: llvm/test/Transforms/LoopUnroll/FullUnroll.ll:4-6 +; We don't end up deleting the loop, but we remove everything inside of it so checking for any +; reasonable

[PATCH] D79448: [X86] Allow Yz inline assembly constraint to choose ymm0 or zmm0 when avx/avx512 are enabled and type is 256 or 512 bits

2020-05-05 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0fac1c191281: [X86] Allow Yz inline assembly constraint to choose ymm0 or zmm0 when… (authored by craig.topper). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D79448?v

[PATCH] D79451: [libclang] Remove duplicate dependency on LLVMSupport

2020-05-05 Thread Jan Korous via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG02b303321d3f: [libclang] Remove duplicate dependency on LLVMSupport (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHA

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

2020-05-05 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Sorry for the delayed review here. I'm not the biggest fan of this cos it's encoding knowledge of `llvm_add_library`'s internal behavior (that it creates a `*_static` target if both STATIC

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

2020-05-05 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. LGTM, too. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new/ https://reviews.llvm.org/D78827 ___ cfe-commits mailing list cfe-

[clang] 04bd2c3 - [local-bounds] Ignore volatile operations

2020-05-05 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-05-05T23:08:08-07:00 New Revision: 04bd2c37caf48e79589dbccc486c6ad2541bec7a URL: https://github.com/llvm/llvm-project/commit/04bd2c37caf48e79589dbccc486c6ad2541bec7a DIFF: https://github.com/llvm/llvm-project/commit/04bd2c37caf48e79589dbccc486c6ad2541bec7a.diff L

[PATCH] D78607: [local-bounds] Ignore volatile operations

2020-05-05 Thread Vitaly Buka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG04bd2c37caf4: [local-bounds] Ignore volatile operations (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.l

[PATCH] D78607: [local-bounds] Ignore volatile operations

2020-05-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 262294. vitalybuka marked an inline comment as done. vitalybuka added a comment. add =undefined note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.llvm.org/D78607 Files: clang/d

[PATCH] D72281: [Matrix] Add matrix type to Clang.

2020-05-05 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. > The type of m1 matches the matrix argument in all 3 definitions of use_matrix > and for some reason the return type is not used to disambiguate the > definitions: C++ does not have the ability to use return types to disambiguate function calls. > I am not sure wher

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

2020-05-05 Thread Sam Parker via Phabricator via cfe-commits
samparker accepted this revision. samparker added a comment. This revision is now accepted and ready to land. > Eli said in his comments we don't really need to worry about APCS but only to > linker veneers and I don't think a linker would clear the sticky Q bit or > touch the GE ones. Ah, yes,

<    1   2   3