[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. In D79014#2010746 , @jsji wrote: > Looks like this is causing buildbot failure when built with > `-DBUILD_SHARED_LIBS=ON`. > > http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio

[PATCH] D74813: [RFC] Add hash of block contents to function block names

erik.pilkington edited reviewers, added: rjmccall; removed: libc++abi. erik.pilkington added a comment. In D74813#2010767 , @alexbdv wrote: > @erik.pilkington would the hash-based numbering be OK for now ? Feel free to drop the demangler changes for now,

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. In D78785#2010738 , @erichkeane wrote: > In D78785#2010654 , @rjmccall wrote: > > > Every target does something similar, they just all do it in different ways > > because they're mostly wr

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. See my audit/WIP on calling conventions here: https://reviews.llvm.org/D79118 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___ cf

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. In D79014#2010746 , @jsji wrote: > Looks like this is causing buildbot failure when built with > `-DBUILD_SHARED_LIBS=ON`. > > http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. Ah, sorry, stale tab :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 261003. hliao added a comment. Rebase to trunk and resolve the conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu created this revision. zequanwu added a reviewer: rnk. zequanwu added a project: clang. Herald added a subscriber: cfe-commits. Related to D78659 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79121 Files: clang/include/clang/Basic/

[PATCH] D78762: build: use `find_package(Python3)` if available

thakis added a comment. I believe this breaks check-builtins on macOS. See https://bugs.chromium.org/p/chromium/issues/detail?id=1076480 for details. The `split()` on the subprocess output throws since it wants a b'.' on py3, but that code has an unqualified except block. That means (I think) w

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 261004. DiggerLin marked an inline comment as done. DiggerLin added a comment. take out the functionality of "remove -u from clang" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.ll

[PATCH] D74813: [RFC] Add hash of block contents to function block names

dexonsmith added a comment. In D74813#2010859 , @erik.pilkington wrote: > In D74813#2010767 , @alexbdv wrote: > > > @erik.pilkington would the hash-based numbering be OK for now ? > > > Feel free to drop the demang

[clang-tools-extra] e7a7deb - [clangd] Fix BUILD_SHARED_LIBS build more.

Author: Sam McCall Date: 2020-04-29T22:46:41+02:00 New Revision: e7a7deb60ab0ee4ccd9e1f0de8e164b615344ae2 URL: https://github.com/llvm/llvm-project/commit/e7a7deb60ab0ee4ccd9e1f0de8e164b615344ae2 DIFF: https://github.com/llvm/llvm-project/commit/e7a7deb60ab0ee4ccd9e1f0de8e164b615344ae2.diff LO

[clang] 911add1 - Disable _ExtInt by default

Author: Erich Keane Date: 2020-04-29T13:48:12-07:00 New Revision: 911add149af563a5a61458de0dd730e3f5348623 URL: https://github.com/llvm/llvm-project/commit/911add149af563a5a61458de0dd730e3f5348623 DIFF: https://github.com/llvm/llvm-project/commit/911add149af563a5a61458de0dd730e3f5348623.diff L

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. I think there's more, just running a local shared build so I can catch them (I should really have done this ahead of time). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. Alright then, I've disabled by default(911add149af563a5a61458de0dd730e3f5348623 ). I'll enable 1 at a time as I fix the calling conventions in D79118 . Repository:

[PATCH] D78762: build: use `find_package(Python3)` if available

thakis added a comment. I attempted a fix in e071ea48e923651ae21b9b684b0473248630322c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78762/new/ https://reviews.llvm.org/D78762

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. In D79014#2011034 , @sammccall wrote: > I think there's more, just running a local shared build so I can catch them > (I should really have done this ahead of time). OK, this now builds for me in shared mode after e7a7deb60ab

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @dexonsmith what regression are you referring to ? What this change is effectively doing now is changing the numbering of the blocks from incremental to hash-based. So the demangler functionality remains the same (i think) - I saw that it is ignoring the (currently incr

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + efriedma wrote: > sdesmalen wrote: > > efriedma wrote: > > > I'm vaguely suspicious th

Re: [PATCH] D78853: [Analysis] Fix null pointer dereference warnings [1/n]

My previous email details why we are doing this: http://lists.llvm.org/pipermail/llvm-dev/2020-April/141167.html Basically, we ran the PREfast static analysis tool on LLVM/Clang and it reported a lot of warnings. I guess some of them are false positives after all. As David suggests that maybe I sh

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1143 Style.PenaltyReturnTypeOnItsOwnLine = 1000; + Style.AllowShortEnumsOnASingleLine = (Language != FormatStyle::LK_Cpp); Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None;

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Sorry please adjust the patch to remove the un-related changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 __

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM with minor comment. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2143 + case GlobalValue::AvailableExternallyLinkage: +report_fatal_error("Unhandled AvailableExtern

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 261036. mibintc added a comment. Thanks for your review @sepavloff and @erichkeane, I have responded to your feedback and reverted the name back to reassoc which is what Serge prefers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + sdesmalen wrote: > efriedma wrote: > > sdesmalen wrote: > > > efriedma wrote: > > > > I'm vaguely suspicious this might be wrong fo

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

rnk added a comment. This looks pretty close, let's do one more iteration. Comment at: llvm/include/llvm/IR/InstrTypes.h:1720 + /// Determine if the invoke cannot be tail merged. + bool cannotMerge() const { return hasFnAttr(Attribute::NoMerge); } Let's say

[clang] 5b862b6 - Fix ext-int Sema test that didn't specify a triple.

Author: Erich Keane Date: 2020-04-29T14:34:53-07:00 New Revision: 5b862b6aa7705fdbd893dc5946289631e7b6d662 URL: https://github.com/llvm/llvm-project/commit/5b862b6aa7705fdbd893dc5946289631e7b6d662 DIFF: https://github.com/llvm/llvm-project/commit/5b862b6aa7705fdbd893dc5946289631e7b6d662.diff L

[PATCH] D49890: Clang-Tidy Export Problem

ngzhian added a comment. I found this patch while searching for a similar problem I faced while tryin to use clang-tidy to fix some warnings in V8 (Chrome's JavaScript engine). The setup for our compilation is as such: - basedir - src/ - out/ -arch1/ - .o files, generated files -

[PATCH] D79121: Add nomerge function attribute to clang

rnk added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1799 + let Spellings = [Clang<"nomerge">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [NoMergeDocs]; Clang supports many function-like things that are not functions,

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

Re: [PATCH] D78853: [Analysis] Fix null pointer dereference warnings [1/n]

Am 29.04.20 um 23:11 schrieb Mandeep Singh Grang: > My previous email details why we are doing > this: http://lists.llvm.org/pipermail/llvm-dev/2020-April/141167.html > Basically, we ran the PREfast static analysis tool on LLVM/Clang and > it reported a lot of warnings. I guess some of them are fal

[clang-tools-extra] 30d17d8 - [clangd] Parse `foo` in documentation comments and render as code.

Author: Sam McCall Date: 2020-04-30T00:22:15+02:00 New Revision: 30d17d88528329558b6df22cc9595eae95a9f77c URL: https://github.com/llvm/llvm-project/commit/30d17d88528329558b6df22cc9595eae95a9f77c DIFF: https://github.com/llvm/llvm-project/commit/30d17d88528329558b6df22cc9595eae95a9f77c.diff LO

[libclc] 174c41d - libclc: Pass system libraries to the linker after llvm libraries

Author: Tom Stellard Date: 2020-04-29T15:34:54-07:00 New Revision: 174c41defc63db4ac7594e00a5044672ff624a31 URL: https://github.com/llvm/llvm-project/commit/174c41defc63db4ac7594e00a5044672ff624a31 DIFF: https://github.com/llvm/llvm-project/commit/174c41defc63db4ac7594e00a5044672ff624a31.diff

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

sammccall marked an inline comment as done. sammccall added a comment. Discussed offline, will follow up with fix for spaces and preserving backticks in text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77456/new/ https://reviews.llvm.org/D77456

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

jsji added a comment. Thanks all, yes, it is passing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D79079: [clangd] Make use of URIs in FileShardedIndex

kadircet updated this revision to Diff 261061. kadircet marked 2 inline comments as done. kadircet added a comment. - Update FileSymbols to express keys are not necessarily file paths. - Use Uri for keys of PreambleSymbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 261059. zequanwu marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 Files: llvm/docs/LangRef.rst llvm/include/llvm/Bitcode/LLVMBitCodes.h llvm/include/llvm/IR/Attributes.t

[PATCH] D79079: [clangd] Make use of URIs in FileShardedIndex

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:183 const auto &IGN = IndexIt.getValue(); // Note that sources do not contain any information regarding missing // headers, since we

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

This revision was automatically updated to reflect the committed changes. Closed by commit rG30d17d885283: [clangd] Parse `foo` in documentation comments and render as code. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77456?vs=255010&id=261063#toc Repository:

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

rnk added a comment. I think this looks good, but I would like to get a second opinion from Alina (@asbirlea). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 ___ cfe-commits mailing list cfe-commit

[PATCH] D79079: [clangd] Make use of URIs in FileShardedIndex

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/FileIndex.h:59 +/// A container of slabs associated with a key. It can be updated at key +/// granularity, replacing all

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Old model: chunks are always separated by one space. This makes it impossible to render "Foo `bar`.

[PATCH] D74813: [RFC] Add hash of block contents to function block names

dexonsmith added a comment. In D74813#2011083 , @alexbdv wrote: > @dexonsmith what regression are you referring to ? > What this change is effectively doing now is changing the numbering of the > blocks from incremental to hash-based. > So the demangle

[PATCH] D79142: [clangd] Render doc-comment code spans with `backticks` in plaintext mode

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79142 Files: clang-tools-extra/cla

[PATCH] D79147: [WIP] Merge -debug-info-kind=constructor into -debug-info-kind=limited

akhuang created this revision. Herald added subscribers: lldb-commits, cfe-commits, aprantl. Herald added projects: clang, LLDB. There will be an RFC for this in cfe-dev. This reduces the amount of class debug info emitted in Limited debug info mode. Repository: rG LLVM Github Monorepo https:

[PATCH] D78979: OpenCL: Include builtin header by default

jvesely added a comment. In D78979#2006901 , @yaxunl wrote: > In D78979#2006847 , @arsenm wrote: > > > I'm also wondering if using -nogpulib for the corresponding linker purpose > > was correct, since in the OpenCL

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev added a comment. In D79014#2011034 , @sammccall wrote: > I think there's more, just running a local shared build so I can catch them > (I should really have done this ahead of time). Ah, I've done that (since I primarily build in the shared mod

[PATCH] D77221: [AVR] Rework MCU family detection to support more AVR MCUs

aykevl added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. A thought: should the AVR family be included in the target triple? Like `avr5-unknown-unknown` (similar to `armv6m-none-eabi`, `armv7m-none-eabi`, etc). The different variations do sometimes change the

[PATCH] D79094: [SemaObjC] Warn on visibility attributes on an @implementation

ahatanak added a comment. What if someone wants to use the attribute on either the interface or the implementation but can't modify the header? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79094/new/ https://reviews.llvm.org/D79094 ___ cf

[PATCH] D79094: [SemaObjC] Warn on visibility attributes on an @implementation

ahatanak added a comment. This seems fine to me unless there are cases where the user wants to use it on the implementation. I can't think of a case where that is needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79094/new/ https://reviews.llvm.org/D79094 ___

Buildbot numbers for the last week of 04/12/2020 - 04/18/2020

Hello everyone, Below are some buildbot numbers for the last week of 04/12/2020 - 04/18/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the last week of 04/19/2020 - 04/25/2020

Hello everyone, Below are some buildbot numbers for the last week of 04/19/2020 - 04/25/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[PATCH] D77168: Add a flag to debug automatic variable initialization

jfb added a comment. I think you want to emit a diagnostic any time auto-init doesn't happen because of this new flag. With the code simplification I propose, it would be pretty hard to introduce a regression... and it someone does it wouldn't be a silent one :) Comment at:

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

johnchen902 added a comment. Well... I don't know how to land this. I guess I don't have commit access anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/ https://reviews.llvm.org/D78694 ___ cfe-commits mailing list cfe-commit

[PATCH] D78655: [HIP] Let lambda be host device by default

pfultz2 added a subscriber: AlexVlx. pfultz2 added a comment. > says we capture host variable reference in a device lambda. Is that required to be an error? I know @AlexVlx added support to hcc at one point to capture host variables by reference. So it seems to be possible for it to work correc

[PATCH] D78655: [HIP] Let lambda be host device by default

hliao added a comment. In D78655#2003837 , @yaxunl wrote: > In D78655#2003681 , @hliao wrote: > > > I though the goal of adding HD/D attributes for lambda is to make the > > static check easier as lambda used in de

[PATCH] D78655: [HIP] Let lambda be host device by default

hliao added a comment. In D78655#2011823 , @pfultz2 wrote: > > says we capture host variable reference in a device lambda. > > Is that required to be an error? I know @AlexVlx added support to hcc at one > point to capture host variables by reference. So

[PATCH] D78035: [PoC][RISCV] enable LTO/ThinLTO on RISCV

khchen updated this revision to Diff 261132. khchen retitled this revision from "[PoC][RISCV] enable LTO/ThinLTO on RISCV " to "[PoC][RISCV] enable LTO/ThinLTO on RISCV". khchen edited the summary of this revision. khchen added a comment. Herald added a project: clang. Herald added a subscriber: c

[PATCH] D72281: [Matrix] Add matrix type to Clang.

rjmccall added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1274 + TRY_TO(TraverseType(TL.getTypePtr()->getElementType())); +}) + Might as well do this instead of accumulating the technical debt. MatrixTypeLoc should store the att

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

smeenai added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:52 + // The maximum size depends on size_type used. + static constexpr size_t SizeMax() { +return std::numeric_limits::max(); browneee wrote: > dexonsmith wrote: > > STL data str

<    1   2