[PATCH] D77754: [MS] Fix packed struct layout for arrays of aligned non-record types

2020-04-10 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, so this is basically just saying that the required-alignment-defeats-packed rule looks through arrays? Make sense. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

2020-04-10 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Is the renaming just being done to avoid breakpoints from triggering in the stub? Can you not disable debugging the stub using whatever mechanism `__attribute__((nodebug))` uses? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77743/new/ https://reviews.llvm.o

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

2020-04-10 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. If someone writes up a short proposal for this, with motivation and impact, we'd be happy to present it internally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 _

<    1   2