[PATCH] D77766: [clangd] Set up machinery for gtests of ClangdLSPServer.

sammccall updated this revision to Diff 256449. sammccall marked 12 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77766/new/ https://reviews.llvm.org/D77766 Files: clang

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea marked 2 inline comments as done. asbirlea added a comment. Thank you for all the comments. Comment at: llvm/include/llvm/Support/GenericDomTreeConstruction.h:325 +auto &GD = BUI ? BUI->PreViewCFG : EmptyGD; +return !empty(children({&GD, N})); }

[clang-tools-extra] 1229245 - [clangd] Set up machinery for gtests of ClangdLSPServer.

Author: Sam McCall Date: 2020-04-10T02:50:57+02:00 New Revision: 1229245df7c7323fa916054bf20edc01b3606dd2 URL: https://github.com/llvm/llvm-project/commit/1229245df7c7323fa916054bf20edc01b3606dd2 DIFF: https://github.com/llvm/llvm-project/commit/1229245df7c7323fa916054bf20edc01b3606dd2.diff LO

[PATCH] D77766: [clangd] Set up machinery for gtests of ClangdLSPServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1229245df7c7: [clangd] Set up machinery for gtests of ClangdLSPServer. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77766/new/ htt

[clang] a903749 - [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

Author: Alina Sbirlea Date: 2020-04-09T18:08:39-07:00 New Revision: a90374988e4eb8c50d91e11f4e61cdbd5debb235 URL: https://github.com/llvm/llvm-project/commit/a90374988e4eb8c50d91e11f4e61cdbd5debb235 DIFF: https://github.com/llvm/llvm-project/commit/a90374988e4eb8c50d91e11f4e61cdbd5debb235.diff

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa90374988e4e: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff. (authored by asbirlea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77341/n

[clang] 60c642e - [TLI] Per-function fveclib for math library used for vectorization

Author: Wenlei He Date: 2020-04-09T18:26:38-07:00 New Revision: 60c642e74be6af86906d9f3d982728be7bd4329f URL: https://github.com/llvm/llvm-project/commit/60c642e74be6af86906d9f3d982728be7bd4329f DIFF: https://github.com/llvm/llvm-project/commit/60c642e74be6af86906d9f3d982728be7bd4329f.diff LOG

[PATCH] D77845: [analyzer][CallAndMessage][NFC] Change old callbacks to rely on CallEvent

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, balazske, martong, rnkovacs, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sid

[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Caveats: - only works when the header is changed in the editor and the editor provides the notificat

[PATCH] D77846: [analyzer][CallAndMessage][NFC] Split up checkPreCall

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, balazske, martong, baloghadamsoftware, rnkovacs, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sid

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

This revision was automatically updated to reflect the committed changes. Closed by commit rG60c642e74be6: [TLI] Per-function fveclib for math library used for vectorization (authored by wenlei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77632/ne

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

wenlei updated this revision to Diff 256465. wenlei marked an inline comment as done. wenlei added a comment. rebase, update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77632/new/ https://reviews.llvm.org/D77632 Files: clang/lib/CodeGen/B

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab added inline comments. Comment at: llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp:233 + if (!STI->useLVILoadHardening() || !STI->is64Bit()) +return false; // FIXME: support 32-bit + craig.topper wrote: > sconstab wrote: > > mattdr wrote:

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

stella.stamenova added a comment. It looks like this broke the windows lldb buildbot: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/15542 It already had a test failure, so you probably didn’t get the email. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

Re: [PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

I'm hoping rG5da1671bf823 fixes them. Please let me know if not and I will revert. Alina On Thu, Apr 9, 2020 at 7:03 PM Stella Stamenova via Phabricator < revi...@reviews.llvm.org> wrote: > stella.stamenova added a comment. > > It looks like this broke the windows lldb buildbot: > > lab.llvm.org

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

NoQ added a comment. We're doing much more here than just fixing the CFError behavior; we're actually making the whole analyzer respect these annotations in top frame. Let's add checker-inspecific tests. We have a test checker `debug.ExprInspection` just for that: // RUN: %clang_analyze_cc1

[clang] 17d8334 - [OpenMP] Allow to go first in C++-mode in target regions

Author: Johannes Doerfert Date: 2020-04-09T22:10:31-05:00 New Revision: 17d83342235f01d4b110dc5d4664fe96f6597f11 URL: https://github.com/llvm/llvm-project/commit/17d83342235f01d4b110dc5d4664fe96f6597f11 DIFF: https://github.com/llvm/llvm-project/commit/17d83342235f01d4b110dc5d4664fe96f6597f11.d

[PATCH] D77774: [OpenMP] Allow to go first in C++-mode in target regions

This revision was automatically updated to reflect the committed changes. Closed by commit rG17d83342235f: [OpenMP] Allow to go first in C++-mode in target regions (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

stephanemoore accepted this revision. stephanemoore added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/objc-nsinvocation-argument-lifetime.m:64-69 +- (void)processInvocation:(NSInvocation *)Invocation { + [Invocation getArgument:&Argument atIndex:2];

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

jdoerfert added a comment. In D77683#1970826 , @mehdi_amini wrote: > I am still not sure what "if someone has asked for extra review of a specific > area" refers to? As said earlier >> If I understand this correctly, this is meant to cover situations

[PATCH] D77257: Clean up usages of asserting vector getters in Type

efriedma added inline comments. Comment at: clang/lib/CodeGen/PatternInit.cpp:60 unsigned BitWidth = llvm::APFloat::semanticsSizeInBits( -(Ty->isVectorTy() ? Ty->getVectorElementType() : Ty) +(Ty->isVectorTy() ? cast(Ty)->getElementType() : Ty) -

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

mehdi_amini added a comment. But this sentence alone at the end of this paragraph does not solve anything to me: how is one know that someone in an "area" (whatever that means) is expected to review all the "non-trivial" patches pre-commit? I don't necessarily disagree with your underlying inte

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

dblaikie added a comment. In D77683#1973757 , @jdoerfert wrote: > In D77683#1970826 , @mehdi_amini > wrote: > > > I am still not sure what "if someone has asked for extra review of a > > specific area" refers to?

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

nridge updated this revision to Diff 256502. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76896/new/ https://reviews.llvm.org/D76896 Files: clang-tools-ext

[PATCH] D77545: Represent FP options in AST by special Expression node

sepavloff added a comment. In D77545#1973169 , @rjmccall wrote: > Pragma nodes don't require AST changes to existing nodes, but they require > large changes to a number of clients, If a client is unaware of peculiarities of floating point operations, it

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:157 +resolveConflict(ArrayRef Tokens) { + if (Tokens.size() != 2) +return llvm::None; sammccall wrote: > why a limit of 2, vs a loop? I'm not aware of a scenario wher

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

bondhugula added a comment. @asbirlea This has broken the MLIR build. Could you please build with `-DLLVM_ENABLE_PROJECTS=mlir`? FAILED: tools/mlir/lib/Analysis/CMakeFiles/MLIRAnalysis.dir/Dominance.cpp.o /usr/lib64/ccache/clang++ -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=1 -D_DE

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

hliao updated this revision to Diff 256511. hliao added a comment. Add more comments to explain what that pass does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org/D7 Files: clang/lib/CodeGen/TargetInfo.cpp

[clang] 57d2d48 - Revert "[DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff."

Author: Mehdi Amini Date: 2020-04-10T06:27:59Z New Revision: 57d2d48399b63c0ef1dda490fdaf28efbb80c2c0 URL: https://github.com/llvm/llvm-project/commit/57d2d48399b63c0ef1dda490fdaf28efbb80c2c0 DIFF: https://github.com/llvm/llvm-project/commit/57d2d48399b63c0ef1dda490fdaf28efbb80c2c0.diff LOG: R

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

mehdi_amini added inline comments. Comment at: llvm/include/llvm/Support/GenericDomTree.h:32 #include "llvm/ADT/SmallVector.h" +#include "llvm/IR/CFGDiff.h" #include "llvm/Support/CFGUpdate.h" This looks like a layering violation to me here: I wouldn't expect a

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

mehdi_amini added a comment. In D77341#1973827 , @bondhugula wrote: > @asbirlea This has broken the MLIR build. Could you please build with > `-DLLVM_ENABLE_PROJECTS=mlir`? If you use arcanist, you get pre-merge testing on Phabricator :) Repository:

[PATCH] D77859: Revert "[DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff."

bondhugula created this revision. bondhugula added reviewers: asbirlea, mehdi_amini, rriddle. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. This reverts commit a90374988e4eb8c50d91e11f4e61cdbd5debb235

<    1   2   3