[PATCH] D77534: [clangd] DefineOutline: removes static token from static CXXMethodDecl

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77534/new/ https://reviews.llvm.org/D77534 ___

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

wenlei created this revision. Herald added subscribers: cfe-commits, dexonsmith, hiraditya. Herald added a project: clang. wenlei edited the summary of this revision. wenlei added reviewers: tejohnson, hoyFB, spatel, gchatelet. Encode `-fveclib` setting as per-function attribute so it can be threa

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

wenlei added a comment. In D77484#1965976 , @tejohnson wrote: > In D77484#1965629 , @wenlei wrote: > > > > Ok then it does sound like these could be handled on a per-function > > > basis, similar to how -fno-builti

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t { --

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

sylvestre.ledru added a comment. @lebedev.ri @jdoerfert Looks like it might have caused: https://bugs.llvm.org/show_bug.cgi?id=45453 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77574/new/ https://reviews.llvm.org/D77574 ___

[PATCH] D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding

tambre updated this revision to Diff 255607. tambre marked an inline comment as done. tambre added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77502/new/ https://reviews.llvm.org/D77502 Files: clang/lib/CodeGen/CGExpr

[PATCH] D75364: [clang-format] Handle macros in function params and return value

tamas.petz marked 2 inline comments as done. tamas.petz added a comment. @all, thank you for the review so far. The case I am trying to handle is way too ambiguous. IMHO looking at tokens only is not going to lead to a "perfect" formatter. The case I am trying to handle is quite common but it can

[PATCH] D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding

tambre marked an inline comment as done. tambre added a comment. Updated the comment. Please commit this for me, as I lack commit privileges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77502/new/ https://reviews.llvm.org/D77502 _

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

yutsumi accepted this revision. yutsumi added a comment. This revision is now accepted and ready to land. Thank you very much. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___

[PATCH] D77491: [Sema] Fix incompatible builtin redeclarations in non-global scope

yutsumi added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D77585: Stop passing site cfg files via --param to llvm-lit.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/CMakeLists.txt:113 -set(ANALYZER_TEST_PARAMS - USE_Z3_SOLVER=0) This and ANALYZER_TEST_PARAMS_Z3 are just dropped because they're

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255609. hlopko marked 6 inline comments as done. hlopko added a comment. Adressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:264 + auto *FrontMapping = mappingStartingBeforeSpelled(File, &Spelled.front()); + unsigned SpelledFrontI = &Spelled.front() - File.SpelledTokens.data(); + unsigned ExpandedBegin; gr

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255610. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/Tooling/Syntax/To

[PATCH] D77633: [Parser] Improve diagnostic and error recovery when C++ keywords are used as identifiers.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Previously, clang emitted a less-usefull diagnostic and didnt recover well when the keywords is used as identifier in function paramter. void foo(int case, int x); // previously we drop all paramete

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:218 Opts.StackDepth = CGOpts.SanitizeCoverageStackDepth; - PM.add(createSanitizerCoverageModulePass(Opts)); + PM.add(createSanitizerCoverageModulePass(Opts, CGOpts.SanitizeCoverageWhitelistFiles

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ftynse added a comment. LGTM for MLIR part. Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:60 + } else { emitError(loc) << "expected sequential LLVM types wrapping a scalar"; return nullptr; Nit: can we update the error message not to menti

[PATCH] D77615: [Syntax] Merge overlapping top-level macros in TokenBuffer

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:452 + +// The *last* token of the macro reference is in the main file for A and B. +if (Range.getEnd

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77614/new/ https://reviews.llvm.org/D77614 __

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

kadircet added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:560 + SpelledTokens[NextSpelled].location() < Target) { + // If we know of mapping bounds at [Next, KnownEnd] (e.g. macro expansion) + // then we want to partition our (empty) map

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

sammccall updated this revision to Diff 255618. sammccall added a comment. Crash with a nice message if our loop gets stuck. Looks like ok Token(`void`, void, length = 4) ok Token(`test`, identifier, length = 4) ok Token(`(`, l_paren, length = 1) ok Token(`int`, int, length = 3) ok Tok

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

pratyai updated this revision to Diff 255619. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77244/new/ https://reviews.llvm.org/D77244 Files: llvm/include/llvm/Transforms/Instrumentation.h llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cp

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

sammccall updated this revision to Diff 255621. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77614/new/ https://reviews.llvm.org/D77614 Files: clang/lib/Tooling/Syntax/Tokens.cpp Index: clang/lib/Too

[PATCH] D77615: [Syntax] Merge overlapping top-level macros in TokenBuffer

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:461 + +// If the macro invocation B starts in a macro A but ends in a file, we'll +// create a merged mapping for A & B by overwriting the endpoint

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:588 +auto &NextSpelled = this->NextSpelled[File]; + +if (Tok.location().isFileID()) { kadircet wrote: > nit: maybe create mapping

[clang] 08fab9e - [X86] Fix implicit sign conversion warnings in X86 headers.

Author: Pierre Gousseau Date: 2020-04-07T11:25:08+01:00 New Revision: 08fab9ebecf72a682279d75489dc2460121cbeed URL: https://github.com/llvm/llvm-project/commit/08fab9ebecf72a682279d75489dc2460121cbeed DIFF: https://github.com/llvm/llvm-project/commit/08fab9ebecf72a682279d75489dc2460121cbeed.dif

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

mattdr added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:318 +} +auto *VertexArray = new Node[VertexSize + 1 /* terminator node */]; +auto *EdgeArray = new Edge[EdgeSize]; sconstab wrote: > mattdr wrote: > > sconstab wrote: > > >

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau updated this revision to Diff 255626. pgousseau added a comment. Added label CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 Files: clang/lib/Headers/emmintrin.h clang/lib/Headers/xmmintrin.h clang/test/Headers/x86-header-warning

[PATCH] D77309: [clangd] Get rid of ASTWorker::getCurrentFileInputs

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:459 /// be consumed by clients of ASTWorker. - std::shared_ptr FileInputs; /* GUARDED_BY(Mutex) */ + Parse

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG08fab9ebecf7: [X86] Fix implicit sign conversion warnings in X86 headers. (authored by Pierre Gousseau ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

thakis added inline comments. Comment at: clang/test/Headers/x86-header-warnings.c:3 +// in intrinsic headers. +// Preprocess file to workaround no warnings in system headers. +// RUN: %clang_cc1 %s -triple x86_64-pc-linux-gnu -ffreestanding -E 2>&1 \ Does Wsyste

[clang-tools-extra] 353a988 - [clangd] DefineOutline: removes static token from static CXXMethodDecl

Author: Nathan James Date: 2020-04-07T11:57:43+01:00 New Revision: 353a9883680e9d9666d02516a6692e8319af6d66 URL: https://github.com/llvm/llvm-project/commit/353a9883680e9d9666d02516a6692e8319af6d66 DIFF: https://github.com/llvm/llvm-project/commit/353a9883680e9d9666d02516a6692e8319af6d66.diff

[clang] 3d1424b - Fixed licenses in dynamic ast matchers

Author: Nathan James Date: 2020-04-07T12:08:06+01:00 New Revision: 3d1424bc7a0e9a6f9887727e2bc93a10f50e1709 URL: https://github.com/llvm/llvm-project/commit/3d1424bc7a0e9a6f9887727e2bc93a10f50e1709 DIFF: https://github.com/llvm/llvm-project/commit/3d1424bc7a0e9a6f9887727e2bc93a10f50e1709.diff

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

kadircet added a comment. still LG Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:588 +auto &NextSpelled = this->NextSpelled[File]; + +if (Tok.location().isFileID()) { sammccall wrote: > kadircet wrote: > > nit: maybe create mapping here and increment

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau marked 2 inline comments as done. pgousseau added inline comments. Comment at: clang/test/Headers/x86-header-warnings.c:12 +void test() { + // CHECK-NOT: warning: + _MM_SET_DENORMALS_ZERO_MODE(_MM_DENORMALS_ZERO_ON); RKSimon wrote: > Add a LABEL check

[PATCH] D77309: [clangd] Get rid of ASTWorker::getCurrentFileInputs

kadircet updated this revision to Diff 255632. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77309/new/ https://reviews.llvm.org/D77309 Files: clang-tools-ex

[PATCH] D77534: [clangd] DefineOutline: removes static token from static CXXMethodDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG353a9883680e: [clangd] DefineOutline: removes static token from static CXXMethodDecl (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77

[clang] a010ef8 - Add map-type check for target and target data directive, by Chi Chun

Author: cchen Date: 2020-04-07T07:15:52-04:00 New Revision: a010ef8bd88fe28908c48362b04f59b89ad41250 URL: https://github.com/llvm/llvm-project/commit/a010ef8bd88fe28908c48362b04f59b89ad41250 DIFF: https://github.com/llvm/llvm-project/commit/a010ef8bd88fe28908c48362b04f59b89ad41250.diff LOG: Ad

[clang-tools-extra] 4ac7b80 - [clangd] Get rid of ASTWorker::getCurrentFileInputs

Author: Kadir Cetinkaya Date: 2020-04-07T13:48:00+02:00 New Revision: 4ac7b805b7c4aa7af0a82d6187e3bd6ac0cf38cd URL: https://github.com/llvm/llvm-project/commit/4ac7b805b7c4aa7af0a82d6187e3bd6ac0cf38cd DIFF: https://github.com/llvm/llvm-project/commit/4ac7b805b7c4aa7af0a82d6187e3bd6ac0cf38cd.dif

[clang-tools-extra] 59c2810 - [clangd] Fix printing for Inclusion

Author: Kadir Cetinkaya Date: 2020-04-07T13:48:00+02:00 New Revision: 59c28103a4a4d05db036157605a52a8075d60082 URL: https://github.com/llvm/llvm-project/commit/59c28103a4a4d05db036157605a52a8075d60082 DIFF: https://github.com/llvm/llvm-project/commit/59c28103a4a4d05db036157605a52a8075d60082.dif

[PATCH] D77637: [part 2] sancov/inline-bool-flag clang flags.

pratyai updated this revision to Diff 255638. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77637/new/ https://reviews.llvm.org/D77637 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Dri

[PATCH] D77385: [clangd] Add index export to dexp

sammccall added a comment. Thanks, this looks pretty good! Comment at: clang-tools-extra/clangd/index/YAMLSerialization.cpp:36 namespace { using RefBundle = this is independent of adding the dump command - can we split this into a separate patch? Partly be

[PATCH] D77637: [part 2] sancov/inline-bool-flag clang flags.

pratyai created this revision. pratyai added reviewers: kcc, vitalybuka. Herald added a project: clang. Herald added a subscriber: cfe-commits. pratyai updated this revision to Diff 255638. (must follow part 1: https://reviews.llvm.org/D77244) In the previous part, we implemented the instrumentat

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Herald added a subscriber: yaxunl. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 255641. baloghadamsoftware added a comment. Experimenting... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h clang/incl

[PATCH] D77581: Add map-type check for target and target data directive

This revision was automatically updated to reflect the committed changes. Closed by commit rGa010ef8bd88f: Add map-type check for target and target data directive, by Chi Chun Chen (authored by cchen, committed by ABataev). Changed prior to commit: https://reviews.llvm.org/D77581?vs=255497&id=2

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

Meinersbur added a comment. LGTM, since it continues current practice. `optnone` will always be the more annoying. In D77058#1964714 , @fhahn wrote: > IIUC we don't need a patch similar like this one for optnone, as it already > gets added to the functi

[PATCH] D77309: [clangd] Get rid of ASTWorker::getCurrentFileInputs

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ac7b805b7c4: [clangd] Get rid of ASTWorker::getCurrentFileInputs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77309/new/ https://r

[PATCH] D75364: [clang-format] Handle macros in function params and return value

MyDeveloperDay added a comment. Did you try putting 'ElfW and 'M' in the list of TypenameMacros? --- Language: Cpp BasedOnStyle: LLVM TypenameMacros: ['ElfW'] PointerAlignment: Left const ElfW(Addr)* foo(ElfW(Addr)* addr); const M(Addr) * foo(M(Addr) * addr); $ clang-format

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Any idea for `LazyCompoundVal` parameters of functions not inlined? Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:231-235 +if (dyn_cast_or_null(LCtx->getParentMap().ge

[clang] 448b777 - Stop passing site cfg files via --param to llvm-lit.

Author: Nico Weber Date: 2020-04-07T08:20:40-04:00 New Revision: 448b777b864a312e3b2ceae1e0cd59752a1fe90e URL: https://github.com/llvm/llvm-project/commit/448b777b864a312e3b2ceae1e0cd59752a1fe90e DIFF: https://github.com/llvm/llvm-project/commit/448b777b864a312e3b2ceae1e0cd59752a1fe90e.diff LO

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus accepted this revision. Szelethus added a comment. Whoo! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D77585: Stop passing site cfg files via --param to llvm-lit.

thakis marked an inline comment as done. thakis added a comment. Thanks! Comment at: clang/test/CMakeLists.txt:113 -set(ANALYZER_TEST_PARAMS - USE_Z3_SOLVER=0) hans wrote: > This and ANALYZER_TEST_PARAMS_Z3 are just dropped because they're unused, > right?

[PATCH] D75364: [clang-format] Handle macros in function params and return value

tamas.petz added a comment. Wow, I have missed that configuration option. I will try it, I assume it should work. Looks like this change should be abandoned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75364/new/ https://reviews.llvm.org/D75364

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong created this revision. martong added reviewers: NoQ, Szelethus, balazske. Herald added subscribers: cfe-commits, ASDenysPetrov, uenoku, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:570 +llvm::Optional +lookupGlobalCFunction(StringRef Name, const ASTContext &ACtx) { + IdentifierInfo &II = ACtx.Idents.get(Name)

[PATCH] D77585: Stop passing site cfg files via --param to llvm-lit.

This revision was automatically updated to reflect the committed changes. Closed by commit rG448b777b864a: Stop passing site cfg files via --param to llvm-lit. (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 041080c - [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

Author: Haojian Wu Date: 2020-04-07T14:29:38+02:00 New Revision: 041080c247351da15b6bb21a7196c8dc9bc6babc URL: https://github.com/llvm/llvm-project/commit/041080c247351da15b6bb21a7196c8dc9bc6babc DIFF: https://github.com/llvm/llvm-project/commit/041080c247351da15b6bb21a7196c8dc9bc6babc.diff LO

[PATCH] D77527: [AST] Adjust existing tests for recovery-exprs

sammccall added a comment. I'm a bit leery about this because we lose test coverage of the "live" configuration. I know it's a pain, but maybe it's possible to keep this as a local patch/branch? :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D77392 . Enables building ASTs with stale preamble

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255654. hlopko added a comment. Assert the Spelled subrange more effectively Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/Tooling/Syntax/

[PATCH] D77507: [clangd] Fix HitMapping assertion in Tokens.cpp

vabridgers added a comment. ayup, no problem and thanks for the fix. I'll abandon this change. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77507/new/ https://reviews.llvm.org/D77507 ___ cfe-com

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

ldionne added inline comments. Comment at: clang/test/SemaObjCXX/type-traits-is-pointer.mm:1 +// RUN: %clang_cc1 -fsyntax-only -fobjc-arc -fobjc-runtime-has-weak -verify %s +// expected-no-diagnostics ldionne wrote: > Why do you run this through `-verify`? Can't

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG041080c24735: [AST] Fix a crash on invalid constexpr Ctorinitializer when building… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77041

[clang] cfd388d - [analyzer] Try to lift 'REQUIRES: shell' for scan-build tests.

Author: Denys Petrov Date: 2020-04-07T15:56:50+03:00 New Revision: cfd388d344ab29ad5e311ac96e382d96bd85d994 URL: https://github.com/llvm/llvm-project/commit/cfd388d344ab29ad5e311ac96e382d96bd85d994 DIFF: https://github.com/llvm/llvm-project/commit/cfd388d344ab29ad5e311ac96e382d96bd85d994.diff

[clang] ec0b990 - [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

Author: Sam McCall Date: 2020-04-07T15:01:34+02:00 New Revision: ec0b9908952a9f4a19c3eb92ba0fc01cffcb8614 URL: https://github.com/llvm/llvm-project/commit/ec0b9908952a9f4a19c3eb92ba0fc01cffcb8614 DIFF: https://github.com/llvm/llvm-project/commit/ec0b9908952a9f4a19c3eb92ba0fc01cffcb8614.diff LO

[clang] 338be9c - [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

Author: Florian Hahn Date: 2020-04-07T14:01:55+01:00 New Revision: 338be9c59527c3d172f64e8861bcbb472297d52d URL: https://github.com/llvm/llvm-project/commit/338be9c59527c3d172f64e8861bcbb472297d52d DIFF: https://github.com/llvm/llvm-project/commit/338be9c59527c3d172f64e8861bcbb472297d52d.diff

[clang] d66afd6 - [Syntax] Merge overlapping top-level macros in TokenBuffer

Author: Sam McCall Date: 2020-04-07T15:06:04+02:00 New Revision: d66afd6dde542dc373f87e07fe764c071fe20d76 URL: https://github.com/llvm/llvm-project/commit/d66afd6dde542dc373f87e07fe764c071fe20d76 DIFF: https://github.com/llvm/llvm-project/commit/d66afd6dde542dc373f87e07fe764c071fe20d76.diff LO

[clang] 1bf055c - [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

Author: Marcel Hlopko Date: 2020-04-07T15:07:16+02:00 New Revision: 1bf055c9891f1a5ab2ff6a04348bd83fcc0a9cde URL: https://github.com/llvm/llvm-project/commit/1bf055c9891f1a5ab2ff6a04348bd83fcc0a9cde DIFF: https://github.com/llvm/llvm-project/commit/1bf055c9891f1a5ab2ff6a04348bd83fcc0a9cde.diff

[PATCH] D77440: [Hexagon] Update include paths for linux/musl

sidneym updated this revision to Diff 255655. sidneym added a comment. Herald added a subscriber: ormris. Break out linux parts of hexagon-toolchain-elf.c into hexagon-toolchain-linux.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77440/new/ https

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

thakis added a comment. This seems to break tests on Windows: http://45.33.8.238/win/12320/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76768/new/ https://reviews.llvm.org/D76768 ___ cfe-co

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

hokein added a comment. I'm not familiar with the code, but this patch does fix the large-preamble crashes we encountered internally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 _

[PATCH] D75364: [clang-format] Handle macros in function params and return value

MyDeveloperDay added a comment. In D75364#1966743 , @tamas.petz wrote: > Wow, I have missed that configuration option. > I will try it, I assume it should work. > > Looks like this change should be abandoned. To be honest, I forget what we've got too! ;

[PATCH] D77614: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGec0b9908952a: [Syntax] Simplify TokenCollector::Builder, use captured expansion bounds. NFC (authored by sammccall). Changed prior to commit: https://reviews.

[PATCH] D77615: [Syntax] Merge overlapping top-level macros in TokenBuffer

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGd66afd6dde54: [Syntax] Merge overlapping top-level macros in TokenBuffer (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77615?vs=

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

This revision was automatically updated to reflect the committed changes. Closed by commit rG338be9c59527: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77058/

[PATCH] D77645: [clangd] Support dexp -c "some command"

sammccall created this revision. sammccall added reviewers: mnauw, kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. It runs one command and exits. See D77385 for motiva

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bf055c9891f: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer (authored by hlopko, committed by gribozavr). Changed prior to commit: https://reviews.llvm.org/D77209?vs=255654&id=255

[clang] 6b3353e - Revert "[analyzer] Try to lift 'REQUIRES: shell' for scan-build tests."

Author: Artem Dergachev Date: 2020-04-07T16:37:42+03:00 New Revision: 6b3353e832940e9484bba7b8017b8ea1f0c63806 URL: https://github.com/llvm/llvm-project/commit/6b3353e832940e9484bba7b8017b8ea1f0c63806 DIFF: https://github.com/llvm/llvm-project/commit/6b3353e832940e9484bba7b8017b8ea1f0c63806.dif

[clang] c97be2c - [hip] Remove `hip_pinned_shadow`.

Author: Michael Liao Date: 2020-04-07T09:51:49-04:00 New Revision: c97be2c377852fad7eb38409aae5692fa417e49b URL: https://github.com/llvm/llvm-project/commit/c97be2c377852fad7eb38409aae5692fa417e49b DIFF: https://github.com/llvm/llvm-project/commit/c97be2c377852fad7eb38409aae5692fa417e49b.diff

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

ZarkoCA added a comment. @jhibbits is this patch going to be committed soon? I have a patch (https://reviews.llvm.org/D76360) that I will need to rebase once this is in. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73290/new/ https://re

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau updated this revision to Diff 255666. pgousseau added a comment. Fix false negative test introduce while attempting to add label check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 Files: clang/lib/Headers/emmintrin.h clang/lib/

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

pgousseau reopened this revision. pgousseau added a comment. This revision is now accepted and ready to land. Reopening to fix false negative test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 ___

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

NoQ added a comment. In D76768#1966813 , @thakis wrote: > This seems to break tests on Windows: http://45.33.8.238/win/12320/step_7.txt Thank you! Reverted. Comment at: clang/test/Analysis/scan-build/exclude_directories.test:1-2 -// F

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#1966711 , @baloghadamsoftware wrote: > Any idea for `LazyCompoundVal` parameters of functions not inlined? OK, I can reach them from the `ConstructionContext` of the arguments. However, they are temporaries

[PATCH] D76238: [SveEmitter] Implement builtins for contiguous loads/stores

Andrzej added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:186 +def SVLDFF1 : MInst<"svldff1[_{2}]", "dPc", "csilUcUsUiUlhfd", [IsLoad], MemEltTyDefault, "aarch64_sve_ldff1">; +def SVLDFF1SB : MInst<"svldff1sb_{d}", "dPS", "silUsUiUl",

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus updated this revision to Diff 255668. Szelethus marked 8 inline comments as done. Szelethus added a comment. Fixing according to the reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76605/new/ https://reviews.llvm.org/D76605 Files: clang/include/clang/StaticAnalyzer/C

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#1966885 , @baloghadamsoftware wrote: > OK, I can reach them from the `ConstructionContext` of the arguments. > However, they are temporaries and for some strange reason not alive which > means that `checkDea

[PATCH] D76605: [analyzer] Display the checker name in the text output

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp:112 reportPiece(NoteID, Piece->getLocation().asLocation(), -Piece->getString(), Piece->getRanges(), Piece->getFixits()); +Piece->getStr

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

ASDenysPetrov added a comment. @NoQ Yes, I have some thoughts. I am on revision master from [02.04.2020 10:29:20] (5 days ago). I've check these test and all passes on my PC. As you can see in the log : scan-build: Removing directory '/c/src/llvm-project/out/gn/obj/clang/test/Analysis/scan-

[PATCH] D77440: [Hexagon] Update include paths for linux/musl

bcain added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77440/new/ https://reviews.llvm.org/D77440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D77583: [hip] Remove `hip_pinned_shadow`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc97be2c37785: [hip] Remove `hip_pinned_shadow`. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77583/new/ https://reviews.llvm.org/D7758

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2700 + if (std::error_code EC = Text.getError()) +return make_string_error(EC.message()); + std::error_code ParserErrorCode = if you return here IsSuitable will be true.. ==

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

jhibbits added a reviewer: nemanjai. jhibbits added a comment. @ZarkoCA I think someone else should also review this, so added @nemanjai as a potential reviewer. He might have more insight to the code in question. I'd like to see this go in soon, though, so that it gets into 11, and we can use

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

ASDenysPetrov added a comment. @NoQ I've just pulled all from github and make a build. Then I ran the tests, and they successfully passed. Namely, **scan-build** analyzed inputs and create //stdout //with diagnostics. Then **filecheck **checked without fails. But in case of **buildbot **it did

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

chill added a comment. Needs a test in `clang/test` that `__builtin_extract_return_address` is translated to `llvm.extractreturnaddress`. What if LLVM IR contains a call to `llvm.extractreturnaddress`, but the target is not AArch64? Comment at: llvm/include/llvm/CodeGen/ISDO

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

chill added a comment. In D75044#1966997 , @chill wrote: > Needs a test in `clang/test` that `__builtin_extract_return_address` is > translated to `llvm.extractreturnaddress`. Nevermind, I'm blind. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

wenlei updated this revision to Diff 255679. wenlei added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77632/new/ https://reviews.llvm.org/D77632 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/libcalls-veclib.c llv

[PATCH] D77440: [Hexagon] Update include paths for linux/musl

sidneym updated this revision to Diff 255680. sidneym added a comment. Fix formatting issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77440/new/ https://reviews.llvm.org/D77440 Files: clang/lib/Driver/ToolChains/Hexagon.cpp clang/lib/Dri

  1   2   3   >