[PATCH] D77410: [analyzer] StdLibraryFunctionsChecker: match signature based on FunctionDecl

martong marked 2 inline comments as done. martong added a comment. In D77410#1963288 , @Szelethus wrote: > LGTM! Maybe its worth glancing over the rest of the code (comments in > particular) whether anything would be outdated by this change. Yeah, seems

[PATCH] D77410: [analyzer] StdLibraryFunctionsChecker: match signature based on FunctionDecl

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG8f961399739f: [analyzer] StdLibraryFunctionsChecker: match signature based on FunctionDecl (authored by martong). Changed prior to commit: https://reviews.llvm.

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

zoecarver marked an inline comment as done. zoecarver added a comment. @ldionne of course! Comment at: libcxx/include/type_traits:901 +// In clang 10.0.0 and earlier __is_pointer didn't work with Objective-C types. +#if __has_keyword(__is_pointer) && _LIBCPP_CLANG_VER > 1000 +

[PATCH] D77411: [analyzer] StdLibraryFunctionsChecker: Add test for function with default parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rGab1fad8a3a8b: [analyzer] StdLibraryFunctionsChecker: Add test for function with default… (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske updated this revision to Diff 255360. balazske added a comment. - Adding comment about ferror, feof. - Enabled core checker in test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 Files: cl

[PATCH] D77548: clang-format: [JS] handle pseudo-keywords.

This revision was automatically updated to reflect the committed changes. Closed by commit rG92201505cdec: clang-format: [JS] handle pseudo-keywords. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D77548?vs=255314&id=255357#toc Repository: rG LLVM Github Monorepo C

[PATCH] D77257: Clean up usages of asserting vector getters in Type

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5830 BuiltinID == NEON::BI__builtin_neon_vqrdmulhq_lane_v) - RTy = llvm::VectorType::get(Ty->getVectorEl

[clang] 2aa593b - Fix a typo in an assert message; NFC.

Author: BoYao Zhang Date: 2020-04-06T11:50:50-04:00 New Revision: 2aa593be5486a9c5d3092647f2576273f84f3159 URL: https://github.com/llvm/llvm-project/commit/2aa593be5486a9c5d3092647f2576273f84f3159 DIFF: https://github.com/llvm/llvm-project/commit/2aa593be5486a9c5d3092647f2576273f84f3159.diff L

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

zoecarver updated this revision to Diff 255361. zoecarver added a comment. Fix based on review: - Use static_assert directly in the test - Update run command to work on non-objc platforms (e.g. linux) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added a comment. In D68115#1962892 , @rsmith wrote: > In D68115#1962863 , @jfb wrote: > > > In D68115#1962833 , @rsmith wrote: > > > > > I think the ma

[PATCH] D77519: Fix __is_pointer builtin type trait to work with Objective-C pointer types.

zoecarver updated this revision to Diff 255362. zoecarver added a comment. Diff from master not last commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77519/new/ https://reviews.llvm.org/D77519 Files: clang/lib/Sema/SemaExprCXX.cpp clang/t

[PATCH] D77532: Fix a typo in clang/lib/Frontend/FrontendAction.cpp

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've committed on your behalf in 2aa593be5486a9c5d3092647f2576273f84f3159 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. yep, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77058/new/ https://reviews.llvm.org/D77058

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/llvmlibc/ImplementationInNamespaceCheck.cpp:21 + Finder->addMatcher( + decl(hasParent(translationUnitDecl(

[PATCH] D77507: [clangd] Fix HitMapping assertion in Tokens.cpp

vabridgers added a comment. Thank you for the comments. I'll keep looking at this to find a proper fix, but any hints you may have would be greatly appreciated (debugging tips, strategies, areas of code to focus on). This code is new to me, so I may not be as efficient at tracking this down as

[clang] 1c92448 - [OPENMP]Fix PR45439: `omp for collapse(2) ordered(2)` generates invalid

Author: Alexey Bataev Date: 2020-04-06T12:07:43-04:00 New Revision: 1c924486564461810903603542ffc2d7db204dde URL: https://github.com/llvm/llvm-project/commit/1c924486564461810903603542ffc2d7db204dde DIFF: https://github.com/llvm/llvm-project/commit/1c924486564461810903603542ffc2d7db204dde.diff

[PATCH] D77028: Speed up deferred diagnostic emitter

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1558 +// visited before. +if (Done.count(FD)) + return; rjmccall wrote: > `insert` returns whether it changed the set, so you can combine this

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. I would guess that some visitor still has a `VisitCompoundAssignOperator` implementation, and that the behavior of `VisitBinAssign` happens to do what's needed for it. You basically have two options: - Keep a `VisitCompoundAssignOperator` around in `StmtVisitor` for a

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13651 + llvm::getConstantStringInfo(Scope, scp); + SSID = getLLVMContext().getOrInsertSyncScopeID(scp); + sameerds wrote: > saiislam wrote: > > sameerds wrote: > > > This

[PATCH] D77414: [OpenMP] Add match_{all,any,none} declare variant selector extensions.

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. Looks okay to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77414/new/ https://reviews.llvm.org/D77414 __

[PATCH] D76211: OpenMP Metadirective with user defined condition

tomdeakin added a comment. Herald added a subscriber: yaxunl. Is there an update on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailin

[PATCH] D77379: [FPEnv] Use single enum to represent rounding mode

rjmccall added a reviewer: scanon. rjmccall added inline comments. Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:26 +/// assigned to the rounding modes must agree with the values used by FLT_ROUNDS +/// (C11, 5.2.4.2.2p8). +enum class RoundingMode : int8_t {

[PATCH] D77520: Treat default values in LangOptions.def in the scope of enums

sepavloff abandoned this revision. sepavloff added a comment. Thank you, Reid! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77520/new/ https://reviews.llvm.org/D77520 ___ cfe-commits mailing list cfe-

[PATCH] D77545: Represent FP options in AST by special Expression node

rjmccall added a comment. The goal here seems to be to avoid the need to store pragma state in operator expressions. As I mentioned in another review, I'm not sure how directly interesting that goal is if we can avoid memory overhead in the common case. Storing pragma state in operators certa

[clang] 11a04a6 - [DebugInfo] Change to constructor homing debug info mode: skip literal types

Author: Amy Huang Date: 2020-04-06T09:52:53-07:00 New Revision: 11a04a64aaa3dba6fddadbcf026d197fc02226e0 URL: https://github.com/llvm/llvm-project/commit/11a04a64aaa3dba6fddadbcf026d197fc02226e0 DIFF: https://github.com/llvm/llvm-project/commit/11a04a64aaa3dba6fddadbcf026d197fc02226e0.diff LOG

[clang] 2c31aa2 - Speed up deferred diagnostic emitter

Author: Yaxun (Sam) Liu Date: 2020-04-06T13:07:43-04:00 New Revision: 2c31aa2de13a23a00ced87123b92e905f2929c7b URL: https://github.com/llvm/llvm-project/commit/2c31aa2de13a23a00ced87123b92e905f2929c7b DIFF: https://github.com/llvm/llvm-project/commit/2c31aa2de13a23a00ced87123b92e905f2929c7b.dif

RE: [clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] commit 2c31aa2de13a23a00ced87123b92e905f2929c7b should fix this. Thanks. Sam -Original Message- From: Liu, Yaxun (Sam) Sent: Sunday, April 5, 2020 12:20 PM To: Joerg Sonnenberger ; Yaxun Liu Cc: cfe-commits@lists.llvm.org Subject: R

[clang] b36c19b - [AST] Remove DeclCXX.h dep on ASTContext.h

Author: Reid Kleckner Date: 2020-04-06T10:09:01-07:00 New Revision: b36c19bc4f2110a8e33f8d93751ef28b6dcd0292 URL: https://github.com/llvm/llvm-project/commit/b36c19bc4f2110a8e33f8d93751ef28b6dcd0292 DIFF: https://github.com/llvm/llvm-project/commit/b36c19bc4f2110a8e33f8d93751ef28b6dcd0292.diff

[PATCH] D77028: Speed up deferred diagnostic emitter

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1558 +// visited before. +if (Done.count(FD)) + return; yaxunl wrote: > rjmccall wrote: > > `insert` returns whether it changed the set, so you can combine this check > > with the i

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

Meinersbur added a comment. Note that loop-metadata is best-effort only and may be forgotten in the optimization pipeline. Do we also need an equivalent to `-Xclang -disable-O0-optnone`? Personally, I don't like to the `optnone` approach: There have been many post on llvm-dev using `clang -emi

[PATCH] D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct

erik.pilkington updated this revision to Diff 255385. erik.pilkington marked 3 inline comments as done. erik.pilkington added a comment. Don't bother including zero length bit-fields in the mangling of the copy/destroy helpers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76782/new/ h

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Do you already have commit access or should i commit this for you? Comment at: clang/test/Analysis/SpecialFunctionsCFError.cpp:2 +// RUN: %clang_analyze_cc1 -

[PATCH] D77499: [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

njames93 updated this revision to Diff 255387. njames93 marked 4 inline comments as done. njames93 added a comment. - Added test cases and addressed nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77499/new/ https://reviews.llvm.org/D77499 Fil

[PATCH] D77305: [Analyzer][VLASize] Support multi-dimensional arrays.

balazske updated this revision to Diff 255388. balazske added a comment. Added comments and test for extent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77305/new/ https://reviews.llvm.org/D77305 Files: clang/lib/StaticAnalyzer/Checkers/VLASiz

[PATCH] D77499: [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

njames93 added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:16-17 +if (Item.equals_lower(Search)) { + if (Item.equals(Search)) +return Item.str(); + MaxEditDistance = 1; aaron.ballman wrote: > Is this case possi

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau updated this revision to Diff 255390. ctetreau added a comment. Address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGe

[PATCH] D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. I did run the math_cpp11 tests. I don't have a cuda environment so it was probably of limited value. I didn't see any failures that seemed related to this during the compiles. R

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:127 + const auto *Init = ICC->getCXXCtorInitializer(); + return getObjectUnderConstruction(State, Init, LCtx); +} baloghadamsoftware wrote: > This does not find a

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

Szelethus added inline comments. Comment at: clang/test/Analysis/SpecialFunctionsCFError.cpp:2 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,osx.coreFoundation.CFError \ +// RUN: -analyzer-store=region -verify %s + NoQ wrote: > `-analyzer-store=region` is

[PATCH] D64321: [OpenCL] Change diagnostic for function declaration

svenvh abandoned this revision. svenvh added a comment. Abandoning after an offline discussion with @Anastasia. Overloading is not a feature of OpenCL C in the first place so adding complexity to Clang isn't really justifiable. Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds requested changes to this revision. sameerds added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13651 + llvm::getConstantStringInfo(Scope, scp); + SSID = getLLVMContext().getOrInsertSyncScopeID(scp)

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

vsavchenko marked an inline comment as done. vsavchenko added a comment. In D77551#1964441 , @NoQ wrote: > Looks great, thanks! Do you already have commit access or should i commit > this for you? Thanks :-) No, I don't have commit access ===

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen updated this revision to Diff 255377. khchen added reviewers: evandro, HsiangKai. khchen added a comment. Herald added a subscriber: hiraditya. update implementation and handle `-mcpu` with explicitly specified `-march`. If `-mcpu` has default march, explicitly `-march` will overwrite it.

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. Herald added a subscriber: yaxunl. In D74387#1950593 , @jdoerfert wrote: > This is needed for OpenMP as well. Does it make sense to include it in this > patch or in another one? I thought OpenMP already has diagnostics for uns

[PATCH] D77432: [DebugInfo] Change to constructor homing debug info mode: skip constexpr constructed types

This revision was automatically updated to reflect the committed changes. Closed by commit rG11a04a64aaa3: [DebugInfo] Change to constructor homing debug info mode: skip literal types (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D77570: [clang][CodeComplete] Dont perform fallback completion for incomplete member ref

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang performs expression based completion whenever it can't figure out base of a member reference expression. It might be quite confusing in cases like inco

[PATCH] D77028: Speed up deferred diagnostic emitter

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG2c31aa2de13a: Speed up deferred diagnostic emitter (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 9b1e4a8 - [analyzer] Fix NSErrorChecker false positives on constructors.

Author: Artem Dergachev Date: 2020-04-06T20:33:38+03:00 New Revision: 9b1e4a8218b7fcb8900d0382704fdb4e38b52eb0 URL: https://github.com/llvm/llvm-project/commit/9b1e4a8218b7fcb8900d0382704fdb4e38b52eb0 DIFF: https://github.com/llvm/llvm-project/commit/9b1e4a8218b7fcb8900d0382704fdb4e38b52eb0.dif

[clang] 2ddd332 - [analyzer] Fix scan-build and exploded-graph-rewriter tests on Windows.

Author: Artem Dergachev Date: 2020-04-06T20:33:37+03:00 New Revision: 2ddd3325c4d7ab47b62a9fe72a0d1c1d8ec7f9d7 URL: https://github.com/llvm/llvm-project/commit/2ddd3325c4d7ab47b62a9fe72a0d1c1d8ec7f9d7 DIFF: https://github.com/llvm/llvm-project/commit/2ddd3325c4d7ab47b62a9fe72a0d1c1d8ec7f9d7.dif

Re: [clang] 8527c1e - Added constraints on cl-options.cu test

Yup 32-bit vis 64-bit does dis trip linux tests, too some time back. We ended up passing explicit target triples to avoid host architecture leaking into the test. On a side note, shouldn't we pass -nocudalib via /clang: ? On Mon, Apr 6, 2020 at 7:05 AM Hans Wennborg wrote: > Oh no, the warning

[clang-tools-extra] 76221c7 - Remove llvm::Error include form Diagnostic.h

Author: Reid Kleckner Date: 2020-04-06T10:42:17-07:00 New Revision: 76221c734eac81387f772aca9299f10a7c921bda URL: https://github.com/llvm/llvm-project/commit/76221c734eac81387f772aca9299f10a7c921bda DIFF: https://github.com/llvm/llvm-project/commit/76221c734eac81387f772aca9299f10a7c921bda.diff

[clang-tools-extra] 00a5755 - [clang-tidy] Add check llvmlibc-implementation-in-namespace.

Author: Paula Toth Date: 2020-04-06T10:49:49-07:00 New Revision: 00a57558978d3e4f11d08bed486497a8674000e3 URL: https://github.com/llvm/llvm-project/commit/00a57558978d3e4f11d08bed486497a8674000e3 DIFF: https://github.com/llvm/llvm-project/commit/00a57558978d3e4f11d08bed486497a8674000e3.diff LO

[PATCH] D77570: [clang][CodeComplete] Dont perform fallback completion for incomplete member ref

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. It'd be nice to suppress the fallback more directly, but this is pretty clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77570/new/ ht

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

NoQ added inline comments. Comment at: clang/test/Analysis/SpecialFunctionsCFError.cpp:2 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,osx.coreFoundation.CFError \ +// RUN: -analyzer-store=region -verify %s + vsavchenko wrote: > Szelethus wrote: > > NoQ wr

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen added a comment. @lenary (Sorry for the very late reply...) In D71124#1829998 , @lenary wrote: > In D71124#1792216 , @khchen wrote: > > > The problem is how `-mcpu` interact with explicitly specified `-march

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:127 + const auto *Init = ICC->getCXXCtorInitializer(); + return getObjectUnderConstruction(State, Init, LCtx); +} NoQ wrote: > baloghadamsoftware wrote: > > This

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre created this revision. mgehre added reviewers: aaron.ballman, alexfh, hokein. Herald added subscribers: xazax.hun, mgorny. Herald added a project: clang. Finds range-based for loops that can be replaced by a call to ``std::any_of`` or ``std::all_of``. In C++ 20 mode, suggests ``std::ranges:

[PATCH] D77571: Add ClangTidy check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

mwyman created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. mwyman added reviewers: stephanemoore, benhamilton, dmaclach. mwyman added a project: clang-tools-extra. mwyman edited the summary of this revision. This check is similar to an ARC Migration

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

Xiangling_L added inline comments. Comment at: clang/test/CodeGen/aix-vararg.c:15 + + // 32BIT: define void @aix_varg(i32 %a, ...) #0 { + // 32BIT-NEXT: entry: `#0`, `#1`[the last three lines] are redundant, could you clean them up? Repository: rG LL

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

craig.topper added a comment. Seems fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D77342: Sema: check for null TInfo in ActOnBaseSpecifier

zarko abandoned this revision. zarko added a comment. I can confirm that this has been fixed by the revision that rsmith has linked. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77342/new/ https://reviews.llvm.org/D77342 __

[PATCH] D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76782/new/ https://reviews.llvm.org/D76782 ___ cfe-commits mailing list cfe-commi

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rG00a57558978d: [clang-tidy] Add check llvmlibc-implementation-in-namespace. (authored by PaulkaToast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76818/new

[PATCH] D77499: [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77499/new/ https://reviews.llvm.org/D77499 _

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b1e4a8218b7: [analyzer] Fix NSErrorChecker false positives on constructors. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D77551?vs=255337&id=255407#toc Repository: rG

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ddd3325c4d7: [analyzer] Fix scan-build and exploded-graph-rewriter tests on Windows. (authored by dergachev.a). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to com

Re: [clang] 8527c1e - Added constraints on cl-options.cu test

On Mon, Apr 6, 2020 at 7:36 PM Artem Belevich wrote: > > Yup 32-bit vis 64-bit does dis trip linux tests, too some time back. We ended > up passing explicit target triples to avoid host architecture leaking into > the test. > > On a side note, shouldn't we pass -nocudalib via /clang: ? Yes, tha

[clang] 2c5d6df - [Hexagon] Make lld be the default linker for linux/musl

Author: Sid Manning Date: 2020-04-06T12:59:07-05:00 New Revision: 2c5d6dfda98e409f6a6b4b577ebdf59a35ff2ebe URL: https://github.com/llvm/llvm-project/commit/2c5d6dfda98e409f6a6b4b577ebdf59a35ff2ebe DIFF: https://github.com/llvm/llvm-project/commit/2c5d6dfda98e409f6a6b4b577ebdf59a35ff2ebe.diff L

[clang] 77e2493 - [NFC] Minor fix for deferred diagnostics emitter

Author: Yaxun (Sam) Liu Date: 2020-04-06T14:01:41-04:00 New Revision: 77e24936022add9e5a0b4ff3db99148c96d113af URL: https://github.com/llvm/llvm-project/commit/77e24936022add9e5a0b4ff3db99148c96d113af DIFF: https://github.com/llvm/llvm-project/commit/77e24936022add9e5a0b4ff3db99148c96d113af.dif

[clang-tools-extra] 97aa593 - [OpenMP] Fix layering problem with FrontendOpenMP

Author: Johannes Doerfert Date: 2020-04-06T13:04:26-05:00 New Revision: 97aa593a8387586095b7eac12974ba2fdd08f4c3 URL: https://github.com/llvm/llvm-project/commit/97aa593a8387586095b7eac12974ba2fdd08f4c3 DIFF: https://github.com/llvm/llvm-project/commit/97aa593a8387586095b7eac12974ba2fdd08f4c3.d

[clang] 0731132 - [clang][CodeComplete] Dont perform fallback completion for incomplete member ref

Author: Kadir Cetinkaya Date: 2020-04-06T20:08:24+02:00 New Revision: 0731132888a0219179fdb4303cd690a6687cc130 URL: https://github.com/llvm/llvm-project/commit/0731132888a0219179fdb4303cd690a6687cc130 DIFF: https://github.com/llvm/llvm-project/commit/0731132888a0219179fdb4303cd690a6687cc130.dif

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

jdoerfert created this revision. jdoerfert added a reviewer: lebedev.ri. Herald added subscribers: martong, guansong, bollu, yaxunl, mgorny. Herald added a project: clang. lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG ASTMatche

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77574/new/ https://reviews.llvm.org/D77574 _

[PATCH] D77028: Speed up deferred diagnostic emitter

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1558 +// visited before. +if (Done.count(FD)) + return; rjmccall wrote: > yaxunl wrote: > > rjmccall wrote: > > > `insert` returns whether it c

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

fhahn added a comment. In D77058#1964427 , @Meinersbur wrote: > Note that loop-metadata is best-effort only and may be forgotten in the > optimization pipeline. Agreed, that can be a potential issue (I tried to note that in the description), but I thin

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77062: [analyzer] Added check for unacceptable equality operation between Loc and NonLoc types

NoQ added a comment. I still think that the mistake was made earlier. Why are we getting a compound value here? The argument of `strcpy` is a plain pointer, not a compound value. It points to an array of chars which may be interpreted as a compound value, but in any case our intention is defini

[PATCH] D77498: [Hexagon] Select lld as the default linker for linux-musl target

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c5d6dfda98e: [Hexagon] Make lld be the default linker for linux/musl (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77498/new/ https:

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

This revision was automatically updated to reflect the committed changes. Closed by commit rG97aa593a8387: [OpenMP] Fix layering problem with FrontendOpenMP (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77574/new/ https://re

[PATCH] D77570: [clang][CodeComplete] Dont perform fallback completion for incomplete member ref

This revision was automatically updated to reflect the committed changes. Closed by commit rG0731132888a0: [clang][CodeComplete] Dont perform fallback completion for incomplete member ref (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D77571: Add ClangTidy check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

mwyman updated this revision to Diff 255423. mwyman added a comment. Check for Objective-C block pointers as well, which also require __unsafe_unretained when retrieved as arguments from NSInvocation under ARC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This seems to LGTM, in the absence of any other input, I guess we have to rely on the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71512/new/ https://reviews.

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:455 +def StreamTesterChecker : Checker<"StreamTester">, + HelpText<"Add test functions to StreamChecker for test and debugging purposes.">, This should go into the

[PATCH] D76768: [analyzer] Added support of scan-build and exploded-graph-rewriter regression tests for Windows

NoQ added a comment. I landed it without removing `REQUIRES: shell` first and buildbots seem to be fine. That said, it's likely that `REQUIRES: shell` still disables them on Windows buildbots. I'll try to remove `REQUIRES: shell` tomorrow and see what happens. Repository: rG LLVM Github Mon

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added inline comments. Comment at: clang/test/CodeGenHIP/builtin_memory_fence.cpp:9 + // CHECK: fence syncscope("workgroup") seq_cst + __builtin_memory_fence(__ATOMIC_SEQ_CST, "workgroup"); + sameerds wrote: > JonChesterfield wrote: > > samee

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with the minor addition an extra CHECK-LABEL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 ___

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:620-624 + "AggressiveEraseModeling", + "Enables exploration of the past-the-end branch for the " + "return value of the erase() method

[PATCH] D77391: [analyzer][AnalysisOrder] Display the CallEvent type for preCall/postCall

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Wonderful tests! Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:202 virtual Kind getKind() const = 0; + virtual StringRef getKindAsString() cons

[PATCH] D76790: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

NoQ added a comment. In D76790#1957061 , @Szelethus wrote: > Yup, looks great Can confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76790/new/ https://reviews.llvm.org/D76790 _

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 255425. kadircet marked 10 inline comments as done. kadircet added a comment. - Address comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://reviews.llvm.org/D76725 Files: cl

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added inline comments. Comment at: clang/test/CodeGenHIP/builtin_memory_fence.cpp:9 + // CHECK: fence syncscope("workgroup") seq_cst + __builtin_memory_fence(__ATOMIC_SEQ_CST, "workgroup"); + JonChesterfield wrote: > sameerds wrote: > > JonCh

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:224 + std::vector CIDiags, WantDiagnostics WantDiags) { // Make possibly expensive copy while not holding the lock. +Request Req =

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

tra added a reviewer: sammccall. tra added a comment. Please add some more details to the bug description. This change is to make clangd work when compilation database sees CUDA sources compiled with nvcc. NVCC uses different options that should be properly translated. This patch only deals wit

[clang] 427c1dc - [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

Author: Nathan James Date: 2020-04-06T20:00:30+01:00 New Revision: 427c1dc4f4248ec71e32a8f3832a4e6258446672 URL: https://github.com/llvm/llvm-project/commit/427c1dc4f4248ec71e32a8f3832a4e6258446672 DIFF: https://github.com/llvm/llvm-project/commit/427c1dc4f4248ec71e32a8f3832a4e6258446672.diff

[PATCH] D77499: [ASTMatchers] Matchers that take enumerations args provide hints with invalid arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG427c1dc4f424: [ASTMatchers] Matchers that take enumerations args provide hints with invalid… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] a473f0a - Fix mismatch from D77112 and D77499

Author: Nathan James Date: 2020-04-06T20:19:12+01:00 New Revision: a473f0a36c3f4117d8e77d3d8636303ff2f99d09 URL: https://github.com/llvm/llvm-project/commit/a473f0a36c3f4117d8e77d3d8636303ff2f99d09 DIFF: https://github.com/llvm/llvm-project/commit/a473f0a36c3f4117d8e77d3d8636303ff2f99d09.diff

[clang-tools-extra] 276a95b - [clangd] Decouple preambleworker from astworker, NFCI

Author: Kadir Cetinkaya Date: 2020-04-06T21:20:16+02:00 New Revision: 276a95bdf27c887a0a8c6c703db1fd2f8da27a03 URL: https://github.com/llvm/llvm-project/commit/276a95bdf27c887a0a8c6c703db1fd2f8da27a03 DIFF: https://github.com/llvm/llvm-project/commit/276a95bdf27c887a0a8c6c703db1fd2f8da27a03.dif

[clang-tools-extra] c31367e - [clangd] Build ASTs only with fresh preambles or after building a new preamble

Author: Kadir Cetinkaya Date: 2020-04-06T21:20:17+02:00 New Revision: c31367e95ce1e1e3fe97b1aee54a746f8dafc779 URL: https://github.com/llvm/llvm-project/commit/c31367e95ce1e1e3fe97b1aee54a746f8dafc779 DIFF: https://github.com/llvm/llvm-project/commit/c31367e95ce1e1e3fe97b1aee54a746f8dafc779.dif

[clang-tools-extra] 6b85032 - [clangd] Update TUStatus api to accommodate preamble thread

Author: Kadir Cetinkaya Date: 2020-04-06T21:20:17+02:00 New Revision: 6b85032c95bee2e15ce7f239316de4d11e6ca08b URL: https://github.com/llvm/llvm-project/commit/6b85032c95bee2e15ce7f239316de4d11e6ca08b DIFF: https://github.com/llvm/llvm-project/commit/6b85032c95bee2e15ce7f239316de4d11e6ca08b.dif

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:455 +def StreamTesterChecker : Checker<"StreamTester">, + HelpText<"Add test functions to StreamChecker for test and debugging purposes.">, NoQ wrote: > This

<    1   2   3   4   >