[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

efriedma updated this revision to Diff 252169. efriedma edited the summary of this revision. efriedma added a comment. Add testcase to show missing vector handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76528/new/ https://reviews.llvm.org/D

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

efriedma added a comment. Actually looking again, I'm not sure there's any way to make clang generate a bool vector at the moment. Added tests for the rest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76528/new/ https://reviews.llvm.org/D76528

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:6364-6371 +const llvm::fltSemantics &Semantics = Info.Ctx.getFloatTypeSemantics(Ty); +unsigned NumBits = APFloat::semanticsSizeInBits(Semantics); +assert(NumBits % 8 == 0); +CharUnits Width =

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

kripken accepted this revision. kripken added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/AttrDocs.td:4173 +attribute for the WebAssembly target. This attribute may be attached to a +function declaration, where it causes

[clang] 5bd0611 - Update documentation for __builtin_operator_new and

Author: Richard Smith Date: 2020-03-23T16:31:10-07:00 New Revision: 5bd06118c2a798f1f87b9251953bae8a27f21e5f URL: https://github.com/llvm/llvm-project/commit/5bd06118c2a798f1f87b9251953bae8a27f21e5f DIFF: https://github.com/llvm/llvm-project/commit/5bd06118c2a798f1f87b9251953bae8a27f21e5f.diff

[clang-tools-extra] edf6a19 - [clangd] Rename theia-derived semantic highlighting protocol. NFC

Author: Sam McCall Date: 2020-03-24T00:39:47+01:00 New Revision: edf6a19adf7acf54f96e78718fb2339e5fcbc444 URL: https://github.com/llvm/llvm-project/commit/edf6a19adf7acf54f96e78718fb2339e5fcbc444 DIFF: https://github.com/llvm/llvm-project/commit/edf6a19adf7acf54f96e78718fb2339e5fcbc444.diff LO

[PATCH] D76622: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

NoQ added a comment. Sounds good but eventually i hope we re-enable this assert in release+assert builds (D57062 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76622/new/ https://reviews.llvm.org/D76622 __

[PATCH] D76605: [analyzer] Display the checker name in the text output

NoQ added a comment. Sounds great! Does the checker name get printed on the final note as well in text output? We should probably test it. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:313-316 +ANALYZER_OPTION(bool, ShouldDisplayCheckerNameForText, "

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

NoQ added a comment. In D76379#1930917 , @baloghadamsoftware wrote: > In D76379#1929698 , @Szelethus wrote: > > > The patch looks great, though I'd kindly ask you to wait a bit for someone > > with a bit more expe

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, mgorny, dschuff. Herald added a project: clang. sbc100 retitled this revision from "Allow -DDEFAULT_SYSROOT to be a relative path" to "[clang] Allow -DDEFAULT_SYSROOT to be a relative path". sbc100 added reviewe

[PATCH] D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc

LiuChen3 marked an inline comment as done. LiuChen3 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1570 +return 4; +} else if (Align < 16) + return MinABIStackAlignInBytes; LiuChen3 wrote: > jyknight wrote: > > If I understoo

[PATCH] D76643: [objc_direct] also go through implementations when looking for clashes

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaDeclObjC.cpp:4621 + // - when we do not find a match in a given @interface container, + // we need to attempt lookin

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 added a comment. I have no idea how to write a test for this, but I tested it locally with wasi SDK. Hopefully fucia will find this useful too as a generic version of https://reviews.llvm.org/D42019 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is a simpler request/response protocol. Reference: https://github.com/microsoft/vscode-

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

phosek added inline comments. Comment at: clang/lib/Driver/Driver.cpp:140 + if (llvm::sys::path::is_relative(SysRoot)) { +SysRoot = GetResourcesPath(ClangExecutable, SysRoot); + } I don't think this is an intended use for `GetResourcesPath` since this is no

[PATCH] D76592: [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:709 } SwitchDiagnoser(Cond); + // The TypoExpr might be corrected to a non-intergral-or-enum type in the + // later stage without the proper type check, which is invalid for switch How

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76528/new/ https://reviews.llvm.org/D76528 ___ cf

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added inline comments. Herald added a subscriber: ASDenysPetrov. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:713 + StringRef Name; + if (const auto *DRE = dyn_cast(ContE->IgnoreParenCasts())) { +Name = DRE->getDecl()->getName();

[PATCH] D74541: [Analyzer] Use note tags to track iterator increments and decrements

NoQ added inline comments. Herald added a subscriber: ASDenysPetrov. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:489-490 +StringRef ChangeText = + ((Op == OO_Plus || Op == OO_PlusEqual) != (ChangeVal <= 0)) ? + "incremented" : "decremented"; +

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

NoQ added inline comments. Herald added a subscriber: ASDenysPetrov. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto &LCV1 = It1.getAs()) { + BR.markInteresting(LCV1->getRegion()); +

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:713 + StringRef Name; + if (const auto *DRE = dyn_cast(ContE->IgnoreParenCasts())) { +Name = DRE->getDecl()->getName(); NoQ wrote: > baloghadamsoftware wrote: > >

[PATCH] D74615: [Analyzer] Add visitor to track iterator invalidation

NoQ added a comment. Herald added a subscriber: ASDenysPetrov. > However, if //something// happens to the value in a transition which is done > by another checker (or the core engine) then ... then //that// checker (or the engine) adds a tag in order to explain itself, because from its point of

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso marked 5 inline comments as done. Charusso added a comment. Thanks for the feedback! Given that it will remain an `alpha` checker for a long time (~1 year), no one really should use it. Comment at: clang/docs/analyzer/checkers.rst:1935 + +alpha.security.cert.str.31c +

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252203. oontvoo added a comment. (hopefully) Final revision ... running out of idea for edit comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/incl

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252206. oontvoo added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252205. oontvoo added a comment. Fix build errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL, error if an output loc is missing for PathDiagConsumers that need it

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:209 AnalysisConstraints AnalysisConstraintsOpt = RangeConstraintsModel; - AnalysisDiagClients AnalysisDiagOpt = PD_HTML; + AnalysisDiagClients AnalysisDiagOpt = PD_TEXT_MINIMAL;

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

NoQ added a comment. In D76229#1929453 , @martong wrote: > Please note about the alignment requirements that they are not checked in the > static analyzer for a reason. To track the alignment data across the data > flow, probably we should modify the ana

[clang] 20d704a - [objc_direct] also go through implementations when looking for clashes

Author: Pierre Habouzit Date: 2020-03-23T20:49:09-07:00 New Revision: 20d704a75ed51c7a9a155aa3978d0c02671c3f69 URL: https://github.com/llvm/llvm-project/commit/20d704a75ed51c7a9a155aa3978d0c02671c3f69 DIFF: https://github.com/llvm/llvm-project/commit/20d704a75ed51c7a9a155aa3978d0c02671c3f69.dif

[PATCH] D76643: [objc_direct] also go through implementations when looking for clashes

This revision was automatically updated to reflect the committed changes. Closed by commit rG20d704a75ed5: [objc_direct] also go through implementations when looking for clashes (authored by MadCoder). Changed prior to commit: https://reviews.llvm.org/D76643?vs=252162&id=252214#toc Repository:

[clang] d0f4af8 - [Coroutines] Insert lifetime intrinsics even O0 is used

Author: Jun Ma Date: 2020-03-24T13:41:55+08:00 New Revision: d0f4af8f3088f72df7fea9983127cbeeebbef6a1 URL: https://github.com/llvm/llvm-project/commit/d0f4af8f3088f72df7fea9983127cbeeebbef6a1 DIFF: https://github.com/llvm/llvm-project/commit/d0f4af8f3088f72df7fea9983127cbeeebbef6a1.diff LOG: [

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D76119: [Coroutines] Insert lifetime intrinsics even O0 is used

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd0f4af8f3088: [Coroutines] Insert lifetime intrinsics even O0 is used (authored by junparser). Herald added a project: cla

<    1   2   3