[clang] 19fccc5 - [Concepts] Fix incorrect control flow when TryAnnotateTypeConstraint annotates an invalid template-id

Author: Saar Raz Date: 2020-03-17T01:49:42+02:00 New Revision: 19fccc52ff2c1da1f93d9317c34769bd9bab8ac8 URL: https://github.com/llvm/llvm-project/commit/19fccc52ff2c1da1f93d9317c34769bd9bab8ac8 DIFF: https://github.com/llvm/llvm-project/commit/19fccc52ff2c1da1f93d9317c34769bd9bab8ac8.diff LOG:

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D73513: [memtag] Plug in stack safety analysis.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a3723ef114d: [memtag] Plug in stack safety analysis. (authored by eugenis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73513/new/ https://reviews.llvm.o

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1013 + if (V->hasInit()) +return Visit(V->getInit(), V->getType()); +return nullptr; rsmith wrote: > nickdesaulniers wrote: > > efriedma wrote: > > > You need to be

[clang] fbb23c9 - Fix profiling options on PS4 target:

Author: Dmitry Mikulin Date: 2020-03-16T16:52:47-07:00 New Revision: fbb23c9714f21c5f46ced5ccaed0cb90e05f61e7 URL: https://github.com/llvm/llvm-project/commit/fbb23c9714f21c5f46ced5ccaed0cb90e05f61e7 DIFF: https://github.com/llvm/llvm-project/commit/fbb23c9714f21c5f46ced5ccaed0cb90e05f61e7.diff

[PATCH] D74238: [clang] Improve diagnostic note for implicit conversion sequences that would work if more than one implicit user-defined conversion were allowed.

rsmith added a comment. How do you defend against attempting an infinite sequence of user-defined conversion? For example: template struct X { operator X(); }; X<0> x0 = X<1>(); Comment at: clang/lib/Sema/SemaOverload.cpp:7333 +// Save the bad conversion in th

[PATCH] D75274: Fix profiling option on PS4 target

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbb23c9714f2: Fix profiling options on PS4 target: - libclang_rt.profile should be added when… (authored by dmikulin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds added a comment. In D75917#1917296 , @JonChesterfield wrote: > In D75917#1916972 , @sameerds wrote: > > > Well, there is a problem: The LangRef says that scopes are target-defined. > > This change says th

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1013 + if (V->hasInit()) +return Visit(V->getInit(), V->getType()); +return nullptr; efriedma wrote: > rsmith wrote: > > nickdesaulniers wrote: > > > efriedma wrote: >

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl marked 23 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1470 +/// diagnostics should be emitted. +SmallVector DeclsToCheckForDeferredDiags; + rjmccall wrote: > This needs to be saved and restored

[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl created this revision. yaxunl added a reviewer: rjmccall. This patch is extracted from https://reviews.llvm.org/D70172 https://reviews.llvm.org/D76262 Files: clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/UsedDeclVisitor.h Index: clang/lib/Sema/UsedDeclVisitor.h

[clang] 90a2fbd - Switch to TypeSystemClang over to CreateDeserialized() (NFC)

Author: Adrian Prantl Date: 2020-03-16T18:11:36-07:00 New Revision: 90a2fbdb044bcf285646e79f3b096ccb196f6d02 URL: https://github.com/llvm/llvm-project/commit/90a2fbdb044bcf285646e79f3b096ccb196f6d02 DIFF: https://github.com/llvm/llvm-project/commit/90a2fbdb044bcf285646e79f3b096ccb196f6d02.diff

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added a comment. In D75917#1925617 , @sameerds wrote: > Is it really? The scope argument of the IR fence is a target-specific string: > http://llvm.org/docs/LangRef.html#syncscope > > The change that I see here is assuming a numerical argu

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1013 + if (V->hasInit()) +return Visit(V->getInit(), V->getType()); +return nullptr; rsmith wrote: > efriedma wrote: > > rsmith wrote: > > > nickdesaulniers wrote: >

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl updated this revision to Diff 250666. yaxunl marked 6 inline comments as done. yaxunl added a comment. revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 Files: clang/include/clang/Sema/ExternalSemaSource.h cl

[PATCH] D75715: Switch TypeSystemClang over to CreateDeserialized() (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG90a2fbdb044b: Switch to TypeSystemClang over to CreateDeserialized() (NFC) (authored by aprantl). Herald added projects: clang, LLDB. Herald added a subscriber: cfe-commits. Changed prior to commit: htt

[PATCH] D76262: [NFC] Add UsedDeclVisitor

rjmccall added a comment. Thanks, looks good except for one oversight. Comment at: clang/lib/Sema/UsedDeclVisitor.h:43 + asImpl().visitUsedDecl(E->getMemberLoc(), D); +} + } You need to recurse on the base expression here. (And that's a good test cas

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { bader wrote: > yaxunl wrote: > > rjmccall wrote: > > > yaxunl wr

[PATCH] D76264: [ObjC generics] Fix missing protocols on type parameter for unparameterized generics.

vsapsai created this revision. vsapsai added reviewers: erik.pilkington, ahatanak. Herald added subscribers: ributzka, jfb, dexonsmith, jkorous. Herald added a project: clang. When a type parameter is used with some protocols, we should keep these protocols both when the generic type is parameteri

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 250684. alokmishra.besu added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Adding test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://revi

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a subscriber: manmanren. rjmccall added a comment. This might also be interesting to @manmanren. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:677 + E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +Cleanup.setExprNeedsCleanups(true); + Why only when the l-value is volatile? Comment at

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

rjmccall added a comment. Ugh. I'd hate to introduce yet another weird little tweak to `ABIArgInfo` that's used on exactly one target. For 16-bit composite types, we seem to coerce to a type like `[1 x i32]`; would that be okay here? You don't have a test that checks that you get the IR you w

[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl updated this revision to Diff 250688. yaxunl marked 2 inline comments as done. yaxunl added a comment. visit base expr of member expr. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76262/new/ https://reviews.llvm.org/D76262 Files: clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/U

[PATCH] D76262: [NFC] Add UsedDeclVisitor

yaxunl added inline comments. Comment at: clang/lib/Sema/UsedDeclVisitor.h:43 + asImpl().visitUsedDecl(E->getMemberLoc(), D); +} + } rjmccall wrote: > You need to recurse on the base expression here. (And that's a good test > case for your own patch!)

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds added a comment. In D75917#1925700 , @JonChesterfield wrote: > > I think I follow. The syncscope takes a string, therefore the builtin that > maps onto fence should also take a string for that parameter? That's fine by > me. Will help if a

[PATCH] D76262: [NFC] Add UsedDeclVisitor

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76262/new/ https://reviews.llvm.org/D76262 ___ cfe-commits mailing list

[PATCH] D60748: Fix i386 struct and union parameter alignment

LiuChen3 added a comment. In D60748#1924794 , @rjmccall wrote: > Oh, I see you just updated your patch months ago without ever mentioning that > it was ready for review. > > It sounds to me like GCC retroactively added a switch specifying which > version

[PATCH] D76269: [opaque pointer types] Remove deprecated Instruction/IRBuilder APIs.

efriedma created this revision. efriedma added reviewers: nhaehnle, t.p.northover, dblaikie. Herald added a reviewer: bollu. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Removes deprecated overloads of LoadInst constructor, CallInst::Create, InvokeInst::Create, IRBui

[PATCH] D60748: Fix i386 struct and union parameter alignment

rjmccall added a comment. In D60748#1925907 , @LiuChen3 wrote: > In D60748#1924794 , @rjmccall wrote: > > > Oh, I see you just updated your patch months ago without ever mentioning > > that it was ready for review.

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

lebedev.ri added a reviewer: NoQ. lebedev.ri added a comment. Herald added a subscriber: Charusso. In D76229#1925371 , @f00kat wrote: > In D76229#1925360 , @lebedev.ri > wrote: > > > This seems to be already handle

<    1   2