[PATCH] D75737: [Sema][SVE] Don't allow fields to have sizeless type

efriedma added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1633 +if (RequireCompleteSizedType(Loc, FieldType, + diag::err_field_incomplete_or_sizeless)) { RD->setInvalidDecl(); Can BuildCaptureField actual

[PATCH] D75573: [Sema][SVE] Reject aligned/_Alignas for sizeless types

efriedma added a comment. LGTM Technically, you could still do math on the address, and the difference would be visible. Granted, it's unlikely to matter in practice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75573/new/ https://reviews.llvm.o

[PATCH] D75736: [Sema][SVE] Don't allow static or thread-local variables to have sizeless type

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75736/new/ https://reviews.llvm.org/D75736 ___

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-unintended-adl.cpp:202 +void macro_test(T t) { +#define MACRO(x) find_if(x, x, x) + logan-5 wrote: > EricWF wrote: > > Arguably this is *exactly* the kind of code

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert created this revision. aaronpuchert added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have to properly initialize from the given initialization expression to make types match. Repository: rG LLVM Github Monorepo https://reviews.ll

Re: [PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

On Wed, Mar 11, 2020 at 8:35 PM Arthur O'Dwyer via Phabricator < revi...@reviews.llvm.org> wrote: > Quuxplusone added inline comments. > > > > Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.h:27 > +class UnintendedADLCheck : public ClangTidyCheck { > + const

[clang] 214d24e - [X86] Support intrinsic _mm_broadcastsi128_si256

Author: Shengchen Kan Date: 2020-03-12T10:56:39+08:00 New Revision: 214d24e1f8e0737a5aa2e2c52a1ae095fb1c1abd URL: https://github.com/llvm/llvm-project/commit/214d24e1f8e0737a5aa2e2c52a1ae095fb1c1abd DIFF: https://github.com/llvm/llvm-project/commit/214d24e1f8e0737a5aa2e2c52a1ae095fb1c1abd.diff

[PATCH] D76039: [HIP] Let clang recognize .hip extension

yaxunl created this revision. yaxunl added a reviewer: tra. https://reviews.llvm.org/D76039 Files: clang/lib/Frontend/FrontendOptions.cpp clang/test/CodeGenCUDA/hip-pinned-shadow.cu clang/test/CodeGenCUDA/hip-pinned-shadow.hip clang/test/Driver/hip-autolink.hip clang/test/Driver/hip-def

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert planned changes to this revision. aaronpuchert added a comment. In D76038#1918571 , @aaronpuchert wrote: > @rsmith, should I put a testcase under `test/SemaTemplate/`, perhaps as > `instantiate-lambda.cpp`? I'll probably put it into `test/

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 marked an inline comment as done. logan-5 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-unintended-adl.cpp:202 +void macro_test(T t) { +#define MACRO(x) find_if(x, x, x) + Quuxplusone wrote: > logan-5 wrote: > > E

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert added a comment. @rsmith, should I put a testcase under `test/SemaTemplate/`, perhaps as `instantiate-lambda.cpp`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76038/new/ https://reviews.llvm.org/D76038 ___

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rnk created this revision. rnk added reviewers: aaron.ballman, rjmccall, jdoerfert. Herald added a project: clang. After this change, clang spends ~200ms parsing Attrs.inc instead of ~560ms. A large part of the cost was from the StringSwitch instantiations, but this is a good way to avoid similar

[PATCH] D75897: [X86] Support intrinsic _mm_broadcastsi128_si256

This revision was automatically updated to reflect the committed changes. Closed by commit rG214d24e1f8e0: [X86] Support intrinsic _mm_broadcastsi128_si256 (authored by skan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75897/new/ https://reviews.

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert added a comment. Seems the same issue in `Sema::SubstParmVarDecl` was fixed in rGdc40b618cf397df7369406b3f61e91ccb57fb9f6 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang-tools-extra] d7c5037 - Prune TargetInfo.h include from ParsedAttr.h, NFC

Author: Reid Kleckner Date: 2020-03-11T20:47:11-07:00 New Revision: d7c5037e6b9f0ac76f4880c529ae4e14b78e0bf0 URL: https://github.com/llvm/llvm-project/commit/d7c5037e6b9f0ac76f4880c529ae4e14b78e0bf0 DIFF: https://github.com/llvm/llvm-project/commit/d7c5037e6b9f0ac76f4880c529ae4e14b78e0bf0.diff

[clang] c4d23d8 - Add a missing include to clang unit tests

Author: Reid Kleckner Date: 2020-03-11T21:05:20-07:00 New Revision: c4d23d8854840294bf49c524f93e2be85a401f00 URL: https://github.com/llvm/llvm-project/commit/c4d23d8854840294bf49c524f93e2be85a401f00 DIFF: https://github.com/llvm/llvm-project/commit/c4d23d8854840294bf49c524f93e2be85a401f00.diff

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rjmccall added a comment. Are there any classes of methods which are worth continuing to generate inline? Surely some of the accessors are trivial. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76040/new/ https://reviews.llvm.org/D76040 __

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rnk marked an inline comment as done. rnk added a comment. The main things going out of line are: - Create* factory methods - Constructors - Enum/string converters (use StringSwitch -> slow to instantiate) Here's two examples from before & after: https://reviews.llvm.org/P8203 https://reviews.ll

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added a comment. In D72841#1917459 , @rjmccall wrote: > In D72841#1917340 , @mibintc wrote: > > > @rjmccall Since CompoundAssignmentOperator derives from BinaryOperator, > > it's not simple to add Trailing

[PATCH] D76040: [TableGen] Move generated *Attr class methods out of line

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76040/new/ https://reviews.llvm.org/D76040 __

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

vvereschaka added a comment. I tried to reproduce the problem on the builder in a temporary folder and I found that CMAKE_SOURCE_DIR == CMAKE_BINARY_DIR == . Here is a list of all CMAKE_ variables available on a moment of initial configuration: -- CMAKE_AR: c:/buildbot/temp/build/bin/llvm-ar.

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 added a comment. In D57497#1917835 , @apazos wrote: > Shiva, I see a warning always being printed: > > '+small-data-limit=' is not a recognized feature for this target (ignoring > feature) > > > This is because it is being passed down as a

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 249835. shiva0217 added a comment. Update the patch to address @apazos's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497 Files: clang/docs/ClangCommandLin

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 updated this revision to Diff 249838. MarcusJohnson91 added a comment. New squashed commit with all changes present CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Format

<    1   2   3