[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c70dec18c7e: [libunwind] Remove __FILE__ and __LINE__ from error reporting (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75890/ne

[PATCH] D75901: [clang-tidy] misc-unconventional-assign-operator suggest to use rvalue references in C++03 mode

tetsuo-cpp marked an inline comment as done. tetsuo-cpp added a comment. @njames93 @MaskRay Thanks for helping me with testing. I'll remember this for next time. I also saw this pattern of retrieving `LangOptions` from an `ASTContext` in some other checks (`RedundantExpressionCheck` and `Static

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds added a comment. The commit summary needs improvement. The syntax is not really necessary there, but instead this needs a better explanation of how this builtin fits in with the overall scheme of language-specific and target-specific details of an atomic operation. For example, is this

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 249544. PaulkaToast added a comment. Addressed @Eugene.Zelenko comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-extra/clang-tidy/CMake

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 249545. shiva0217 added a comment. Update patch to address @evandro's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497 Files: clang/docs/ClangCommandLineRe

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

skan updated this revision to Diff 249546. skan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75723/new/ https://reviews.llvm.org/D75723 Files: clang/lib/Headers/ia32intrin.h clang/test/CodeGen/bitscan-

[PATCH] D75894: [X86] Support intrinsics _bextr2*

skan updated this revision to Diff 249547. skan added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75894/new/ https://reviews.llvm.org/D75894 Files: clang/lib/Headers/bmiintrin.h clang/test/CodeGen/bmi-builti

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

craig.topper added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:456 + __extension__({ \ +long long c = (long long)(b); \ +unsigned char d;

[PATCH] D75896: [X86] Support intrinsic _mm_cldemote

skan updated this revision to Diff 249548. skan added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75896/new/ https://reviews.llvm.org/D75896 Files: clang/lib/Headers/cldemoteintrin.h clang/test/CodeGen/cldemote.c Index:

[PATCH] D75894: [X86] Support intrinsics _bextr2*

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75894/new/ https://reviews.llvm.org/D75894 ___

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

craig.topper added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:417 +#define _BitScanForward(a, b) \ + __extension__({ \ +int c = (int)(b);

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

jrtc27 added a comment. I believe my previous comments have indeed been addressed. Comment at: clang/docs/ClangCommandLineReference.rst:2958 + +Put global and static data smaller than the limitation into a special section (RISCV only) + lenary wrote: > "(RISC-

[PATCH] D75971: Should not need the second predicate.If `II->hasMacroDefinition()` is true, then the whole expr is always true.

oontvoo created this revision. oontvoo added a reviewer: jyknight. Herald added a project: clang. Herald added a subscriber: cfe-commits. remove redundant pred Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75971 Files: clang/include/clang/Lex/Preprocessor.h Index: clang/i

[PATCH] D75896: [X86] Support intrinsic _mm_cldemote

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75896/new/ https://reviews.llvm.org/D75896 ___

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

craig.topper added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:417 +#define _BitScanForward(a, b) \ + __extension__({ \ +int c = (int)(b);

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

skan updated this revision to Diff 249550. skan marked an inline comment as done. skan added a comment. Make the variale name in macro start with 2 underscores Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75723/new/ https://reviews.llvm.org/D75723

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

skan added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:456 + __extension__({ \ +long long c = (long long)(b); \ +unsigned char d;

[clang] 37fa9d6 - [CodeGen][ObjC] Don't extend lifetime of ObjC pointers passed to calls

Author: Akira Hatanaka Date: 2020-03-10T22:10:32-07:00 New Revision: 37fa9d65eaa7d8fae7e5b787c4e8ef0a982cead5 URL: https://github.com/llvm/llvm-project/commit/37fa9d65eaa7d8fae7e5b787c4e8ef0a982cead5 DIFF: https://github.com/llvm/llvm-project/commit/37fa9d65eaa7d8fae7e5b787c4e8ef0a982cead5.diff

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

craig.topper added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:421 +if (__c != 0) { \ + *(a) = (unsigned)__bsfd(__c); \ + __d = 1;

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

shiva0217 updated this revision to Diff 249558. shiva0217 added a comment. Update patch to address @jrtc27's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497 Files: clang/docs/ClangCommandLineRefe

[PATCH] D75723: [X86] Enable intrinsics _BitScan*

skan marked an inline comment as done. skan added inline comments. Comment at: clang/lib/Headers/ia32intrin.h:421 +if (__c != 0) { \ + *(a) = (unsigned)__bsfd(__c); \

<    1   2   3