[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

2020-03-09 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. In D75563#1911375 , @aaron.ballman wrote: > Thank you for working on this, this LGTM! If you wanted a follow-up patch > beyond adding semantic support for the `inline` key

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

2020-03-09 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers planned changes to this revision. nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1545 +Diag(Tok, diag::err_global_asm_qualifier_ignored) +<< GNUAsmQualifiers::getSpecifier

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

2020-03-09 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 249246. nickdesaulniers added a comment. This revision is now accepted and ready to land. - rebase, divorce from DeclSpec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.or

[clang] 2669e41 - PR45083: Mark statement expressions as being dependent if they contain

2020-03-09 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-03-09T16:57:07-07:00 New Revision: 2669e41b7b9c1561a01048d5ed0aba3c62432dfc URL: https://github.com/llvm/llvm-project/commit/2669e41b7b9c1561a01048d5ed0aba3c62432dfc DIFF: https://github.com/llvm/llvm-project/commit/2669e41b7b9c1561a01048d5ed0aba3c62432dfc.diff

[clang] 6333cc2 - Revert "PR45083: Mark statement expressions as being dependent if they contain"

2020-03-09 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-03-09T17:03:56-07:00 New Revision: 6333cc2a12dc72d0cfaaac5ade00e9a1b9d6dbce URL: https://github.com/llvm/llvm-project/commit/6333cc2a12dc72d0cfaaac5ade00e9a1b9d6dbce DIFF: https://github.com/llvm/llvm-project/commit/6333cc2a12dc72d0cfaaac5ade00e9a1b9d6dbce.diff

[clang] 77eec38 - [ASTMatchers] Add hasAnyOverloadedOperatorName matcher

2020-03-09 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-03-10T00:11:27Z New Revision: 77eec38626cb9e796f6cbb108ea9be5ee6e0ce81 URL: https://github.com/llvm/llvm-project/commit/77eec38626cb9e796f6cbb108ea9be5ee6e0ce81 DIFF: https://github.com/llvm/llvm-project/commit/77eec38626cb9e796f6cbb108ea9be5ee6e0ce81.diff LOG:

[PATCH] D75841: [ASTMatchers] Add hasAnyOverloadedOperatorName matcher

2020-03-09 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG77eec38626cb: [ASTMatchers] Add hasAnyOverloadedOperatorName matcher (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75841/new/ https:

[clang-tools-extra] 97572fa - [NFC] use hasAnyOperatorName and hasAnyOverloadedOperatorName functions in clang-tidy matchers

2020-03-09 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-03-10T00:42:21Z New Revision: 97572fa6e9daecd648873496fd11f7d1e25a55f0 URL: https://github.com/llvm/llvm-project/commit/97572fa6e9daecd648873496fd11f7d1e25a55f0 DIFF: https://github.com/llvm/llvm-project/commit/97572fa6e9daecd648873496fd11f7d1e25a55f0.diff LOG:

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

2020-03-09 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 249254. nickdesaulniers added a comment. This revision is now accepted and ready to land. - DRY up getting the Qualifier, and checking Tok.is Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ htt

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

2020-03-09 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers planned changes to this revision. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. Sorry, got a little trigger happy with the refactoring. Having a weekend to think about this more definitely helps. It's nice to avoid instantiating a whole inst

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

2020-03-09 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D75579#1912535 , @serge-sans-paille wrote: > @MaskRay The library version prooved to be a bad path: we wanted clang-cpp to > always link to a shared library, which interacts in ungraceful ways with > BUILD_SHARED_LIBS. > > Th

[PATCH] D75323: Support relative dest paths in headermap files

2020-03-09 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno requested changes to this revision. bruno added a comment. This revision now requires changes to proceed. I also want to understand why you want this change. I'm not convinced this is the behavior we want and it's not like we encourage people to use header maps in the first place. I'd be f

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

2020-03-09 Thread Shiva Chen via Phabricator via cfe-commits
shiva0217 added a comment. In D57497#1913473 , @apazos wrote: > Shiva, we forgot about this patch. Can you rebase it so we move on with > merging. Ok, I'll rebase the patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D75890: [libunwind] Add flag to disable logging

2020-03-09 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan created this revision. leonardchan added a reviewer: phosek. Herald added subscribers: libcxx-commits, cfe-commits, mgorny. Herald added projects: clang, libc++. We were seeing non-deterministic binary size differences depending on which toolchain was used to build fuchsia. This is be

[PATCH] D75890: [libunwind] Add flag to disable logging

2020-03-09 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. Herald added a reviewer: mclow.lists. I'd prefer to make this the behavior when just `NDEBUG` is set, I think it's rather unexpected to still get debug messages even after you set `NDEBUG`, but since that would be a breaking change, it deserves an email to llvm-dev to en

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

2020-03-09 Thread Shiva Chen via Phabricator via cfe-commits
shiva0217 updated this revision to Diff 249279. shiva0217 added a comment. Rebase to the trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497 Files: clang/docs/ClangCommandLineReference.rst clang/inclu

<    1   2   3