[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis added a comment. In D74692#1911150 , @Quuxplusone wrote: > Anyway, I still don't see the point of this patch. It seems like you're just > duplicating the work of `performance-move-const-arg`. People who want to be > shown notes about moves-of-

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis marked 2 inline comments as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:342 + // CHECK-NOTES: [[@LINE-5]]:20: note: variable 'a' implicitly captured const here }; } --

[PATCH] D75732: [ASTImporter] Added visibility check for variable templates.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75732/new/ https://reviews.llvm.org/D75732

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

a_sidorin added a comment. Hello Balazs, This look almost good to me except some comments inline. Comment at: clang/lib/AST/ASTImporter.cpp:3635 +static std::tuple +getFriendCountAndPosition(FriendDecl *FD) { It's better to turn the tuple into a named struct

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaron.ballman added a comment. In D72635#1911495 , @aaronpuchert wrote: > @aaron.ballman, I've just noted that one of the `-Wthread-safety-attributes` > warnings says > >

[clang] 073dbaa - Fix GCC warnings. NFC.

Author: Michael Liao Date: 2020-03-08T13:00:36-04:00 New Revision: 073dbaae39724ea860b5957fe47ecc1c2a84b197 URL: https://github.com/llvm/llvm-project/commit/073dbaae39724ea860b5957fe47ecc1c2a84b197 DIFF: https://github.com/llvm/llvm-project/commit/073dbaae39724ea860b5957fe47ecc1c2a84b197.diff

[PATCH] D75779: [OpenMP] `omp begin/end declare variant` - part 2, semantic analysis

jdoerfert planned changes to this revision. jdoerfert added a comment. I'll try to remove the extra namespace and I'll split the `function(is_definition)` matcher out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75779/new/ https://reviews.llvm.o

[PATCH] D75827: Add new `attribute push` matcher `function(is_definition)`

jdoerfert created this revision. jdoerfert added reviewers: erichkeane, aaron.ballman. Herald added a subscriber: bollu. Herald added a project: clang. This can also be used as a subject for attributes. TODO: Tests are missing. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaronpuchert added a comment. In D72635#1911671 , @aaron.ballman wrote: > However, do we want to diagnose when the capability strings are different? Hmm, interesting question. The way I think about ordering capabilities is this: assuming I have more th

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

boga95 updated this revision to Diff 249019. boga95 marked 2 inline comments as done. boga95 added a comment. Rebase to master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71524/new/ https://reviews.llvm.org/D71524 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[clang-tools-extra] fc3c80c - [ASTMatchers] adds isComparisonOperator to BinaryOperator and CXXOperatorCallExpr

Author: Nathan James Date: 2020-03-09T00:05:10Z New Revision: fc3c80c38643aff6c4744433ab485c7550ee77b9 URL: https://github.com/llvm/llvm-project/commit/fc3c80c38643aff6c4744433ab485c7550ee77b9 DIFF: https://github.com/llvm/llvm-project/commit/fc3c80c38643aff6c4744433ab485c7550ee77b9.diff LOG:

[PATCH] D75800: [ASTMatchers] adds isComparisonOperator to BinaryOperator and CXXOperatorCallExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc3c80c38643: [ASTMatchers] adds isComparisonOperator to BinaryOperator and… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75800/new/