[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

2020-03-06 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen marked an inline comment as done. sdesmalen added a comment. Herald added a subscriber: danielkiss. In D75470#1907562 , @SjoerdMeijer wrote: > Adding @simon_tatham in case he feels wants to have a look too. Thanks Sjoerd! @simon_tatham and I h

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

2020-03-06 Thread Michael Wyman via Phabricator via cfe-commits
mwyman updated this revision to Diff 248788. mwyman added a comment. Update documentation to include description of the FixMacroNames config option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75569/new/ https://reviews.llvm.org/D75569 Files:

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

2020-03-06 Thread John Brawn via Phabricator via cfe-commits
john.brawn marked 3 inline comments as done. john.brawn added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6701-6707 if (!AL.isStmtAttr()) { // Type attributes are handled elsewhere; silently move on. assert(AL.isTypeAttr() && "Non-type attribut

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

2020-03-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 248789. ABataev marked an inline comment as done. ABataev added a comment. Rebase + fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 Files: clang/include/clang-c

[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

2020-03-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6701-6707 if (!AL.isStmtAttr()) { // Type attributes are handled elsewhere; silently move on. assert(AL.isTypeAttr() && "Non-type attribute not handled"); break; }

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

2020-03-06 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:4100 + if (E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +pushDestroy(QualType::DK_nontrivial_c_struct, DeclPtr, E->getType()); +

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

2020-03-06 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 248797. ahatanak added a comment. Don't try to push a cleanup in C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64464/new/ https://reviews.llvm.org/D64464 Files: clang/include/clang/AST/ASTImporter.h

[PATCH] D53327: [Hexagon] Use -fuse-ld update checks.

2020-03-06 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53327/new/ https://reviews.llvm.org/D53327 ___ cfe-commits ma

[PATCH] D75723: [X86] Make intrinsics _BitScan* not limited to Windows

2020-03-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:1904 +// BITSCAN +TARGET_BUILTIN(_BitScanForward, "UcUNi*UNi", "n", "") +TARGET_BUILTIN(_BitScanReverse, "UcUNi*UNi", "n", "") craig.topper wrote: > skan wrote: > > craig.topper wrot

[clang] 00b2a9d - Reapply "clang: Treat ieee mode as the default for denormal-fp-math"

2020-03-06 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2020-03-06T11:46:55-08:00 New Revision: 00b2a9df452d25cf4a780d20bab7d557d76604ae URL: https://github.com/llvm/llvm-project/commit/00b2a9df452d25cf4a780d20bab7d557d76604ae DIFF: https://github.com/llvm/llvm-project/commit/00b2a9df452d25cf4a780d20bab7d557d76604ae.diff

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

2020-03-06 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. Thanks, Verified that this fixes the kernel warnings in my local builds with https://gist.github.com/nathanchance/767cccf4d093c1342e1994083518815e! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75758/new/ https://review

[PATCH] D74361: [Clang] Undef attribute for global variables

2020-03-06 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield updated this revision to Diff 248807. JonChesterfield marked 2 inline comments as done. JonChesterfield added a comment. - Review comments, add tests for private_extern Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https:

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

2020-03-06 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3673 +def warn_pointer_to_enum_cast : Warning< + "cast to smaller integer type %1 from %0">, + InGroup; You can reuse warning text: warn_pointer_to_int_cast.Text I th

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

2020-03-06 Thread Jeremy Stenglein via Phabricator via cfe-commits
jstenglein created this revision. jstenglein added reviewers: efriedma, lebedev.ri, rsmith, erichkeane. jstenglein added a project: clang. Herald added a subscriber: cfe-commits. Clang is missing a warning for __builtin_return_address/__builtin_frame_address called with > 0 argument. Gcc provide

[PATCH] D74361: [Clang] Undef attribute for global variables

2020-03-06 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. > I thought err_loader_uninitialized_extern says that the variable cannot have > external linkage? Embarrassing! This was a badly written error message, now fixed to: `external declaration of variable cannot have the 'loader_uninitialized' attribute` The premis

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

2020-03-06 Thread Zachary Turner via Phabricator via cfe-commits
zturner added a comment. If the current listed reviewers on this patch are not the best people for reviewing this, would one of them please suggest a more appropriate reviewer so we can get some traction on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

2020-03-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable about the intended guidance for adding to Wmost, so if you can clarify this decision I'd be grateful. Otherwise I think this patch looks fine. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

2020-03-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I agree with the reasoning, but this is likely to fire all over existing C++ code. In fact, the one we just added finds issues in Chrome https://ci.chromium.org/p/chrome/builders/ci/ToTWin/5879 ../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller integer

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

2020-03-06 Thread Jeremy Stenglein via Phabricator via cfe-commits
jstenglein added a comment. In D75768#1910303 , @erichkeane wrote: > Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable > about the intended guidance for adding to Wmost, so if you can clarify this > decision I'd be grateful. O

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

2020-03-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/MethodUnavailableNotOverrideCheck.cpp:63 + } + return FixItHint::CreateRemoval(MD->getSourceRange()); +} I'm not an ObjC expert, so I apologize if this is a dumb question, but w

[PATCH] D75770: [WebAssembly] Add SIMD integer min/max builtins

2020-03-06 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added reviewers: aheejin, dschuff, kripken. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. Although SIMD integer min/max operations can be expressed using the ?: operator in C++, that operator is disal

[clang] 6d894af - PR45124: Don't leave behind pending cleanups when declaring implicit

2020-03-06 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-03-06T13:22:10-08:00 New Revision: 6d894afdea433879f54e5ba07e827db006645b7b URL: https://github.com/llvm/llvm-project/commit/6d894afdea433879f54e5ba07e827db006645b7b DIFF: https://github.com/llvm/llvm-project/commit/6d894afdea433879f54e5ba07e827db006645b7b.diff

[libunwind] eb755df - Split findUnwindSectionsByPhdr into target-specific functions.

2020-03-06 Thread Sterling Augustine via cfe-commits
Author: Sterling Augustine Date: 2020-03-06T13:28:09-08:00 New Revision: eb755df5c27f5687a4f43a62e7eb0713c3f8f030 URL: https://github.com/llvm/llvm-project/commit/eb755df5c27f5687a4f43a62e7eb0713c3f8f030 DIFF: https://github.com/llvm/llvm-project/commit/eb755df5c27f5687a4f43a62e7eb0713c3f8f030.

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

2020-03-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D75768#1910324 , @jstenglein wrote: > In D75768#1910303 , @erichkeane > wrote: > > > Any reason to not put this in -Wall like GCC? I'm not terribly > > knowledgeable about the intend

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

2020-03-06 Thread Jeremy Stenglein via Phabricator via cfe-commits
jstenglein added a comment. In D75768#1910339 , @erichkeane wrote: > In D75768#1910324 , @jstenglein > wrote: > > > In D75768#1910303 , @erichkeane > > wrote: > > > > > Any

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

2020-03-06 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers marked 4 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:746-755 ParseTypeQualifierListOpt(DS, AR_VendorAttributesParsed); // GNU asms accept, but warn, about type-qualifiers other than volatile.

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

2020-03-06 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 248816. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. Herald added subscribers: jfb, aheejin. - completely drop use of Parse::ParseTypeQualifierListOpt - move paren parsing into helper - fix up test cases for global

[clang] 16af23f - [clang][Headers] Use __has_builtin instead of _MSC_VER.

2020-03-06 Thread Michael Spencer via cfe-commits
Author: Michael Spencer Date: 2020-03-06T13:48:09-08:00 New Revision: 16af23fae8ad2949048e0fc34cf9114dfbe4742a URL: https://github.com/llvm/llvm-project/commit/16af23fae8ad2949048e0fc34cf9114dfbe4742a DIFF: https://github.com/llvm/llvm-project/commit/16af23fae8ad2949048e0fc34cf9114dfbe4742a.dif

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

2020-03-06 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:15 -def warn_asm_qualifier_ignored : Warning< - "ignored %0 qualifier on asm">, CatInlineAsm, InGroup; -def warn_file_asm_vola

[PATCH] D75719: [clang][Headers] Use __has_builtin instead of _MSC_VER.

2020-03-06 Thread Michael Spencer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG16af23fae8ad: [clang][Headers] Use __has_builtin instead of _MSC_VER. (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75719/new/ http

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

2020-03-06 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance updated this revision to Diff 248824. nathanchance edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75758/new/ https://reviews.llvm.org/D75758 Files: clang/include/clang/Basic/DiagnosticGroups.td cl

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

2020-03-06 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 248825. nickdesaulniers added a comment. - use better error name - reorder new errors - git-clang-format HEAD~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563 F

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

2020-03-06 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance marked 2 inline comments as done. nathanchance added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3673 +def warn_pointer_to_enum_cast : Warning< + "cast to smaller integer type %1 from %0">, + InGroup; xbolva00 wrot

[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

2020-03-06 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. Specifically regarding ../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller integer type 'unsigned long' from 'void *', I sent out a change to fix that: https://chromium-review.googlesource.com/c/chromium/src/+/2091215, and tried compiling with ToT

[PATCH] D75517: [clang-format] Do not format C# array subscript operators as attributes

2020-03-06 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added a comment. sorry could you please take another look at the comments I left Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75517/new/ https://reviews.llvm.org/D75517 ___ cfe-commits mailin

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

2020-03-06 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 248827. nickdesaulniers added a comment. - add release note about change in behavior of -Wduplicate-decl-specifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D7556

[clang] d43fcd0 - [WebAssembly] Add SIMD integer min/max builtins

2020-03-06 Thread Thomas Lively via cfe-commits
Author: Thomas Lively Date: 2020-03-06T14:28:52-08:00 New Revision: d43fcd0c0410d474a947cf51a3c67aa2e8d5a711 URL: https://github.com/llvm/llvm-project/commit/d43fcd0c0410d474a947cf51a3c67aa2e8d5a711 DIFF: https://github.com/llvm/llvm-project/commit/d43fcd0c0410d474a947cf51a3c67aa2e8d5a711.diff

[PATCH] D75770: [WebAssembly] Add SIMD integer min/max builtins

2020-03-06 Thread Thomas Lively via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd43fcd0c0410: [WebAssembly] Add SIMD integer min/max builtins (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75770/new/ https://review

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-03-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 248845. jdoerfert added a comment. Pass parsed attribute kind explicitly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75210/new/ https://reviews.llvm.org/D75210 Files: clang/include/clang/Sema/ParsedAttr.

Re: [clang] 8e4a867 - Revert "PR45083: Mark statement expressions as being dependent if they contain"

2020-03-06 Thread Richard Smith via cfe-commits
On Fri, 6 Mar 2020 at 02:11, Stephan Herhut via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: Stephan Herhut > Date: 2020-03-06T11:09:45+01:00 > New Revision: 8e4a8677be3061317056335d298d85ce60c23dff > > URL: > https://github.com/llvm/llvm-project/commit/8e4a8677be3061317056335d298d85

[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

2020-03-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I re-read Richard's comment: > Would it make sense to put the MS extension warning into the > -Wpointer-to-int-cast group so that we can control this warning consistently > across platforms? You co

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

2020-03-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1028 else - MC.mangleName(ND, Out); + MC.mangleName(GD, Out); } else { yaxunl wrote: > rjmccall wrote: > > What would be neces

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

2020-03-06 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added reviewers: aaron.ballman, hans. Herald added projects: clang, LLDB. Herald added a subscriber: lldb-commits. Module.h takes 86ms to parse, mostly parsing the class itself. Avoid it if possible. ASTContext.h depends on ExternalASTSource.h. A few NFC changes wer

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

2020-03-06 Thread Paula Toth via Phabricator via cfe-commits
PaulkaToast updated this revision to Diff 248851. PaulkaToast added a comment. Thanks for the suggestions, the general check sounds like a great idea. I can see the use case for this as it can be used by anyone. I took the time to port out fuchsia's check and flesh out the user facing documentat

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

2020-03-06 Thread Paula Toth via Phabricator via cfe-commits
PaulkaToast created this revision. PaulkaToast added a reviewer: aaron.ballman. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, phosek, xazax.hun, mgorny. Herald added a project: clang. Created a general check for restrict-system-includes under portability as

[clang] f4d791f - [CodeGen][ObjC] Extend lifetime of ObjC pointers passed to calls to

2020-03-06 Thread via cfe-commits
Author: Akira Hatanaka Date: 2020-03-06T16:46:50-08:00 New Revision: f4d791f8332c2bb7e89849d0fe4ef48cb0a23229 URL: https://github.com/llvm/llvm-project/commit/f4d791f8332c2bb7e89849d0fe4ef48cb0a23229 DIFF: https://github.com/llvm/llvm-project/commit/f4d791f8332c2bb7e89849d0fe4ef48cb0a23229.diff

[PATCH] D75323: Support relative dest paths in headermap files

2020-03-06 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. What use case are you trying to support? Currently the added test `headermap_relpath.cpp` is passing without the changes to `HeaderSearch.cpp`, so it's not entirely clear what problem it should address. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75323/new/

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

2020-03-06 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. We're not using this module in Fuchsia at the moment, so I'd be fine not having an alias at all, if we start using it again in the future we'll use the new name. Repository: rG LLVM Github

[PATCH] D75788: [WIP][OpenMP] Reuse CUDA wrappers in `nvptx` target regions.

2020-03-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim, aaron.ballman. Herald added subscribers: guansong, bollu, mgorny. Herald added a project: clang. This is a WIP patch to show o

[PATCH] D75784: Avoid including Module.h from ExternalASTSource.h

2020-03-06 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. This will no doubt also need some patches to the Swift compiler, but given the NFC-ness this hopefully should be fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75784/new/ https://reviews.llvm.org/D75784 ___

[clang-tools-extra] 7003f64 - [clang-doc] Improving Markdown Output

2020-03-06 Thread Petr Hosek via cfe-commits
Author: Petr Hosek Date: 2020-03-06T17:37:08-08:00 New Revision: 7003f64c1eb25e6a0dd10a4beabc3ca7bcaef7eb URL: https://github.com/llvm/llvm-project/commit/7003f64c1eb25e6a0dd10a4beabc3ca7bcaef7eb DIFF: https://github.com/llvm/llvm-project/commit/7003f64c1eb25e6a0dd10a4beabc3ca7bcaef7eb.diff LO

[PATCH] D72954: [clang-doc] Improving Markdown Output

2020-03-06 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7003f64c1eb2: [clang-doc] Improving Markdown Output (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D72954?vs=248338&id=248875#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

2020-03-06 Thread Marcus Johnson via Phabricator via cfe-commits
MarcusJohnson91 created this revision. MarcusJohnson91 added a reviewer: cfe-commits. Herald added a project: clang. and refactored the BraceWrapping.AfterExternBlock code so that it only deals with wrapping the brace after an extern block. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

2020-03-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:123 +- New alias :doc:`fuchsia-restrict-system-includes + ` to Delete `fuchsia-restrict-system-includes` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

2020-03-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 248873. yaxunl added a comment. Remove mangleCXXCtor/Dtor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75700/new/ https://reviews.llvm.org/D75700 Files: clang/include/clang/AST/GlobalDecl.h clang/include/clang/AST/Mangle.h clang/lib/AST/Expr

[PATCH] D75788: [WIP][OpenMP] Reuse CUDA wrappers in `nvptx` target regions.

2020-03-06 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. That's less invasive than I feared. Nicely done. It may worth keeping the openmp header wrapper to do architecture dispatch. Something like: #ifndef __CLANG_OPENMP_MATH_DECLARES_H__ #define __CLANG_OPENMP_MATH_DECLARES_H__ #ifndef _OPENMP #error "This

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

2020-03-06 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:107 + + Moved fuchsia's restrict-system-includes check to portability to allow for + general use. I don't think that this statement is necessary. Commen

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

2020-03-06 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/AST/Expr.cpp:693 else - MC->mangleName(ND, Out); + GD = GlobalDecl(ND); +MC->mangleName(GD, Out); This will need an extension for your case, right? Maybe there should be co

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

2020-03-06 Thread Paula Toth via Phabricator via cfe-commits
PaulkaToast updated this revision to Diff 248882. PaulkaToast marked 5 inline comments as done. PaulkaToast added a comment. Thanks for the heads up phosek, I removed the check from fuchsia's directory. Also addressed Eurgene.Zelenko's comments. (: Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D75723: [X86] Make intrinsics _BitScan* not limited to Windows

2020-03-06 Thread Kan Shengchen via Phabricator via cfe-commits
skan marked an inline comment as done. skan added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:1904 +// BITSCAN +TARGET_BUILTIN(_BitScanForward, "UcUNi*UNi", "n", "") +TARGET_BUILTIN(_BitScanReverse, "UcUNi*UNi", "n", "") rnk wrote: > cr

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

2020-03-06 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:130 ^^ +- The 'fuchsia-restrict-system-headers' check was renamed to :doc:`portability-restrict-system-includes + Please insert empty line above. Repositor

[PATCH] D75788: [WIP][OpenMP] Reuse CUDA wrappers in `nvptx` target regions.

2020-03-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked an inline comment as done. jdoerfert added a comment. In D75788#1910743 , @JonChesterfield wrote: > That's less invasive than I feared. Nicely done. We need to run some more tests to make sure it works as expected but I hope we can com

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

2020-03-06 Thread Paula Toth via Phabricator via cfe-commits
PaulkaToast updated this revision to Diff 248900. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75786/new/ https://reviews.llvm.org/D75786 Files: clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt clang-tools-extra/clang-tidy/fuchsia/FuchsiaTid

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

2020-03-06 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Can objc instance methods be redeclared, the AST suggests so, if so you should probably only warm on the first occurrence but create fix its for each. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75569/new/ https://revie

<    1   2