[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

tbaeder added a comment. I know this has been reverted, but for the record, the implementation has a few shortcomings that makes it hard to use it for projects that rely on fallthrough comments: - The comment is not recognized if it is on the same line as the last statement, e.g. case 2:

Re: [clang] bdad0a1 - PR45083: Mark statement expressions as being dependent if they appear in

Pushed to 10.x as 3a843031a5ad83a00d2603f623881cb2b2bf719d. Please let me know if you hear about any follow-up issues. Thanks! On Wed, Mar 4, 2020 at 12:28 AM Richard Smith via cfe-commits wrote: > > > Author: Richard Smith > Date: 2020-03-03T15:20:40-08:00 > New Revision: bdad0a1b79273733df9acc

[clang] 810127f - [ARM,MVE] Add the `vsbciq` intrinsics.

Author: Simon Tatham Date: 2020-03-04T08:49:27Z New Revision: 810127f6ab5d5d7e7d6b8c3ae0b96f2027437ca8 URL: https://github.com/llvm/llvm-project/commit/810127f6ab5d5d7e7d6b8c3ae0b96f2027437ca8 DIFF: https://github.com/llvm/llvm-project/commit/810127f6ab5d5d7e7d6b8c3ae0b96f2027437ca8.diff LOG:

[clang] 068b2f3 - [ARM,MVE] Add the `vshlcq` intrinsics.

Author: Simon Tatham Date: 2020-03-04T08:49:27Z New Revision: 068b2f313c7d27d9f6445df12d4d45d2d8c00898 URL: https://github.com/llvm/llvm-project/commit/068b2f313c7d27d9f6445df12d4d45d2d8c00898 DIFF: https://github.com/llvm/llvm-project/commit/068b2f313c7d27d9f6445df12d4d45d2d8c00898.diff LOG:

[PATCH] D75445: [ARM,MVE] Add the `vshlcq` intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG068b2f313c7d: [ARM,MVE] Add the `vshlcq` intrinsics. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75445/new/ https://reviews.ll

[PATCH] D75444: [ARM,MVE] Add the `vsbciq` intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG810127f6ab5d: [ARM,MVE] Add the `vsbciq` intrinsics. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75444/new/ https://reviews.ll

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:182 + + auto IncTok = std::next(HashTok); + assert(IncTok != MainFileTokens.end()); ni

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

kadircet updated this revision to Diff 248123. kadircet marked 2 inline comments as done. kadircet added a comment. - Add the old test for hover over operator back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75106/new/ https://reviews.llvm.org/D

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Selection.cpp:612 + // underlying TypeLoc. + // FIXME: Unfortunately this doesn't work, even though RecursiveASTVisi

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:612 + // underlying TypeLoc. + // FIXME: Unfortunately this doesn't work, even though RecursiveASTVisitor + // traverses the underlying TypeLoc inside DeclarationName, it is null f

[clang-tools-extra] ec7c8ba - [clangd] Make use of syntax tokens in ReplayPreamble

Author: Kadir Cetinkaya Date: 2020-03-04T11:01:35+01:00 New Revision: ec7c8bae84557a987d8dce701e8d1ef9183f6cf3 URL: https://github.com/llvm/llvm-project/commit/ec7c8bae84557a987d8dce701e8d1ef9183f6cf3 DIFF: https://github.com/llvm/llvm-project/commit/ec7c8bae84557a987d8dce701e8d1ef9183f6cf3.dif

[clang-tools-extra] e6b8181 - [clangd] Fix early selection for non-vardecl declarators

Author: Kadir Cetinkaya Date: 2020-03-04T11:01:35+01:00 New Revision: e6b8181895b96740dbe54aca036aa237e0a8363d URL: https://github.com/llvm/llvm-project/commit/e6b8181895b96740dbe54aca036aa237e0a8363d DIFF: https://github.com/llvm/llvm-project/commit/e6b8181895b96740dbe54aca036aa237e0a8363d.dif

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet updated this revision to Diff 248124. kadircet marked 2 inline comments as done. kadircet added a comment. - More annotations to the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74842/new/ https://reviews.llvm.org/D74842 Files: cl

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, just a reminder -- the API change of the clangdServer::Callback would break out our internal integration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

This revision was automatically updated to reflect the committed changes. Closed by commit rGec7c8bae8455: [clangd] Make use of syntax tokens in ReplayPreamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74842/new/ https://

[PATCH] D75570: [AST][SVE] Add new Type queries for sizeless types

rsandifo-arm updated this revision to Diff 248125. rsandifo-arm added a comment. Run git-clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75570/new/ https://reviews.llvm.org/D75570 Files: clang/include/clang/AST/CanonicalType.h clan

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6b8181895b9: [clangd] Fix early selection for non-vardecl declarators (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75106/new/ http

[clang] ec3060c - [AST] Refactor propagation of dependency bits. NFC

Author: Ilya Biryukov Date: 2020-03-04T11:25:17+01:00 New Revision: ec3060c72de6ab6992269318d92764199856e5fe URL: https://github.com/llvm/llvm-project/commit/ec3060c72de6ab6992269318d92764199856e5fe DIFF: https://github.com/llvm/llvm-project/commit/ec3060c72de6ab6992269318d92764199856e5fe.diff

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

lebedev.ri added a comment. IIUC `default(firstprivate)` is being added in openmp-5.1, it is not in openmp-4.5, so it should not be accepted in pre-openmp-5.1-mode (i.e. it should be diagnosed) Comment at: clang/lib/Sema/SemaOpenMP.cpp:56 + DSA_firstprivate = + 1 << 1 | 1

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:73 virtual void onDiagnosticsReady(PathRef File, +const llvm::json::Value &Version, std::vector Diagnostics) {} --

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille updated this revision to Diff 248130. serge-sans-paille added a comment. Fix lto-test bugs + convert more files, still not ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

thakis added a comment. Breaks win: http://45.33.8.238/win/9705/step_9.txt (Or your other change that landed at the same time) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74842/new/ https://reviews.llvm.org/D74842

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jeroen.dobbelaere added a comment. Be aware that c99 restrict has a special case for nested restrict that makes the rules stronger: void f(int* restrict *restrict pA, int* restrict * restrict pB) { **pA=**pB; } although pA and pB are only read, (c99 6.7.3.1 #4) specifies that, writing

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGec3060c72de6: [AST] Refactor propagation of dependency bits. NFC (authored by ilya-biryukov, committed by hokein). Changed prior to commit: https://reviews.llvm.

[clang-tools-extra] a8706b2 - [clangd] Fix windows buildbots

Author: Kadir Cetinkaya Date: 2020-03-04T12:07:23+01:00 New Revision: a8706b22a62e3b635bb1b124ad9448544c4b0673 URL: https://github.com/llvm/llvm-project/commit/a8706b22a62e3b635bb1b124ad9448544c4b0673 DIFF: https://github.com/llvm/llvm-project/commit/a8706b22a62e3b635bb1b124ad9448544c4b0673.dif

[PATCH] D75571: [Sema][SVE] Add tests for valid and invalid type usage

rsandifo-arm updated this revision to Diff 248135. rsandifo-arm added a comment. Changes in v2: - Reformat the tests using git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75571/new/ https://reviews.llvm.org/D75571 Files: clang/te

[PATCH] D74467: [analyzer] Teach scan-build how to rebuild index.html without analyzing.

Charusso added a comment. Could you mention how to use this feature in the Summary please? cd reports scan-build --generate-index-only . --- And something is not right, I have tried it: Use of uninitialized value $Clang in concatenation (.) or string at /llvm-project/clang/tools/scan-bu

[clang] 9488543 - Fix some getAs/castAs null dereference static analyzer warnings.

Author: Simon Pilgrim Date: 2020-03-04T11:25:50Z New Revision: 94885431e19687dcc8f2e2f23932b4a6d170b78d URL: https://github.com/llvm/llvm-project/commit/94885431e19687dcc8f2e2f23932b4a6d170b78d DIFF: https://github.com/llvm/llvm-project/commit/94885431e19687dcc8f2e2f23932b4a6d170b78d.diff LOG:

[PATCH] D75160: [AArch64][SVE] Add SVE2 intrinsic for xar

andwar accepted this revision. andwar added a comment. This revision is now accepted and ready to land. LGTM, cheers for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75160/new/ https://reviews.llvm.org/D75160 __

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jeroen.dobbelaere added a comment. The reason I bring this up, is that in the full restrict implementation (D68484 ), the alias analysis will do a recursive analysis, proving that *pA and *pB will never alias, because pA and pB will never alias. But this phrasin

[clang-tools-extra] 2128a79 - [clangd] Fix buildbots

Author: Kadir Cetinkaya Date: 2020-03-04T12:41:26+01:00 New Revision: 2128a79c46995de96c5e44c098228e47be8205d6 URL: https://github.com/llvm/llvm-project/commit/2128a79c46995de96c5e44c098228e47be8205d6 DIFF: https://github.com/llvm/llvm-project/commit/2128a79c46995de96c5e44c098228e47be8205d6.dif

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:958 + + unsigned getNumArgs() const override { return getDecl()->getNumParams(); } + NoQ wrote: > Charusso wrote: > > `return getOriginExpr()->getNumAr

[PATCH] D75160: [AArch64][SVE] Add SVE2 intrinsic for xar

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5502c7035a9: [AArch64][SVE] Add SVE2 intrinsic for xar (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75160/new/ https://reviews.

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. Friendly ping, please take a look. In large repos there is a significant problem with maintaining .clang-tidy configs in sync without some kind of inheritance with local overrides. If you have thoughts how to make it better, please speak up. Repository: rG LL

[clang] 7d2fdd3 - [clang-format] parse C# object initialisers

Author: Jonathan Coe Date: 2020-03-04T12:14:00Z New Revision: 7d2fdd3f6639731284dd8b6b274f01f04fd19215 URL: https://github.com/llvm/llvm-project/commit/7d2fdd3f6639731284dd8b6b274f01f04fd19215 DIFF: https://github.com/llvm/llvm-project/commit/7d2fdd3f6639731284dd8b6b274f01f04fd19215.diff LOG:

[PATCH] D75473: [clang-format] parse C# object initialisers

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75473/new/ https://reviews.llvm.org/D75473 ___ cfe-commits mailing list cfe

[PATCH] D75473: [clang-format] parse C# object initialisers

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d2fdd3f6639: [clang-format] parse C# object initialisers (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75473/

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This patch adds an instrumentation mode for clangd (enabled by corresponding option in cc_opts). If th

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:33-50 +void SignalInMultithreadedProgramCheck::registerMatchers(MatchFinder *Finder) { + auto signalCall = + callExpr( + ignoringImpCasts(hasDes

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Internally we have something similar, but with unconditional inheritance and a way to include other configs. I was thinking about implementing this in the FileOptionsProvider, but de

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Otherwise they can force us to build lots of snapshots that we don't need. Particula

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

balazske updated this revision to Diff 248155. balazske added a comment. - Moved enum comments. - Updated fseek behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75356/new/ https://reviews.llvm.org/D75356 Files: clang/lib/StaticAnalyzer/C

[PATCH] D75604: [clangd] Round WorkDoneProgressBegin.percentage down

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kbobyrev updated this revision to Diff 248164. kbobyrev added a comment. %s/ceil/floor/g Wh

[PATCH] D75538: [clang-tidy] Updated language supported restrictions on some checks

alexfh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp:1 -// RUN: %check_clang_tidy -std=c++98 %s modernize-use-nullptr %t -- -- -Wno-non-literal-null-conversion -// gribozavr2 wrote: > njames93 wrot

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

balazske marked 5 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:37-40 + // NoError: No error flag is set or stream is not open. + // EofError: EOF condition (feof returns true) + // OtherError: other (n

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

Szelethus added a comment. In D75163#1902816 , @xazax.hun wrote: > The name of the patch implies refactoring but some functional changes were > also done. Is it possible to separate the functional changes into a separate > patch? If it is not a big effor

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

usaxena95 updated this revision to Diff 248160. usaxena95 added a comment. Addressed linter issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75603/new/ https://reviews.llvm.org/D75603 Files: clang-tools-extra/clangd/CodeComplete.cpp clang

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. The scope of the patch is small and is well tested. I suggest to move the discussion about debug messages and `NoteTag`s to the next revision. LGTM! CHANGES SINCE LAST ACTION https://

[PATCH] D75606: [clang-format] Improve identification of C# nullables

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider `? identifier =` and `? identifier;` to be nullable within function bodies. Repository: rG LLVM Github Monorepo

[PATCH] D75604: [clangd] Round WorkDoneProgressBegin.percentage down

kbobyrev updated this revision to Diff 248164. kbobyrev added a comment. %s/ceil/floor/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75604/new/ https://reviews.llvm.org/D75604 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp Index: clang-

[PATCH] D75514: [Analyzer] Only add container note tags to the operations of te affected container

Szelethus added a comment. In D75514#1903153 , @baloghadamsoftware wrote: > Alternative approach for debugging (instead of checking the source range): > `clang_analyzer_express()` from `ExprInspection` marks its argument as > interesting in the bug repo

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.h:141 + /// Ideally this must be disabled when being used by ClangdLSPServer. + bool EnableInstrumentationMode = false; + std::function* RecordCCResults; I'm wondering if we can

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1465 +if (Opts.EnableInstrumentationMode) + (*Opts.RecordCCResults)(toCodeCompleteResult(Top)); + can't we make use of the trace::Span instead ? Repository: rG LLVM

[libunwind] 00c5793 - Revert "Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structure"

Author: Mikhail Maltsev Date: 2020-03-04T14:54:24Z New Revision: 00c5793edefdb465db6cff06b3b50706c31b25c1 URL: https://github.com/llvm/llvm-project/commit/00c5793edefdb465db6cff06b3b50706c31b25c1 DIFF: https://github.com/llvm/llvm-project/commit/00c5793edefdb465db6cff06b3b50706c31b25c1.diff LO

[clang] 2bb3fb0 - Handle PluginAttrInstances using ManagedStatic

Author: John Brawn Date: 2020-03-04T15:03:13Z New Revision: 2bb3fb05e20e272790170e86fb76dac23a67f52c URL: https://github.com/llvm/llvm-project/commit/2bb3fb05e20e272790170e86fb76dac23a67f52c DIFF: https://github.com/llvm/llvm-project/commit/2bb3fb05e20e272790170e86fb76dac23a67f52c.diff LOG: Ha

[PATCH] D75556: [AST Matchers] Restrict `optionally` matcher to a single argument.

ymandel updated this revision to Diff 248171. ymandel added a comment. Updated the matcher HTML doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75556/new/ https://reviews.llvm.org/D75556 Files: clang/docs/LibASTMatchersReference.html clang/

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

Szelethus added a comment. Okay, I think we're mostly in agreement so far -- could we implement a warning and add some test files for unchecked stream states after a failed `fseek` call? The title of the revision is "[Analyzer][StreamChecker] Introduction of stream error state handling.", yet i

[PATCH] D75556: [AST Matchers] Restrict `optionally` matcher to a single argument.

ymandel updated this revision to Diff 248170. ymandel added a comment. Updated comments for matcher. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75556/new/ https://reviews.llvm.org/D75556 Files: clang/include/clang/ASTMatchers/ASTMatchers.h

[clang] 4f29d30 - [OPENMP50]'source' and 'sink' kinds are not allowed in depobj.

Author: Alexey Bataev Date: 2020-03-04T10:17:42-05:00 New Revision: 4f29d30f7ce1359ef9073d251002d90709614b99 URL: https://github.com/llvm/llvm-project/commit/4f29d30f7ce1359ef9073d251002d90709614b99 DIFF: https://github.com/llvm/llvm-project/commit/4f29d30f7ce1359ef9073d251002d90709614b99.diff

[clang] 16c6e0f - Quote a python executable path

Author: Jeremy Morse Date: 2020-03-04T15:23:48Z New Revision: 16c6e0f387e957d21ab90c8694c11cd269ec7719 URL: https://github.com/llvm/llvm-project/commit/16c6e0f387e957d21ab90c8694c11cd269ec7719 DIFF: https://github.com/llvm/llvm-project/commit/16c6e0f387e957d21ab90c8694c11cd269ec7719.diff LOG:

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM Comment at: clang-tools-extra/clangd/Cancellation.cpp:39 + return true; return false; // Not in scope of a task. } comment seems to

[PATCH] D75606: [clang-format] Improve identification of C# nullables

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good with 1 suggestion. Comment at: clang/lib/Format/TokenAnnotator.cpp:1018 + (Tok->Next && Tok->Next->is(tok::identifier) && Tok->Next->Next && +

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

yusra.syeda added a comment. Overall the patch LGTM, aside from 1 change we may want to make. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:531 + + bool isCXXGlobalInitAndDtorFuncInternal() const override { return false; } + Perhaps adding a check to see if

[PATCH] D75612: [Analyzer][StreamChecker] Adding PreCall and refactoring (NFC).

balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Adding PreCall callback. Argum

[clang] 95a94df - [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

Author: Balazs Benics Date: 2020-03-04T17:03:59+01:00 New Revision: 95a94df5a9c3d7d2aa92b6beb13e82d8d5832e2e URL: https://github.com/llvm/llvm-project/commit/95a94df5a9c3d7d2aa92b6beb13e82d8d5832e2e DIFF: https://github.com/llvm/llvm-project/commit/95a94df5a9c3d7d2aa92b6beb13e82d8d5832e2e.diff

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske added a comment. I had no other work to do so here is the change for the non-functional part of this: https://reviews.llvm.org/D75612 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/ https://reviews.llvm.org/D75163

[PATCH] D74467: [analyzer] Teach scan-build how to rebuild index.html without analyzing.

NoQ added a comment. In D74467#1905011 , @Charusso wrote: > Could you mention how to use this feature in the Summary please? > > cd reports > scan-build --generate-index-only . > Yup, this was supposed to work. > And something is not right, I have t

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

SjoerdMeijer added a comment. Big patch, I only did a first scan, but looks very reasonable in general. Just a first round of nits and 2 questions. Comment at: clang/include/clang/Basic/arm_sve.td:121 +// Load one vector (scalar base) +def SVLD1 : MInst<"svld1[_{2}]", "dPc",

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, Mordante, rtrieu. Herald added a project: clang. Herald added a subscriber: cfe-commits. aaronpuchert added a comment. This addresses my earlier comment D73007#1853563 . The

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

aaronpuchert added a comment. This addresses my earlier comment D73007#1853563 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75613/new/ https://reviews.llvm.org/D75613 _

[PATCH] D75614: [Analyzer][StreamChecker] Check for opened stream before operations.

balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. According to documentations, a

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske added a comment. And the second part: https://reviews.llvm.org/D75614 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/ https://reviews.llvm.org/D75163 ___ cfe-commits mailing list cfe-

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG95a94df5a9c3: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D720

[PATCH] D75615: Revert "[CGBlocks] Improve line info in backtraces containing *_helper_block"

aprantl created this revision. aprantl added reviewers: vsk, shafik. aprantl added a project: debug-info. aprantl updated this revision to Diff 248190. aprantl updated this revision to Diff 248192. Block copy/destroy helpers are now `linkonce_odr` functions, meant to be uniqued, and thus attachin

[PATCH] D74467: [analyzer] Teach scan-build how to rebuild index.html without analyzing.

Charusso added a comment. In D74467#1905416 , @NoQ wrote: > In D74467#1905011 , @Charusso wrote: > > > Could you mention how to use this feature in the Summary please? > > And something is not right, I have tried i

[PATCH] D75602: [clangd] Cancel certain operations if the file changes before we start.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:58 +/// without any explicit user action. +static TUScheduler::ASTActionInvalidation LikelyImplicit = +TUScheduler::InvalidateOnUpdate; nit: i would actually keep `Invalidat

[PATCH] D75615: Revert "[CGBlocks] Improve line info in backtraces containing *_helper_block"

aprantl updated this revision to Diff 248192. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75615/new/ https://reviews.llvm.org/D75615 Files: clang/lib/CodeGen/CGBlocks.cpp clang/test/CodeGenObjC/debug-info-blocks.m Index: clang/test/CodeGenObjC/debug-info-blocks.m

[PATCH] D75615: Revert "[CGBlocks] Improve line info in backtraces containing *_helper_block"

aprantl updated this revision to Diff 248190. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75615/new/ https://reviews.llvm.org/D75615 Files: clang/lib/CodeGen/CGBlocks.cpp clang/test/CodeGenObjC/debug-info-blocks.m Index: clang/test/CodeGenObjC/debug-info-blocks.m

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs created this revision. jroelofs added reviewers: njames93, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. https://reviews.llvm.org/D74669#inline-685657 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75621 Files: clang

[clang] d4f9675 - [analyzer] decode() a bytes object to make Python3 happy

Author: Jeremy Morse Date: 2020-03-04T17:12:48Z New Revision: d4f9675b5509e26573058318682a9ed5d7aaf320 URL: https://github.com/llvm/llvm-project/commit/d4f9675b5509e26573058318682a9ed5d7aaf320 DIFF: https://github.com/llvm/llvm-project/commit/d4f9675b5509e26573058318682a9ed5d7aaf320.diff LOG:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 248203. jroelofs added a comment. Split out https://reviews.llvm.org/D75621 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugpr

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248206. jroelofs added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/ https://reviews.llvm.org/D75621 Files: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializers

[PATCH] D75615: Revert "[CGBlocks] Improve line info in backtraces containing *_helper_block"

vsk added inline comments. Comment at: clang/test/CodeGenObjC/debug-info-blocks.m:24 // CHECK: load {{.*}}, !dbg ![[DESTROY_LINE:[0-9]+]] -// CHECK: ret void, !dbg ![[DESTROY_LINE]] +// CHECK-DAG: [[DBG_LINE]] = !DILocation(line: 0, scope: ![[COPY_SP:[0-9]+]])

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss marked 4 inline comments as done. danielkiss added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 + if (CodeGenOpts.BranchTargetEnforcement) { +FuncAttrs.addAttribute("branch-target-enforcement", "true"); + } chill wrote: > I woul

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 248208. jroelofs marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss updated this revision to Diff 248201. danielkiss added a comment. Thanks for the comments, patch is improved isStringAttribute() check removed, the attribute is always a string in this case or "null" so the check is not needed. Function level the attribute is now only change when neede

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. This will break existing `.clang-tidy` configs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/ https://reviews.llvm.o

[PATCH] D75538: [clang-tidy] Updated language supported restrictions on some checks

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp:1 -// RUN: %check_clang_tidy -std=c++98 %s modernize-use-nullptr %t -- -- -Wno-non-literal-null-conversion -// -

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

rsandifo-arm updated this revision to Diff 248215. rsandifo-arm added a comment. Changes in v2: - Emit the diagnostic from RequireCompleteTypeImpl instead of checking for sizeless types separately. This implements option 3. from the earlier discussion. - Reformat the patch using git-clang-for

[PATCH] D75623: [clangd][VSCode] Force VSCode to use the ranking provided by clangd.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall added a comment. I tested this with an example like: int a_b_c; char *abc; in

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss updated this revision to Diff 248222. danielkiss marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenModule

[PATCH] D75623: [clangd][VSCode] Force VSCode to use the ranking provided by clangd.

sammccall added a comment. I tested this with an example like: int a_b_c; char *abc; int x = ab^ // prefer a_b_c due to type match. before this patch, we see [abc, a_b_c]. After this patch, [a_b_c, abc]. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

rsmith added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File, /*isVolatile=*/false); + Buf = FileMgr.getBufferForFile(

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers marked 4 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/test/Parser/asm-qualifiers.c:20 + +void combinations(void) { + asm volatile inline(""); nathanchance wrote: > nickdesaulniers wrote: > > nathanchance wrote

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248225. nickdesaulniers added a comment. - combine combinations into permutations test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563 Files: clang/docs/Relea

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

njames93 added a comment. The `llvm::StringRef::split` function can take multiple split characters, So it would be best to split on both for the time being but mark cases where `,` is used as deprecated. This way we keep the options in line with other clang-tidy checks but keep some backwards c

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

rsandifo-arm added a comment. In D75572#1904517 , @efriedma wrote: > I think the specialized error messages are useful. I don't have a strong > opinion on what order the patches should land. OK. The new version keeps the tailored diagnostic but emits

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248226. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - git-clang-format HEAD~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D755

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:746-755 ParseTypeQualifierListOpt(DS, AR_VendorAttributesParsed); // GNU asms accept, but warn, about type-qualifiers other than volatile.

[PATCH] D75606: [clang-format] Improve identification of C# nullables

jbcoe updated this revision to Diff 248232. jbcoe marked an inline comment as done. jbcoe added a comment. Remove duplicate check following review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75606/new/ https://reviews.llvm.org/D75606 Files: clang/lib/Format/TokenAnnotator.

  1   2   >