[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

2020-03-03 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. On Arch Linux side, I reported a similar issue https://bugs.archlinux.org/task/64464#comment183541 for ldc (LLVM-based D compiler) % cmake -H. -BArch -G Ninja -DCMAKE_BUILD_TYPE=Debug -DD_COMPILER=$HOME/dlang/dmd-2.089.0/linux/bin64/dmd -DCMAKE_CXX_STANDARD=14 -DLDC

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

2020-03-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 248069. sammccall added a comment. Fix accidental default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75582/new/ https://reviews.llvm.org/D75582 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cla

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

2020-03-03 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Just looked at the comment on D75572 ; not sure if RequireCompleteType is going to reject sizeless types. In any case, you have to instantiate templates using RequireCompleteType before you can determine whether a type is sizeless. R

[PATCH] D62962: Clang implementation of sizeless types

2020-03-03 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Okay, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62962/new/ https://reviews.llvm.org/D62962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

2020-03-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 248070. sammccall added a comment. Fix incomplete message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75582/new/ https://reviews.llvm.org/D75582 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cla

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

2020-03-03 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added a comment. In D75572#1904415 , @efriedma wrote: > The planned changes to RequireCompleteType should catch this, right? If we > want a specialized diagnostic for sizeless types in RequireCompleteType, we > should probably just pass it

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

2020-03-03 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D74735#1903503 , @martong wrote: > @NoQ > > I've found the following reproducer to crash in `CallAndMessageChecker`: > > class a { > public: > a(int); > }; > struct b : a { > using a::a; > }; > void c() { > i

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

2020-03-03 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. I think the specialized error messages are useful. I don't have a strong opinion on what order the patches should land. The difference between emitting the diagnostic in RequireCompleteType, vs. letting the caller do it, is basically just that it's harder to forget to

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

2020-03-03 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > This is because many of the builtins are protected by an architecture guard > like `#ifdef __ARM_FEATURE_SVE` or `#ifdef __ARM_FEATURE_SVE2`. I think TARGET_HEADER_BUILTIN has support for requiring target features. Granted, we don't use it much at the moment, so the

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

2020-03-03 Thread Hongtao Yu via Phabricator via cfe-commits
hoyFB added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:2551 - Intrinsic<[llvm_v4f32_ty], [llvm_v8i16_ty], [IntrNoMem]>; - def int_x86_vcvtph2ps_256 : GCCBuiltin<"__builtin_ia32_vcvtph2ps256">, - Intrinsic<[llvm_v8f32_ty], [llvm_v

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

2020-03-03 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:104 + + Finds methods marked unavailable that do not override any method from a + superclass. Please synchronize with first statement in documentation.

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

2020-03-03 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I love where this is going. > the reason behind this is that neither does `preStmt` have a > `postStmt` pair. But I have no clue why that is :^) I'm pretty sure it's forgotten :/ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

2020-03-03 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel created this revision. atmnpatel added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, guansong. Herald added projects: clang, LLVM. This implements the default(firstprivate) clause as defined in OpenMP Technical Report 8 (2.22.4). Repository: rG LLVM Gith

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

2020-03-03 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:2551 - Intrinsic<[llvm_v4f32_ty], [llvm_v8i16_ty], [IntrNoMem]>; - def int_x86_vcvtph2ps_256 : GCCBuiltin<"__builtin_ia32_vcvtph2ps256">, - Intrinsic<[llvm_v8f32_ty],

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

2020-03-03 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 248097. Charusso marked 4 inline comments as done. Charusso edited the summary of this revision. Charusso added a comment. - Set the size properly. - Add new debug.ExprInspection patterns: region, size, element count. - `clang-format -i ExprInspectionChecker.

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

2020-03-03 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicSize.cpp:85 +if (CI->getValue().isUnsigned()) + Size = SVB.makeIntVal(CI->getValue(), /*IsUnsigned=*/false); + That one is interes

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

2020-03-03 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 248098. atmnpatel added a comment. Fixes typos that causes certain unit tests to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files: clang/docs/LibASTMatch

LLVM buildmaster will be restarted soon

2020-03-03 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted in few minutes. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cac0686 - [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

2020-03-03 Thread via cfe-commits
Author: hsmahesha Date: 2020-03-04T10:54:26+05:30 New Revision: cac068600e55e489844156d3581b61eeecee7d4e URL: https://github.com/llvm/llvm-project/commit/cac068600e55e489844156d3581b61eeecee7d4e DIFF: https://github.com/llvm/llvm-project/commit/cac068600e55e489844156d3581b61eeecee7d4e.diff LOG

[clang] f69c74d - [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

2020-03-03 Thread via cfe-commits
Author: Charusso Date: 2020-03-04T06:26:33+01:00 New Revision: f69c74db34f42c20c167b8fb0f93ec05a0e77b45 URL: https://github.com/llvm/llvm-project/commit/f69c74db34f42c20c167b8fb0f93ec05a0e77b45 DIFF: https://github.com/llvm/llvm-project/commit/f69c74db34f42c20c167b8fb0f93ec05a0e77b45.diff LOG:

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

2020-03-03 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso marked an inline comment as done. Charusso added a comment. Thanks everyone! I hope the Analyzer developers start to use the wonderful features from Clang-Tidy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

2020-03-03 Thread Mahesha S via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcac068600e55: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

2020-03-03 Thread Csaba Dabis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf69c74db34f4: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script (authored by Charusso). Changed prior to commit: https://reviews.llvm.org/D69746?vs=246209&id=248103#toc Repository

[clang] abdd33c - [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

2020-03-03 Thread via cfe-commits
Author: Charusso Date: 2020-03-04T06:56:32+01:00 New Revision: abdd33c86a34517bbbe91adcacaae1ed5ea6b1d8 URL: https://github.com/llvm/llvm-project/commit/abdd33c86a34517bbbe91adcacaae1ed5ea6b1d8 DIFF: https://github.com/llvm/llvm-project/commit/abdd33c86a34517bbbe91adcacaae1ed5ea6b1d8.diff LOG:

Buildbot numbers for the week of 02/16/2020 - 02/22/2020

2020-03-03 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the week of 02/16/2020 - 02/22/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 02/23/2020 - 02/29/2020

2020-03-03 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the last week of 02/23/2020 - 02/29/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[clang] 7e1a6ca - [analyzer] AnalysisDeclContext: Refactor and documentation

2020-03-03 Thread via cfe-commits
Author: Charusso Date: 2020-03-04T07:06:54+01:00 New Revision: 7e1a6ca9e89c3ea08f8b008e9140d9fdc048d1df URL: https://github.com/llvm/llvm-project/commit/7e1a6ca9e89c3ea08f8b008e9140d9fdc048d1df DIFF: https://github.com/llvm/llvm-project/commit/7e1a6ca9e89c3ea08f8b008e9140d9fdc048d1df.diff LOG:

[PATCH] D73729: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

2020-03-03 Thread Csaba Dabis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGabdd33c86a34: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks' (authored by Charusso). Changed prior to commit: https://reviews.llvm.org/D73729?vs=241507&id=248106#toc Repository: rG LLVM Githu

[PATCH] D73519: [analyzer] AnalysisDeclContext: Refactor and documentation

2020-03-03 Thread Csaba Dabis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7e1a6ca9e89c: [analyzer] AnalysisDeclContext: Refactor and documentation (authored by Charusso). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73729: [analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'

2020-03-03 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added a comment. [Achievement unlocked] 3 green marks. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73729/new/ https://reviews.llvm.org/D73729 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D75461: Ignore macro expansions when scanning for fallthrough comments

2020-03-03 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder abandoned this revision. tbaeder added a comment. fallthrough comment detection has been reverted, so abandon this in the meantime. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75461/new/ https://reviews.llvm.org/D75461 ___

[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

2020-03-03 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:44 -/// BugReporterVisitors are used to add custom diagnostics along a path. +/// BugReporterVisitors are used to add custom diagnostics along a \emoji bug +//

[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

2020-03-03 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 248110. Charusso marked 4 inline comments as done. Charusso added a comment. Herald added subscribers: martong, steakhal. - Make the tags robust and more unique. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73520/new/ https://reviews.llvm.org/D735

<    1   2   3