[libunwind] d933712 - Promote nameless lambda used by dl_iterate_phdr to named function to clean up control flow inside findUnwindSections. Also, expose the data structure

Author: Sterling Augustine Date: 2020-03-03T09:13:01-08:00 New Revision: d93371238e7f5d5f9c506a88cf4f05f8dea9d008 URL: https://github.com/llvm/llvm-project/commit/d93371238e7f5d5f9c506a88cf4f05f8dea9d008 DIFF: https://github.com/llvm/llvm-project/commit/d93371238e7f5d5f9c506a88cf4f05f8dea9d008.

[clang] 9f8a7e8 - [clang-format] Allow nested [] in C# attributes

Author: Jonathan Coe Date: 2020-03-03T17:35:09Z New Revision: 9f8a7e82b85078b5afbbc44429355f156e044205 URL: https://github.com/llvm/llvm-project/commit/9f8a7e82b85078b5afbbc44429355f156e044205 DIFF: https://github.com/llvm/llvm-project/commit/9f8a7e82b85078b5afbbc44429355f156e044205.diff LOG:

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:684 +.Case({ +ReturnValueCondition(LessThanOrEq, ArgNo(2)), +}) Two lines below you are using the `{0U}` initialization syntax

[PATCH] D75514: [Analyzer] Only add container note tags to the operations of te affected container

baloghadamsoftware updated this revision to Diff 247934. baloghadamsoftware added a comment. Updated according to the style comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75514/new/ https://reviews.llvm.org/D75514 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cp

[PATCH] D75056: [Driver] Default to -fno-common for all targets

SjoerdMeijer added a comment. Ha, these test-suite apps fail with `multiple definition of ...` link errors, so actually require a little bit of porting! :-) But I think I will prepare a patch that adds `-fcommon` to their makefiles, as I don't want to change too many things at the same time. R

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

sdesmalen added a comment. In D75298#1901578 , @efriedma wrote: > How are you planning to handle them with your current approach? Each prototype will get a `arm_sve_alias` attribute that specifies which builtin it relates to. For example: __attribute

[PATCH] D75538: [clang-tidy] Updated language supported restrictions on some checks

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75538 Files: clang-to

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 247937. akhuang added a comment. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-i

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers updated this revision to Diff 247936. vabridgers added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75529/new/ https://reviews.llvm.org/D75529 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunc

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers marked 2 inline comments as done. vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:514 + // Set UCharMax to min of int or uchar maximum value. + // The C standard states that functions like isalpha must be

[PATCH] D75455: [clang-format] Allow nested [] in C# attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f8a7e82b850: [clang-format] Allow nested [] in C# attributes (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

steakhal added a comment. In D71524#1902654 , @steakhal wrote: > In D71524#1889566 , @boga95 wrote: > > > @steakhal's revision is on the top of this. Changing the order will only > > cause unnecessary work on both

[PATCH] D75285: Mark restrict pointer or reference to const as invariant

rjmccall added a comment. In D75285#1903284 , @yaxunl wrote: > In D75285#1902835 , > @jeroen.dobbelaere wrote: > > > In D75285#1902788 , @Anastasia > > wrote: > > > > > In

[PATCH] D75538: [clang-tidy] Updated language supported restrictions on some checks

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp:1 -// RUN: %check_clang_tidy -std=c++98 %s modernize-use-nullptr %t -- -

[PATCH] D75056: [Driver] Default to -fno-common for all targets

MaskRay added a comment. In D75056#1903363 , @SjoerdMeijer wrote: > Ha, these test-suite apps fail with `multiple definition of ...` link errors, > so actually require a little bit of porting! :-) > But I think I will prepare a patch that adds `-fcommon

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache created this revision. modocache added reviewers: rsmith, RKSimon, aaron.ballman, wenlei. Herald added a project: clang. A closed-source C++ codebase I help maintain began hitting a Clang ICE with a stack trace that referenced `clang::OverloadCandidate::getNumParams`: https://gist.github

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

martong added a comment. @NoQ I've found the following reproducer to crash in `CallAndMessageChecker`: class a { public: a(int); }; struct b : a { using a::a; }; void c() { int d; b x(d); //Crash!, Note, x(0) causes no crash } I am working on a fix, but any insight

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache marked an inline comment as done. modocache added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:7371 return; } @rsmith I'd definitely appreciate any pointers here -- if initializing `IsSurrogate` with a value as I do in this pa

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

hsmhsm added a comment. In D75402#1901471 , @hsmhsm wrote: > Take care review comments by hliao. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75402/new/ https://reviews.llvm.org/D75402 __

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 247960. PaulkaToast marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-too

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

MaskRay added a comment. > `RestrictSystemLibcHeadersCheck` As I commented previously, I think the checker name should be generalized, as it does not need to be coupled with llvm-libc. Other projects may have similar needs. For example, they don't want to accidentally include a system zlib.h ->

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

MaskRay added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvmlibc-restrict-system-libc-headers.rst:16-20 +This check is necesary because accidentally including sytem libc headers can +lead to subtle and hard to detect bugs. For example consider a syste

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang added a comment. In D75215#1901961 , @rnk wrote: > BTW, I am curious to know if this helps V8 PDB size. IIRC you said there were > some PDBs in Chrome that have this problem a lot. I think I just noticed that the PDB size increased after enablin

[PATCH] D75285: Mark restrict pointer or reference to const as invariant

yaxunl added a comment. In D75285#1903444 , @rjmccall wrote: > That is not true for two reasons: first, `restrict` guarantees that the > variable is not accessed through any non-derived l-value within its scope, > and that would certainly include from ot

[PATCH] D75402: [HIP] Make sure, unused hip-pinned-shadow global var is kept within device code

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75402/new/ https://reviews.llvm.org/D75402 __

[clang] 82f7c20 - [OPENMP50]Support 'update' clause for 'depobj' directive.

Author: Alexey Bataev Date: 2020-03-03T13:59:32-05:00 New Revision: 82f7c207f51b28c834d71bbb3b0f818f51c8b090 URL: https://github.com/llvm/llvm-project/commit/82f7c207f51b28c834d71bbb3b0f818f51c8b090 DIFF: https://github.com/llvm/llvm-project/commit/82f7c207f51b28c834d71bbb3b0f818f51c8b090.diff

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

grokos added a comment. @ABataev, @jdoerfert, does the patch look good to you? Can someone accept it if it's ready to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75223/new/ https://reviews.llvm.org/D75223 _

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you for the explanations! Looking good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75465/new/ https://reviews.llvm.org/D75465 _

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

rnk added a comment. I think we should commit the change to clang separately from the first one you made to LLVM to handle method types. Setting flags on forward declarations is something I'd like to get additional input on before landing. Comment at: clang/lib/CodeGen/CGDebu

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

vsapsai added a comment. In D66831#1902176 , @smeenai wrote: > Thanks for that explanation; that makes sense. Do you think that the > `@interface J : I` would also ideally be an error then? Theoretically, I think `@interface J : I` should also trigger a

[PATCH] D75473: [clang-format] parse C# object initialisers

krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1978 + if (FormatTok->is(tok::l_paren)) +parseParens(); + I don't understand why this is needed, and removing this `if` does not cause any tests to fail. Please add

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis updated this revision to Diff 247982. zinovy.nis added a comment. 1. Special handling for captured variables in lambdas, 2. messages texts were changed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74692/new/ https://reviews.llvm.org/D74692 Files: clang-tools-extra/clang-

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis updated this revision to Diff 247985. zinovy.nis added a comment. Typo fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74692/new/ https://reviews.llvm.org/D74692 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/test/clang-tidy/che

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75223/new/ https://reviews.llvm.org/D75223 ___

[clang] fca49fe - [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

Author: George Rokos Date: 2020-03-03T12:31:40-08:00 New Revision: fca49fe8e34f13632c42e68aad4b14e3e00bdcc8 URL: https://github.com/llvm/llvm-project/commit/fca49fe8e34f13632c42e68aad4b14e3e00bdcc8 DIFF: https://github.com/llvm/llvm-project/commit/fca49fe8e34f13632c42e68aad4b14e3e00bdcc8.diff

[PATCH] D75285: Mark restrict pointer or reference to const as invariant

rjmccall added a comment. In D75285#1903611 , @yaxunl wrote: > In D75285#1903444 , @rjmccall wrote: > > > That is not true for two reasons: first, `restrict` guarantees that the > > variable is not accessed through

[PATCH] D75558: [clang-tidy] Update abseil-duration-unnecessary-conversion check to find more cases.

hwright created this revision. hwright added reviewers: aaron.ballman, ymandel. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. This check now handles cases where there's a scalar multiplication happening between the two conversions. Repository: rG LLVM Github

[PATCH] D75556: [AST Matchers] Restrict `optionally` matcher to a single argument.

ymandel created this revision. ymandel added reviewers: sbenza, aaron.ballman. Herald added a project: clang. Currently, `optionally` can take multiple arguments, which commits it to a particular strategy for those arguments (in this case, "for each"). We limit the matcher to a single argument, wh

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

nridge marked 3 inline comments as done. nridge added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4856 +private: + // Infer members of T, given that the expression E (dependent on T) is true. + void believe(const Expr *E, const TemplateTypeParmType *T) { --

[PATCH] D75056: [Driver] Default to -fno-common for all targets

SjoerdMeijer added a comment. Patch for the test-suite: D75557 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056 ___ cfe-commits

[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

krasimir added a comment. Here's some empirical ideas about the approach: In clang-format, braces can be handled in two quite distinct ways, controlled by BraceBlockKind : BK_

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

This revision was automatically updated to reflect the committed changes. Closed by commit rGfca49fe8e34f: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of… (authored by grokos). Changed prior to commit: https://reviews.llvm.org/D75223?vs=246870&id=247991#toc Repository

[clang-tools-extra] e70a9f3 - [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

Author: Nathan Ridge Date: 2020-03-03T15:52:05-05:00 New Revision: e70a9f3850255cb610fc56a30dec6f52b9d734e9 URL: https://github.com/llvm/llvm-project/commit/e70a9f3850255cb610fc56a30dec6f52b9d734e9 DIFF: https://github.com/llvm/llvm-project/commit/e70a9f3850255cb610fc56a30dec6f52b9d734e9.diff

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5006 + if (/*Inserted*/ R.second || + std::make_tuple(M.Operator, M.ArgTypes.hasValue(), + M.ResultType != nullptr)

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

nridge added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4972 + +// In T::foo::bar, `foo` must be a type. +bool VisitNestedNameSpecifier(NestedNameSpecifier *NNS) { nridge wrote: > sammccall wrote: > > nridge wrote: > > > It would be

[PATCH] D75538: [clang-tidy] Updated language supported restrictions on some checks

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp:1 -// RUN: %check_clang_tidy -std=c++98 %s modernize-use-nullptr %t -- -- -Wno-non-literal-null-conversion -// -

[PATCH] D75517: [clang-format] Do not format C# array subscript operators as attributes

krasimir accepted this revision. krasimir added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:376 + +// Chains [] in of `identifier[i][j][k]` are not attributes. +if (Tok.Previous && Tok.Previous->is(tok:

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall updated this revision to Diff 247993. sammccall added a comment. comment and tweak order of AccessOperator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73649/new/ https://reviews.llvm.org/D73649 Files: clang/include/clang/Sema/Scope.h

[PATCH] D75492: [clang-tidy]: modernize-use-using: don't diagnose typedefs in `extern "C"` DeclContexts

george.burgess.iv planned changes to this revision. george.burgess.iv added a comment. I see -- that seems like a much broader change, but also probably worthwhile. I have a few ideas about how to tackle that; let me see what I can come up with locally. Thanks! Repository: rG LLVM Github Mo

[PATCH] D75560: Make Decl::setFromASTFile() public. (NFC)

aprantl created this revision. aprantl added reviewers: teemperor, rsmith, shafik. This API is going to be used by LLDB to recreate owning module information for Decls deserializwed from DWARF. https://reviews.llvm.org/D75560 Files: clang/include/clang/AST/DeclBase.h Index: clang/include/c

[PATCH] D75292: [clangd] Remove vsc-extension-quickstart.md from the vscode-clangd plugin

nridge updated this revision to Diff 247996. nridge added a comment. Remove entire file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75292/new/ https://reviews.llvm.org/D75292 Files: clang-tools-extra/clangd/clients/clangd-vscode/vsc-extension-

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

aprantl created this revision. aprantl added reviewers: teemperor, rsmith, shafik. This API is used by LLDB to attach owning module information to Declarations deserialized from DWARF. https://reviews.llvm.org/D75561 Files: clang/include/clang/AST/ExternalASTSource.h clang/lib/AST/External

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248003. akhuang added a comment. add back line in test that accidentally got deleted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: clang/test/CodeGenCXX/debu

[PATCH] D75538: [clang-tidy] Updated language supported restrictions on some checks

gribozavr2 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp:1 -// RUN: %check_clang_tidy -std=c++98 %s modernize-use-nullptr %t -- -- -Wno-non-literal-null-conversion -// njames93 wrote: > alexfh wrot

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

nridge added a comment. Thanks! Consider the patch "accepted" from my POV. One last nit: please link to https://github.com/clangd/clangd/issues/261 in the commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73649/new/ https://reviews.llv

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248001. akhuang added a comment. Splitting the forward declaration flag into a different review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: clang/test/Cod

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:989 + llvm::DINode::DIFlags Flags = llvm::DINode::FlagFwdDecl; + if (const CXXRecordDecl *CXXRD = dyn_cast(RD)) +if (!CXXRD->hasDefinition() || ---

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

This revision was automatically updated to reflect the committed changes. nridge marked 4 inline comments as done. Closed by commit rGe70a9f385025: [clangd] Handle go-to-definition in macro invocations where the target appears… (authored by nridge). Changed prior to commit: https://reviews.llvm

[PATCH] D75194: [clang-format] Do not merge very long C# automatic properties

MyDeveloperDay added a comment. @krasimir, well I learned something new, so thanks for taking the time to explain that to help improve our understanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75194/new/ https://reviews.llvm.org/D75194 _

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers added a comment. I still plan to add CodeGen support for `asm inline` before the next release, which should be as simple as emitting an additional `inlinehint`, but I'd like to save that for a follow up patch on top of this. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

rnk accepted this revision. rnk added a comment. lgtm, but please remove the clang test update from this patch, since it shouldn't pass yet. Comment at: clang/test/CodeGenCXX/debug-info-flag-nontrivial.cpp:1 +// RUN: %clang_cc1 -emit-llvm -gcodeview -debug-info-kind=limited %s

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers created this revision. nickdesaulniers added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers added a comment. I still plan to add CodeGen support for `asm inline` before the next release, which should be as simple a

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248019. nickdesaulniers added a comment. - remove impossible case in ParseGNUAsmQualifierListOpt - simplify SetGNUAsmQual - fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ h

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248020. nickdesaulniers added a comment. - seems `arc diff` wiped out my previous changes... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563 Files: clang/docs

[clang] 27a3ece - [clang][Modules] Add -fsystem-module flag

Author: Michael Spencer Date: 2020-03-03T14:14:24-08:00 New Revision: 27a3ecee45584f6e78b4674ebbbe5554faad URL: https://github.com/llvm/llvm-project/commit/27a3ecee45584f6e78b4674ebbbe5554faad DIFF: https://github.com/llvm/llvm-project/commit/27a3ecee45584f6e78b4674ebbbe5554faad.dif

[clang] 900dee8 - [clang-format] Do not merge target-name and : for C# attributes

Author: Jonathan Coe Date: 2020-03-03T22:17:25Z New Revision: 900dee8c8e03abc5a566e22b4f5499ecdc960803 URL: https://github.com/llvm/llvm-project/commit/900dee8c8e03abc5a566e22b4f5499ecdc960803 DIFF: https://github.com/llvm/llvm-project/commit/900dee8c8e03abc5a566e22b4f5499ecdc960803.diff LOG:

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang updated this revision to Diff 248025. akhuang added a comment. remove tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75215/new/ https://reviews.llvm.org/D75215 Files: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp llvm/test/DebugIn

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers updated this revision to Diff 248027. nickdesaulniers added a comment. - make sure to initialize GNUAsmQualifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75563/new/ https://reviews.llvm.org/D75563 Files: clang/docs/ReleaseN

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b3b21f02588: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nathanchance added inline comments. Comment at: clang/test/Parser/asm-qualifiers.c:20 + +void combinations(void) { + asm volatile inline(""); I'm probably being dense but what is intended to be tested differently between `combinations` and `permutations`? I ass

[clang] 736fef9 - [clang-format] Do not format C# array subscript operators as attributes

Author: Jonathan Coe Date: 2020-03-03T22:21:33Z New Revision: 736fef97c7ac4113388fc56db10c599fb4d2f074 URL: https://github.com/llvm/llvm-project/commit/736fef97c7ac4113388fc56db10c599fb4d2f074 DIFF: https://github.com/llvm/llvm-project/commit/736fef97c7ac4113388fc56db10c599fb4d2f074.diff LOG:

[PATCH] D75395: [clang][Modules] Add -fsystem-module flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG27a3ecee4558: [clang][Modules] Add -fsystem-module flag (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75395/new/ https://reviews.ll

[PATCH] D75465: [clang-format] Do not merge target-name and : for C# attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG900dee8c8e03: [clang-format] Do not merge target-name and : for C# attributes (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D75517: [clang-format] Do not format C# array subscript operators as attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG736fef97c7ac: [clang-format] Do not format C# array subscript operators as attributes (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D75473: [clang-format] parse C# object initialisers

jbcoe marked an inline comment as done. jbcoe added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1978 + if (FormatTok->is(tok::l_paren)) +parseParens(); + krasimir wrote: > I don't understand why this is needed, and removing

[PATCH] D75473: [clang-format] parse C# object initialisers

jbcoe updated this revision to Diff 248039. jbcoe added a comment. Remove code without test coverage. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75473/new/ https://reviews.llvm.org/D75473 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTestCSharp.cpp

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added parent revisions: D75570: [AST][SVE] Add new

[PATCH] D75570: [AST][SVE] Add new Type queries for sizeless types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, kristof.beyls, tschuett, mgorny. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added a comment. rsandifo-

[PATCH] D75569: New ClangTidy check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

mwyman created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Such method declarations don't provide any benefit, as even without the declaration the compiler would complain about calling the method as it doesn't exist. Repository: rG LLVM Github

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nickdesaulniers added inline comments. Comment at: clang/test/Parser/asm-qualifiers.c:20 + +void combinations(void) { + asm volatile inline(""); nathanchance wrote: > I'm probably being dense but what is intended to be tested differently > between `combinations

[PATCH] D75570: [AST][SVE] Add new Type queries for sizeless types

rsandifo-arm added a comment. At the moment the queries just return true for SVE types, so an obvious alternative would be to check specifically for SVE types. The sizeless type concept is more general than that though. E.g. my understanding from: https://gcc.gnu.org/ml/gcc/2019-11/msg00092

[PATCH] D75571: [Sema][SVE] Add tests for valid and invalid type usage

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, jfb, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added a child revision: D75572: [Sema][SVE] R

[PATCH] D75573: [Sema][SVE] Reject aligned/_Alignas for sizeless types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a project: clang. A previous patch rejected alignof for sizeless types. This patch extends that to cover the "alig

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 248044. PaulkaToast marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-too

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast added a comment. In D75332#1903570 , @MaskRay wrote: > > `RestrictSystemLibcHeadersCheck` > > As I commented previously, I think the checker name should be generalized, as > it does not need to be coupled with llvm-libc. Other projects may hav

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Motivated by the new objc_direct attribute, this change aims to limit metadata generation from Protocols that the programmer knows isn't going to be used at runtime. This attribute simply causes the

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge marked 6 inline comments as done. nridge added a comment. I'm posting some partial responses because I have some questions (really just one, about fuzzy matching). In general the comments seem reasonable and I plan to address all of them. (I've marked some comments as done because I've a

[PATCH] D62962: Clang implementation of sizeless types

rsandifo-arm added a comment. In D62962#1887242 , @efriedma wrote: > Can you make a list of the complete stack of patches here? Sorry for the slow reply, I was out last week. I've updated the stack for this revision: the only parent patch is D62961

[PATCH] D75486: [SVE] Make CompositeType not inherit from Type

ctetreau updated this revision to Diff 248050. ctetreau added a comment. Cleaned up code, resolved clang-format lints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75486/new/ https://reviews.llvm.org/D75486 Files: clang/lib/CodeGen/CGDecl.cpp

[clang] bdad0a1 - PR45083: Mark statement expressions as being dependent if they appear in

Author: Richard Smith Date: 2020-03-03T15:20:40-08:00 New Revision: bdad0a1b79273733df9acc1be4e992fa5d70ec56 URL: https://github.com/llvm/llvm-project/commit/bdad0a1b79273733df9acc1be4e992fa5d70ec56 DIFF: https://github.com/llvm/llvm-project/commit/bdad0a1b79273733df9acc1be4e992fa5d70ec56.diff

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvmlibc-restrict-system-libc-headers.rst:18 +lead to subtle and hard to detect bugs. For example consider a system libc +whose `dirent` struct has slightly different field ordering than l

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

MaskRay added a subscriber: juliehockett. MaskRay added a comment. In D75332#1904264 , @PaulkaToast wrote: > In D75332#1903570 , @MaskRay wrote: > > > > `RestrictSystemLibcHeadersCheck` > > > > As I commented previo

[PATCH] D75486: [SVE] Make CompositeType not inherit from Type

efriedma added a comment. It's possible to mess with the way "cast<>" actually casts values by specializing the function template in question. That, plus an appropriate classof implementations, should allow you to avoid the whole CompositeType::get thing. See, for example, https://github.com

[clang] ad18665 - PR45087: Fix check for emptiness when determining whether a trivial copy

Author: Richard Smith Date: 2020-03-03T15:57:48-08:00 New Revision: ad18665e377824fd545ca81117b4953e60e2823c URL: https://github.com/llvm/llvm-project/commit/ad18665e377824fd545ca81117b4953e60e2823c DIFF: https://github.com/llvm/llvm-project/commit/ad18665e377824fd545ca81117b4953e60e2823c.diff

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

PaulkaToast updated this revision to Diff 248059. PaulkaToast marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75332/new/ https://reviews.llvm.org/D75332 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-too

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

nridge added a comment. Thanks for putting this together, this is really neat and will indeed complement D72874 nicely! I have one high-level comment about the interface, the rest are nits. Comment at: clang-tools-extra/clangd/XRefs.cpp:337 +

[PATCH] D75579: [WIP] Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by libraries

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, tstellar. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, gbedwell, aheejin, hiraditya, mgorny, dschuff. Herald added a reviewer: JDevlieghere. Herald added a reviewer: andreadb. Herald

[PATCH] D75572: [Sema][SVE] Reject sizeof and alignof for sizeless types

efriedma added a comment. The planned changes to RequireCompleteType should catch this, right? If we want a specialized diagnostic for sizeless types in RequireCompleteType, we should probably just pass it to RequireCompleteType. (Otherwise, you'll end up with the "wrong" diagnostic in templa

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

nathanchance added inline comments. Comment at: clang/test/Parser/asm-qualifiers.c:20 + +void combinations(void) { + asm volatile inline(""); nickdesaulniers wrote: > nathanchance wrote: > > I'm probably being dense but what is intended to be tested differently

[PATCH] D75582: [clangd] Track document versions, include them with diags, enhance logs

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. sammccall updated this revision to Diff 248069. sammccall added a comment. sammccall added a reviewer: hokein. sammcca

<    1   2   3   >