[clang] 59fb9cd - Devirtualize a call on alloca without waiting for post inline cleanup and next

Author: Hiroshi Yamauchi Date: 2020-02-26T09:51:24-08:00 New Revision: 59fb9cde7a4a96fe8485a80d9010e4420ffdca82 URL: https://github.com/llvm/llvm-project/commit/59fb9cde7a4a96fe8485a80d9010e4420ffdca82 DIFF: https://github.com/llvm/llvm-project/commit/59fb9cde7a4a96fe8485a80d9010e4420ffdca82.di

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

dmajor updated this revision to Diff 246771. dmajor edited the summary of this revision. dmajor added a comment. Updated the tests: three cases for {default, old, new} linkers in the platform-version tests; left alone the tests not specifically targeting this path. CHANGES SINCE LAST ACTION

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

Anastasia updated this revision to Diff 246774. Anastasia added a comment. Addressed comments from Hans and Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst =

[PATCH] D75056: [Driver] Default to -fno-common

hubert.reinterpretcast added a comment. I have no objections; however, it may help for the title of the patch to clearly indicate "for all targets". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056 _

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

I mean anything that's testing assembly output out of clang is less than ideal. There are some circumstances, but this doesn't seem like one of them. On Wed, Feb 26, 2020, 9:10 AM Sanjay Patel wrote: > The test file dates back to: > https://reviews.llvm.org/D5698 > ...and I'm not familiar with _

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75125/new/ https://reviews.llvm.org/D75125 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

steven_wu added a comment. Thanks. LGTM. I will let @arphaman to approve this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74784/new/ https://reviews.llvm.org/D74784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9965 "memory order clause '%0' is specified here">; +def err_omp_non_lvalue_in_map_or_motion_clauses: Error< + "expected lvalue with no function call in '#pragma omp target update' and

[PATCH] D75056: [Driver] Default to -fno-common

MaskRay added inline comments. Comment at: clang/test/Driver/clang_f_opts.c:15 // CHECK-OPTIONS2: -fshort-enums -// CHECK-OPTIONS2: -fno-common +// CHECK-OPTIONS2-NOT: -fcommon // CHECK-OPTIONS2: -fno-show-source-location I think such NOT patterns should just b

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 might've broken our toolchain again: FAIL: Clang :: Driver/riscv32-toolchain-extra.c (5723 of 17018) TEST 'Clang

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl added a comment. I tried recording functions to be emitted during normal parsing and using it as starting point for the final traversal. It is quite promising. I only get one lit test failure for OpenMP: int foobar2(); #pragma omp declare target int (*B)() = &foobar2; #pragma

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

To be clear - the test is checking IR instructions, but it's checking -O1 IR for various targets. So there must be different expectations per target... But I just tried a test of turning everything down to -O0, and it all passed except for the "fast-math" run for AArch64. I can tweak that to not be

Re: r329762 - Introduce a new builtin, __builtin_dump_struct, that is useful for dumping structure contents at runtime in circumstances where debuggers may not be easily available (such as in kernel w

On Tue, Feb 25, 2020 at 4:36 PM Richard Smith wrote: > > It looks like we forgot to document this builtin. Can some documentation be > added? If Paul doesn't get to it first, I can try to stub some out. ~Aaron > > On Tue, 10 Apr 2018 at 15:01, Aaron Ballman via cfe-commits > wrote: >> >> Aut

[PATCH] D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.

epastor created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. epastor added a child revision: D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM.. ParsingInlineAsm was a misleading name. These values are onl

[PATCH] D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75198/new/ https://reviews.llvm.org/D75198 ___ cfe-c

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson added a comment. Sent fix for review in D75201 . If the new problem showed up later and not when this one first went in, then it seems likely it is different than this issue. I'll see if I can reproduce and take a look. Repository: rG LLVM Github

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Did you want to delete the lexer check in getDeducedType or is that another patch? Comment at: clang-tools-extra/clangd/Hover.cpp:533 + } + auto TokensAroundCursor =

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes hasName AST matcher is confused by extern "C" in namespace. Repository: rG LL

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM to me too. With @steven_wu and me on board, I don't think you need to wait for @arphaman. Thanks for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74784/new/

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added a comment. In D70172#1894036 , @yaxunl wrote: > I tried recording functions to be emitted during normal parsing and using it > as starting point for the final traversal. It is quite promising. I only get > one lit test failure for OpenMP:

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 > > might've broken our toolchain again: s***t. Can y

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

Does adding // REQUIRES: platform-linker to Driver/riscv32-toolchain-extra.c fixes your issue? On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 >

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9965 "memory order clause '%0' is specified here">; +def err_omp_non_lvalue_in_map_or_motion_clauses: Error< + "expected lvalue with no function c

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

Will you be sending out the patch for this? On Wed, Feb 26, 2020 at 12:05 PM Leonard Chan wrote: > Yup, I added it to both *-extra.c files and it seemed to fix the tests. > > On Wed, Feb 26, 2020 at 11:37 AM Serge Guelton > wrote: > >> Does adding >> >> // REQUIRES: platform-linker >> >> to Dri

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

Yup, I added it to both *-extra.c files and it seemed to fix the tests. On Wed, Feb 26, 2020 at 11:37 AM Serge Guelton wrote: > Does adding > > // REQUIRES: platform-linker > > to Driver/riscv32-toolchain-extra.c fixes your issue? > > > On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. Unsure if my reply was sent over email so copying it here. Yup, adding `// REQUIRES: platform-linker` to both `*-extra.c` files seems to fix it. Thanks. Will you be sending out the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang] ca50f09 - [clang] fix error detection in consteval calls

Author: Tyker Date: 2020-02-26T21:09:31+01:00 New Revision: ca50f09db9f86eb5ac7aa0cb53c52637f2b7effa URL: https://github.com/llvm/llvm-project/commit/ca50f09db9f86eb5ac7aa0cb53c52637f2b7effa DIFF: https://github.com/llvm/llvm-project/commit/ca50f09db9f86eb5ac7aa0cb53c52637f2b7effa.diff LOG: [c

[PATCH] D74418: [clang] fix error detection in consteval calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGca50f09db9f8: [clang] fix error detection in consteval calls (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

On Wed, Feb 26, 2020 at 08:08:49PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Unsure if my reply was sent over email so copying it here. > > Yup, adding `// REQUIRES: platform-linker` to both `*-extra.c` files seems to > fix it. Thanks. Will you be sending out

[PATCH] D75056: [Driver] Default to -fno-common for all targets

SjoerdMeijer updated this revision to Diff 246808. SjoerdMeijer retitled this revision from "[Driver] Default to -fno-common" to "[Driver] Default to -fno-common for all targets". SjoerdMeijer edited the summary of this revision. SjoerdMeijer added a comment. Removed the CHECK-NOTs from some test

[clang] 85b641c - [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.

Author: Eric Astor Date: 2020-02-26T15:19:40-05:00 New Revision: 85b641c27aecee637d3f7ab25915f47438f55848 URL: https://github.com/llvm/llvm-project/commit/85b641c27aecee637d3f7ab25915f47438f55848 DIFF: https://github.com/llvm/llvm-project/commit/85b641c27aecee637d3f7ab25915f47438f55848.diff LO

[PATCH] D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.

This revision was automatically updated to reflect the committed changes. Closed by commit rG85b641c27aec: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity. (authored by epastor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] d2cbaf1 - Fix for the test failues introduced in https://reviews.llvm.org/D74704.

Author: Leonard Chan Date: 2020-02-26T12:23:15-08:00 New Revision: d2cbaf1755ffa90300365c0d71400a5ee4ada3bd URL: https://github.com/llvm/llvm-project/commit/d2cbaf1755ffa90300365c0d71400a5ee4ada3bd DIFF: https://github.com/llvm/llvm-project/commit/d2cbaf1755ffa90300365c0d71400a5ee4ada3bd.diff

[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

ABataev created this revision. ABataev added reviewers: tra, hfinkel. Herald added a subscriber: guansong. Herald added a project: clang. Inherited support for complex math functions from CUDA implementation. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75209 Files: clang/

[PATCH] D75056: [Driver] Default to -fno-common for all targets

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Hope @tstellar and @jyknight can confirm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056 _

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. Submitted fixes in d2cbaf1755ffa90300365c0d71400a5ee4ada3bd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.org/D74704

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl added a comment. Also, we cannot remove traversing of RecordDecl and CapturedDecl encountered in function body since we have OpenMP test like this: int main() { #pragma omp target { t1(0); } return 0; } This results in a kernel function embedded in a captured reco

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/test/OpenMP/target_update_codegen.cpp:371-372 + // CK6-DAG: store i32* [[ADD_PTR:%.+]], i32** [[PC0]] + // CK6-DAG: [[ADD_PTR]] = getelementptr inbounds i32, i32* [[ONE:%.+]], i{{32|64}} [[IDX_EXT:%.+]] + // CK6-DAG: [[TWO:%.+]

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://reviews.llvm.org/D74941

[PATCH] D75056: [Driver] Default to -fno-common for all targets

jyknight added a comment. Are there any tests remaining that check that with -fcommon, IR generation creates "common" variables, now that all these tests have been modified? If there are not, one should be added. Comment at: clang/docs/ClangCommandLineReference.rst:1311 +Plac

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

jdoerfert created this revision. jdoerfert added reviewers: erichkeane, aaron.ballman, rjmccall, john.brawn. Herald added a subscriber: bollu. Herald added a project: clang. ParsedAttr is used for `clang attribute push/pop` a utility that is reusable in other contexts as well. This allows us to cr

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

erichkeane added a comment. I don't see anything glaring here, but I would love some better explanation as to the goal here. I don't see this used anywhere, the commit message is a bit underwhelming in its reasoning, and there is no test/etc showing why I would want this. C

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Wawha added a comment. In D44609#1893390 , @christophe-calmejane wrote: > Nice to finally see this patch integrated! > > But, it looks like you didn't include all the test case I posted 1.5y ago in > this post, that are still problematic and not formatti

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:518 +// Linkage Spec can just be ignored +// FIXME: Any other DeclContext kinds that can

[clang] 7848a3c - Update the ARC docs for non-trivial ownership in structs.

Author: John McCall Date: 2020-02-26T16:42:08-05:00 New Revision: 7848a3c8ab54570f5875e63606ff75b5736750b4 URL: https://github.com/llvm/llvm-project/commit/7848a3c8ab54570f5875e63606ff75b5736750b4 DIFF: https://github.com/llvm/llvm-project/commit/7848a3c8ab54570f5875e63606ff75b5736750b4.diff L

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 246826. hliao added a comment. Rebase to the latest trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/Pars

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

jdoerfert marked an inline comment as done. jdoerfert added a comment. In D75210#1894370 , @erichkeane wrote: > I don't see anything glaring here, but I would love some better explanation > as to the goal here. I don't see this used anywhere, the commit

[clang] 16cabf2 - [ASTMatchers] HasNameMatcher handles `extern "C"`

Author: Nathan James Date: 2020-02-26T22:07:47Z New Revision: 16cabf278fc8c14d415e677ce0bc40d46a6de30d URL: https://github.com/llvm/llvm-project/commit/16cabf278fc8c14d415e677ce0bc40d46a6de30d DIFF: https://github.com/llvm/llvm-project/commit/16cabf278fc8c14d415e677ce0bc40d46a6de30d.diff LOG:

Re: r355698 - Re-fix _lrotl/_lrotr to always take Long, no matter the platform.

I believe this commit is wrong. These intrinsics were originally implemented to support Windows code which expects _lrot{l,r}'s first argument to be 32 bits, it's a breaking change to change these definitions. I'm fine with adding the Intel version of these intrinsics, but you can't just break the

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

njames93 updated this revision to Diff 246829. njames93 marked an inline comment as done. njames93 added a comment. - Add extra test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75202/new/ https://reviews.llvm.org/D75202 Files: clang/lib/A

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:518 +// Linkage Spec can just be ignored +// FIXME: Any other DeclContext kinds that can be safely disregarded +if (isa(Ctx)) -

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

EricWF added a subscriber: ldionne. EricWF added a comment. @ldionne Since this has the possibility of breaking existing users of `std::max_align_t`, can you test this against your c++03 codebases? @joerg I still don't understand why you need this change. Why can't we provide the name in C++03

[PATCH] D75202: [ASTMatchers] HasNameMatcher handles `extern "C"`

This revision was automatically updated to reflect the committed changes. Closed by commit rG16cabf278fc8: [ASTMatchers] HasNameMatcher handles `extern "C"` (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75202/new/ https://rev

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson added a comment. In D73242#1894146 , @tejohnson wrote: > Sent fix for review in D75201 . > > If the new problem showed up later and not when this one first went in, then > it seems likely it is different than thi

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

dmajor added a comment. Thanks! I'm still working on getting commit access, would one of you be able to submit for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74784/new/ https://reviews.llvm.org/D74784 ___ cfe-commits mailing list cf

[clang] 98ed0c5 - PR44978: Accept as an extension some cases where destructor name lookup

Author: Richard Smith Date: 2020-02-26T14:55:31-08:00 New Revision: 98ed0c5475df57ca5cd4df0997d8bba323c843aa URL: https://github.com/llvm/llvm-project/commit/98ed0c5475df57ca5cd4df0997d8bba323c843aa DIFF: https://github.com/llvm/llvm-project/commit/98ed0c5475df57ca5cd4df0997d8bba323c843aa.diff

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg added a comment. libc++ has no idea what a correct max_align_t is. The internal definition works due to historic requirements that all three fundamental types are supported for new/delete, but we don't have any such guarantees for every other context. A correctly implemented stddef.h does

[PATCH] D75056: [Driver] Default to -fno-common for all targets

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:87 +- -fno-common has been enabled as the default for all targets. jyknight wrote: > Might be nice to expand upon this somewhat, to give users a clue what it > means to the

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang created this revision. akhuang added reviewers: rnk, asmith. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This change checks for the return type in the frontend and adds a flag to the DISubroutineType to indicate that the option should

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao added a comment. @rjmccall @rsmith @tra, could you review on this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 ___ cfe-commits mailing list c

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:992 getTagForRecord(RD), RDName, Ctx, DefUnit, Line, 0, Size, Align, llvm::DINode::FlagFwdDecl, Identifier); if (CGM.getCodeGenOpts().DebugFwdTemplateParams) One alternative

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. I ran into this issue again, and would like to move forward with this. I'll rebase it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 ___

[PATCH] D71314: Warn of uninitialized variables on asm goto's indirect branch

void updated this revision to Diff 246849. void added a comment. Rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71314/new/ https://reviews.llvm.org/D71314 Files: clang/lib/Analysis/UninitializedValues.cpp clang/test/Analysis/uninit-asm-goto.cpp Index: clang/test/Analysis/

[PATCH] D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration.

yamauchi closed this revision. yamauchi added a comment. Committed as https://reviews.llvm.org/rG59fb9cde7a4a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69591/new/ https://reviews.llvm.org/D69591 __

[PATCH] D75220: [clang-tidy] RenamerClangTidy now correctly renames decls

njames93 updated this revision to Diff 246853. njames93 added a comment. - Remove unnecessary include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75220/new/ https://reviews.llvm.org/D75220 Files: clang-tools-extra/clang-tidy/utils/RenamerClang

[PATCH] D75220: [clang-tidy] RenamerClangTidy now correctly renames decls

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, JonasToth, hokein, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 updated this revision to Diff 246853. njames93 added a comment. - Remove unnecessary include F

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

aaronpuchert updated this revision to Diff 246862. aaronpuchert added a comment. Rebase on top of D66437 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112 Files: clang/inc

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

aaronpuchert reclaimed this revision. aaronpuchert removed a reviewer: riccibruno. aaronpuchert added a comment. The diff between both changes might still be interesting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm

[PATCH] D75215: [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:992 getTagForRecord(RD), RDName, Ctx, DefUnit, Line, 0, Size, Align, llvm::DINode::FlagFwdDecl, Identifier); if (CGM.getCodeGenOpts().DebugFwdTe

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

grokos created this revision. grokos added reviewers: ABataev, vzakhari. grokos added projects: OpenMP, clang. Herald added a reviewer: jdoerfert. Currently, the offload-wrapper tool inserts `__tgt_register_lib` to the list of global ctors of a target module with `Priority=0`. This means that it'

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

vzakhari added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:291 // Add this function to global destructors. appendToGlobalDtors(M, Func, 0); } I think __tgt_unregister_lib should have a matching priority. R

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames marked 2 inline comments as done. arames added a comment. In D72100#1855483 , @jkorous wrote: > We should either simplify the implementation to reflect that we don't support > e. g. `*:42` (seems preferable to me) or have the codepaths that are >

[PATCH] D70700: [WebAssembly] Mangle the argc/argv `main` as `__main_argc_argv`

sbc100 added a comment. Would you mind re-basing? I'd like to download and try this but it seems to have conflicts right now. (i'll do my best to resolve them you might do better). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70700/new/ https:

[PATCH] D75223: [clang-offload-wrapper] Lower priority of __tgt_register_lib in favor of __tgt_register_requires

grokos updated this revision to Diff 246870. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75223/new/ https://reviews.llvm.org/D75223 Files: clang/test/Driver/clang-offload-wrapper.c clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp In

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies updated this revision to Diff 246871. ffrankies marked 5 inline comments as done. ffrankies added a comment. Addressed comments by @aaron.ballman - Removed commented-out code and irrelevant FIXMEs - Added Fix-Its to insert/amend the aligned and packed struct attributes as needed. CHA

Re: r355698 - Re-fix _lrotl/_lrotr to always take Long, no matter the platform.

I'm not clear as to what you're saying is broken. On MS platforms, long is 32-bit, so either way this function takes a 32bit value, right? And, Microsoft's docs say this function takes a long. On Wed, Feb 26, 2020, 5:09 PM Michael Spencer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I

<    1   2