[PATCH] D75152: Fix typo

2020-02-25 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75152 Files: clang-tools-extra/clang-tidy/add_new_check.py Index: clang-tools-extra/clang-tidy/add_new_check.py =

[PATCH] D75134: [clang-tidy] Improved renamer check logic

2020-02-25 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Feel free to apply this and see how it works. Tested with checks that have alias variants which seem to respond well. Renaming a check then renaming it back reverts the state to how it was before apart from release notes and maybe some non standard comments Repositor

[clang] 6fb70c8 - [Analysis] Fix -Wrange-loop-analysis after D69876

2020-02-25 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-02-25T18:05:09-08:00 New Revision: 6fb70c87251708af8fc27b501fd79e26162f7e65 URL: https://github.com/llvm/llvm-project/commit/6fb70c87251708af8fc27b501fd79e26162f7e65 DIFF: https://github.com/llvm/llvm-project/commit/6fb70c87251708af8fc27b501fd79e26162f7e65.diff

[PATCH] D75152: Fix typo

2020-02-25 Thread Eric Christopher via Phabricator via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This probably qualifies as "obvious" :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75152/new/ https://reviews.llvm.org/D75152

[PATCH] D75134: [clang-tidy] Improved renamer check logic

2020-02-25 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D75134#1892607 , @Eugene.Zelenko wrote: > It'll be reasonable to find out what are naming conventions for Python in > LLVM. I just stuck to the trusty old c++ naming conventions. Having a look I see most of it is using `lo

[PATCH] D75152: Fix typo

2020-02-25 Thread Nathan James via Phabricator via cfe-commits
njames93 closed this revision. njames93 added a comment. In D75152#1892621 , @echristo wrote: > This probably qualifies as "obvious" :) This was arc diff screwing up and creating a new revision instead of updating :) Repository: rG LLVM Github Monore

[PATCH] D75097: [MC] Default MCContext::UseNamesOnTempLabels to false and only use it for MCAsmStreamer

2020-02-25 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75097/new/ https://reviews.llvm.org/D75097 ___

[PATCH] D75134: [clang-tidy] Improved renamer check logic

2020-02-25 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 246614. njames93 added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75134/new/ https://reviews.llvm.org/D75134 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-tools-extra

[PATCH] D75097: [MC] Default MCContext::UseNamesOnTempLabels to false and only set it to true for MCAsmStreamer

2020-02-25 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 246616. MaskRay retitled this revision from "[MC] Default MCContext::UseNamesOnTempLabels to false and only use it for MCAsmStreamer" to "[MC] Default MCContext::UseNamesOnTempLabels to false and only set it to true for MCAsmStreamer". MaskRay edited the sum

[PATCH] D75097: [MC] Default MCContext::UseNamesOnTempLabels to false and only set it to true for MCAsmStreamer

2020-02-25 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb61a4aaca5f8: [MC] Default MCContext::UseNamesOnTempLabels to false and only set it to true… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Diffusion] rG396b7253944e: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

2020-02-25 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added subscribers: aprantl, cfe-commits, dexonsmith. dexonsmith added inline comments. BRANCHES master /clang/test/OpenMP/PR44893.c:1 Can you change this to a `-cc1` test (invoking `%clang_cc1`), instead of calling the driver? /clang/test/OpenMP/PR44893.c:3 Can you add some sort of

[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

2020-02-25 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea created this revision. aganea added reviewers: tejohnson, thakis, rnk, RobRich999. Herald added subscribers: cfe-commits, dang, dexonsmith, mikhail.ramalho, steven_wu, MaskRay, aheejin, hiraditya, arichardson, inglorion, sbc100, emaste. Herald added a reviewer: espindola. Herald added proje

Buildbot cleaning for zorg upgrade

2020-02-25 Thread Galina Kistanova via cfe-commits
Hello everyone, Zorg upgrade to a recent version of buildbot is coming. We would do our best to make the transition as smooth and transparent to the majority of LLVM community, as possible. The process will be handled similar to how we did the github transition. As the next step, we will be clea

Re: Buildbot cleaning for zorg upgrade

2020-02-25 Thread Michael Kruse via cfe-commits
Looking forward to the upgrade. Thanks for investing the time. I am trying to re-add buildbots for polly-x86_64 (https://reviews.llvm.org/D75127) and I am not use whether you received my messages about it. In any case, would you prefer to wait until the new instance of buildbot-master is available

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

2020-02-25 Thread Zinovy Nis via Phabricator via cfe-commits
zinovy.nis updated this revision to Diff 246628. zinovy.nis added a comment. Warning on use after move is still generated. But there's also an additional note > std::move of the const expression has no effect; remove std::move() or make > the variable non-const CHANGES SINCE LAST ACTION h

[Diffusion] rG396b7253944e: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

2020-02-25 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. BRANCHES master /clang/test/OpenMP/PR44893.c:3 > Can you add some sort of positive test, related to where the crash was? I did, in deduplication.ll. > If this was a debug info related crash, maybe you can test that

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

2020-02-25 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D59319#1892544 , @JonChesterfield wrote: > I'd like to rebase this on the current deviceRTL, and add any nvptx/amdgcn > specific hooks if necessary. Any objections? No generic objections. Please take a look at the TRegion

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-25 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 246630. jdoerfert marked 5 inline comments as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://reviews.llvm.org/D74941 Files: clang/inclu

[PATCH] D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks

2020-02-25 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added reviewers: NoQ, Szelethus, baloghadamsoftware. Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. This doesn't seem to be in line with the current idea behind `core` checkers. Turning them off is strongly disenco

[PATCH] D75106: [clangd] Fix early selection for non-vardecl declarators

2020-02-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 246635. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75106/new/ https://reviews.llvm.org/D75106 Files: clang-tools-ex

[PATCH] D75021: [clang][analyzer] Enable core.builtin even with -no-default-checks

2020-02-25 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. @Charusso implemented a flag that can //silence// checkers in D66042 . I can offer that as an alternative while we're working on separating modeling and reporting in the checker insfrastructure. Repository: rG LLVM Github Monorepo

<    1   2   3