[PATCH] D62962: Clang implementation of sizeless types

2020-02-21 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Can you make a list of the complete stack of patches here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62962/new/ https://reviews.llvm.org/D62962 ___ cfe-commits mailing lis

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-21 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen marked an inline comment as done. cchen added a comment. In D74970#1887193 , @ABataev wrote: > Did you try to run the tests? I would suggest adding a test, at least, where > a function is mapped. We should see the error message here. Seems to me, we

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

2020-02-21 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. In D74935#1886020 , @nhaehnle wrote: > I find this phrasing pretty confusing. How about the following: > > > This indicates that objects accessed via pointer values based on the > > argument or return value are not **modified**,

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-21 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D74970#1887246 , @cchen wrote: > In D74970#1887193 , @ABataev wrote: > > > Did you try to run the tests? I would suggest adding a test, at least, > > where a function is mapped. We shoul

[PATCH] D74500: clang: Treat ieee mode as the default for denormal-fp-math

2020-02-21 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 245972. arsenm edited the summary of this revision. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74500/new/ https://reviews.llvm.org/D74500 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Dri

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-21 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1251 "expected '#pragma omp end declare target'">; +def err_expected_end_declare_target_or_variant : Error< + "expected '#pragma omp end declare %select{target|variant}0'">; --

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-21 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added a comment. In D74970#1887252 , @ABataev wrote: > In D74970#1887246 , @cchen wrote: > > > In D74970#1887193 , @ABataev wrote: > > > > > Did you try to run the test

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-21 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 245978. cchen added a comment. Add test for mapping function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/ta

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-21 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added a comment. So an alternative is to: - patch `openmp/runtime/cmake/LibompCheckLinkerFlag.cmake` to make the `libomp_check_linker_flag` function to ignore the "Unknown CUDA version" warning, AND - ask users to build with `-DCMAKE_CXX_FLAGS=-Wno-unknown-cuda-version -DCMAKE_C_FLAGS=

LLVM buildmaster will be updated and restarted tonight

2020-02-21 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-21 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15358-15360 + if (!AE->getIdx()->isValueDependent()) +if (AE->getIdx()->EvaluateAsInt(Result, SemaRef.getASTContext())) { if (!Result.Val.getInt().isNullValue()) { Si

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-21 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 245983. cchen added a comment. Fix test and sorry for my carelessness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/

[clang] a6c8698 - clang/Modules: Finish renaming CompilerInstance::ModuleManager, NFC.

2020-02-21 Thread Volodymyr Sapsai via cfe-commits
Author: Volodymyr Sapsai Date: 2020-02-21T13:56:50-08:00 New Revision: a6c8698924d2b31a2f096e0f4c06a7015ecccb5e URL: https://github.com/llvm/llvm-project/commit/a6c8698924d2b31a2f096e0f4c06a7015ecccb5e DIFF: https://github.com/llvm/llvm-project/commit/a6c8698924d2b31a2f096e0f4c06a7015ecccb5e.di

[PATCH] D74939: clang/Modules: Finish renaming CompilerInstance::ModuleManager, NFC.

2020-02-21 Thread Volodymyr Sapsai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa6c8698924d2: clang/Modules: Finish renaming CompilerInstance::ModuleManager, NFC. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74939

[clang] d37cbda - [Hexagon] Define __ELF__ by default.

2020-02-21 Thread Sid Manning via cfe-commits
Author: Sid Manning Date: 2020-02-21T16:10:31-06:00 New Revision: d37cbda5f9a47a4206439632ef4fa1534e66f856 URL: https://github.com/llvm/llvm-project/commit/d37cbda5f9a47a4206439632ef4fa1534e66f856 DIFF: https://github.com/llvm/llvm-project/commit/d37cbda5f9a47a4206439632ef4fa1534e66f856.diff L

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-21 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added a comment. Hi @jdoerfert , thank you for working on this. I have a couple of high level comments. 1. I am not familiar with `OpenMP technical report 8 (TR8)`. Could you please provide a link in the description? Same for PR42061, PR42798, PR42799. It would be useful to get an

[PATCH] D74972: [hexagon] Define __ELF__ by default.

2020-02-21 Thread Sid Manning via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd37cbda5f9a4: [Hexagon] Define __ELF__ by default. (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74972/new/ https://reviews.llvm.org/

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-21 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D74970#1887337 , @cchen wrote: > Fix test and sorry for my carelessness No problem. But I don't see the changes in the test. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15473 + ERange)

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-21 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added a comment. Since it is a TR8 feature, should we have this guarded by `-fopenmp-version=`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://reviews.llvm.org/D74941 ___ cfe-c

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-21 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 245995. cchen added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_messages.cpp

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-21 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D74941#1887381 , @kkwli0 wrote: > Since it is a TR8 feature, should we have this guarded by `-fopenmp-version=`? Not this one. It is required to fix the issues with math functions and should work for all versions of OpenMP. O

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-21 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked 6 inline comments as done. jdoerfert added a comment. In D74941#1887367 , @fpetrogalli wrote: > 1. I am not familiar with `OpenMP technical report 8 (TR8)`. Could you please > provide a link in the description? Same for PR42061, PR42798,

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-21 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen added a comment. @ABataev, can you land it for me when you have time? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 ___ cfe-commits mailing list

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

2020-02-21 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. In D72872#1872242 , @hans wrote: > [...snip...] > Thanks! I applied the patch and was able to build large parts of Chromium > without any problems. Thanks for checking! Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D69868: Allow "callbr" to return non-void values

2020-02-21 Thread Quentin Colombet via Phabricator via cfe-commits
qcolombet added a comment. > I've been concerned about the register live-ins too (I'm less concerned about > the successors issue). Is there documentation on the original decision to > disallow physical register live-ins for MBBs before register allocation? We > could then check to see if we're

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

2020-02-21 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

2020-02-21 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 246005. vsapsai added a comment. - Fix some clang-format checks. Ignore the check to add a space between a generic name and its type parameters as it's not the style the rest of the header uses and not what Apple SDK headers are using. Repository: rG LLV

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

2020-02-21 Thread Scott Linder via Phabricator via cfe-commits
scott.linder added a comment. Sorry for the delay; I can just commit this, no need to update the review. I will hopefully be back to a terminal to push it a bit later tonight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/ https://review

[PATCH] D74996: [arcconfig] Delete subproject arcconfigs

2020-02-21 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. smeenai added reviewers: jyknight, phosek, rnk. Herald added a reviewer: bollu. Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits. >From

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/test/OpenMP/begin-declare-variant_elided_range_withouth_end.c:5 +// TODO: Improve the error message +#pragma omp begin declare variant match(device={kind(cpu)}) // expected-error {{un

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 246032. jdoerfert marked an inline comment as done. jdoerfert added a comment. Herald added a subscriber: jfb. Add tests and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://r

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

2020-02-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 246035. jdoerfert added a comment. Revert test check lines to the parser part only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://reviews.llvm.org/D74941 Files: clang/include/clang/AST/Op

[clang] 340feac - [Driver] Escape the program path for -frecord-command-line

2020-02-21 Thread Scott Linder via cfe-commits
Author: Scott Linder Date: 2020-02-21T19:16:59-05:00 New Revision: 340feac6721e840f88c1e77dd79931eea5eaccf3 URL: https://github.com/llvm/llvm-project/commit/340feac6721e840f88c1e77dd79931eea5eaccf3 DIFF: https://github.com/llvm/llvm-project/commit/340feac6721e840f88c1e77dd79931eea5eaccf3.diff

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

2020-02-21 Thread Scott Linder via Phabricator via cfe-commits
scott.linder added a comment. Recommitted as 340feac6721e840f88c1e77dd79931eea5eaccf3 , hopefully this version sticks, cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-02-21 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 created this revision. kkwli0 added reviewers: tra, ABataev, JonChesterfield, jdoerfert, ye-luo. Herald added subscribers: guansong, mgorny. With CUDA 10.2 installed on the system, the compiler issues a warning about unknown CUDA version. The warning message makes the `LIBOMP_HAVE_VERSIO

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

2020-02-21 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. mcgrathr updated this revision to Diff 246043. mcgrathr added a comment. mcgrathr edited the summary of this revision. update log Make Clang on aarch64 targets predefine `__AARCH6

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

2020-02-21 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr updated this revision to Diff 246043. mcgrathr added a comment. update log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75002/new/ https://reviews.llvm.org/D75002 Files: clang/lib/Basic/Targets/AArch64.cpp clang/test/Preprocessor/ini

[PATCH] D75003: [X86] Fix __code_model_*__ predefine names

2020-02-21 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr created this revision. mcgrathr added a reviewer: tamur. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC defines __code_model_*__ (two trailing underscores), not __code_model_*_ (one trailing underscore). Repository: rG LLVM Github Monorepo https://reviews.

[PATCH] D75003: [X86] Fix __code_model_*__ predefine names

2020-02-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG. The full story: // gcc/config/i386/i386-c.c case CM_SMALL: case CM_SMALL_PIC: def_or_undef (parse_in, "__code_model_small__"); break; case CM_MEDIUM:

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

2020-02-21 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added a comment. @rsmith: is this fine for you as well? If this is ready for landing, I would appreciate if somebody can land this on my behalf since I do not have commit rights. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D75003: [X86] Fix __code_model_*__ predefine names

2020-02-21 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr added a comment. Thanks! Can you land it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75003/new/ https://reviews.llvm.org/D75003 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

2020-02-21 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr added a comment. Thanks! Can you land it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75002/new/ https://reviews.llvm.org/D75002 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

2020-02-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:200 +CodeModel = "small"; + for (auto& c : CodeModel) { +c = toupper(c); This can be simplified. I'll do that. Repository: rG LLVM Github M

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-02-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I like this way better. I was hoping we could do it in our cmake only :) Give others a day or so to comment before your commit but I'm fine with this. CHANGES SINCE LAST ACTION https:

[clang] 59a572e - [Preprocessor][test] Move AArch64 tests from init.c to init-aarch.c

2020-02-21 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-02-21T22:22:59-08:00 New Revision: 59a572eb742437c17b78f6cf63f14d4b808fe61f URL: https://github.com/llvm/llvm-project/commit/59a572eb742437c17b78f6cf63f14d4b808fe61f DIFF: https://github.com/llvm/llvm-project/commit/59a572eb742437c17b78f6cf63f14d4b808fe61f.diff

[clang] 0123744 - [Preprocessor][test] Fix __VERSION__ in init-aarch64.c

2020-02-21 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-02-21T22:38:20-08:00 New Revision: 0123744d46a1fd6041755b403633af2d6c47f64a URL: https://github.com/llvm/llvm-project/commit/0123744d46a1fd6041755b403633af2d6c47f64a DIFF: https://github.com/llvm/llvm-project/commit/0123744d46a1fd6041755b403633af2d6c47f64a.diff

[clang] fc6057e - [Frontend] Replace CC1 option -mcode-model with -mcmodel=

2020-02-21 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-02-21T23:10:50-08:00 New Revision: fc6057e34fb3b1cfbbfcd5d71ae25ba24eb3ffa3 URL: https://github.com/llvm/llvm-project/commit/fc6057e34fb3b1cfbbfcd5d71ae25ba24eb3ffa3 DIFF: https://github.com/llvm/llvm-project/commit/fc6057e34fb3b1cfbbfcd5d71ae25ba24eb3ffa3.diff

[clang] d2e949e - [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

2020-02-21 Thread Fangrui Song via cfe-commits
Author: Roland McGrath Date: 2020-02-21T23:27:36-08:00 New Revision: d2e949eed5b49ca70a8845dfaf7bac6ca40c429d URL: https://github.com/llvm/llvm-project/commit/d2e949eed5b49ca70a8845dfaf7bac6ca40c429d DIFF: https://github.com/llvm/llvm-project/commit/d2e949eed5b49ca70a8845dfaf7bac6ca40c429d.diff

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

2020-02-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 246060. MaskRay added a comment. Add tests Rebase after -mcmodel cleanups (including fc6057e34fb3b1cfbbfcd5d71ae25ba24eb3ffa3 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

2020-02-21 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e949eed5b4: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does (authored by mcgrathr, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D75002?vs=246060&id=246061#toc Reposit

[clang] 271f964 - [Preprocessor][X86] Fix __code_model_*__ predefine macros

2020-02-21 Thread Fangrui Song via cfe-commits
Author: Roland McGrath Date: 2020-02-21T23:30:07-08:00 New Revision: 271f96477328f42cbf31a2b42433cdef8ed91914 URL: https://github.com/llvm/llvm-project/commit/271f96477328f42cbf31a2b42433cdef8ed91914 DIFF: https://github.com/llvm/llvm-project/commit/271f96477328f42cbf31a2b42433cdef8ed91914.diff

[PATCH] D75003: [X86] Fix __code_model_*__ predefine names

2020-02-21 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG271f96477328: [Preprocessor][X86] Fix __code_model_*__ predefine macros (authored by mcgrathr, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

<    1   2