[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

2020-02-19 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGba3f863dfb9c: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class (authored by fghanim, committed by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D74562?vs=245227

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

2020-02-19 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 nit, otherwise LGTM. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2996 +def warn_alignment_not_power_of_two : Warning< + "requested alignment is no

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

2020-02-19 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D73996#1883360 , @erichkeane wrote: > 1 nit, otherwise LGTM. Thank you for the review! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2996 +def warn_alignment_not_power_of_two : Warning< +

[PATCH] D74452: [MS] Mark vectorcall FP and vector args inreg

2020-02-19 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74452/new/ https://reviews.llvm.org/D74452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D74116: [Sema][C++] Propagate conversion type in order to specialize the diagnostics

2020-02-19 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Yeah, looks like returning true causes the variable to be marked as invalid (not unreasonable, since maybe its type is wrong), which causes downstream diagnostics to be suppressed. Both test cases should probably be fixed to assign into a different variable so that we

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

2020-02-19 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added reviewers: dblaikie, rjmccall, rsmith, nathanchance, nickdesaulniers. Mordante added a project: clang. The diagnostic added in D72231 also shows a diagnostic when casting to a _Bool. This is unwanted. This patch rem

[PATCH] D74455: [MS] Pass aligned, non-trivially copyable things indirectly on x86

2020-02-19 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 245491. rnk added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74455/new/ https://reviews.llvm.org/D74455 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/test/CodeGenCXX/inalloca-overal

[PATCH] D74452: [MS] Mark vectorcall FP and vector args inreg

2020-02-19 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 245490. rnk added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74452/new/ https://reviews.llvm.org/D74452 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/vectorcall.c clang/te

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

2020-02-19 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Can we test the same thing in C++? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/ https://reviews.llvm.org/D74860 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

2020-02-19 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. The test you added in this change seems to be failing on Windows, can you take a look? http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14409 FAIL: Clang :: CodeCompletion/included-symlinks.cpp (1779 of 16867) - TEST 'Clang :: CodeCompletion/included-symli

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

2020-02-19 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. Ping2? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://reviews.llvm.org/D73245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74860: [Sema] Fix pointer-to-int-cast diagnostic for _Bool

2020-02-19 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Also, make sure to run `git-clang-format HEAD~` on the patch, as the linter suggests. Thanks for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74860/new/ https://reviews.llvm.org/D74860 __

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

2020-02-19 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2187 + DEFINE_MDNODE_GET(DITemplateTypeParameter, +(MDString * Name, Metadata *Type, bool IsDefault), +(Name, Type, IsDefault)) clang-form

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

2020-02-19 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM with outstanding inline comments addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

2020-02-19 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Seems to me, it causes some other issues. See https://bugs.llvm.org/show_bug.cgi?id=44948 for example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

2020-02-19 Thread David Goldman via Phabricator via cfe-commits
dgoldman added a comment. In D74790#1883466 , @dyung wrote: > `The test you added in this change seems to be failing on Windows, can you > take a look? > > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14409 > > FAIL: Clang :: CodeComp

[PATCH] D74813: [RFC] Add hash of block contents to function block names

2020-02-19 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. In D74813#1883241 , @alexbdv wrote: > As for making it default - would rather have this under a flag as hashing the > block contents does have some overhead and I imagine this feature wouldn't be > beneficial in most scenarios. Also,

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

2020-02-19 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added reviewers: EricWF, mehdi_amini. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without that patch, the test case associated to this patch segfaults in Release mode. This also makes the llvm-test-suite build f

[clang] 7d91633 - Fix broken test on Windows caused by D74790

2020-02-19 Thread David Goldman via cfe-commits
Author: David Goldman Date: 2020-02-19T16:58:22-05:00 New Revision: 7d91633a2b9b1f563dc14c632cc0c461c3651f76 URL: https://github.com/llvm/llvm-project/commit/7d91633a2b9b1f563dc14c632cc0c461c3651f76 DIFF: https://github.com/llvm/llvm-project/commit/7d91633a2b9b1f563dc14c632cc0c461c3651f76.diff

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

2020-02-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D70172#1883567 , @ABataev wrote: > Seems to me, it causes some other issues. See > https://bugs.llvm.org/show_bug.cgi?id=44948 for example I will fix that bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74813: [RFC] Add hash of block contents to function block names

2020-02-19 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Thanks for working on this, I agree it's a really important problem. I'm as optimistic as Vedant that this is the right approach though. - On compile time, I do think there's reason to be concerned, since dumping IR was fairly expensive last I checked due to numberin

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

2020-02-19 Thread David Goldman via Phabricator via cfe-commits
dgoldman added a comment. Submitted https://github.com/llvm/llvm-project/commit/7d91633a2b9b1f563dc14c632cc0c461c3651f76 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 __

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

2020-02-19 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. On the assumption that we will never get a `::max_align_t` in C++98 mode anyway (which will be the case if the `` is conforming), this looks like the best we can do to me. Comment at: libcxx/include/new:229-237 +#if !defined(_LIBCPP_CXX03_LANG) +using

[clang] 7ff1f55 - libclang: Add static build support for Windows

2020-02-19 Thread Martin Storsjö via cfe-commits
Author: Cristian Adam Date: 2020-02-20T00:05:46+02:00 New Revision: 7ff1f55a1219719f57a6f7905c26ce41d1767e4c URL: https://github.com/llvm/llvm-project/commit/7ff1f55a1219719f57a6f7905c26ce41d1767e4c DIFF: https://github.com/llvm/llvm-project/commit/7ff1f55a1219719f57a6f7905c26ce41d1767e4c.diff

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

2020-02-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { rjmccall wrote: > erichke

[PATCH] D74564: libclang: Add static build support for Windows

2020-02-19 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7ff1f55a1219: libclang: Add static build support for Windows (authored by cristian.adam, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 4960eb4 - Another fix for 7d91633a2b9b1f563dc14c632cc0c461c3651f76

2020-02-19 Thread David Goldman via cfe-commits
Author: David Goldman Date: 2020-02-19T17:15:11-05:00 New Revision: 4960eb4a1bdd6f469d5ad6d5049609cf97a982f3 URL: https://github.com/llvm/llvm-project/commit/4960eb4a1bdd6f469d5ad6d5049609cf97a982f3 DIFF: https://github.com/llvm/llvm-project/commit/4960eb4a1bdd6f469d5ad6d5049609cf97a982f3.diff

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

2020-02-19 Thread Scott Linder via Phabricator via cfe-commits
scott.linder accepted this revision. scott.linder added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/ https://reviews.llvm.org/D74811 __

[PATCH] D69868: Allow "callbr" to return non-void values

2020-02-19 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. Ugh, it's actually been that long, hasn't it...I'm really sorry about that. :( I've been actively spending time to look at this over the last couple weeks. I haven't been able to convince myself that the weird-successors and having allocatable registers across BBs here

[clang] ed07c89 - Add cl_khr_mipmap_image_writes as supported to AMDGPU

2020-02-19 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-02-19T17:40:40-05:00 New Revision: ed07c89fc50f38c4f1403b19897468edd7e5cbf3 URL: https://github.com/llvm/llvm-project/commit/ed07c89fc50f38c4f1403b19897468edd7e5cbf3 DIFF: https://github.com/llvm/llvm-project/commit/ed07c89fc50f38c4f1403b19897468edd7e5cbf3.dif

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

2020-02-19 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. It is used both in `` and `` and the use in the latter is currently unconditional AFAICT. I don't have a problem splitting the conditional to avoid the typedef. That would address the ODR concern? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73245/new/ https://

[PATCH] D74807: Add cl_khr_mipmap_image_writes as supported to AMDGPU

2020-02-19 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGed07c89fc50f: Add cl_khr_mipmap_image_writes as supported to AMDGPU (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D69868: Allow "callbr" to return non-void values

2020-02-19 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. In D69868#1883687 , @jyknight wrote: > Ugh, it's actually been that long, hasn't it...I'm really sorry about that. :( No worries. Thanks for getting back to us! > I've been actively spending time to look at this over the last coupl

[clang] 709fd98 - [clang-tidy] fix readability-redundant-member-init auto-fix of Function-try-block

2020-02-19 Thread Nathan James via cfe-commits
Author: Alexander Lanin Date: 2020-02-19T23:04:05Z New Revision: 709fd989b644a80527e0f4a22503d54255bc095c URL: https://github.com/llvm/llvm-project/commit/709fd989b644a80527e0f4a22503d54255bc095c DIFF: https://github.com/llvm/llvm-project/commit/709fd989b644a80527e0f4a22503d54255bc095c.diff LO

[PATCH] D74800: [clang-tidy] fix readability-redundant-member-init auto-fix of Function-try-block

2020-02-19 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG709fd989b644: [clang-tidy] fix readability-redundant-member-init auto-fix of Function-try… (authored by AlexanderLanin, committed by njames93). Herald added a project: clang. Herald added a subscriber: cf

[clang-tools-extra] d1d5180 - [NFC] Fix issues with clang-tidy checks list.rst

2020-02-19 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-02-19T23:19:09Z New Revision: d1d5180e6904b3fa86f750a05a6721163e115f4d URL: https://github.com/llvm/llvm-project/commit/d1d5180e6904b3fa86f750a05a6721163e115f4d DIFF: https://github.com/llvm/llvm-project/commit/d1d5180e6904b3fa86f750a05a6721163e115f4d.diff LOG:

[PATCH] D74795: Make diagnostic reporting more robust in presence of corrupt PCH data.

2020-02-19 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. Thanks for working on this. > I'm not sure how (or if it's possible) to add a test that would demonstrate > the before/after here. Happy to take advice! Yea, those are some times hard. Did you try to write a unittest that hits the assertion and trigger this case? Perhaps

[clang] 0edb212 - [MS] Mark vectorcall FP and vector args inreg

2020-02-19 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-02-19T16:37:50-08:00 New Revision: 0edb2129258c727e9efe6fa234b28880ff64c1b9 URL: https://github.com/llvm/llvm-project/commit/0edb2129258c727e9efe6fa234b28880ff64c1b9 DIFF: https://github.com/llvm/llvm-project/commit/0edb2129258c727e9efe6fa234b28880ff64c1b9.diff

[PATCH] D74813: [RFC] Add hash of block contents to function block names

2020-02-19 Thread Alex Borcan via Phabricator via cfe-commits
alexbdv added a comment. @vsk - about breaking existing workflows - I was referring only to if / when this gets shipped out as the default - all the names for the function blocks will change and this might cause issue with tooling that relies on symbol names being consistent across builds. @de

[PATCH] D69868: Allow "callbr" to return non-void values

2020-02-19 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. Would you be okay with me submitting this and working on making INLINEASM_BR a non-terminator? I'd like to give this feature some bake time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D6

[PATCH] D74564: libclang: Add static build support for Windows

2020-02-19 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:117 if(ENABLE_SHARED) + target_compile_definitions(libclang PUBLIC CINDEX_EXPORTS) if(WIN32) Is this enough? Every target that depends on libclang now needs to define CINDEX_EXPOR

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

2020-02-19 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. You mention a test case in the description but I don't see it? Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3607 +// Cannot discard value names when processing llvm-ir, because IR loading +// is conservative wrt. names. +if (Res

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

2020-02-19 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: libcxx/include/new:229-237 +#if !defined(_LIBCPP_CXX03_LANG) +using __libcpp_max_align_t = max_align_t; +#else +union __libcpp_max_align_t { + void * __f1; + long long int __f2; + long double __f3; rsmith wrote: > Is t

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

2020-02-19 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. This seems wrong to me. Discarding value names is the default and has been forever in non-assert builds. Why is this not a bug in w/e is handling the IR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://revi

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

2020-02-19 Thread Nathan James via Phabricator via cfe-commits
njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, For what this is trying to achieve I have no issue, follow up patches can be submitted for the other enhancements needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

2020-02-19 Thread Rong Xu via Phabricator via cfe-commits
xur created this revision. xur added reviewers: tejohnson, jeroen.dobbelaere. This patch fixes PR44896. For IR input files, option fdiscard-value-names should be ignored as we need named values in loadModule(). Commit 60d3947922

[PATCH] D74452: [MS] Mark vectorcall FP and vector args inreg

2020-02-19 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0edb2129258c: [MS] Mark vectorcall FP and vector args inreg (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74452/new/ https://reviews.llvm

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

2020-02-19 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. lgtm. Thanks for explaining lvalue/value trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74668/new/ https://reviews.llvm.org/D74668 __

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

2020-02-19 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFPreserveDIType.cpp:1 +//===- BPFPreserveType.cpp - Preserve DebugInfo Types -===// +// BPFPreserveDIType.cpp Comment at: llvm/lib/Target/BPF/BPFPreserveDIType.cp

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

2020-02-19 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1514 + void visitUsedDecl(SourceLocation Loc, Decl *D) { +if (auto *TD = dyn_cast(D)) { + for (auto *DD : TD->decls()) { yaxunl wrote: > rjmccall wrote: > > erichkeane wrote: > > > rjmc

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

2020-02-19 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. I'd suggest possibly adding 2 Options at Global Level SourceFileExtensions and HeaderFileExtensions, both would take semicolon seperated lists. Reason they are Global is there are probably other checks that could use them. The SourceFileExtensions could be defaulted to

[PATCH] D69471: [Coverage] Revise format to reduce binary size

2020-02-19 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Compiling with -fdump-record-layouts revealed the problem: *** Dumping AST Record Layout 0 | struct llvm::coverage::CovMapFunctionRecordV3 0 | struct llvm::coverage::accessors::FuncHashAndDataSize (base) (empty) 1 | struct llvm::coverage

[clang-tools-extra] 6730f39 - Fixup test after changes made in 709fd989.

2020-02-19 Thread Douglas Yung via cfe-commits
Author: Douglas Yung Date: 2020-02-19T18:39:54-08:00 New Revision: 6730f390a1fb069e567ebd635390de381d21b994 URL: https://github.com/llvm/llvm-project/commit/6730f390a1fb069e567ebd635390de381d21b994 DIFF: https://github.com/llvm/llvm-project/commit/6730f390a1fb069e567ebd635390de381d21b994.diff

[clang] 490a9a4 - [examples] Fix the clang-interpreter example for changes in 85fb997659b.

2020-02-19 Thread Lang Hames via cfe-commits
Author: Lang Hames Date: 2020-02-19T19:01:32-08:00 New Revision: 490a9a4b77ea23f388cae67d732af6bd8aa576f9 URL: https://github.com/llvm/llvm-project/commit/490a9a4b77ea23f388cae67d732af6bd8aa576f9 DIFF: https://github.com/llvm/llvm-project/commit/490a9a4b77ea23f388cae67d732af6bd8aa576f9.diff LO

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

2020-02-19 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. In D73580#1883861 , @njames93 wrote: > LGTM, For what this is trying to achieve I have no issue, follow up patches > can be submitted for the other enhancements needed. Please commit patch if you'll have time. See summary

[PATCH] D69471: [Coverage] Revise format to reduce binary size

2020-02-19 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D69471#1883912 , @rnk wrote: > Everything is off-by-one because the empty bases are not zero sized. The MSVC > record layout algorithm is just different in this area. =/ Do all the MSVCs we support building with support `_

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

2020-02-19 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. (I sent this to the mailing list, but I guess it doesn't show up here unless I do it through Phab. Quoting myself—) I see your point about how users who care should always be passing this check alongside "performance-move-const-arg"; but IMHO it still makes sense fo

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

2020-02-19 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFPreserveDIType.cpp:95 + + std::string BaseName = "llvm.bpf_pdit."; + int Count = 0; ast wrote: > may be "llvm.btf_type_id." instead? > Oh, y

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

2020-02-19 Thread Ravi Ramaseshan via Phabricator via cfe-commits
ravi-ramaseshan added a comment. Can you please land this change for me since I do not have commit rights. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/ https://reviews.llvm.org/D74811

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

2020-02-19 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 245574. yonghong-song added a comment. change llvm.bpf_pdit to llvm.btf_type_id variable name to make it easy to understand. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74572/new/ https://reviews.llvm.

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

2020-02-19 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast accepted this revision. ast added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/BPF/BPFPreserveDIType.cpp:1 +//===- BPFPreserveType.cpp - Preserve DebugInfo Types -===// +// ast wrote: > BPF

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

2020-02-19 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 245578. serge-sans-paille added a comment. Added test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://reviews.llvm.org/D74871 Files: clang/include/clang/Basic/DiagnosticDrive

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

2020-02-19 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. In D74871#1883884 , @EricWF wrote: > Why is this not a bug in w/e is handling the IR? It may totally be. Consider this review as a way to start the discussion. The problem, as it appears, is triggered when some value i

[clang] 3a0f6e6 - Fix compiler extension in standalone mode

2020-02-19 Thread via cfe-commits
Author: serge-sans-paille Date: 2020-02-20T07:19:04+01:00 New Revision: 3a0f6e699bb6d96dc62dce6faef20ac26cf103fd URL: https://github.com/llvm/llvm-project/commit/3a0f6e699bb6d96dc62dce6faef20ac26cf103fd DIFF: https://github.com/llvm/llvm-project/commit/3a0f6e699bb6d96dc62dce6faef20ac26cf103fd.d

[PATCH] D74757: Fix compiler extension in standalone mode

2020-02-19 Thread serge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3a0f6e699bb6: Fix compiler extension in standalone mode (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://re

[PATCH] D69868: Allow "callbr" to return non-void values

2020-02-19 Thread Chris Lattner via Phabricator via cfe-commits
lattner accepted this revision. lattner added a comment. I'm super excited to see this progress towards supporting 'asm goto' with results! Great work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 __

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

2020-02-19 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 245582. yonghong-song added a comment. fix a typo (BPFPreserveType.cpp => BPFPreserveDIType.cpp) in the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74572/new/ https://reviews.llvm.org/D74572

<    1   2