[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. @balazske Do you see any problems with this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74542/new/ https://reviews.llvm.org/D74542 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D74620: [ARM,MVE] Add vector-scalar intrinsics

dmgreen added a comment. I like how this uses a splat for all the register arguments. That sounds like a good idea. The one's that worry me are the floating point instructions. Last time we tried those it was actually causing performance regressions because of extra sp->gpr mov's left in the l

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

richard.barton.arm added inline comments. Comment at: clang/test/Driver/flang/clang-driver-2-frontend01.f90:10 +! RUN: cp %clang %t1 +! RUN: %clang --driver-mode=flang -fortran-fe %basename_t.tmp1 -### %s 2>&1 | FileCheck --check-prefixes=ALL %s + CarolineConcat

[clang] 7ae1347 - clang analyzer: Fix the webpage rendering

Author: Sylvestre Ledru Date: 2020-02-17T10:03:20+01:00 New Revision: 7ae1347fb259c6f5feb92567192c0b1032553c02 URL: https://github.com/llvm/llvm-project/commit/7ae1347fb259c6f5feb92567192c0b1032553c02 DIFF: https://github.com/llvm/llvm-project/commit/7ae1347fb259c6f5feb92567192c0b1032553c02.dif

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin added a comment. Is there any chance to get this commit cherry-picked to 10.x branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71460/new/ https://reviews.llvm.org/D71460 ___ cfe-commi

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

lebedev.ri added a comment. Bump @rsmith / @erichkeane thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73996/new/ https://reviews.llvm.org/D73996 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri added a comment. Bump @rsmith thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73020/new/ https://reviews.llvm.org/D73020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

kadircet added a comment. Oh god, this code is a mess, so many knobs, and apparently I made it worst in the past sorry for that :D I totally understand if you want to make minimal changes to the code like this, but it would be great to simplify it a little bit without regressing too much, curr

[PATCH] D33029: [clang-format] add option for dangling parenthesis

iolojz added a comment. In D33029#1538200 , @gracicot wrote: > Will this option also work with dangling braces from initializers? > > I have some code that looks like this: > > return some_type_with_a_long_name{ > get_param_number_one(), > ge

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

sdesmalen added a comment. Nice, thanks for adding those tests @kmclaughlin. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74550/new/ https://reviews.llvm.org/D74550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp:43 + +void SuspiciousIncludePPCallbacks::InclusionDirective( +SourceLocation HashLoc, const Token &IncludeTok, StringRef FileName, This function is us

[PATCH] D74639: Add linkage check to ASTNodeImporter::hasSameVisibilityContext and rename to hasSameVisibilityContextAndLinkage

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:989 !Found->hasExternalFormalLinkage(); } This would be equivalent but more clear code (formatting is probably not correct here): ``` if (Found->getLinkageInternal() != Fr

[PATCH] D74634: Remove "ELF Only" restriction from section flags

hans accepted this revision. hans added a comment. In the commit message, which is currently "Remove "ELF Only" restriction from section flags" maybe add "help text" or something to make it obvious this only changes the help text -- i.e. it's not removing any actual "elf only" restriction. R

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rG633db60f3ed0: [AArch64][SVE] Add SVE index intrinsic (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74550/new/ https://reviews.llv

[PATCH] D74620: [ARM,MVE] Add vector-scalar intrinsics

miyuki marked an inline comment as done. miyuki added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/vaddq.c:2 // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py -// RUN: %clang_cc1 -triple thumbv8.1m.main-arm-none-eabi -target-feat

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:3880 +ToType, From->getType(), From, Action); +// assert(Diagnosed && "failed to diagnose bad conversion"); +(void)Diagnosed; r

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

balazske added a comment. In D74542#1878576 , @teemperor wrote: > @balazske Do you see any problems with this patch? I have no opinion against the change. Probably sorting order of imported source locations makes not much sense (specially if recursive i

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein added a comment. > I totally understand if you want to make minimal changes to the code like > this, but it would be great to simplify it a little bit without regressing > too much, currently there is a knob for function locals and then another for > parameters in declarations, then ther

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein updated this revision to Diff 244935. hokein marked 2 inline comments as done. hokein added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74610/new/ https://reviews.llvm.org/D74610 Files: clang-tools-extra/clang

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

njames93 updated this revision to Diff 244939. njames93 added a comment. - Added check if size() method is const for range loops - Optimised FixItHint creation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74689/new/ https://reviews.llvm.org/D74689

[clang] 801627e - [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

Author: Sergej Jaskiewicz Date: 2020-02-17T15:24:04+03:00 New Revision: 801627ee490e1106380184256503dbd520c5f802 URL: https://github.com/llvm/llvm-project/commit/801627ee490e1106380184256503dbd520c5f802 DIFF: https://github.com/llvm/llvm-project/commit/801627ee490e1106380184256503dbd520c5f802.d

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG801627ee490e: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake (authored by broadwaylamb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille created this revision. serge-sans-paille added a reviewer: asb. Herald added subscribers: cfe-commits, evandro, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, Ma

[clang] 35367e0 - Revert "[CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake"

Author: Sergej Jaskiewicz Date: 2020-02-17T16:06:30+03:00 New Revision: 35367e06b84618e21945674aa22e7cfda1957ea4 URL: https://github.com/llvm/llvm-project/commit/35367e06b84618e21945674aa22e7cfda1957ea4 DIFF: https://github.com/llvm/llvm-project/commit/35367e06b84618e21945674aa22e7cfda1957ea4.d

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille updated this revision to Diff 244943. serge-sans-paille added a comment. Add test case. This test fails with current master, see https://bugzilla.redhat.com/show_bug.cgi?id=1803698 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D747

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb added a comment. Reverted this because it broke our buildbot: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4704/steps/build-llvm-project/logs/stdio. Going to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added inline comments. Comment at: clang/include/clang-c/Platform.h:31 +#elif defined(CINDEX_EXPORTS) + #define CINDEX_LINKAGE __attribute__((visibility("default"))) +#endif yvvan wrote: > Is it different from just leaving CINDEX_LINKAGE empty? On

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam updated this revision to Diff 244944. cristian.adam marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 Files: clang/include/clang-c/Platform.h clang/tools/libc

[clang] d4741c4 - [ASTImporter] Added visibility check for scoped enums.

Author: Balázs Kéri Date: 2020-02-17T14:34:13+01:00 New Revision: d4741c44ab45a6ab9f32d773612f1bb79854f52f URL: https://github.com/llvm/llvm-project/commit/d4741c44ab45a6ab9f32d773612f1bb79854f52f DIFF: https://github.com/llvm/llvm-project/commit/d4741c44ab45a6ab9f32d773612f1bb79854f52f.diff L

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4741c44ab45: [ASTImporter] Added visibility check for scoped enums. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D74554?vs=244582&id=244951#toc Repository: rG LLVM Githu

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

njames93 updated this revision to Diff 244952. njames93 added a comment. - Moved const size method check to matcher Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74689/new/ https://reviews.llvm.org/D74689 Files: clang-tools-extra/clang-tidy/perf

[PATCH] D74709: [clangd] Allow renaming class templates in cross-file rename.

hokein created this revision. hokein added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. It was disabled because we don't handle explicit template specialization well (due to the index limitation). r

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ilya added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D74704: Support -fuse-ld=lld for riscv

lenary added a comment. I am worried about the interaction between `-fuse-ld=lld` and linker relaxation (which is not supported by LLD, as I understand it) 1. clang could ignore `-fuse-ld=lld` when linker relaxation is enabled 2. clang could ignore (disable) linker relaxation if `-fuse-ld=lld` i

[PATCH] D74639: Add linkage check to ASTNodeImporter::hasSameVisibilityContext and rename to hasSameVisibilityContextAndLinkage

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/AST/ASTImporter.cpp:989 !Found->hasExternalFormalLinkage(); } balazske wrote: > This would be equivalent but mor

[clang-tools-extra] 5fc5c7d - Strength reduce vectors into arrays. NFCI.

Author: Benjamin Kramer Date: 2020-02-17T15:37:35+01:00 New Revision: 5fc5c7db38672c8962879b6fdce68393181c5e08 URL: https://github.com/llvm/llvm-project/commit/5fc5c7db38672c8962879b6fdce68393181c5e08 DIFF: https://github.com/llvm/llvm-project/commit/5fc5c7db38672c8962879b6fdce68393181c5e08.dif

[clang] 5fc5c7d - Strength reduce vectors into arrays. NFCI.

Author: Benjamin Kramer Date: 2020-02-17T15:37:35+01:00 New Revision: 5fc5c7db38672c8962879b6fdce68393181c5e08 URL: https://github.com/llvm/llvm-project/commit/5fc5c7db38672c8962879b6fdce68393181c5e08 DIFF: https://github.com/llvm/llvm-project/commit/5fc5c7db38672c8962879b6fdce68393181c5e08.dif

[PATCH] D74704: Support -fuse-ld=lld for riscv

jrtc27 added a comment. In D74704#1878921 , @lenary wrote: > I am worried about the interaction between `-fuse-ld=lld` and linker > relaxation (which is not supported by LLD, as I understand it) > > 1. clang could ignore `-fuse-ld=lld` when linker relaxat

[PATCH] D74704: Support -fuse-ld=lld for riscv

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. In D74704#1878944 , @jrtc27 wrote: > This isn't a new problem. The Linux and FreeBSD toolchains already support > -fuse-ld=lld properly, it's just the

[PATCH] D74336: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family.

simon_tatham updated this revision to Diff 244969. simon_tatham added a comment. Made the new isel patterns work in big-endian as well as little. Depends on the extra preparatory patch D74716 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein added a comment. Looking the source code closely, we also have another code path of indexing the `ParmVarDecl` in `clang/lib/Index/IndexTypeSourceInfo.cpp`, it was called via `IndexCtx.indexTypeSourceInfo` in `handleDeclarator`. In summary: 1. default arguments will be visited if this

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein updated this revision to Diff 244968. hokein added a comment. remove an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74610/new/ https://reviews.llvm.org/D74610 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp c

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

simon_tatham updated this revision to Diff 244970. simon_tatham added a comment. Added tests to make sure the isel rules work in both big- and little-endian. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74337/new/ https://reviews.llvm.org/D74337

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

mboehme added a comment. I've added some individual comments above, but I'd question whether it's really necessary to make this change? Even if no move actually happens, the code is still wrong (it shouldn't be using std::move in the first place), and it's likely the author actually intended fo

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, just wondering though if you've tried the solution we discussed offline regarding updating `indexTypeSourceInfo` instead of this call site, could you mention the results in here? So

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

hokein added a comment. Thanks for the patch. May I know the motivation of this patch? Personally, I'd be conservative of exposing too many options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74689/new/ https://reviews.llvm.org/D74689 __

[clang] dd4d093 - [ARM] Add initial support for Custom Datapath Extension (CDE)

Author: Mikhail Maltsev Date: 2020-02-17T15:39:16Z New Revision: dd4d09376209cdc5615097a5be92105f55d06f5d URL: https://github.com/llvm/llvm-project/commit/dd4d09376209cdc5615097a5be92105f55d06f5d DIFF: https://github.com/llvm/llvm-project/commit/dd4d09376209cdc5615097a5be92105f55d06f5d.diff LO

[PATCH] D74336: [ARM,MVE] Add the vmovlbq,vmovltq intrinsic family.

dmgreen accepted this revision. dmgreen added a comment. Nice one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74336/new/ https://reviews.llvm.org/D74336 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd4d09376209: [ARM] Add initial support for Custom Datapath Extension (CDE) (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74044/new/ h

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein added a comment. In D74610#1879054 , @kadircet wrote: > LGTM, > > just wondering though if you've tried the solution we discussed offline > regarding updating `indexTypeSourceInfo` instead of this call site, could you > mention the results in here

[clang-tools-extra] af8b0cd - [clang][Index] Visit the default parameter arguements in libindex.

Author: Haojian Wu Date: 2020-02-17T16:45:04+01:00 New Revision: af8b0cd58dbda773a0cbbb2a9c67559fc6a59d1d URL: https://github.com/llvm/llvm-project/commit/af8b0cd58dbda773a0cbbb2a9c67559fc6a59d1d DIFF: https://github.com/llvm/llvm-project/commit/af8b0cd58dbda773a0cbbb2a9c67559fc6a59d1d.diff LO

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

njames93 added a comment. In D74689#1879065 , @hokein wrote: > Thanks for the patch. May I know the motivation of this patch? Personally, > I'd be conservative of exposing too many options. I was using custom classes with a different naming convention w

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

dmgreen added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/vmovn.c:10 +// CHECK-NEXT:[[TMP0:%.*]] = shufflevector <16 x i8> [[A:%.*]], <16 x i8> undef, <16 x i32> +// CHECK-NEXT:[[TMP1:%.*]] = bitcast <16 x i8> [[TMP0]] to <8 x i16> +// CHECK-NEXT:

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf8b0cd58dbd: [clang][Index] Visit the default parameter arguements in libindex. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74610/ne

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/vmovn.c:10 +// CHECK-NEXT:[[TMP0:%.*]] = shufflevector <16 x i8> [[A:%.*]], <16 x i8> undef, <16 x i32> +// CHECK-NEXT:[[TMP1:%.*]] = bit

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. Summary - In order to avoid the bug in PR44587 , one needs to build with >9.0. - With CUDA toolkit 10.2, building the trunk will fail because 10.0.0 does not support it yet. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:114-117 + const auto MacroIt = llvm::find_if( + PP.macros(), [&](const auto &K) { return K.first->getName() == Macro; }); + if (MacroIt ==

[PATCH] D74720: [ASTImporter] Improved variable template redecl chain handling.

balazske created this revision. Herald added subscribers: cfe-commits, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

Fznamznon added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1468 } - S.DeviceDeferredDiags.erase(It); This particular change causes duplication of deferred diagnostics. Consider the following example (please correct me if I'm doing something wrong,

[PATCH] D74721: [ARM,MVE] Add vbrsrq intrinsics family

miyuki created this revision. miyuki added reviewers: simon_tatham, dmgreen, ostannard, MarkMurrayARM. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. miyuki added a parent revision: D74620: [ARM,MVE] Add vector-scalar intrinsics.

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:114-117 + const auto MacroIt = llvm::find_if( + PP.macros(), [&](const auto &K) { return K.first->getName() == Macro; }); + if (MacroIt ==

[PATCH] D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers

3nids added a comment. Hi there, is there anything we can do to help this to go through? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60225/new/ https://reviews.llvm.org/D60225 ___ cfe-commits mailing list cfe-commi

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

simon_tatham updated this revision to Diff 244984. simon_tatham added a comment. Test on the clang side in both endiannesses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74337/new/ https://reviews.llvm.org/D74337 Files: clang/include/clang/Bas

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao added a comment. + @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D74337: [ARM,MVE] Add the vmovnbq,vmovntq intrinsic family.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74337/new/ https://reviews.llvm.org/D74337

[clang-tools-extra] 351ed50 - Reland "[clang-tools-extra] fix the check for if '-latomic' is necessary""

Author: Gokturk Yuksek Date: 2020-02-17T16:53:29Z New Revision: 351ed50dcb2a67a88213ef67469f70bd5e2b4a60 URL: https://github.com/llvm/llvm-project/commit/351ed50dcb2a67a88213ef67469f70bd5e2b4a60 DIFF: https://github.com/llvm/llvm-project/commit/351ed50dcb2a67a88213ef67469f70bd5e2b4a60.diff LOG

[PATCH] D74724: [AArch64][SVE] CodeGen of ACLE Builtin Types

sdesmalen created this revision. sdesmalen added reviewers: rsandifo-arm, rovka, rjmccall, efriedma. Herald added subscribers: llvm-commits, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added projects: clang, LLVM. This patch adds codegen support for the ACLE builtin types added in

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

SjoerdMeijer added inline comments. Comment at: clang/test/Driver/arm-cde.c:12 + +// RUN: %clang -target arm-none-none-eabi -march=armv8m.main+cdecp0+cdecp3 %s -### -c 2>&1 | FileCheck %s --check-prefix=CHECK-CDE1 +// CHECK-CDE1: "-triple" "thumbv8m.main-none-none-eabi"

[PATCH] D68578: [HIP] Fix device stub name

yaxunl updated this revision to Diff 244988. yaxunl added a comment. Herald added a subscriber: kerbowa. Revised by John's comments. Introduced HIPKernelType for GlobalDecl so that we can use GlobalDecl to represent stub and kernel during host compilation. Revised mangler so that GlobalDecl carr

[PATCH] D74620: [ARM,MVE] Add vector-scalar intrinsics

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:4566 + 0b0, VTI.Unsigned>; + defvar unpred_op = !if(VTI.Unsigned, unpred_op_u, unpred_op_s);

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs updated this revision to Diff 244994. jroelofs added a comment. Implement review feedback re: DiagLoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp:59 +Optional File = PP->LookupFile( +HashLoc /* FIXME: lies */, (FileName + RE).str(), IsAngled, nullptr, +

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

miyuki added a comment. @SjoerdMeijer, thanks for the heads up. Will fix in a followup patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74044/new/ https://reviews.llvm.org/D74044 ___ cfe-commits ma

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:3880 +ToType, From->getType(), From, Action); +// assert(Diagnosed && "failed to diagnose bad conversion"); +(void)Diagnosed; Anastasia wrote: > rjmccall wrote: > > This as

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

rjmccall added a comment. In D72231#1878528 , @nathanchance wrote: > There appear to a be semantic difference between GCC and clang with the > current version of this patch which results in a lot of additional warnings > in the Linux kernel: https://god

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rG3eaa53e80543: Reapply "[IRBuilder] Virtualize IRBuilder" (authored by nikic). Changed prior to commit: https://reviews.llvm.org/D73835?vs=244871&id=245004#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

AnakinZheng created this revision. AnakinZheng added reviewers: kadircet, sammccall. AnakinZheng added a project: clang. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Previously this piece of code asserts when processing extended ASCII. Proposing a

[PATCH] D74732: [ARM,CDE] Cosmetic changes, additonal driver tests

miyuki created this revision. miyuki added reviewers: SjoerdMeijer, simon_tatham, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This is a follow-up patch addressing post-commit comments in https://reviews.llvm.org/D74044

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1468 } - S.DeviceDeferredDiags.erase(It); Fznamznon wrote: > This particular change causes duplication of deferred diagnostics. > Consider the followi

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

fghanim updated this revision to Diff 245014. fghanim marked 2 inline comments as done. fghanim added a comment. Fixed bug where variables where still being allocated in original function entry block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

teemperor added a comment. This broke the LLVM_ENABLE_MODULES build because it introduces a cyclic dependency between LLVM_IR and LLVM_intrinsic_gen: FAILED: tools/lld/lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o /Applications/Xcode.app/Contents/De

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. In D74542#1878732 , @balazske wrote: > In D74542#1878576 , @teemperor wrote: > > > @balazske Do you see any problems with this patch? > > > I have no opinion against the change. Probably s

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

fghanim added a comment. Regarding the third comment (which was removed for some reason), This new update should fix that Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3134 // TODO: Replace with a generic helper function for emitting body auto BodyGenCB = [MasterR

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

jpienaar added a comment. This seems to result in triggering clang/lib/CodeGen/CGExpr.cpp:2626 when compiling mlir/lib/Transforms/AffineDataCopyGeneration.cpp with clang build with assertions on (clean build at e8e078c just

[PATCH] D74734: [AArch64][SVE] Add the SVE dupq_lane intrinsic

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, c-rhodes, cameron.mcinally, efriedma, dancgr. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the @llvm.aarch64.sve

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))) { // ASCII or extended ASCII character. if (CB(1,

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

rjmccall added a comment. In D74387#1874612 , @Fznamznon wrote: > > In D74387#1869845 , @rjmccall > > wrote: > > > >> The right approach here is probably what we do in ObjC ARC when we see > >> types that are ill

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:798 +if (Tok.is(tok::l_square)) { + ConsumeBracket(); + if (!SkipUntil(tok::r_square)) Do you want to check for double-brackets here? Repository: rG LLVM

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, kristof.beyls. Herald added a project: clang. `CXXInheritedCtorInitExpr

[PATCH] D74724: [AArch64][SVE] CodeGen of ACLE Builtin Types

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenTypes.cpp:559 #include "clang/Basic/AArch64SVEACLETypes.def" -{ - unsigned DiagID = CGM.getDiags().getCustomDiagID( - DiagnosticsEngine::Error, - "cannot yet generate code for SVE typ

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] I am taking a look. Thanks. Sam -Original Message- From: Jacques Pienaar via Phabricator Sent: Monday, February 17, 2020 10:58 AM To: Liu, Yaxun (Sam) ; t...@google.com; rjmcc...@gmail.com; rich...@metafoo.co.uk; jdoerf...@anl.gov;

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

sammccall added a comment. Yeah I think there must be some confusion about what this code is doing. It's specifically iterating over the unicode codepoints of what are supposed to be UTF-8-encoded input bytes. The input turns out sometimes not to be UTF-8 (e.g. the file on disk is ISO-8859-1 a

[PATCH] D74361: [Clang] Uninitialize attribute on global variables

rjmccall added a comment. I'm not sure if it's a good idea to be re-using the existing attribute like this. It's not that unreasonable, I guess, but I'd like to hear JF's thoughts. I think you do need to update the documentation to mention the impact on globals. For normal targets (i.e. ones

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

AnakinZheng updated this revision to Diff 245021. AnakinZheng added a comment. Fix the previous stupid mistake. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74731/new/ https://reviews.llvm.org/D74731 Files: clang-tools-extra/clangd/SourceCode.cpp Index: clang-tools-extra/clangd/So

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

AnakinZheng marked an inline comment as done. AnakinZheng added a comment. Update patch. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

zinovy.nis added a comment. In D74692#1879039 , @mboehme wrote: > Even if no move actually happens, the code is still wrong IMHO, it's not wrong, but it's inefficient. And will be reported by performance-move-const-arg. Repository: rG LLVM Github Mo

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

sammccall added a comment. Specifically, we can't change the return value for any valid utf-8 string (see tests). Instead, where we currently assert length is between 2 and 4, you could change that to an if and treat it (arbitrarily) as a one-utf-8-byte, one-utf-16-code-unit character. This n

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))) { // ASCII or extended ASCII character. if (CB(1,

[PATCH] D74731: [Clangd] Fixed assertion when processing extended ASCII characters.

AnakinZheng marked an inline comment as done. AnakinZheng added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:62 unsigned char C = static_cast(U8[I]); -if (LLVM_LIKELY(!(C & 0x80))) { // ASCII character. +if (LLVM_LIKELY(!(C & 0x100))) { // ASC

  1   2   >