[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

jdoerfert created this revision. jdoerfert added reviewers: rogfer01, ABataev, JonChesterfield, kiranchandramohan, fghanim. Herald added subscribers: cfe-commits, guansong, bollu, hiraditya. Herald added projects: clang, LLVM. In order to fix PR44560 and to prepare for loop transformations we now

[PATCH] D74374: [clang-tidy] Added check to disable bugprone-infinite-loop on known false condition

njames93 created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 edited the summary of this revision. njames93 added reviewers: aaron.ballman, alexfh, hokein, gribozavr2, JonasToth. njames93 added a project: clang-tools-extra. Addresses bugp

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies updated this revision to Diff 243717. ffrankies marked 3 inline comments as done. ffrankies added a comment. Implemented requested changes by @Eugene.Zelenko - Changed `auto` to `const auto *` - Changed `if(IsNDRange == true)` to `if(IsNDRange)` - Highlighted 1600 with single back-quote

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added a comment. > In D68049#1865967 , @MaskRay wrote: > If you don't mind, I can push a Diff to this Differential which will address > these review comments. I can't because I can't figure out the patch relationship... First, this patch does no

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

rnk added a comment. What is the motivation for adding a best effort `-fsemantic-interposition`? Was there anything wrong with our previously unstated project policy of ignoring this complexity and surviving without this mode? Less modes -> less conditional soup... Comment a

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

serge-sans-paille added inline comments. Herald added a subscriber: miyuki. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:871 if (!Var->isThreadLocal() && -(RM == llvm::Reloc::Static || CGOpts.PIECopyRelocations)) +(RM == llvm::Reloc::Static || (LOpts.PIE &

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

efriedma added a comment. In D71600#1867320 , @adalava wrote: > > For compiler-rt, are you really disabling > > COMPILER_RT_EXCLUDE_ATOMIC_BUILTIN? Are you sure you understand the > > implications of that? > > I didn't understood "disable COMPILER_RT_E

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

efriedma added a comment. atomic.c is disabled by default for a good reason: it doesn't work correctly in general. In particular, if an atomic variable is shared across two shared libraries, the two libraries will use different locks, and therefore the operation won't be atomic. It might make

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

adalava added a comment. In D71600#1868284 , @efriedma wrote: > On master, atomic.c is not built by default. It's only built if you > explicitly request it with something like the CMake flag > -DCOMPILER_RT_EXCLUDE_ATOMIC_BUILTIN=Off . If you're not do

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Such changes can be risky. Hope someone can verify the build on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74384/new/ https://revi

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

MaskRay added a comment. You may join https://reviews.llvm.org/project/view/78/ and let the bot test Linux for you.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74384/new/ https://reviews.llvm.org/D74384 __

[PATCH] D74385: [ARCMT][NFC] Reduce #include dependencies

nicolas17 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace some #includes in ARCMigrate source files with more specific includes and forward declarations. This reduces the number of files that need to be rebuilt when a header changes (and save

[clang] 42ca012 - remove outdated comparison with other open-source c++ compilers

Author: John Regehr Date: 2020-02-11T00:05:16-07:00 New Revision: 42ca012befa546d6cddde2155242ca85e155eda4 URL: https://github.com/llvm/llvm-project/commit/42ca012befa546d6cddde2155242ca85e155eda4 DIFF: https://github.com/llvm/llvm-project/commit/42ca012befa546d6cddde2155242ca85e155eda4.diff L

[PATCH] D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount.

huihuiz created this revision. huihuiz added reviewers: sdesmalen, efriedma, apazos, spatel, huntergr, willlovett. huihuiz added a project: LLVM. Herald added subscribers: cfe-commits, psnobl, rkruppe, hiraditya, tschuett. Herald added a project: clang. Support ConstantInt::get() and Constant::ge

[PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

jlebar added a comment. > Such changes can be risky. Heh, well said. I feel good about it because I found two or three real bugs in clang/llvm as a result of this cleanup. But still, we've got to land it safely... I joined the group; what do I do to get tests run for this? > Hope someone ca

[PATCH] D74372: [OpenMP][IRBuilder] Perform finalization (incl. outlining) late

rogfer01 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:114 + +// Add some known attributes to the outlined function. +Function *OutlinedFn = Extractor.extractCodeRegion(CEAC); This comment seems misplaced now.

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

ianlevesque updated this revision to Diff 243749. ianlevesque added a comment. Now with 100% more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73842/new/ https://reviews.llvm.org/D73842 Files: clang/include/clang/Driver/XRayArgs.h clan

Re: [PATCH] D74384: Use std::foo_t rather than std::foo in LLVM.

> I joined the group; what do I do to get tests run for this? you need to upload a diff to trigger the bots > > Hope someone can verify the build on Windows. > Do you think I should go on IRC and ask? Not much help before committing, but for post-commit there is http://45.33.8.238/. Doesn't con

<    1   2