[PATCH] D74063: [Clang] Remove #pragma clang __debug handle_crash

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ecde3ac34bb: [Clang] Remove unused #pragma clang __debug handle_crash (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D74063?vs=242644&id=242980#toc Repository: rG LLVM Githu

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane updated this revision to Diff 242982. erichkeane added a comment. Herald added a subscriber: jfb. Add _Complex support for these types. As it turns out, they 'just work'! I added a check to the same place we check 'int' in the declaration specifiers, and the IR that gets generated i

[clang] 5fedc2b - [Clang] Avoid crashing when generating crash diagnostics when '#pragma clang __debug [assert|crash|parser_crash|llvm_fatal_error|llvm_unreachable|overflow_stack]' are used

Author: Alexandre Ganea Date: 2020-02-06T15:48:51-05:00 New Revision: 5fedc2b410853a6aef05e8edf19ebfc4e071e28f URL: https://github.com/llvm/llvm-project/commit/5fedc2b410853a6aef05e8edf19ebfc4e071e28f DIFF: https://github.com/llvm/llvm-project/commit/5fedc2b410853a6aef05e8edf19ebfc4e071e28f.dif

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

This revision was automatically updated to reflect the committed changes. aganea marked 2 inline comments as done. Closed by commit rG5fedc2b41085: [Clang] Avoid crashing when generating crash diagnostics when '#pragma clang… (authored by aganea). Changed prior to commit: https://reviews.llvm.o

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane updated this revision to Diff 242984. erichkeane added a comment. Fixed test that expected _Complex _ExtInt to fail. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.

[clang] f41ec70 - [Clang][Driver] Remove -M group options before generating crash diagnostics

Author: Alexandre Ganea Date: 2020-02-06T16:23:25-05:00 New Revision: f41ec709d9d388dc43469e6ac7f51b6313f7e4af URL: https://github.com/llvm/llvm-project/commit/f41ec709d9d388dc43469e6ac7f51b6313f7e4af DIFF: https://github.com/llvm/llvm-project/commit/f41ec709d9d388dc43469e6ac7f51b6313f7e4af.dif

[clang] 38fd699 - [Concepts] Fix incorrect check when instantiating abbreviated template type-constraints

Author: Saar Raz Date: 2020-02-06T23:29:07+02:00 New Revision: 38fd69995fc5a6f16e0aa132a46e5ccdbc2eebb3 URL: https://github.com/llvm/llvm-project/commit/38fd69995fc5a6f16e0aa132a46e5ccdbc2eebb3 DIFF: https://github.com/llvm/llvm-project/commit/38fd69995fc5a6f16e0aa132a46e5ccdbc2eebb3.diff LOG:

[PATCH] D74076: [Clang][Driver] Remove -M group options before generating crash diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rGf41ec709d9d3: [Clang][Driver] Remove -M group options before generating crash diagnostics (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D74076?vs=242676&id=242992#toc Reposito

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:386 + if (FPFeatures.allowFEnvAccess()) { +FunctionDecl *F = getCurFunctionDecl(); +F->setUsesFPIntrin(true); There isn't necessarily a current function declaration; this is usable i

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, cebowleratibm, yusra.syeda, sfertile, jasonliu, xingxue, hfinkel. Xiangling_L added a project: LLVM. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added a project: clang. Xiangling_L a

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876 __

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rsmith updated this revision to Diff 243022. rsmith marked 4 inline comments as done. rsmith added a comment. Updates based on review comments from @rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74103/new/ https://reviews.llvm.org/D74103

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rsmith updated this revision to Diff 243023. rsmith added a comment. Add test coverage for the 'friend' case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74103/new/ https://reviews.llvm.org/D74103 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:4394 +isa(D)) + continue; + rjmccall wrote: > This is essentially part of the next paragraph. > > I believe `friend` declarations also do not declare "members", under the same >

[PATCH] D72954: [clang-doc] Improving Markdown Output

Clayton updated this revision to Diff 243027. Clayton added a comment. Updating tests affected by this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/D72954 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/M

[PATCH] D72954: [clang-doc] Improving Markdown Output

Clayton reopened this revision. Clayton added a comment. This revision is now accepted and ready to land. Fixing unit tests affected by this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/D72954 __

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 243029. bader added a comment. Ignore `-sycl-std` if it used in non-SYCL mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/clang/Basic/LangOpti

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

xazax.hun added a comment. Please add a test as well. Otherwise looks good. Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:97 .Case("clang_analyzer_express", &ExprInspectionChecker::analyzerExpress) +.StartsWith("clang_analyzer_isTainted", &Ex

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:401 +return; + case nonloc::ConcreteIntKind: { +const llvm::APSInt &IntVal = V.castAs().getValue(); Dealing with only concrete ints might be a g

[PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fe839ef3a51: [CMake] Rename EXCLUDE_FROM_ALL and make it an argument to add_lit_testsuite (authored by JDevlieghere). Herald added projects: clang, Sanitizers, OpenMP. Herald added subscribers: openmp-com

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:268 CheckerContext &C) { - if (isTainted(State, E, C.getLocationContext()) || isStdin(E, C)) + if (isTainted(State, E, C.ge

[PATCH] D73536: [analyzer][taint] Remove taint from symbolic expressions if used in comparisons

xazax.hun added a comment. I think a crucial part of the design is what would we do for the following case: if (x < y || x > z) return; // Here we might not have ranges for x when y and z were symbolic. mySink(x); // requires x to be in [0, 255] So would we warn for the code above? X

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:4394 +isa(D)) + continue; + rsmith wrote: > rjmccall wrote: > > This is essentially part of the next paragraph. > > > > I believe `friend` declarations also do not declare "memb

[clang] ad0e03f - Revert "[FPEnv][X86] Platform-specific builtin constrained FP enablement"

Author: Kevin P. Neal Date: 2020-02-06T19:17:14-05:00 New Revision: ad0e03fd4c8066843f4138e44661ee0287ceb631 URL: https://github.com/llvm/llvm-project/commit/ad0e03fd4c8066843f4138e44661ee0287ceb631 DIFF: https://github.com/llvm/llvm-project/commit/ad0e03fd4c8066843f4138e44661ee0287ceb631.diff

Re: [clang] ad0e03f - Revert "[FPEnv][X86] Platform-specific builtin constrained FP enablement"

You can't generate assembly from a frontend test unless you also put "REQUIRES: x86-registered-target" in the test ~Craig On Thu, Feb 6, 2020 at 4:17 PM Kevin P. Neal via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Kevin P. Neal > Date: 2020-02-06T19:17:14-05:00 > New Revision:

[clang] 96c8994 - C++ DR2026: static storage duration variables are not zeroed before

Author: Richard Smith Date: 2020-02-06T16:37:22-08:00 New Revision: 96c899449b61b866b583560a49c4627f561336fc URL: https://github.com/llvm/llvm-project/commit/96c899449b61b866b583560a49c4627f561336fc DIFF: https://github.com/llvm/llvm-project/commit/96c899449b61b866b583560a49c4627f561336fc.diff

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rsmith updated this revision to Diff 243048. rsmith marked 3 inline comments as done. rsmith added a comment. Extend assert comment to suggest likely remediations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74103/new/ https://reviews.llvm.org/D7

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

eandrews updated this revision to Diff 243049. eandrews edited the summary of this revision. eandrews added a comment. Thanks for taking a look Richard. This patch adds the required value-dependency check and sets type-dependency accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, scanon. Herald added subscribers: ributzka, dexonsmith, jkorous. Without this, LLVM will assume the pointer has the type's alignment, which is undefined if the value is actually underaligned. rdar://58316406 http

[clang] 96400ae - Recommit "[FPEnv][X86] Platform-specific builtin constrained FP enablement"

Author: Craig Topper Date: 2020-02-06T16:54:35-08:00 New Revision: 96400ae2a45c5038ebb4f012f90ffc6dfb30369f URL: https://github.com/llvm/llvm-project/commit/96400ae2a45c5038ebb4f012f90ffc6dfb30369f DIFF: https://github.com/llvm/llvm-project/commit/96400ae2a45c5038ebb4f012f90ffc6dfb30369f.diff

Re: [clang] ad0e03f - Revert "[FPEnv][X86] Platform-specific builtin constrained FP enablement"

Recommitted at 96400ae2a45c5038ebb4f012f90ffc6dfb30369f ~Craig On Thu, Feb 6, 2020 at 4:23 PM Craig Topper wrote: > You can't generate assembly from a frontend test unless you also put > "REQUIRES: x86-registered-target" in the test > > ~Craig > > > On Thu, Feb 6, 2020 at 4:17 PM Kevin P. Neal

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM, assuming that we do indeed want to ban friends. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74103/new/ https://reviews.llvm.

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rsmith updated this revision to Diff 243057. rsmith marked an inline comment as done. rsmith added a comment. Add back a diagnostic for remaining cases that the new langauge rule doesn't handle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74103/n

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rsmith added a comment. Ugh, you mentioned template argument lists and made me realize we can still reach problem cases that way. And with array bounds. :( I've added back in a diagnostic for the case where we compute the linkage too early for a "C-like" struct. Hopefully people won't hit it to

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

arphaman added a comment. @jyknight @rjmccall I'm not sure this change is 100% fine. For example, the following code no longer compiles with ARC: @protocol Delegate @end @interface X @end @interface Y @property id d; @end @implementation X + (void)foo:(Y *)y wit

[PATCH] D74103: Implement P1766R1: diagnose giving non-C-compatible classes a typedef name for linkage purposes.

rjmccall added a comment. Okay, if the basic idea is to avoid anything that would need the linkage to be computed, that seems like exactly the right goal. I know one of the awful ways to get an early reference to the anonymous type is to define a typedef of like a pointer to it, then use that i

[clang] 7931e8e - Update hwasan docs to cover outlined checks and globals.

Author: Peter Collingbourne Date: 2020-02-06T17:44:43-08:00 New Revision: 7931e8eee3dafe64101dcc1e88276ba81071 URL: https://github.com/llvm/llvm-project/commit/7931e8eee3dafe64101dcc1e88276ba81071 DIFF: https://github.com/llvm/llvm-project/commit/7931e8eee3dafe64101dcc1e88276ba81071

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

pcc marked 5 inline comments as done. pcc added inline comments. Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:87 + bl __hwasan_check_x0_2_short // call outlined tag check +// (a

[PATCH] D74150: Update hwasan docs to cover outlined checks and globals.

This revision was automatically updated to reflect the committed changes. pcc marked an inline comment as done. Closed by commit rG7931e8eee3da: Update hwasan docs to cover outlined checks and globals. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D74150?vs=242962&id=2430

[clang] fafddbd - Revert "[Clang][Driver] Remove -M group options ..." and "[Clang] Avoid crashing when generating crash diagnostics when '#pragma clang __debug ..."

Author: Jordan Rupprecht Date: 2020-02-06T17:59:15-08:00 New Revision: fafddbd956dbe439787f6d717c247e648bb07ff5 URL: https://github.com/llvm/llvm-project/commit/fafddbd956dbe439787f6d717c247e648bb07ff5 DIFF: https://github.com/llvm/llvm-project/commit/fafddbd956dbe439787f6d717c247e648bb07ff5.di

[PATCH] D74076: [Clang][Driver] Remove -M group options before generating crash diagnostics

rupprecht added a comment. FYI - reverted this too since I had conflicts when also reverting D74070 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74076/new/ https://reviews.llvm.org/D74076

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

rupprecht added a comment. FYI, temporarily reverted this in fafddbd956dbe439787f6d717c247e648bb07ff5 since it was causing failures in `Clang :: Driver/crash-report.c`. I didn't see the failure on all buildbots (otherwise I c

[clang] 02fffbb - Fix test after test changes added in da3dc00 caused the test to break

Author: Douglas Yung Date: 2020-02-06T18:19:01-08:00 New Revision: 02fffbb5fa9f34a16f2c7959364d0668364332a2 URL: https://github.com/llvm/llvm-project/commit/02fffbb5fa9f34a16f2c7959364d0668364332a2 DIFF: https://github.com/llvm/llvm-project/commit/02fffbb5fa9f34a16f2c7959364d0668364332a2.diff

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2077 +getDataLayout().getABITypeAlignment(getTypes().ConvertType(RetTy))) + SRETAttrs.addAlignmentAttr(Align); ArgAttrs[IRFunctionArgs.getSRetArgNo()] = Why only when under

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey added a comment. Thanks @dblaikie for all of your suggestions. I will commit this in 3 patches after getting the green signal from @aprantl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

rjmccall added a comment. Hmm. The alternative approach, I suppose, would be to recognize that we're about to emit a generic error and just recheck assignment constraints to recompute the AssignConvertType. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74116/new/ https://reviews.llvm

<    1   2