[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

evgeny777 added inline comments. Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:1678 +// breaks any uses on assumes. +if (TypeIdMap.count(TypeId)) + continue; tejohnson wrote: > evgeny777 wrote: > > tejohnson wrote: > > > evgeny777 wrote:

[PATCH] D73966: [analyzer][WIP] Add 10.0.0 release notes.

balazske added inline comments. Comment at: clang/docs/ReleaseNotes.rst:408 + +- New checker: ``alpha.plusplus.PlacementNew`` to detect whether the storage + provided for default placement new is sufficiently large. Szelethus wrote: > NoQ wrote: > > I think this

[clang-tools-extra] 6e8d6bc - [clangd] Preserve -nostdinc and --sysroot when calling query driver

Author: Kadir Cetinkaya Date: 2020-02-05T09:58:06+01:00 New Revision: 6e8d6bc9ec8739ec22b73a23f740f171f452e234 URL: https://github.com/llvm/llvm-project/commit/6e8d6bc9ec8739ec22b73a23f740f171f452e234 DIFF: https://github.com/llvm/llvm-project/commit/6e8d6bc9ec8739ec22b73a23f740f171f452e234.dif

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. Ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D73966: [analyzer][WIP] Add 10.0.0 release notes.

Charusso added inline comments. Comment at: clang/docs/ReleaseNotes.rst:408 + +- New checker: ``alpha.plusplus.PlacementNew`` to detect whether the storage + provided for default placement new is sufficiently large. balazske wrote: > Szelethus wrote: > > NoQ wro

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74025 Files: clang-tools-extra/clangd/Find

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet closed this revision. kadircet added a comment. closed by 6e8d6bc9ec8739ec22b73a23f740f171f452e234 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62441 tests passed, 0 failed and 845 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[clang-tools-extra] ca1c21d - [clangd] Use printf instead of `echo -e` to be compliant with dash

Author: Kadir Cetinkaya Date: 2020-02-05T10:21:32+01:00 New Revision: ca1c21d4b659bfa5edb38c4a54b3050e43c4b51a URL: https://github.com/llvm/llvm-project/commit/ca1c21d4b659bfa5edb38c4a54b3050e43c4b51a DIFF: https://github.com/llvm/llvm-project/commit/ca1c21d4b659bfa5edb38c4a54b3050e43c4b51a.dif

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72932/new/ https://reviews.llvm.org/D72932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

hokein added a comment. thanks, mostly good. the only concern from my side is about the `SymbolRole::Implicit`, I think we should get rid of it. Comment at: clang-tools-extra/clangd/index/Ref.h:53 + // The reference explicitly spells out declaration's name. Such references c

[PATCH] D74028: [clang] Add release notes for the 10.x branch for things I've done

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74028 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein updated this revision to Diff 242536. hokein added a comment. update based on the offline discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

Abpostelnicu created this revision. Abpostelnicu added a reviewer: hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. Abpostelnicu edited the summary of this revision. Abpostelnicu edited the summary of this revision. Abpostelnicu added a subscriber: sylvestre.ledru. Sinc

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/SourceCode.cpp:1139 + // Double check that this is an actual protobuf header. + if (!SM.getBufferData(FID).startswith

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

Szelethus added inline comments. Comment at: clang/docs/ReleaseNotes.rst:408 + +- New checker: ``alpha.plusplus.PlacementNew`` to detect whether the storage + provided for default placement new is sufficiently large. Charusso wrote: > balazske wrote: > > Szeleth

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

Szelethus updated this revision to Diff 242539. Szelethus marked 10 inline comments as done. Szelethus retitled this revision from "[analyzer][WIP] Add 10.0.0 release notes." to "[analyzer] Add 10.0.0 release notes.". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73966/new/ https://revie

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein updated this revision to Diff 242543. hokein added a comment. address a final comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-e

[PATCH] D74033: [clang-tidy] Fix PR#44620 'readability-redundant-string-cstr quick-fix causes invalid code'

f00kat created this revision. f00kat added reviewers: aaron.ballman, alexfh. f00kat added projects: clang-tools-extra, clang. Herald added subscribers: cfe-commits, xazax.hun. #include static void f2(std::string&&) { } static void f() { std::string const s; f2(s.c_st

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[PATCH] D73693: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. if it is trivial, it would be nice to add some unittests in `clang/unittests/AST/DeclPrinterTest.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang-tools-extra] f8865c0 - [clangd] Pull out a isProtoFile function.

Author: Haojian Wu Date: 2020-02-05T12:04:03+01:00 New Revision: f8865c01944fe409857eeb30e0963bfa5ced294d URL: https://github.com/llvm/llvm-project/commit/f8865c01944fe409857eeb30e0963bfa5ced294d DIFF: https://github.com/llvm/llvm-project/commit/f8865c01944fe409857eeb30e0963bfa5ced294d.diff LO

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8865c01944f: [clangd] Pull out a isProtoFile function. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

sammccall added a comment. Libclang changes need tests I think. Comment at: clang-tools-extra/clangd/Protocol.cpp:265 case index::SymbolKind::Parameter: + case index::SymbolKind::TemplateParm: return SymbolKind::Variable; this seems kind of dubious, ma

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74036 Files: clang-tools-extra/clangd/refactor/Rename.

[PATCH] D74036: [clangd] don't rename on protobuf symbols.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[clang] 6198e1c - Fix MSVC signed/unsigned warning. NFCI.

Author: Simon Pilgrim Date: 2020-02-05T11:53:16Z New Revision: 6198e1c40abce7135ce68e2b91d433ec02454a50 URL: https://github.com/llvm/llvm-project/commit/6198e1c40abce7135ce68e2b91d433ec02454a50 DIFF: https://github.com/llvm/llvm-project/commit/6198e1c40abce7135ce68e2b91d433ec02454a50.diff LOG:

[clang] f780e15 - [OpenCL] Fix support for cl_khr_mipmap_image_writes

Author: Alexey Sotkin Date: 2020-02-05T14:55:32+03:00 New Revision: f780e15caf1bed0a9fbc87fde70bd5ab3d80a439 URL: https://github.com/llvm/llvm-project/commit/f780e15caf1bed0a9fbc87fde70bd5ab3d80a439 DIFF: https://github.com/llvm/llvm-project/commit/f780e15caf1bed0a9fbc87fde70bd5ab3d80a439.diff

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

This revision was automatically updated to reflect the committed changes. AlexeySotkin marked an inline comment as done. Closed by commit rGf780e15caf1b: [OpenCL] Fix support for cl_khr_mipmap_image_writes (authored by AlexeySotkin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Apologies for inserting myself in here :) Please use the "[analyzer]" tag instead of "[clang][checkers]" in future changes, because we've used that traditionally for years, and

[PATCH] D73350: [analyzer] Small StreamChecker refactoring (NFC).

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Cool! Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:157 + ProgramStateRef StateNotNull, StateNull; + std::tie(StateNotNull, StateNull) = C.getConst

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://reviews.llvm.org/D71451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

hans added a comment. lgtm, but if you want it wouldn't hurt to include even more details from the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74031/new/ https://reviews.llvm.org/D74031

[PATCH] D73359: [analyzer]StreamChecker refactoring (NFC).

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Charusso. LGTM! The code looks a lot cleaner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73359/new/ https://

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

Abpostelnicu added a comment. In D74031#1859084 , @hans wrote: > lgtm, but if you want it wouldn't hurt to include even more details from the > commit message. This is a good idea, in my latest patch you will see that I've added more context present in

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

Abpostelnicu updated this revision to Diff 242562. Abpostelnicu added a comment. Adding extra comments to the release patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74031/new/ https://reviews.llvm.org/D74031 Files: clang/docs/ReleaseNotes.

[clang-tools-extra] eaf0c89 - [clangd] Add the missing elaborated types in FindTarget.

Author: Haojian Wu Date: 2020-02-05T14:03:36+01:00 New Revision: eaf0c89ec5f866b6cef296c542c030bb2cf8481d URL: https://github.com/llvm/llvm-project/commit/eaf0c89ec5f866b6cef296c542c030bb2cf8481d DIFF: https://github.com/llvm/llvm-project/commit/eaf0c89ec5f866b6cef296c542c030bb2cf8481d.diff LO

[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

Szelethus added a comment. I'm late to the party, but have looked at the code and I really, really-really like what you did in this patch! It solves one of my biggest complaints about this project. LGTM! Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:1389

[PATCH] D74025: [clangd] Add the missing elaborated types in FindTarget.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf0c89ec5f8: [clangd] Add the missing elaborated types in FindTarget. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D74025?vs=242524&id=242566#toc Repository: rG LLVM Githu

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr added a comment. In D73775#1856869 , @aaron.ballman wrote: > In D73775#1856848 , @alexeyr wrote: > > > In D73775#1856765 , @aaron.ballman > > wrote: > > > > > In D7

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus added a comment. In D72705#1838324 , @balazske wrote: > I am still unsure about how this checker works if the function to check is > "modeled" or evaluated by another checker. Then the function may have already > a constrained value at the Post

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

aaron.ballman added a comment. In D73775#1859156 , @alexeyr wrote: > In D73775#1856869 , @aaron.ballman > wrote: > > > In D73775#1856848 , @alexeyr wrote: > > > > > In D7377

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr updated this revision to Diff 242572. alexeyr added a comment. Lower-case warning messages CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73775/new/ https://reviews.llvm.org/D73775 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp clang-tools-extra/test/c

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

miyuki created this revision. miyuki added reviewers: simon_tatham, ostannard, dmgreen, eli.friedman. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch adds assembly-level support for a new Arm M-profile architecture exten

[PATCH] D73636: [AArch64][SVE] SVE2 intrinsics for complex integer arithmetic

sdesmalen added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1758 +def int_aarch64_sve_sqcadd_x : AdvSIMD_2VectorArgIndexed_Intrinsic; +def int_aarch64_sve_cmla_x : AdvSIMD_3VectorArgIndexed_Intrinsic; +def int_aarch64_sve_cmla_lane_x

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[PATCH] D73719: [AArch64][SVE] Add SVE2 intrinsics for widening DSP operations

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73719/new/ https://reviews.llvm.org/D73719

[PATCH] D73903: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations

sdesmalen added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1852 -// SVE2 MLA LANE. -def int_aarch64_sve_smlalb_lane : SVE2_3VectorArg_Indexed_Intrinsic; nit: why are you moving these? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 242577. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files: clang-tools

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks great, thanks! Do you have commit access? If so, go ahead and push directly to the 10.x branch, otherwise let me know and I'll do it for you. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 242578. kbobyrev added a comment. Remove an artifact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files: clang-tools-extra/clangd/index/Ref.h clang-tools-extra

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr added a comment. In D73775#1859167 , @aaron.ballman wrote: > Huh, this does seem like it may be a bug in clang-tidy. I would have expected > `ClangTidyDiagnosticConsumer::forwardDiagnostic()` to do this work. From my debugging attempt it seems

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:644 Dependencies<[ContainerModeling]>, - Documentation, - Hidden; - -def InvalidatedIteratorChecker : Checker<"InvalidatedIterator">, - HelpText<"Check for use of invalidate

[PATCH] D73536: [analyzer][taint] Remove taint from symbolic expressions if used in comparisons

steakhal added a subscriber: martong. steakhal added a comment. I'm convinced that we shouldn't remove taint from expressions used in comparisons. With the current configuration files, `sink` functions are not too useful. For now, I would delay developing a mechanism describing constraints here,

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

Abpostelnicu added a comment. In D74031#1859231 , @hans wrote: > Looks great, thanks! > > Do you have commit access? If so, go ahead and push directly to the 10.x > branch, otherwise let me know and I'll do it for you. Yes I have commit access, pushing

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

Szelethus added a comment. Also, I really like this patch, its well documented, small and very well tested! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D74046: [clang][driver] Fix null pointer dereference warning inside PrintActions1 (PR43462)

RKSimon created this revision. RKSimon added reviewers: sfantao, tra, ABataev, jlebar. Herald added a project: clang. As detailed on PR43462, clang static analyzer is complaining about a null pointer dereference as we provide a 'host' toolchain fallback if the ToolChain pointer is null, but then

[PATCH] D73536: [analyzer][taint] Remove taint from symbolic expressions if used in comparisons

Szelethus added a comment. I think its very good that this conversation came up, and it might just happen that we'll end up removing some taint when we have a better understanding of how this works. For now, I think we can put this aside :) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

Abpostelnicu added a comment. done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74031/new/ https://reviews.llvm.org/D74031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] 482e236 - [analyzer] Fix a couple of bugs in HTML report generation.

Author: Artem Dergachev Date: 2020-02-05T17:16:38+03:00 New Revision: 482e236e569e8324f70778af1eb756923cd490dc URL: https://github.com/llvm/llvm-project/commit/482e236e569e8324f70778af1eb756923cd490dc DIFF: https://github.com/llvm/llvm-project/commit/482e236e569e8324f70778af1eb756923cd490dc.dif

[PATCH] D73993: [analyzer] Fix a couple of bugs in HTML report generation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG482e236e569e: [analyzer] Fix a couple of bugs in HTML report generation. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73993/new/

[PATCH] D69582: Let clang driver support parallel jobs

aganea added inline comments. Comment at: clang/lib/Driver/Compilation.cpp:332 +if (!Next) { + std::this_thread::yield(); continue; yaxunl wrote: > aganea wrote: > > In addition to what @thakis said above, yielding here is maybe not a good > > id

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader created this revision. bader added a reviewer: ABataev. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a project: clang. As a first step this implementation enables compilation of the offload code. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

hans added a comment. > D73760 will be nice to be cherry picked if > there is not much trouble, so we won't have a major release with > unsatisfactory label placement if Linux x86 developers ever want to adopt > -fpatchable-function-entry=. Cherry-picked as 4c

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[PATCH] D73993: [analyzer] Fix a couple of bugs in HTML report generation.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:612 + return !(Range.getBegin().isMacroID() || Range.getEnd().isMacroID()); +} + Charusso wrote: > Side note: I like the other form of

[PATCH] D74046: [clang][driver] Fix null pointer dereference warning inside PrintActions1 (PR43462)

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74046/new/ https://reviews.llvm.org/D74046 ___

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

hans added a comment. In D68923#1857307 , @aaronpuchert wrote: > @hans, could you cherry-pick this on the version 10 branch? As I wrote in > D68923#1857046 , this is a > regression from Clang 8. Sounds good to

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:1678 +// breaks any uses on assumes. +if (TypeIdMap.count(TypeId)) + continue; evgeny777 wrote: > tejohnson wrote:

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3411-3413 +// C++ SYCL options +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; Usually, we add a pair of such flags, `-fsycl` and

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242590. bader added a comment. Rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChain

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

Szelethus added subscribers: steakhal, boga95. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:731 + } + return C.getNoteTag([Text, Name](BugReport &BR) -> std::string { + SmallString<256> Msg; NoQ wrote

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

richard.barton.arm added inline comments. Comment at: clang/include/clang/Driver/Options.td:264 MetaVarName<"">; +def fcc_fortran_name : Separate<["-"], "ffc-fortran-name">, InternalDriverOpt, + HelpText<"Name for native Fortran compiler">; CarolineConcatto w

[clang] fd3437a - [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

Author: Alexey Bataev Date: 2020-02-05T09:57:53-05:00 New Revision: fd3437a4f791cb0520e19b87953141fc68543377 URL: https://github.com/llvm/llvm-project/commit/fd3437a4f791cb0520e19b87953141fc68543377 DIFF: https://github.com/llvm/llvm-project/commit/fd3437a4f791cb0520e19b87953141fc68543377.diff

[PATCH] D73128: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd3437a4f791: [OPENMP][NVPTX]Add NVPTX specific definitions for new/delete operators. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73

[clang] 569dc65 - [OPNEMP50][DOCS]Mark array shaping expression as claimed, NFC.

Author: Alexey Bataev Date: 2020-02-05T10:02:39-05:00 New Revision: 569dc65c63802e2313aebe702d0233ae101c09cf URL: https://github.com/llvm/llvm-project/commit/569dc65c63802e2313aebe702d0233ae101c09cf DIFF: https://github.com/llvm/llvm-project/commit/569dc65c63802e2313aebe702d0233ae101c09cf.diff

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware updated this revision to Diff 242607. baloghadamsoftware added a comment. Updated: checker moved to alpha.cplusplus (until at least one of the iterator-related checkers gets out of alpha state or a new non-alpha container checker is created). Error-branch is protected by an op

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

Szelethus added a comment. I strongly agree with this comment: D70878#1780513 , maybe the placement of functions like `getArg` and `getNumArgs` would be most appropriate in `CallDescription`. How about we try to cut down on duplicating functionalities?

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73242/new/ https://reviews.llvm.org/D73242 _

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:731 + } + return C.getNoteTag([Text, Name](BugReport &BR) -> std::string { + SmallString<256> Msg; Szelethus wrote: > NoQ wrote: > > baloghadamsoftware wrote: >

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/STLAlgorithmModeling.cpp:138-139 + SVB.getConditionType()); +assert(Less.getAs() && + "Symbol co

[PATCH] D69582: Let clang driver support parallel jobs

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/Compilation.cpp:332 +if (!Next) { + std::this_thread::yield(); continue; aganea wrote: > yaxunl wrote: > > aganea wrote: > > > In addition to what

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! Tests for the other value of the option are welcome (: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818 __

[clang] e63abde - [clang][driver] Fix null pointer dereference warning inside PrintActions1 (PR43462)

Author: Simon Pilgrim Date: 2020-02-05T15:32:18Z New Revision: e63abde39f530028b0089ea477446c1b671a28f1 URL: https://github.com/llvm/llvm-project/commit/e63abde39f530028b0089ea477446c1b671a28f1 DIFF: https://github.com/llvm/llvm-project/commit/e63abde39f530028b0089ea477446c1b671a28f1.diff LOG:

[PATCH] D74046: [clang][driver] Fix null pointer dereference warning inside PrintActions1 (PR43462)

This revision was automatically updated to reflect the committed changes. Closed by commit rGe63abde39f53: [clang][driver] Fix null pointer dereference warning inside PrintActions1… (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good, a few nits. before landing the patch, could you please run the clangd-indexer on the llvm project and measure the before/after indexing time? to make sure we don't introdu

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

thakis added a comment. In D69825#1837243 , @hctim wrote: > For tracking purposes. > > The ASan leaks have been worked around in two separate patches in order to > make the bots green again: > > - c38e42527b21acee8d01a016d5bfa2fb83202e29 >

[clang] 91b3083 - [OpenCL] Fix tblgen support for cl_khr_mipmap_image_writes

Author: Sven van Haastregt Date: 2020-02-05T16:05:20Z New Revision: 91b3083aecdcb7beb33d497a94f4467f110b4f6d URL: https://github.com/llvm/llvm-project/commit/91b3083aecdcb7beb33d497a94f4467f110b4f6d DIFF: https://github.com/llvm/llvm-project/commit/91b3083aecdcb7beb33d497a94f4467f110b4f6d.diff

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

lebedev.ri updated this revision to Diff 242622. lebedev.ri retitled this revision from "[Sema] Demote 'alignment is not a power of two' error into a warning" to "[Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning". lebedev.ri added a comment. Sca

[clang] 3627c91 - [ARM][TargetParser] Improve handling of dependencies between target features

Author: Momchil Velikov Date: 2020-02-05T16:07:51Z New Revision: 3627c91ead934486fdb3986b911482a78f101309 URL: https://github.com/llvm/llvm-project/commit/3627c91ead934486fdb3986b911482a78f101309 DIFF: https://github.com/llvm/llvm-project/commit/3627c91ead934486fdb3986b911482a78f101309.diff LO

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/277 Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D74048: [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

bader updated this revision to Diff 242627. bader added a comment. Applied suggestions from Alexey Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74048/new/ https://reviews.llvm.org/D74048 Files: clang/include/clang/Driver/Options.td clang/lib/

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

svenvh added a comment. I have updated the TableGen OpenCL builtin definitions accordingly in 91b3083aecd ("[OpenCL] Fix tblgen support for cl_khr_mipmap_image_writes", 2020-02-05). Repository: rG LLVM Github Monorepo CH

[PATCH] D72762: [ARM][TargetParser] Improve handling of dependencies between target features

This revision was automatically updated to reflect the committed changes. Closed by commit rG3627c91ead93: [ARM][TargetParser] Improve handling of dependencies between target features (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

  1   2   >