Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

This patch has been languishing for 10 days, and it has been pointed out on cfe-dev that it is important to directly CC appropriate reviewers. As there's no-one listed in clang/CODE_OWNERS.TXT for diagnostics, I've now CCed "all other parts" Richard. On 20 Jan 2020, at 16:09, John Marshall via

[PATCH] D73762: [clang] New warning for for-loops where the iteration does not match the loop condition

Eugene.Zelenko added a comment. Check should also consider cases like: i += 2; i = i + 2; i -= 2; i = i - 2. Probably same with multiplications, divisions and shifts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73762/new/ https://reviews.llvm.or

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

ilya-biryukov updated this revision to Diff 241718. ilya-biryukov added a comment. Fix compilation after rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69330/new/ https://reviews.llvm.org/D69330 Files: clang/include/clang/AST/ComputeDepend

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

This revision was automatically updated to reflect the committed changes. antiagainst marked an inline comment as done. Closed by commit rGdf71000d7d5d: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops (authored by antiagainst). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:335 +return AsTExpr; + else +return nullptr; Please don;e use else after return. Comment at: clang-tools-extra/clang-tidy/

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think the pings have gone on long enough -- if there's an issue with the patch, we can address it post-commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

Anastasia added a comment. In D73360#1850001 , @rjmccall wrote: > Is there no follow-up code when actually emitting the failure diagnostic > which tries to figure out a more specific cause of failure? After looking at this a bit more it seems C++ part c

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1168 + Error Err = Error::success(); + QualType ToElementType = T->getElementType(); + Expr *ToSizeExpr = T->getSizeExpr(); shafik wrote: > Should this group be using `importChecked` as w

[PATCH] D73687: [AArch64][SVE] Add SVE2 intrinsics for complex integer dot product

kmclaughlin updated this revision to Diff 241726. kmclaughlin added a comment. - Removed the AdvSIMD_SVE_CDOT_Intrinsic class - Added ImmArg<4> to AdvSIMD_SVE_CDOT_LANE_Intrinsic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73687/new/ https://reviews.llvm.org/D73687 Files: llvm/incl

[PATCH] D73687: [AArch64][SVE] Add SVE2 intrinsics for complex integer dot product

kmclaughlin marked 2 inline comments as done. kmclaughlin added a comment. Thanks for reviewing this, @efriedma! Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td: + LLVMSubdivide4VectorType<0>, + llvm_i32_ty], +[IntrNoMem

[PATCH] D73786: [ARM,MVE] Fix vreinterpretq in big-endian mode.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. In big-endian MVE, the simple vector load/store instructions (i.e. both co

[PATCH] D73701: [clang] fix linkage of nested lambda

hliao accepted this revision. hliao added a comment. This revision is now accepted and ready to land. LGTM, but need @rsmith for the final review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73701/new/ https://reviews.llvm.org/D73701 __

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein added a comment. In D73780#1851654 , @kadircet wrote: > LG. I might be missing some context though, what's the reasoning behind? > Because, I think it is not necessary to treat protobufs differently. > > It might be sensible to have a more generic

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein updated this revision to Diff 241734. hokein marked 3 inline comments as done. hokein added a comment. update, and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 Files: clang-too

<    1   2