[clang] 735f90f - Fix one round of implicit conversions found by g++5.

2020-01-28 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-01-29T01:52:48+01:00 New Revision: 735f90fe42e55935035d842752e01361b5216c11 URL: https://github.com/llvm/llvm-project/commit/735f90fe42e55935035d842752e01361b5216c11 DIFF: https://github.com/llvm/llvm-project/commit/735f90fe42e55935035d842752e01361b5216c11.dif

[clang-tools-extra] 9a5c448 - [clangd] Fix null check in FindTarget.

2020-01-28 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-01-29T02:01:42+01:00 New Revision: 9a5c448a31bacc08e73fcae4636094f9b6e2be6a URL: https://github.com/llvm/llvm-project/commit/9a5c448a31bacc08e73fcae4636094f9b6e2be6a DIFF: https://github.com/llvm/llvm-project/commit/9a5c448a31bacc08e73fcae4636094f9b6e2be6a.diff LO

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

2020-01-28 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 241029. arphaman marked 2 inline comments as done. arphaman added a comment. Add suggested changes. The `-ibuiltininc` flag now interacts with `-nobuiltininc` as well, i.e. it's cancelled out if `-nobuiltininc` comes after it, and vice-versa. Repository:

[clang] 2b36e85 - GCC5 buildbot made it to clang. Fix implicit conversions it found.

2020-01-28 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-01-29T02:19:49+01:00 New Revision: 2b36e85542d24161ff4460cb4f0da635e9f5ab62 URL: https://github.com/llvm/llvm-project/commit/2b36e85542d24161ff4460cb4f0da635e9f5ab62 DIFF: https://github.com/llvm/llvm-project/commit/2b36e85542d24161ff4460cb4f0da635e9f5ab62.dif

[PATCH] D73596: [CodeComplete] WIP member completion for concept-constrained type parameters

2020-01-28 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, mgrang, ilya-biryukov. Herald added a project: clang. see https://github.com/clangd/clangd/issues/261 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73596 Files: clang/include/clang

[PATCH] D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement

2020-01-28 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/test/CodeGen/fma-builtins-constrained.c:4 +// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-apple-darwin -target-feature +fma -S -o - | FileCheck --check-prefix=COMMON --check-prefix=CHECK-ASM %s +// RUN: %clang_cc1 -ffre

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

2020-01-28 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73500/new/ https://reviews.llvm.org/D73500

[clang] bb39b52 - Fix conversions in clang and examples

2020-01-28 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-01-29T02:48:15+01:00 New Revision: bb39b52950e77e650fbdd86f7d5e4b89ff0aac4d URL: https://github.com/llvm/llvm-project/commit/bb39b52950e77e650fbdd86f7d5e4b89ff0aac4d DIFF: https://github.com/llvm/llvm-project/commit/bb39b52950e77e650fbdd86f7d5e4b89ff0aac4d.dif

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

2020-01-28 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Should they use -nostdlibinc instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73500/new/ https://reviews.llvm.org/D73500 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D73596: [CodeComplete] WIP member completion for concept-constrained type parameters

2020-01-28 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62281 tests passed, 0 failed and 827 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 7 warnings

[clang] bd31243 - Fix more implicit conversions. Getting closer to having clang working with gcc 5 again

2020-01-28 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-01-29T02:57:59+01:00 New Revision: bd31243a34da8a045c642ddc77b27b0a45a9bf1e URL: https://github.com/llvm/llvm-project/commit/bd31243a34da8a045c642ddc77b27b0a45a9bf1e DIFF: https://github.com/llvm/llvm-project/commit/bd31243a34da8a045c642ddc77b27b0a45a9bf1e.dif

[clang] f96f64d - [driver][Darwin] Add an -ibuiltininc flag that lets Darwin driver

2020-01-28 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2020-01-28T18:18:43-08:00 New Revision: f96f64d0f2793fe720bf847cac4a45d74a81c0ef URL: https://github.com/llvm/llvm-project/commit/f96f64d0f2793fe720bf847cac4a45d74a81c0ef DIFF: https://github.com/llvm/llvm-project/commit/f96f64d0f2793fe720bf847cac4a45d74a81c0ef.diff L

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

2020-01-28 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf96f64d0f279: [driver][Darwin] Add an -ibuiltininc flag that lets Darwin driver include Clang… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

2020-01-28 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D73500#1846003 , @MaskRay wrote: > Should they use -nostdlibinc instead? Unfortunately they can't control the flag in this specific case, only add flags for specific files. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

2020-01-28 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D73500#1846036 , @arphaman wrote: > In D73500#1846003 , @MaskRay wrote: > > > Should they use -nostdlibinc instead? > > > Unfortunately they can't control the flag in this specific case,

[PATCH] D73603: Driver: Add gcc search path for RHEL devtoolset-9

2020-01-28 Thread Tom Stellard via Phabricator via cfe-commits
tstellar created this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73603 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index: clang/lib/Driver/ToolChains/Gnu.cpp === --- c

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

2020-01-28 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. I tried to push this today but the build failed: /data/src/llvm-project/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:252:36: error: use of undeclared identifier 'BumpPtrAllocator' StringMap, BumpPtrAllocator> InternalVars;

[PATCH] D73603: Driver: Add gcc search path for RHEL devtoolset-9

2020-01-28 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62282 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

2020-01-28 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim added a comment. Thanks for trying. It compiles fine with me. How can I reproduce the problems you're getting? is there a way to pack what you have and send it to me so I can have a look? Also, a second question, how trustworthy is harbormaster when it says something is buildable? Re

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

2020-01-28 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D72304#1846115 , @fghanim wrote: > Thanks for trying. > > It compiles fine with me. How can I reproduce the problems you're getting? is > there a way to pack what you have and send it to me so I can have a look? Did you reb

[PATCH] D73464: [clang] Add TagDecl AST matcher

2020-01-28 Thread Karasev Nikita via Phabricator via cfe-commits
f00kat added a comment. In D73464#1845511 , @aaron.ballman wrote: > In D73464#1844402 , @f00kat wrote: > > > In D73464#1844310 , @aaron.ballman > > wrote: > > > > > LGTM! D

[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

2020-01-28 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. In D73547#1845339 , @NoQ wrote: > This patch is simply moving code around, right? If so, why did tests need to > be removed? All of the container begin- and end-tests were removed from `iterator-modeling.cpp` and mov

[PATCH] D72829: Implement -fsemantic-interposition

2020-01-28 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 241055. serge-sans-paille added a comment. @arichardson doc updated, any other advice? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/Cla

[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

2020-01-28 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ouch, whoops, i didn't notice the new test file. LGTM then! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73547/new/ https://reviews.llvm.org/D73547 _

[PATCH] D72829: Implement -fsemantic-interposition

2020-01-28 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62286 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

<    1   2   3