[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

2020-01-27 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. I don't like the name `getDependencies`, because the function is not getting a list of dependencies, it's getting flags that indicate whether certain properties of the construct are dependent. Maybe `getDependence` or `getDependenceFlags` would be a better name? Likewise

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to functions with no Decl

2020-01-27 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
thegameg marked an inline comment as done. thegameg added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1917 const auto *NBA = Fn->getAttr(); -bool HasWildcard = NBA && llvm::is_contained(NBA->builtinNames(), "*"); -if (getLangOpts().NoBuiltin

[PATCH] D73513: [memtag] Plug in stack safety analysis.

2020-01-27 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis created this revision. eugenis added reviewers: pcc, vitalybuka, ostannard. Herald added subscribers: cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Run StackSafetyAnalysis at the end of the IR pipeline and annotate proven safe allocas with !stack-safe metadata.

[PATCH] D73513: [memtag] Plug in stack safety analysis.

2020-01-27 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added a comment. To explain some design decisions: The analysis is added to the IR pipeline and not to the AArch64 codegen pipeline mainly because we plan to extend it with ThinLTO support in the future. To do that, module summary builder will need to depend on the (function-)local sta

[PATCH] D73513: [memtag] Plug in stack safety analysis.

2020-01-27 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62250 tests passed, 0 failed and 816 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[clang] af80b8c - PR44684: Look through parens and similar constructs when determining

2020-01-27 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-01-27T18:20:57-08:00 New Revision: af80b8ccc5772c14920d4554b7ca7e15f2fad1c4 URL: https://github.com/llvm/llvm-project/commit/af80b8ccc5772c14920d4554b7ca7e15f2fad1c4 DIFF: https://github.com/llvm/llvm-project/commit/af80b8ccc5772c14920d4554b7ca7e15f2fad1c4.diff

[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

2020-01-27 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. - Repository: rC Clang https://reviews.llvm.org/D73520 Fi

[PATCH] D73521: [analyzer][WIP] add-new-checker.py: Introduction

2020-01-27 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This script could be used to generate a dummy Static Analyzer c

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

2020-01-27 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1917 const auto *NBA = Fn->getAttr(); -bool HasWildcard = NBA && llvm::is_contained(NBA->builtinNames(), "*"); -if (getLangOpts().NoBuiltin || HasWildcard) - FuncAttrs.addAt

Re: [clang] af80b8c - PR44684: Look through parens and similar constructs when determining

2020-01-27 Thread Nico Weber via cfe-commits
This seems to break check-clang-tools on non-Linux: http://45.33.8.238/mac/6529/step_8.txt http://45.33.8.238/win/6770/step_8.txt On Mon, Jan 27, 2020 at 9:21 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2020-01-27T18:20:57-08:00 > New Re

[clang] 4953213 - Make AST reading work better with LLVM_APPEND_VC_REV=NO

2020-01-27 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-01-27T22:08:37-05:00 New Revision: 49532137d087d8053789d18540c5e7916b91ef30 URL: https://github.com/llvm/llvm-project/commit/49532137d087d8053789d18540c5e7916b91ef30 DIFF: https://github.com/llvm/llvm-project/commit/49532137d087d8053789d18540c5e7916b91ef30.diff LO

[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

2020-01-27 Thread Nico Weber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG49532137d087: Make AST reading work better with LLVM_APPEND_VC_REV=NO (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D73521: [analyzer][WIP] add-new-checker.py: Introduction

2020-01-27 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso updated this revision to Diff 240759. Charusso added a comment. - Make it runable. Whoops. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73521/new/ https://reviews.llvm.org/D73521 Files: clang/test/Analysis/add-new-checker/add-main-package.rst clang/test/Analysis/add-new-c

[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

2020-01-27 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:195 + + static const char *getTag() { return "FindLastStore"; } + I have made every tag a small-stri

[PATCH] D73521: [analyzer][WIP] add-new-checker.py: Introduction

2020-01-27 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso marked an inline comment as done. Charusso added a comment. This script dumps out a dummy checker which is the continuation of the Clang Tidy's https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clang-tidy/add_new_check.py However, we could stick to the main-function-re

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

2020-01-27 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 240760. yaxunl retitled this revision from "[CUDA][HIP] Fix assertion due to dtor check on windows" to "[CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese". yaxunl edited the summary of this revision. yaxunl added a comment. Herald add

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

2020-01-27 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72820/new/ https://reviews.llvm.org/D72820 ___

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

2020-01-27 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 ___

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

2020-01-27 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi added a comment. Why hasn't this patch landed in llvm.org? I see it on the github apple/master but not on llvm.org master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mail

[clang] f4261e1 - [Clang] Enable -fsanitize=leak on Fuchsia targets

2020-01-27 Thread Petr Hosek via cfe-commits
Author: Roland McGrath Date: 2020-01-27T23:37:51-08:00 New Revision: f4261e1121293c1f5a3aba416668e6309099f9da URL: https://github.com/llvm/llvm-project/commit/f4261e1121293c1f5a3aba416668e6309099f9da DIFF: https://github.com/llvm/llvm-project/commit/f4261e1121293c1f5a3aba416668e6309099f9da.diff

[PATCH] D73397: [Clang] Enable -fsanitize=leak on Fuchsia targets

2020-01-27 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf4261e112129: [Clang] Enable -fsanitize=leak on Fuchsia targets (authored by mcgrathr, committed by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73

[PATCH] D73464: [clang] Add TagDecl AST matcher

2020-01-27 Thread Karasev Nikita via Phabricator via cfe-commits
f00kat updated this revision to Diff 240779. f00kat added a comment. 1. Fix Registry.cpp 2. Generate AST Matchers doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73464/new/ https://reviews.llvm.org/D73464 Files: clang/docs/LibASTMatchersRefere

<    1   2   3