[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

xazax.hun added a comment. I've rerun this on Fuchsia and it got the same results as the previous approach :). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73151/new/ https://reviews.llvm.org/D73151 ___ cfe-commits mailing list cfe-commit

[PATCH] D73335: clang-format: [JS] options for arrow functions.

RKSimon added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3165 + } +} + @mprobst - this is breaking buildbots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/27196/steps/bootstrap%20clang/logs/stdio Please

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73231/new/ https://reviews.llvm.org/D73231 __

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 updated this revision to Diff 240611. njames93 marked 6 inline comments as done. njames93 added a comment. - Tweaked default corresponding header settings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73413/new/ https://reviews.llvm.org/D7

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. I wanted to use the existing infrastructure (ExprEngine) to test what conditions are applied to the function return value. I did not found other way to get this information. So the checker observes what checks are applied to the return value by making assumptions on it

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:75 + continue; +if (AnyHeader || File->NamePart.equals_lower(ThisFile->NamePart)) + return; // Found a good candidate for matching decl -

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: clang/lib/AST/FormatString.cpp:754 + LO.isMSCompatibilityVersionSpecified() && + !LO.isCompatibleWithMSVC(LangOptions::MSVC2015)) { +// The standard libraries

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. This is the original version of the (complete) checker, but now outdated: https://reviews.llvm.org/D71510 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson added a comment. In D71913#1837872 , @tejohnson wrote: > FYI I reverted this in rG90e630a95ecc > due to > a cfi test failure in a windows sanitizer bot. Not sure what is happ

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

aaron.ballman added reviewers: rnk, majnemer, zturner. aaron.ballman added a comment. Adding some more Windows reviewers to see if there are more opinions on how to handle this. Comment at: clang/lib/AST/FormatString.cpp:754 + LO.isMSCompatibilityVersionSpecified() &&

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay, it actually worked! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73151/new/ https://reviews.llvm.org/D73151 ___ cfe-commits mailing list

[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. That's more like it! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73062/new/ https://reviews.llvm.org/D73062 ___ cfe-commits mailing list

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

zturner added a comment. Adding a ping since it's been a week with no additional feedback for the author. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun updated this revision to Diff 240624. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. - Add more tests. - Move the C11 checker to alpha.core CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73376/new/ https://reviews.llvm.org/D73376 Files: clang/include/

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun added a comment. In D73376#1839818 , @NoQ wrote: > I don't see any immediate solutions to the boilerplate that don't consist in > introducing better checker APIs. Eg., we could have introduced a > `LazyBugType` - a wrapper around `Optional` tha

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61841 tests passed, 5 failed and 780 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun marked 2 inline comments as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/c11lock.c:7 +enum { + thrd_success = 0, + thrd_error = 2 Strictly speaking, this is implementation defined. But the C11 implementations I am aware of a

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham updated this revision to Diff 240626. simon_tatham added a comment. Removed the special case for `MSCompatibilityVersion == 0`. If the default compatibility setting needs to be changed, that's a separate piece of work and should be done by someone who understands more than I do abou

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:488 + if (Context.getLangOpts().SemanticInterposition && + (Context.getLangOpts().PICLevel && !Context.getLangOpts().PIE)) +// Require various optimization to respect semantic interposition.

[clang] c98d98b - [analyzer] Fix handle leak false positive when the handle dies too early

Author: Gabor Horvath Date: 2020-01-27T09:52:06-08:00 New Revision: c98d98ba9b0f917385c753becec4ddfef51bc47c URL: https://github.com/llvm/llvm-project/commit/c98d98ba9b0f917385c753becec4ddfef51bc47c DIFF: https://github.com/llvm/llvm-project/commit/c98d98ba9b0f917385c753becec4ddfef51bc47c.diff

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

aprantl added a comment. Thanks! > define a new DIFlag bit That seems to be a good idea. Also please make sure to add a bitcode roundtrip test to test/Assembler/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73261/new/ https://reviews.llvm.org/D73261 __

[PATCH] D73493: [AArch64][SVE] Add SVE2 intrinsics for uniform DSP operations

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, dancgr, cameron.mcinally. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Implements the following intrinsics: - sqrdmlah, sqrdmlsh, sqrdmulh & sqdmulh

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

This revision was automatically updated to reflect the committed changes. Closed by commit rGc98d98ba9b0f: [analyzer] Fix handle leak false positive when the handle dies too early (authored by xazax.hun). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62197 tests passed, 0 failed and 815 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

aprantl added a comment. Herald added a subscriber: ormris. Can you add a bitcode roundtrip test to test/Assembler? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

amccarth added a comment. In D73457#1842493 , @simon_tatham wrote: > Removed the special case for `MSCompatibilityVersion == 0`. If the default > compatibility setting needs to be changed, that's a separate piece of work > and should be done by someone

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 240638. mibintc added a comment. rebase per @sepavloff request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst clang/includ

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

njames93 updated this revision to Diff 240640. njames93 added a comment. - Tweak documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73439/new/ https://reviews.llvm.org/D73439 Files: clang/docs/LibASTMatchersReference.html clang/includ

[clang] 88c7b16 - [analyzer] Simplify BoolAssignmentChecker

Author: Mikhail Gadelha Date: 2020-01-27T14:51:35-04:00 New Revision: 88c7b1642079439a73b4d7a6e57e67347f574a15 URL: https://github.com/llvm/llvm-project/commit/88c7b1642079439a73b4d7a6e57e67347f574a15 DIFF: https://github.com/llvm/llvm-project/commit/88c7b1642079439a73b4d7a6e57e67347f574a15.dif

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! In D73457#1842605 , @amccarth wrote: > In D73457#1842493 , @simon_tatham > wrote: > > > R

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to functions with no Decl

thegameg created this revision. thegameg added reviewers: gchatelet, tejohnson, aaron.ballman, efriedma. thegameg added a project: clang. When using -fno-builtin[-], we don't attach the IR attributes to functions with no Decl. This results in projects using -fno-builtin or -ffreestanding to star

[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG88c7b1642079: [analyzer] Simplify BoolAssignmentChecker (authored by Mikhail Gadelha ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 240643. topisani marked an inline comment as done. topisani added a comment. Addressed CR comments I'm sure about the tests, I basically just added to the one test that already exists that it passes one of each "type" of preservable argument. CHANGES SINC

[clang-tools-extra] 27e3671 - [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

Author: Nathan Date: 2020-01-27T19:23:21Z New Revision: 27e3671ff49b72640f89c34a415412e400503442 URL: https://github.com/llvm/llvm-project/commit/27e3671ff49b72640f89c34a415412e400503442 DIFF: https://github.com/llvm/llvm-project/commit/27e3671ff49b72640f89c34a415412e400503442.diff LOG: [clang

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2155 friend class MDNode; + bool isDefault; What about default arguments for non-type template parameters? ("template" etc... ) Repository: rG LLVM Github Monorepo CH

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62196 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG27e3671ff49b: [clang-tidy] readability-identifier-naming disregards parameters restrictions… (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D73098?vs=240400&id=240647#toc Rep

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

dblaikie added a comment. In D73261#1838683 , @probinson wrote: > In D73261#1838552 , @djtodoro wrote: > > > > Is it necessary to use DIFlags? I am willing to do that but generally, it > > > is not welcomed because

[clang] 2d0b29e - [clang] Fix covered default in switch

Author: Jinsong Ji Date: 2020-01-27T19:28:11Z New Revision: 2d0b29e0de5b2fd7cc05e8a341db3bf460e18d46 URL: https://github.com/llvm/llvm-project/commit/2d0b29e0de5b2fd7cc05e8a341db3bf460e18d46 DIFF: https://github.com/llvm/llvm-project/commit/2d0b29e0de5b2fd7cc05e8a341db3bf460e18d46.diff LOG: [c

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

dblaikie added a comment. General question: What purpose do you (or anyone else - @probinson, @aprantl) have for this attribute? I'd like to encourage the idea that we don't need to implement every feature DWARF provides if there's no planned use for it - things can/should be implemented as-mot

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

NoQ added inline comments. Comment at: clang/test/Analysis/c11lock.c:7 +enum { + thrd_success = 0, + thrd_error = 2 xazax.hun wrote: > Strictly speaking, this is implementation defined. But the C11 > implementations I am aware of are following this trend (`thr

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 added a comment. May need to roll this back, I think as i had this on the same local branch as D73052 I have brought both of them in at once Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/ https:

[clang-tools-extra] c72a6ac - Revert "[clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions"

Author: Shoaib Meenai Date: 2020-01-27T11:50:25-08:00 New Revision: c72a6ac4b630d2344dbea44a7d75fa61795dcd76 URL: https://github.com/llvm/llvm-project/commit/c72a6ac4b630d2344dbea44a7d75fa61795dcd76 DIFF: https://github.com/llvm/llvm-project/commit/c72a6ac4b630d2344dbea44a7d75fa61795dcd76.diff

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

andrew.w.kaylor added a comment. It's not clear to me from reading this how the "precise" control is going to work with relation to the fast math flags. I don't think MSVC allows the granularity of control over these flags that we have in clang, so maybe they don't have this problem. Consider

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun updated this revision to Diff 240650. xazax.hun added a comment. - Add a FIXME. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73376/new/ https://reviews.llvm.org/D73376 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/StaticAnalyzer/Checkers/Pthrea

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:467-475 +// We will use llvm-objcopy to add target objects’ sections to the output +// fat object. These sections should have ‘exclude’ flag set which tells +// link e

[clang] e6d2583 - [OPENMP50]Track changes of lastprivate conditional in parallel-based

Author: Alexey Bataev Date: 2020-01-27T14:53:25-05:00 New Revision: e6d2583e45ef3af7646d4a58bada2e639121 URL: https://github.com/llvm/llvm-project/commit/e6d2583e45ef3af7646d4a58bada2e639121 DIFF: https://github.com/llvm/llvm-project/commit/e6d2583e45ef3af7646d4a58bada2e639121.diff

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM!~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73376/new/ https://reviews.llvm.org/D73376 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

aprantl added a comment. In D73261#1838683 , @probinson wrote: > In D73261#1838552 , @djtodoro wrote: > > > > Is it necessary to use DIFlags? I am willing to do that but generally, it > > > is not welcomed because

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void updated this revision to Diff 240657. void added a comment. Use GNU asm predicate for the "asm goto with outputs" extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319 Files: clang/include/clang

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

nickdesaulniers added a comment. Great idea; thanks for the patch! Needs documentation. :) Comment at: clang/test/Parser/asm-goto-with-outputs.c:7 +#error Extension 'gnu_asm_goto_with_outputs' should be available by default +#endif + probably don't need a bunch

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void added a comment. In D73319#1842900 , @nickdesaulniers wrote: > Great idea; thanks for the patch! Needs documentation. :) I can't find a place for documentation of extensions, at least not the names of extensions like `gnu_asm`.

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void updated this revision to Diff 240663. void marked 2 inline comments as done. void added a comment. Move extension test to exsiting test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319 Files: clang/i

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

arphaman created this revision. arphaman added a reviewer: dexonsmith. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. Some projects use -nostdinc, but need to access some intrinsics files when building specific files. The new `-builtininc` flag lets them use this flag

[PATCH] D73434: [Sema] Remove a -Wrange warning from -Wall

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73434/new/ https://reviews.llvm.org/D73434

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to functions with no Decl

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1917 const auto *NBA = Fn->getAttr(); -bool HasWildcard = NBA && llvm::is_contained(NBA->builtinNames(), "*"); -if (getLangOpts().NoBuiltin || HasWildcard) - FuncAttrs.addAt

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:467-475 +// We will use llvm-objcopy to add target objects’ sections to the output +// fat object. These sections should have ‘exclude’ flag set which tells +// link

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

aaron.ballman accepted this revision. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:58 + } + if (B.isInva

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added a comment. In D72811#1839561 , @ABataev wrote: > In D72811#1839538 , @cchen wrote: > > > In D72811#1837392 , @jdoerfert >

[clang] f4c26d9 - [analyzer] Add FuchsiaLockChecker and C11LockChecker

Author: Gabor Horvath Date: 2020-01-27T13:55:56-08:00 New Revision: f4c26d993bdcb8e5250d774c0d2a6d91fee5ca00 URL: https://github.com/llvm/llvm-project/commit/f4c26d993bdcb8e5250d774c0d2a6d91fee5ca00 DIFF: https://github.com/llvm/llvm-project/commit/f4c26d993bdcb8e5250d774c0d2a6d91fee5ca00.diff

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c26d993bdc: [analyzer] Add FuchsiaLockChecker and C11LockChecker (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D73376?vs=240650&id=240678#toc Repository: rG LLVM Github

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev updated this revision to Diff 240676. sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/ https://reviews.llvm.org/D73408 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOff

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

alexfh added a comment. How is this different from `-Wmissing-prototypes`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73413/new/ https://reviews.llvm.org/D73413 ___ cfe-commits mailing list cfe-comm

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

boga95 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71524/new/ https://reviews.llvm.org/D71524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void updated this revision to Diff 240681. void added a comment. Add description of "gnu_asm_goto_with_outputs" to the language extensions doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319 Files: clang

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. In D72811#1843066 , @cchen wrote: > In D72811#1839561 , @ABataev wrote: > > > In D72811#1839538 , @cchen wrote: > > > > > In D72811#1837392

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

nickdesaulniers added a comment. In D73319#1842951 , @void wrote: > In D73319#1842900 , @nickdesaulniers > wrote: > > > Great idea; thanks for the patch! Needs documentation. :) > > > I can't find a place for docum

[PATCH] D73464: [clang] Add TagDecl AST matcher

alexfh added a comment. A drive-by comment. Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:212 + REGISTER_MATCHER(tagDecl); + REGISTER_MATCHER(tagType); REGISTER_MATCHER(enumConstantDecl); There's already `tagType` registration on the line 497. And

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

dblaikie added inline comments. Comment at: clang/lib/Sema/Sema.cpp:985-986 + +// FIXME: Instantiating implicit templates already in the PCH breaks some +// OpenMP-specific code paths, see https://reviews.llvm.org/D69585 . +if(LangOpts.PCHInstantiateTemplates && !Lang

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Driver/Options.td:503-504 def bind__at__load : Flag<["-"], "bind_at_load">; +def builtininc : Flag<["-"], "builtininc">

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

MaskRay added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1273 + int y; + asm goto("# %0 %1 %2" : "=r"(y) : "r"(x) : : err); + return y; Is the canonical spelling `%l2`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow updated this revision to Diff 240689. wristow added a comment. Used the clearer '!off && !on' (rather than '!(off || on)') in the checks. Added more tests that note the current situation that `-ffast-math` enables FMA. overriding an earlier switch that had disabled it (included a "TODO"

[PATCH] D69876: Allow output constraints on "asm goto"

MaskRay added a comment. Does this depend on D69868 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 ___ cfe-commits mailing l

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow marked 4 inline comments as done. wristow added inline comments. Comment at: clang/test/Driver/fast-math.c:196 +// RUN: %clang -### -ffast-math -ffp-contract=fast -c %s 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-UNSAFE-MATH %s +// wristow wrote: >

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 240691. logan-5 added a comment. Rebased with trunk. Updated whitelist to include more standard designated customization points . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void marked an inline comment as done. void added a comment. In D73319#1843129 , @nickdesaulniers wrote: > In D73319#1842951 , @void wrote: > > > In D73319#1842900 , > > @n

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 240692. void added a comment. Fix extension example, found by eagle-eye @maskray! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/docs/LanguageExtensions.rs

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void marked an inline comment as done. void added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1273 + int y; + asm goto("# %0 %1 %2" : "=r"(y) : "r"(x) : : err); + return y; MaskRay wrote: > Is the canonical spelling `%l2`? Nice c

[PATCH] D69876: Allow output constraints on "asm goto"

void added a comment. In D69876#1843199 , @MaskRay wrote: > Does this depend on D69868 ? Yes. I added it as a parent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/ne

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 updated this revision to Diff 240706. njames93 added a comment. Fix diff, ready to recommit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/ https://reviews.llvm.org/D73098 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp clang-tools-extra/

[clang-tools-extra] c3d20fd - [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

Author: Nathan Date: 2020-01-27T23:47:51Z New Revision: c3d20fd472000c7abdc2c9cad051a2ab339709d9 URL: https://github.com/llvm/llvm-project/commit/c3d20fd472000c7abdc2c9cad051a2ab339709d9 DIFF: https://github.com/llvm/llvm-project/commit/c3d20fd472000c7abdc2c9cad051a2ab339709d9.diff LOG: [clang

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3d20fd47200: [clang-tidy] readability-identifier-naming disregards parameters restrictions… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] 7c90666 - [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

Author: Nathan Date: 2020-01-27T23:51:45Z New Revision: 7c90666d2c3cfb5a519275d89195be317e7cc0ab URL: https://github.com/llvm/llvm-project/commit/7c90666d2c3cfb5a519275d89195be317e7cc0ab DIFF: https://github.com/llvm/llvm-project/commit/7c90666d2c3cfb5a519275d89195be317e7cc0ab.diff LOG: [clang

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c90666d2c3c: [clang-tidy] readability-redundant-string-init now flags redundant… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72448

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 added a comment. In D73413#1843103 , @alexfh wrote: > How is this different from `-Wmissing-prototypes`? This checks variables too, and it looks for a prototype specifically in the header files. missing-prototypes just ensures there is a protot

[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73202/new/ https://reviews.llvm.org/D73202 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman updated this revision to Diff 240716. mwyman marked 7 inline comments as done. mwyman added a comment. Addresses reviewer feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876 Files: clang-tool

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 updated this revision to Diff 240718. njames93 added a comment. - Remove artifacts of old dependent review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73441/new/ https://reviews.llvm.org/D73441 Files: clang-tools-extra/clang-tidy/bugp

[PATCH] D73493: [AArch64][SVE] Add SVE2 intrinsics for uniform DSP operations

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73493/new/ https://reviews.llvm.org/D73493 ___

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman added a comment. Updated the diff based on review feedback. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoriesCheck.cpp:21 + Finder->addMatcher( + objcMethodDecl(hasName("dealloc"), hasDeclContext(objcCategoryImplDecl())) + .bind("dealloc")

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void abandoned this revision. void added a comment. I'm going to merge this into D69876 as it's closely related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

Eugene.Zelenko added a comment. In D73413#1843368 , @njames93 wrote: > In D73413#1843103 , @alexfh wrote: > > > How is this different from `-Wmissing-prototypes`? > > > This checks variables too, and it looks for a

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

Eugene.Zelenko added a comment. Just ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72527/new/ https://reviews.llvm.org/D72527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 240720. void added a comment. Merge "__has_extension" patch into this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/docs/LanguageExtensions.rst c

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62249 tests passed, 0 failed and 816 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang-tools-extra] 6874dfc - [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

Author: Nathan Date: 2020-01-28T00:39:07Z New Revision: 6874dfce3aef4a0d85fc9d45f4c9c3d90cfcbf6e URL: https://github.com/llvm/llvm-project/commit/6874dfce3aef4a0d85fc9d45f4c9c3d90cfcbf6e DIFF: https://github.com/llvm/llvm-project/commit/6874dfce3aef4a0d85fc9d45f4c9c3d90cfcbf6e.diff LOG: [clang

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG6874dfce3aef: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In D72527#1843427 , @Eugene.Zelenko wrote: > Just ping. Are you waiting for other reviewers or for me to "Accept Revision"? If the latter, "stamped"

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

tra updated this revision to Diff 240731. tra edited the summary of this revision. tra added a comment. Use std::string instead of Twine which can't be stored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73231/new/ https://reviews.llvm.org/D73231

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

Eugene.Zelenko added a comment. As I wrote, I don't have GitHub commit access, so I need help with commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72527/new/ https://reviews.llvm.org/D72527 ___ c

<    1   2   3   >