[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. I'm a little uncomfortable about all the tests changing, and I'm unsure if we should be changing the default behaviour. The rules in the past here was to show that this is part of a public style guide. The assumption here is google style wants this. Could you ple

[clang-tools-extra] 70f4c6e - [clan-tidy] Fix false positive in bugprone-infinite-loop

Author: Adam Balogh Date: 2020-01-27T10:13:55+01:00 New Revision: 70f4c6e7b14f225f9628fbdab3620ce037613351 URL: https://github.com/llvm/llvm-project/commit/70f4c6e7b14f225f9628fbdab3620ce037613351 DIFF: https://github.com/llvm/llvm-project/commit/70f4c6e7b14f225f9628fbdab3620ce037613351.diff L

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:387 + unless(inDecltypeOrTemplateArg()), + unless(hasAncestor(cxxNoexceptExpr( .bind("call

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG70f4c6e7b14f: [clan-tidy] Fix false positive in bugprone-infinite-loop (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73270/

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240486. serge-sans-paille added a comment. Improve & comment examples Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/ClangCommandLineRefe

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2685 + if (Args.hasArg(OPT_fsemantic_interposition)) +Opts.SemanticInterposition = 1; + MaskRay wrote: > ` Opts

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

baloghadamsoftware added a comment. Should I also commit it to the release 10.0 branch? This is a bugfix so it should be fixed in the release, I think. I added a dependency between this bug and the 10.0.0 release blockers. Is that enough? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73418/new/ https://reviews.llvm.org/D73418 _

[PATCH] D73449: [Alignment][NFC] Use Align with CreateAlignedLoad

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type. See this thread for context:

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62209 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. This patch adds a simple mechanism to disallow global rename on std symbols. We might extend it to other symbols,

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Use the latest offline version of cppreference. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73451

[clang] 07c9d53 - [Alignment][NFC] Use Align with CreateAlignedLoad

Author: Guillaume Chatelet Date: 2020-01-27T10:58:36+01:00 New Revision: 07c9d5326648802560adbc1b1b61316c7d3c406d URL: https://github.com/llvm/llvm-project/commit/07c9d5326648802560adbc1b1b61316c7d3c406d DIFF: https://github.com/llvm/llvm-project/commit/07c9d5326648802560adbc1b1b61316c7d3c406d.

[PATCH] D73449: [Alignment][NFC] Use Align with CreateAlignedLoad

This revision was automatically updated to reflect the committed changes. Closed by commit rG07c9d5326648: [Alignment][NFC] Use Align with CreateAlignedLoad (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73449/new/ https://re

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

gribozavr2 added a comment. Please talk to Hans Wennborg about cherry-picking this change into the release. I think it is a safe change, if Hans needs that sort of review from someone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73270/new/ htt

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

gribozavr2 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:1276 +namespace PR44667 { +#define REQUIRE(expr) (void)(expr); +struct S {}; njames93 wrote: > gribozavr2 wrote: > > Is the macro a necessary par

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani created this revision. topisani added reviewers: kadircet, klimek. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Solves this issue: https://github.com/clangd/clangd/issues/157 This is my first contribution to an llvm p

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

gribozavr2 added a comment. In D71966#1840957 , @Mordante wrote: > So if I understand correctly: > > - `getParamNameAsWritten` will become `getArgText` > - The `getParamName` will do the translation from the name in the > documentation to the name in the

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 15 errors and 0 warnings

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 marked 3 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:1276 +namespace PR44667 { +#define REQUIRE(expr) (void)(expr); +struct S {}; gribozavr2 wrote: > njames9

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 updated this revision to Diff 240506. njames93 added a comment. - added more unevaluated context checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73441/new/ https://reviews.llvm.org/D73441 Files: clang-tools-extra/clang-tidy/bugpron

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 updated this revision to Diff 240507. njames93 added a comment. - Elide braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73441/new/ https://reviews.llvm.org/D73441 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin updated this revision to Diff 240510. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71460/new/ https://reviews.llvm.org/D71460 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Headers/opencl-c.h clang/test/SemaOpenCL/extension-version.cl Index: clang/t

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

gribozavr2 added a comment. Thank you for the contribution! I didn't review the code thoroughly yet, only the tests. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:29 + + bool isHeader() const { +return llvm::StringSwitch(Extension) -

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin marked 2 inline comments as done. AlexeySotkin added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t i

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:138 IsMainFileOnly = false; - bool IsIndexable = - isa(RenameDecl) && - SymbolCollector::shouldCollectSymbol( - cast(RenameDecl), RenameDecl.getASTContext(), -

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

kadircet added a comment. we seem to be missing some symbols now, like `polymorphic_allocator` `random_shuffle` `gets` etc. and there seems to be a functional change to the parser. Are they intentional, if so why? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62207 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 updated this revision to Diff 240512. njames93 added a comment. - Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73441/new/ https://reviews.llvm.org/D73441 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62206 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 marked 2 inline comments as done. njames93 added a comment. I'll work up those other test cases Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:29 + + bool isHeader() const { +return llvm::StringSwitch(Extension) --

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham created this revision. simon_tatham added reviewers: aaron.ballman, lebedev.ri. Herald added a project: clang. Herald added a subscriber: cfe-commits. The 'z' length modifier, signalling that an integer format specifier takes a `size_t` sized integer, is only supported by the C librar

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62207 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[clang] 0a57d14 - [ASTMatchers] Fix parent traversal with InitListExpr

Author: Stephen Kelly Date: 2020-01-27T11:19:59Z New Revision: 0a57d14abf99333fbfab15fb918a863aa391 URL: https://github.com/llvm/llvm-project/commit/0a57d14abf99333fbfab15fb918a863aa391 DIFF: https://github.com/llvm/llvm-project/commit/0a57d14abf99333fbfab15fb918a863aa391.diff LOG:

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

hokein updated this revision to Diff 240520. hokein added a comment. refine the code to avoid confusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73451/new/ https://reviews.llvm.org/D73451 Files: clang-tools-extra/clangd/CSymbolMap.inc cl

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

hokein added a comment. In D73451#1841510 , @kadircet wrote: > we seem to be missing some symbols now, like `polymorphic_allocator` > `random_shuffle` `gets` etc. yeap, two majoir reasons: - some symbols

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

ostannard added a comment. > It will require changing all possible initializations, with a sensible value. Where are you seeing multiple initializations? It looks like all of the logic for struct layout happens in `CGRecordLowering::lower`, we might need to add a pass there to calculate the val

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 15 errors and 0 warnings

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

kadircet added a comment. In D73451#1841595 , @hokein wrote: > In D73451#1841510 , @kadircet wrote: > > > we seem to be missing some symbols now, like `polymorphic_allocator` > > `random_shuffle` `gets` etc. > > >

[clang] 36a8f7f - [clang-format] Handle escaped " in C# string-literals

Author: Krasimir Georgiev Date: 2020-01-27T12:57:20+01:00 New Revision: 36a8f7f6d8f5a9620b1a091e54abacb517ecfbba URL: https://github.com/llvm/llvm-project/commit/36a8f7f6d8f5a9620b1a091e54abacb517ecfbba DIFF: https://github.com/llvm/llvm-project/commit/36a8f7f6d8f5a9620b1a091e54abacb517ecfbba.d

[PATCH] D73353: [clang-format] Handle escaped " in C# string-literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG36a8f7f6d8f5: [clang-format] Handle escaped " in C# string-literals (authored by krasimir). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[PATCH] D73354: clang-format: insert trailing commas into containers.

krasimir added a comment. An alternative approach (I'm not endorsing this) that would *in theory* circumvent non-idempotency issue (but would be more fiddly~fiddly to implement and spill across different layers of the formatter): This is just a rough idea and can have multiple issues in itself.

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:29 + + bool isHeader() const { +return llvm::StringSwitch(Extension) njames93 wrote: > gribozavr2 wrote: > > I think we should consider any

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM with fixes to the test. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:1276 +namespace PR44667 { +#define REQUIRE(expr) (voi

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein updated this revision to Diff 240528. hokein marked 5 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73450/new/ https://reviews.llvm.org/D73450 Files: clang-tools-extra/cla

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein updated this revision to Diff 240529. hokein added a comment. update the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73450/new/ https://reviews.llvm.org/D73450 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extr

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) kadircet wrote: > `locateDeclAt` is already working on `NamedD

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey created this revision. awpandey added reviewers: probinson, aprantl, dblaikie. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch provides support for //DW_AT_default_value// based on template parameter is default parameter or n

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. Hi @topisani, thanks for working on clangd! Yes that bug fell through the cracks since the logs proposed in the comments were not making use of `-query-driver` option. Do you mind adding some logs to the bug report, without your patch so that we can clearly see its eff

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:29 + + bool isHeader() const { +return llvm::StringSwitch(Extension) gribozavr2 wrote: > njames93

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri updated this revision to Diff 240530. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. For the sake of forward progress, remove overly optimistic alignment annotation, and replace it with FIXME. I have some ideas how to deal with that, but i'd prefer to deal wit

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 marked an inline comment as done. Jac1494 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4598 + if (!(DebugKind == clang::codegenoptions::FullDebugInfo)) +return; aprantl wrote: > nit: > > ``` > if (DebugKind < clang::codege

[PATCH] D73463: [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73463 Files: clang-tools-extra/clangd/unittests/Rename

[PATCH] D73464: [clang] Add TagDecl AST matcher

f00kat created this revision. f00kat added reviewers: aaron.ballman, alexfh, hokein, JonasToth. f00kat added a project: clang. Herald added a subscriber: cfe-commits. In this case https://reviews.llvm.org/D73090#1840501 @aaron.ballman suggest to add new AST matcher for tagDecl to avoid using reco

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. In D71451#1817334 , @aprantl wrote: > In D71451#1816269 , @Jac1494 wrote: > > > ping > > > I'd be curious to the answer to David's questions. If the size increase is > because of unused ext

[PATCH] D73463: [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62207 tests passed, 1 failed and 815 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/lock.pass.cpp {icon check-circle color=

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 updated this revision to Diff 240547. njames93 added a comment. - Fix nits in test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73441/new/ https://reviews.llvm.org/D73441 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveC

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:340 +return false; + if (FDecl->getAccess() == AS_private || FDecl->getAccess() == AS_protected) +return false;

Re: [clang-tools-extra] 58592f6 - Include for std::abort() in clangd

Merged to 10.x in 23d93923900834dd873cde2ea54f7c3a0e071802 On Fri, Jan 24, 2020 at 11:53 AM Dimitry Andric via cfe-commits wrote: > > > Author: Dimitry Andric > Date: 2020-01-24T20:52:37+01:00 > New Revision: 58592f6c49249293f79698cfcb31dba532e12603 > > URL: > https://github.com/llvm/llvm-projec

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

kadircet updated this revision to Diff 240551. kadircet marked 7 inline comments as done. kadircet added a comment. - Propogate types in more cases - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73271/new/ https://reviews.llvm.org/D

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62213 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

kadircet marked 7 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2463 +PreferredType.enterVariableInit(Tok.getLocation(), ThisDecl); ExprResult Init(ParseBraceInitializer()); sammccall wrote: > oops,

[clang] af954e4 - [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

Author: Teresa Johnson Date: 2020-01-27T06:22:24-08:00 New Revision: af954e441a5170a75687699d91d85e0692929d43 URL: https://github.com/llvm/llvm-project/commit/af954e441a5170a75687699d91d85e0692929d43 DIFF: https://github.com/llvm/llvm-project/commit/af954e441a5170a75687699d91d85e0692929d43.diff

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf954e441a51: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73418/new/ htt

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

baloghadamsoftware added a comment. Please consider the following test cases: void test_NullCorrectCheck3() { void *P = aligned_alloc(4, 8); use(*P); // A developer inserted this line before the check by mistake. This will be a null pointer dereference. if (P == NULL) { } }

[PATCH] D73344: [clangd][Hover] Handle uninstantiated templates

kadircet updated this revision to Diff 240559. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73344/new/ https://reviews.llvm.org/D73344 Files: clang-tools-ex

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

thakis added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/CMakeLists.txt:22 + clangToolingCore + ) + Normally we have a single cmake target per CMakeLists.txt. Maybe the library could be in clang-tidy/lib and clang-tidy/tool could use it? The

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. FYI maybe related D33029: [clang-format] add option for dangling parenthesis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73354/new/ https://reviews.llvm.org/D73354

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:257 const NamedDecl *Def = getDefinition(D); -const NamedDecl *Preferred = Def ? Def : D; +if (const NamedDecl *C = llvm::dyn_cast(D->getCanonicalDecl())) + D = C; Is

[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

thakis added a comment. rnk, could you maybe take a look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73202/new/ https://reviews.llvm.org/D73202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

aaron.ballman accepted this revision. aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:340 +return false; + if (FDecl->getAccess() == AS_private || FDecl->getAccess() == AS_protected) +return false;

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

kadircet added a comment. also please fix clang-tidy and format warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73369/new/ https://reviews.llvm.org/D73369 ___ cfe-commits mailing list cfe-commit

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:75 + continue; +if (AnyHeader || File->NamePart.equals_lower(ThisFile->NamePart)) + return; // Found a good candidate for matching decl ---

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

sepavloff added a comment. Could you please rebase the patch against current master? The commit "4aea70ed3292 : [FPEnv] Extended FPOptions with new attributes" changed layout of FPOptions, which affects your patch. Repositor

[PATCH] D73271: [clang][CodeComplete] Support for designated initializers

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62159 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D72703: Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

hans added a comment. > FWIW, I'm not ecstatic about `max_tokens_here`, I thought `max_tokens_lexed` > had a nicer ring to it. /peanut. I mainly like the clarity in the difference between _here and _total. With _lexed, I feel that would not be as clear. CHANGES SINCE LAST ACTION https://rev

[clang] 739b410 - Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

Author: Hans Wennborg Date: 2020-01-27T16:04:17+01:00 New Revision: 739b410f1ff51d507830774320c2db3a80d8610d URL: https://github.com/llvm/llvm-project/commit/739b410f1ff51d507830774320c2db3a80d8610d DIFF: https://github.com/llvm/llvm-project/commit/739b410f1ff51d507830774320c2db3a80d8610d.diff

[PATCH] D72703: Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

This revision was automatically updated to reflect the committed changes. Closed by commit rG739b410f1ff5: Add a warning, flags and pragmas to limit the number of pre-processor tokens in… (authored by hans). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D72703

[PATCH] D73464: [clang] Add TagDecl AST matcher

aaron.ballman added a comment. You should also regenerate the AST matcher documentation by running `clang\docs\tools\dump_ast_matchers.py` Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:211-212 REGISTER_MATCHER(elaboratedType); + REGISTER_MATCHER(tagDecl); + REGIS

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) hokein wrote: > kadircet wrote: > > `locateDeclAt` is alread

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1831 +/// \code +/// void nothrow() noexcpet; +/// void throws();

[PATCH] D73367: [clangd] Go-to-definition on 'override' jumps to overridden method(s)

kadircet added a comment. please fix clang-format and tidy warnings Comment at: clang-tools-extra/clangd/XRefs.cpp:287 +// We may be overridding multiple methods - offer them all. +for (const NamedDecl* ND : CMD->overridden_methods()) { + AddResultDecl(

[clang] 02656f2 - clang-format: [JS] options for arrow functions.

Author: Martin Probst Date: 2020-01-27T16:27:25+01:00 New Revision: 02656f29abda4eedd22e3b2b30bf2f422983514e URL: https://github.com/llvm/llvm-project/commit/02656f29abda4eedd22e3b2b30bf2f422983514e DIFF: https://github.com/llvm/llvm-project/commit/02656f29abda4eedd22e3b2b30bf2f422983514e.diff

[PATCH] D73335: clang-format: [JS] options for arrow functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG02656f29abda: clang-format: [JS] options for arrow functions. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D73335?vs=240202&id=240575#toc Repository: rG LLVM Github Monore

[PATCH] D73344: [clangd][Hover] Handle uninstantiated templates

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62158 tests passed, 5 failed and 811 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp failed:

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-prefer-pre-increment-disable-cpp-opcalls.cpp:44 +}; + +void foo() { njames93 wrote: > JonasToth wrote: > > Test-cases that I would like to see: > > > > - only the

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/CMakeLists.txt:22 + clangToolingCore + ) + thakis wrote: > Normally we have a single cmake target per CMakeLists.txt. Maybe the

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 240584. njames93 marked an inline comment as done. njames93 added a comment. - Added test case when the inc and dec operators are found in a base class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

aaron.ballman added inline comments. Comment at: clang/lib/AST/FormatString.cpp:754 + LO.isMSCompatibilityVersionSpecified() && + !LO.isCompatibleWithMSVC(LangOptions::MSVC2015)) { +// The standard libraries before MSVC2015 didn't support the 'z' length

[clang] 2f63d54 - Restore "[LTO/WPD] Enable aggressive WPD under LTO option"

Author: Teresa Johnson Date: 2020-01-27T07:55:05-08:00 New Revision: 2f63d549f1e1edd165392837aaa53f569f7fb88d URL: https://github.com/llvm/llvm-project/commit/2f63d549f1e1edd165392837aaa53f569f7fb88d DIFF: https://github.com/llvm/llvm-project/commit/2f63d549f1e1edd165392837aaa53f569f7fb88d.diff

[clang-tools-extra] 60249c2 - [clangd] Only re-open files if their flags changed

Author: David Goldman Date: 2020-01-27T10:58:20-05:00 New Revision: 60249c2c3b9e268af6ade0a4be3c883d7d567940 URL: https://github.com/llvm/llvm-project/commit/60249c2c3b9e268af6ade0a4be3c883d7d567940 DIFF: https://github.com/llvm/llvm-project/commit/60249c2c3b9e268af6ade0a4be3c883d7d567940.diff

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62198 tests passed, 0 failed and 815 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D72647: [clangd] Only re-open files if their flags changed

This revision was automatically updated to reflect the committed changes. Closed by commit rG60249c2c3b9e: [clangd] Only re-open files if their flags changed (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/ https://re

Getting started

Hi everyone, My name is Anshil Gandhi and I am currently in my third year of BSc double majoring in Computing Science and Mathematics. I am interested in developing the clang frontend, C++ 1x features implementation in particular. I have cloned the git repository of llvm and explored through vario

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov updated this revision to Diff 240604. ilya-biryukov added a comment. - Use DependencyFlags for TemplateName and NestedNameSpecifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71920/new/ https://reviews.llvm.org/D71920 Files: cla

[PATCH] D73354: clang-format: insert trailing commas into containers.

krasimir added inline comments. Comment at: clang/lib/Format/Format.cpp:1482 +/// ]; +class TrailingCommaInserter : public TokenAnalyzer { +public: sammccall wrote: > Worth a comment (somewhere) about the fact that this never rewraps, in > particular if the

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong edited reviewers, added: teemperor; removed: a.sidorin. martong added a comment. Herald added a reviewer: a.sidorin. @teemperor , @shafik Guys, could you please take a look on this patch? I don't think that type locations could have any effects on LLDB, but one may never know, so, it is

  1   2   3   >