[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:905 + public: + ~$1^Foo() {} + kadircet wrote: > this actually looks troublesome, since we are not returning the functiondecl > anymo

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

mikhail.ramalho updated this revision to Diff 239186. mikhail.ramalho added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Two changes: - Moved the BoolAssignmentChecker changes to separate revision (D73062 ). - Rebase

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 239197. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Finer grain lower bound computations, and simpler control-flow for the checking function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D69978: Separately track input and output denormal mode

arsenm updated this revision to Diff 239196. arsenm added a comment. Herald added a subscriber: kerbowa. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69978/new/ https://reviews.llvm.org/D69978 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Tool

[PATCH] D71566: New checks for fortified sprintf

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62028 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

Jonathan.Crowther updated this revision to Diff 239198. Jonathan.Crowther added a comment. Addressed comments by moving `getLoadModuleFilnameForFunction` to `llvm/lib/Support/SystemUtils.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72736/new/ https://reviews.llvm.org/D72736 File

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 added a comment. hmmm annoyingly this change causes a crash in a side project I'm creating, gotta go bug hunting now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 _

[clang] edd4398 - Revert "PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer."

Author: Mitch Phillips Date: 2020-01-20T16:34:09-08:00 New Revision: edd4398f4cd33a305afbca76ac4e6590e9337f4d URL: https://github.com/llvm/llvm-project/commit/edd4398f4cd33a305afbca76ac4e6590e9337f4d DIFF: https://github.com/llvm/llvm-project/commit/edd4398f4cd33a305afbca76ac4e6590e9337f4d.diff

[PATCH] D49793: [AArch64] - return address signing

hctim added a comment. Herald added a project: LLVM. This change broke the sanitizer buildbots. Please see here for more information: /b/sanitizer-x86_64-linux/build/llvm-pr

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 239208. njames93 added a comment. - Added some sanity tests that fix weird crashes - Added support for CXXMethodDecls that are referenced with depended scope member expr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M where M>0

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, craig.topper, nickdesaulniers, nsz, ostannard, peter.smith. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay added a parent revision: D73071: [X86] Support -fpatchable-function-entry=N,M where M>0

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

hctim added a comment. This change broke the sanitizer buildbots and was reverted here . Please see here for more information: /b/sanitizer-x86_64-li

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62026 tests passed, 1 failed and 783 were skipped. failed: Clang Tools.clang-tidy/checkers/readability-identifier-naming-member-decl-usage.cpp {icon question-circle color=gray} clang-tidy: unknown. {icon times

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked 4 inline comments as done. tejohnson added inline comments. Comment at: llvm/test/Transforms/WholeProgramDevirt/import-indir.ll:2 ; Test that we correctly import an indir resolution for type identifier "typeid1". -; RUN: opt -S -wholeprogramdevirt -wholeprogram

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 239214. tejohnson marked 2 inline comments as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://reviews.llvm.org/D71913 Files: clang/lib/Cod

[PATCH] D73072: [Driver][CodeGen] Support -fpatchable-function-entry=N,M where M>0

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62040 tests passed, 2 failed and 783 were skipped. failed: Clang.CodeGen/patchable-function-entry.c failed: Clang.Driver/fpatchable-function-entry.c {icon question-circle color=gray} clang-tidy: unknown. {ico

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62026 tests passed, 1 failed and 783 were skipped. failed: Clang Tools.clang-tidy/checkers/readability-identifier-naming-member-decl-usage.cpp {icon question-circle color=gray} clang-tidy: unknown. {icon times

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 239218. njames93 added a comment. - rebase master figure out the llvm pre-merge lint test fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 Files: clang-tools-ext

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62040 tests passed, 1 failed and 783 were skipped. failed: Clang Tools.clang-tidy/checkers/readability-identifier-naming-member-decl-usage.cpp {icon question-circle color=gray} clang-tidy: unknown. {icon times

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay added inline comments. Comment at: llvm/lib/IR/Globals.cpp:101 +return true; + return isInterposableLinkage(getLinkage()); +} MaskRay wrote: > Checking `isInterposableLinkage(getLinkage())` first may be more efficient. `if (!isInterposableLinkage(get

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay added a comment. The logic looks good to me. Linkages which were not interposable before and can be interposable now: available_externally, linkonce_odr, weak_odr, external, and appending. `isDefinitionExact` returned true for external before, and can return false if SemanticInterposit

[clang-tools-extra] 38bdb94 - [clangd] Fix rename for explicit destructor calls

Author: Kirill Bobyrev Date: 2020-01-21T05:33:39+01:00 New Revision: 38bdb94120b76f8f79cd27d721892673e573895a URL: https://github.com/llvm/llvm-project/commit/38bdb94120b76f8f79cd27d721892673e573895a DIFF: https://github.com/llvm/llvm-project/commit/38bdb94120b76f8f79cd27d721892673e573895a.diff

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

This revision was automatically updated to reflect the committed changes. Closed by commit rG38bdb94120b7: [clangd] Fix rename for explicit destructor calls (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D72638?vs=239182&id=239227#toc Repository: rG LLVM Github Mon

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

sepavloff added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2537 +if (!Actions.CurContext->isTranslationUnit()) { +//FIXME this seems to be the wrong way to check file-scope +//since the token immediately following a function definition Proba

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added a comment. Please can you regenerate the ClangFormatStyleOptions.rst using docs/tools/dump_style.py and add an entry into the clang release notes in the clang-format section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44609/

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added a comment. I think if you can fix the missing documentation it looks pretty good to go. I do like the use of the static functions and the extensive test cases.. thank you. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1442 +// Search for any p

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 239231. void added a comment. Herald added a subscriber: MatzeB. Split the machine basic block after an INLINEASM_BR instruction that has outputs. The copies then end up in a separate block and the back end doesn't have to deal with COPY instructions between two

[clang] e15fb06 - [RISCV] Pass target-abi via module flag metadata

Author: Zakk Chen Date: 2020-01-20T23:30:54-08:00 New Revision: e15fb06e2d0a068de549464d72081811e7fac612 URL: https://github.com/llvm/llvm-project/commit/e15fb06e2d0a068de549464d72081811e7fac612 DIFF: https://github.com/llvm/llvm-project/commit/e15fb06e2d0a068de549464d72081811e7fac612.diff LOG

[PATCH] D72755: [RISCV] Pass target-abi via module flag metadata

This revision was automatically updated to reflect the committed changes. Closed by commit rGe15fb06e2d0a: [RISCV] Pass target-abi via module flag metadata (authored by Zakk Chen ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

<    1   2