[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:194 +--+--+--+---+ -| devi

Re: [clang] b72a8c6 - PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

cherry-picked in 7a8b8f09daa and fdb501e59f2 Maybe we should expand the release note since this can be a compatibility problem for some? For example it affected Chromium as it broke something in Skia: https://bugs.chromium.org/p/chromium/issues/detail?id=1042470 On Wed, Jan 15, 2020 at 10:18 PM R

[PATCH] D72903: [HIP] use GetProgramPath for executable discovery

DieGoldeneEnte created this revision. DieGoldeneEnte added reviewers: yaxunl, tra. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change replaces the manual building of executable paths using llvm::sys::path::append with GetProgramPath. This enables adding other paths

Re: [clang] e8f198d - Fix pack deduction to only deduce the arity of packs that are actually

Cherry-picked in e241c8fe6d2e6d83e9fb32bd34da8ffcdc0dd83d. Thanks! On Thu, Jan 16, 2020 at 1:22 AM Richard Smith wrote: > > Hi Hans, > > Please consider this bugfix for the Clang 10 release branch. > > On Wed, 15 Jan 2020 at 16:21, Richard Smith via cfe-commits > wrote: >> >> >> Author: Richard

[clang] d293417 - Add __warn_memset_zero_len builtin as a workaround for glibc issue

Author: serge-sans-paille Date: 2020-01-17T09:58:32+01:00 New Revision: d293417931d3a9d46799b42795988ca3b5cfd766 URL: https://github.com/llvm/llvm-project/commit/d293417931d3a9d46799b42795988ca3b5cfd766 DIFF: https://github.com/llvm/llvm-project/commit/d293417931d3a9d46799b42795988ca3b5cfd766.d

[clang] d437fba - Reapply Allow system header to provide their own implementation of some builtin

Author: serge-sans-paille Date: 2020-01-17T09:58:32+01:00 New Revision: d437fba8ef626b6d8b7928540f630163a9b04021 URL: https://github.com/llvm/llvm-project/commit/d437fba8ef626b6d8b7928540f630163a9b04021 DIFF: https://github.com/llvm/llvm-project/commit/d437fba8ef626b6d8b7928540f630163a9b04021.d

Re: [clang] 45d7080 - PR42694 Support explicit(bool) in older language modes as an extension.

Cherry-picked in 0a08d2c4e7830a1b2428c2c77f205ac74fa29899 and 2d2d057ae23036baecb5a2a4a7f929626f46921a. Thanks! On Fri, Jan 17, 2020 at 3:14 AM Richard Smith wrote: > > Also b78e8e0d79c47a6698a0abc10a37b8a253cb6064 which has an extra test file > that I forgot to git add. > > On Wed, 15 Jan 2020

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte updated this revision to Diff 238708. DieGoldeneEnte added a comment. This patch now only adds the executable dirs to the program path, the code to search them is now in D72903 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72806/new/ ht

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

This revision was automatically updated to reflect the committed changes. Closed by commit rGd293417931d3: Add __warn_memset_zero_len builtin as a workaround for glibc issue (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D72827: clang-format: [JS] Handle keyword-named methods.

mprobst added a comment. I've added tests and a fix for try/catch and if/else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72827/new/ https://reviews.llvm.org/D72827 ___ cfe-commits mailing list cfe-

[PATCH] D72827: clang-format: [JS] Handle keyword-named methods.

mprobst added a comment. In D72827#1823895 , @krasimir wrote: > How about `if` and `try`? Is there a list somewhere for all such valid > identifiers? This is a bit annoying - generally speaking, we should parse all keywords in declaration locations as

[PATCH] D72848: Remove some SVN-specific code.

hans added inline comments. Comment at: clang/lib/Basic/Version.cpp:33 #else - StringRef URL(""); + return ""; #endif Eugene.Zelenko wrote: > return {} should be better. Why? I think "" is clearer for a string. Repository: rG LLVM Github Monorepo CHANGES

[clang] 0734fb2 - clang-format: [JS] Handle more keyword-named methods.

Author: Martin Probst Date: 2020-01-17T10:10:16+01:00 New Revision: 0734fb21ed5e267dda1a91e5f8b82f653ac3562d URL: https://github.com/llvm/llvm-project/commit/0734fb21ed5e267dda1a91e5f8b82f653ac3562d DIFF: https://github.com/llvm/llvm-project/commit/0734fb21ed5e267dda1a91e5f8b82f653ac3562d.diff

[PATCH] D72827: clang-format: [JS] Handle keyword-named methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0734fb21ed5e: clang-format: [JS] Handle more keyword-named methods. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D72827?vs=238442&id=238713#toc Repository: rG LLVM Github

Re: [clang] 6b29aa2 - Revert "[OPENMP]Do not use RTTI by default for NVPTX devices."

Cherry-picked to 10.x in 572c7f6fe7b55ce5f7591fb7a445dea27329074a. On Wed, Jan 15, 2020 at 11:42 PM Alexey Bataev via cfe-commits wrote: > > > Author: Alexey Bataev > Date: 2020-01-15T17:42:26-05:00 > New Revision: 6b29aa21180cf14bfb619d38fc4826913cabfb66 > > URL: > https://github.com/llvm/llvm-

Re: [clang] 4456076 - Revert "Further implement CWG 2292"

(Note to self: I double checked that the "Further implement CWG 2292" patch landed just after the 10.x branch, so this revert doesn't need to be cherry-picked there.) On Thu, Jan 16, 2020 at 12:46 AM Amy Huang via cfe-commits wrote: > > > Author: Amy Huang > Date: 2020-01-15T15:46:07-08:00 > New

Re: [clang] 3d210ed - Revert "Allow system header to provide their own implementation of some builtin"

Cherry-picked to 10.x in 9007f06af0e009f41b876ae30e6b1ca96feee02e On Thu, Jan 16, 2020 at 12:04 AM Amy Huang via cfe-commits wrote: > > > Author: Amy Huang > Date: 2020-01-15T15:03:45-08:00 > New Revision: 3d210ed3d1880c615776b07d1916edb400c245a6 > > URL: > https://github.com/llvm/llvm-project/c

[PATCH] D72907: clang-format: [JS] pragmas for tslint, tsc.

mprobst created this revision. mprobst added a reviewer: krasimir. mprobst added a project: clang. tslint and tsc (the TypeScript compiler itself) use comment pragmas of the style: // tslint:disable-next-line:foo // @ts-ignore These must not be wrapped and must stay on their own line, in iso

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

uweigand added a comment. > The constrained fcmp intrinsics don't allow the TRUE/FALSE predicates. Hmm, maybe they should then? The only reason I didn't add them initially was that I wasn't sure they were useful for anything; if they are, it should be straightforward to add them back. Repos

[PATCH] D72910: Fix a bug with clang with object destructor creation, while skipping object initialization - make clang crash

ykfre created this revision. ykfre added a project: clang. Herald added a subscriber: cfe-commits. The following code crashes clang: extern int g; class A { public: A() {}; ~A() {}; }; void b() { if(g) { goto clean_up; } A a; int i =

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

dim added a comment. Eh, no it does not crash clang, at least not here? Instead it gives you a compile error, as it should: cleanup.cpp:15:5: error: cannot jump from this goto statement to its label goto clean_up; ^ cleanup.cpp:20:7: note: jump bypasses v

[PATCH] D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates

This revision was automatically updated to reflect the committed changes. kmclaughlin marked an inline comment as done. Closed by commit rGfe3bb8ec9683: [AArch64][SVE] Add ImmArg property to intrinsics with immediates (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 25afe91 - Fix Wparentheses warning. NFCI.

Author: Simon Pilgrim Date: 2020-01-17T11:26:25Z New Revision: 25afe91fd1b8e26258471007a24f856a0d4b14db URL: https://github.com/llvm/llvm-project/commit/25afe91fd1b8e26258471007a24f856a0d4b14db DIFF: https://github.com/llvm/llvm-project/commit/25afe91fd1b8e26258471007a24f856a0d4b14db.diff LOG:

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

ykfre added a comment. In D72910#1826108 , @dim wrote: > Eh, no it does not crash clang, at least not here? Instead it gives you a > compile error, as it should: > > cleanup.cpp:15:5: error: cannot jump from this goto statement to its label >

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

craig.topper added a comment. In D72906#1826061 , @uweigand wrote: > > The constrained fcmp intrinsics don't allow the TRUE/FALSE predicates. > > Hmm, maybe they should then? The only reason I didn't add them initially > was that I wasn't sure they were

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir added a reviewer: mprobst. Revision a75f8d98d7ac9e557b238a229a9a2647c71feed1 fixed spacing for operators, but caus

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238738. krasimir added a comment. - Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Forma

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

mprobst accepted this revision. mprobst added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:2717 +// operator Foo*() +// dependant on PointerAlignment style. + typo dependent

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 238740. njames93 added a comment. - Streamlined replacement application Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/llvm/LLVM

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238743. krasimir added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/Form

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238741. krasimir added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp clang/unitte

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir marked 3 inline comments as done. krasimir added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2722 +FormatToken *Before = Left.getPreviousNonComment(); +while (Before && Before->isOneOf(tok::kw_const, tok::kw_volatile)) { + Before = Befor

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

krasimir updated this revision to Diff 238746. krasimir added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/Form

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61943 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[clang] 33463cf - clang-format: fix spacing in `operator const char*()`

Author: Krasimir Georgiev Date: 2020-01-17T13:33:41+01:00 New Revision: 33463cfba2be7c8d6c08e666123cc34f114a1f3e URL: https://github.com/llvm/llvm-project/commit/33463cfba2be7c8d6c08e666123cc34f114a1f3e DIFF: https://github.com/llvm/llvm-project/commit/33463cfba2be7c8d6c08e666123cc34f114a1f3e.d

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

This revision was automatically updated to reflect the committed changes. Closed by commit rG33463cfba2be: clang-format: fix spacing in `operator const char*()` (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https:/

[clang] 9835cf1 - clang-format: [JS] pragmas for tslint, tsc.

Author: Martin Probst Date: 2020-01-17T13:39:05+01:00 New Revision: 9835cf159014f40e8ea655d0bb3a341ef7ec34f7 URL: https://github.com/llvm/llvm-project/commit/9835cf159014f40e8ea655d0bb3a341ef7ec34f7 DIFF: https://github.com/llvm/llvm-project/commit/9835cf159014f40e8ea655d0bb3a341ef7ec34f7.diff

[PATCH] D72907: clang-format: [JS] pragmas for tslint, tsc.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9835cf159014: clang-format: [JS] pragmas for tslint, tsc. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72907/new/ https://reviews.ll

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:620 + if (llvm::dyn_cast(E->getMemberDecl())) +NameLocation = E->getEndLoc(); Refs.push_back(ReferenceLoc{E->getQualifierLoc(), kbobyrev wrote: > kadircet wrote:

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Thank you for factoring our this library! I briefly read the UninitializedValues analysis and I also think that this change is a no-op. Comment at: clang/include/cl

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 238753. njames93 added a comment. - added few more functions, fix format error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 Files: clang-tools-extra/clang-tidy/ce

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

dim added a comment. Aha, which version of clang-cl are you using? With the released version of clang-cl 9.0.1, I get a warning instead of an error: cleanup.cpp(15,5): warning: jump from this goto statement to its label is a Microsoft extension [-Wmicrosoft-goto] goto clean

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61941 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

gribozavr2 added a comment. Since I seem to be in the minority about thinking that this check does not pull its weight, I reviewed the code, and will LGTM and push once the few small issues are fixed. Comment at: clang-tools-extra/clang-tidy/bugprone/MisplacedPointerArithmet

Re: [clang] 4456076 - Revert "Further implement CWG 2292"

On Fri, Jan 17, 2020 at 4:40 AM Hans Wennborg via cfe-commits wrote: > > (Note to self: I double checked that the "Further implement CWG 2292" > patch landed just after the 10.x branch, so this revert doesn't need > to be cherry-picked there.) Can confirm. I did the commit after the branch point.

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

hokein added a comment. In D72746#1821097 , @kbobyrev wrote: > The patch could be shorter and slightly less confusing if I preserved 1:1 > `RefKind::Implicit` <-> `index::SymbolKind::Implicit` relation, but I thought > we might want to keep `RefKind` bei

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2910 + + if (Arg *A = Args.getLastArg(options::OPT_fnostack_clash_protection, + options::OPT_fstack_clash_

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 238758. serge-sans-paille marked 5 inline comments as done. serge-sans-paille added a comment. Take into account some of the reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://re

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the new checker -- I've committed on your behalf in 42a0355816d3bc125d59cbd07052c8886e78ca86 Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

spatel added a comment. This follows the reasoning that we discussed in the earlier discussion, but after re-reading the gcc comment in particular, I'm wondering whether this is what we really want to do... If __FAST_MATH__ is purely here for compatibility with gcc, then should we mimic gcc beh

[clang-tools-extra] 42a0355 - Add `bugprone-reserved-identifier`

Author: Logan Smith Date: 2020-01-17T08:44:21-05:00 New Revision: 42a0355816d3bc125d59cbd07052c8886e78ca86 URL: https://github.com/llvm/llvm-project/commit/42a0355816d3bc125d59cbd07052c8886e78ca86 DIFF: https://github.com/llvm/llvm-project/commit/42a0355816d3bc125d59cbd07052c8886e78ca86.diff L

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

broadwaylamb added a comment. In D72717#1824858 , @vvereschaka wrote: > I think it is optimal to pass this parameter directly in the builder > configuration only for libcxx as '-DLLVM_LIT_ARGS="--param > enable_filesystem=False"'. You mean, instead of

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

spatel added reviewers: efriedma, scanon, arsenm, echristo, RKSimon. spatel added a comment. Herald added a subscriber: wdng. Adding potential FP reviewers for question of gcc- (potentially-buggy-) compatibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72675/new/ https://reviews.

[PATCH] D72635: Add "context" capability to Thread Safety Analysis

aaron.ballman added a comment. In D72635#1825219 , @aaronpuchert wrote: > Hmm, I have been wondering about this as well. The way I see it, all of these > things are what we call //capabilities//, and we treat them all the same. The > names are just mean

[PATCH] D68720: Support -fstack-clash-protection for x86

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61960 tests passed, 3 failed and 783 were skipped. failed: Clang.CodeGen/stack-clash-protection.c failed: Clang.Driver/stack-clash-protection.c failed: Clang.Misc/warning-flags.c {icon question-circle color=

[PATCH] D71980: [clang-tidy] Disable Checks on If constexpr statements in template Instantiations for BugproneBranchClone and ReadabilityBracesAroundStatements

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9c46229e4ac: [clang-tidy] Disable Checks on If constexpr statements in template… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71980

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

NoQ added a subscriber: mikhail.ramalho. NoQ added a comment. Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus, a.sidorin, rnkovacs, szepet, baloghadamsoftware. @mikhail.ramalho brought this up in pr41809 so let's revisit this.

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 updated this revision to Diff 238764. njames93 added a comment. - Updated to trunk, fix release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72448/new/ https://reviews.llvm.org/D72448 Files: clang-tools-extra/clang-tidy/readabili

[clang-tools-extra] f9c4622 - [clang-tidy] Disable Checks on If constexpr statements in template Instantiations for BugproneBranchClone and ReadabilityBracesAroundStatements

Author: Nathan Date: 2020-01-17T14:21:38Z New Revision: f9c46229e4ac29053747c96e08c574c6c48d544b URL: https://github.com/llvm/llvm-project/commit/f9c46229e4ac29053747c96e08c574c6c48d544b DIFF: https://github.com/llvm/llvm-project/commit/f9c46229e4ac29053747c96e08c574c6c48d544b.diff LOG: [clang

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

thakis added a comment. Looks like this isn't building on Windows: http://45.33.8.238/win/6039/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72378/new/ https://reviews.llvm.org/D72378 ___ c

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

thakis added a comment. cl.exe prints a different error: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/13716/steps/stage%201%20build/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72378/new/ https://reviews.llvm.org/D72

Re: [PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

On Fri, Jan 17, 2020 at 9:49 AM Nico Weber via Phabricator wrote: > > thakis added a comment. > > Looks like this isn't building on Windows: > http://45.33.8.238/win/6039/step_4.txt Yup, I'm already investigating a fix. ~Aaron > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAS

[clang-tools-extra] bcda877 - Fix a compile error to get bots back to green.

Author: Aaron Ballman Date: 2020-01-17T09:56:04-05:00 New Revision: bcda877b43093459dc52747d35abe0019f8e22e0 URL: https://github.com/llvm/llvm-project/commit/bcda877b43093459dc52747d35abe0019f8e22e0 DIFF: https://github.com/llvm/llvm-project/commit/bcda877b43093459dc52747d35abe0019f8e22e0.diff

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61955 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

pengfei updated this revision to Diff 238769. pengfei marked 7 inline comments as done. pengfei added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72820/new/ https://reviews.llvm.org/D72820 Files: clang/lib/C

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

gribozavr2 added a comment. The only functional change that I see in this patch is in `clang/lib/Tooling/Transformer/Stencil.cpp`. However, I don't understand how that change in the (deprecated) selection() stencil can affect other stencils. Comment at: clang/unittests/Toolin

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

pengfei updated this revision to Diff 238770. pengfei added a comment. Remove unnecessary comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72820/new/ https://reviews.llvm.org/D72820 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Co

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

pengfei marked an inline comment as done. pengfei added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381 + Addend->getType()), +{MulOp0, MulOp1, Addend, MulOp->getOperand(2), MulOp->getOperand(3)}); + else

[PATCH] D72463: [Driver][X86] Add -malign-branch* and -malign-branch-within-32B-boundaries

annita.zhang added a comment. @MaskRay Did you merge it to LLVM 10 branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72463/new/ https://reviews.llvm.org/D72463 ___ cfe-commits mailing list cfe-comm

[clang-tools-extra] 7f4e744 - Another speculative fix for the Windows bots.

Author: Aaron Ballman Date: 2020-01-17T10:23:45-05:00 New Revision: 7f4e744b90ec7a5cd8067cac7032ef36607aa4b8 URL: https://github.com/llvm/llvm-project/commit/7f4e744b90ec7a5cd8067cac7032ef36607aa4b8 DIFF: https://github.com/llvm/llvm-project/commit/7f4e744b90ec7a5cd8067cac7032ef36607aa4b8.diff

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 238775. njames93 marked an inline comment as done. njames93 added a comment. - Fix If stmt and optimise building function name list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

ddcc added a comment. I don't have the time to rebase and retest this currently, so it might be better for someone else to take over this patch. Unfortunately, it's been long enough that I don't remember the details of these changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28955/

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

aaron.ballman added a comment. Thank you for working on this, I think this is a great improvement. I am not super qualified to review the cmake, but it looks eminently reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72875/new/ http

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61956 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Besides the mentioned misindent, the CMake code looks correct. Could you test whether it works with standalone (out-of-LLVM) builds as well? Comment at: clang/docs/CMakeList

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

hubert.reinterpretcast added a comment. In D65761#1814968 , @ajpaverd wrote: > The CFGuard library shouldn't be needed for targets other than ARM, AArch64, > and X86, and it's only being built for these targets. However, it looks like > `llvm-build` is a

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 238781. balazske added a comment. A better (?) implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 Files: clang/include/clang/StaticAnalyzer/Checkers/Che

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

eti-p-doray updated this revision to Diff 238782. eti-p-doray retitled this revision from "Add "context" capability to Thread Safety Analysis" to "Allow arbitrary capability name in Thread Safety Analysis". eti-p-doray added a comment. Allow arbitrary capability CHANGES SINCE LAST ACTION http

[clang] 05c7dc6 - [DataFlow] Factor two worklist implementations out

Author: Gabor Horvath Date: 2020-01-17T08:11:15-08:00 New Revision: 05c7dc66480999574a599ac34d99a4c192d51ba7 URL: https://github.com/llvm/llvm-project/commit/05c7dc66480999574a599ac34d99a4c192d51ba7 DIFF: https://github.com/llvm/llvm-project/commit/05c7dc66480999574a599ac34d99a4c192d51ba7.diff

[clang] 0406b4f - Renamed traverseDecl to TraverseDecl in a test

Author: Dmitri Gribenko Date: 2020-01-17T17:12:23+01:00 New Revision: 0406b4fab94658381ea58db890b07c1a30ff0ae4 URL: https://github.com/llvm/llvm-project/commit/0406b4fab94658381ea58db890b07c1a30ff0ae4 DIFF: https://github.com/llvm/llvm-project/commit/0406b4fab94658381ea58db890b07c1a30ff0ae4.dif

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

eti-p-doray added a comment. Thank you for checking! I updated the changes to lift the restriction. PTAnL? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72635/new/ https://reviews.llvm.org/D72635 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

ymandel marked 2 inline comments as done. ymandel added a comment. In D72274#1826477 , @gribozavr2 wrote: > The only functional change that I see in this patch is in > `clang/lib/Tooling/Transformer/Stencil.cpp`. However, I don't understand how > that ch

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

stevewan added a comment. Provided that you have squashed all changes into the latest commit in your branch, `git diff HEAD^ -U1` should emit the context you need. Adjust the number of lines of context accordingly to fit the size of your files. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

This revision was automatically updated to reflect the committed changes. Closed by commit rG05c7dc664809: [DataFlow] Factor two worklist implementations out (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D72380?vs=238592&id=238785#toc Repository: rG LLVM Github M

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 3 inline comments as done. mibintc added a comment. @sepavloff Thanks a lot for your comments. I added a few replies and I have one question, added inline. Comment at: clang/lib/Parse/ParsePragma.cpp:2522 + IdentifierInfo *II = Tok.getIdentifierInfo(); + Pragm

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. In D72274#1826614 , @ymandel wrote: > In D72274#1826477 , @gribozavr2 > wrote: > > > The only function

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:36 + // one below. + Implicit = 1 << 3, + All = Declaration | Definition | Reference | Implicit, kadircet wrote: > kadircet wrote: > > instead of doing that, could we rather de-co

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev updated this revision to Diff 238786. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address alsmost all comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72746/new/ https://reviews.llvm.org/D72746 Files: cla

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to make use of the `TokenBuffer`, ran into some difficulties when lexing some files and triggering assertions in the process. Will figure it out and update the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review! In D72274#1826634 , @gribozavr2 wrote: > In D72274#1826614 , @ymandel wrote: > > > In D72274#1826477

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Transformer/SourceCode.cpp:128 + // First, lex to the current token (which is the last token of the range that + // we know to be deleted. Then, we process the first token separately from the + // rest based on c

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:882 "10: targets = {ns}\n"}, + // CXX Constructor, destructor and operators. + {R"cpp( hokein wrote: > could we simplify the newly-added test?

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev updated this revision to Diff 238791. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72638/new/ https://reviews.llvm.org/D72638 Files: clang-tools-extr

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61855 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio created this revision. dnsampaio added reviewers: rsmith, rjmccall. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This patch resumes the work of D16586 . According to the AAPCS, volatile bit-fields should be accessed

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[clang] b9d2bf3 - [libTooling] Fix bug in Stencil handling of macro ranges

Author: Yitzhak Mandelbaum Date: 2020-01-17T12:11:25-05:00 New Revision: b9d2bf38e86e6dd8a2f188d9a24f546aa67de8af URL: https://github.com/llvm/llvm-project/commit/b9d2bf38e86e6dd8a2f188d9a24f546aa67de8af DIFF: https://github.com/llvm/llvm-project/commit/b9d2bf38e86e6dd8a2f188d9a24f546aa67de8af.

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

sepavloff added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13129 if (FunctionDecl *F = dyn_cast(CurContext)) { + // If the expression occurs inside an internal global_var_init_function + // then the FunctionDecl is not availble mibint

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d2bf38e86e: [libTooling] Fix bug in Stencil handling of macro ranges (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72274/new/ https

  1   2   >