[PATCH] D72304: [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

jdoerfert added a comment. Phab is not involved in the merge process, it just is a normal git push on top of the llmv-project. Do you have commit rights already? If not I can commit this for you in a few days. Comment at: llvm/lib/Frontend/OpenMP/OMPConstants.cpp:45 ///{ -

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

joerg added a comment. Can this be restricted to Linux? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72304: [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

jdoerfert added a comment. The commit title has a stray `{` instead of `[` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 ___ cfe-commits mailing list cfe-comm

[PATCH] D72890: [xray] Allow instrumenting only function entry and/or only function exit

ianlevesque created this revision. ianlevesque added a reviewer: dberris. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Extend -fxray-instrumentation-bundle to split function-entry and function-exit into two separate options, so that it is poss

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

efriedma added a comment. We currently don't have any mechanism for restricting builtins to specific operating systems. I guess we could add one, but this change doesn't seem like a compelling argument to add that capability. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement

uweigand added a comment. > What are the semantics of vfnmadb with respect to when it rounds vs the > negation? Hmm, interesting. The z/Architecture Principles of Operation states: > The results for each element of VECTOR FP NEGA- > TIVE MULTIPLY AND ADD and VECTOR FP NEGA- > TIVE MULTIPLY A

[clang] 83f4c3a - [modules] Do not cache invalid state for modules that we attempted to load.

Author: Volodymyr Sapsai Date: 2020-01-16T17:12:41-08:00 New Revision: 83f4c3af021cd5322ea10fd1c4e839874c1dae49 URL: https://github.com/llvm/llvm-project/commit/83f4c3af021cd5322ea10fd1c4e839874c1dae49 DIFF: https://github.com/llvm/llvm-project/commit/83f4c3af021cd5322ea10fd1c4e839874c1dae49.di

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

This revision was automatically updated to reflect the committed changes. Closed by commit rG83f4c3af021c: [modules] Do not cache invalid state for modules that we attempted to load. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D72860?vs=238562&id=238668#toc Reposit

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm updated this revision to Diff 238670. arsenm added a comment. Forgot clang parts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/in

[PATCH] D72825: [NFC] Fix options name typo

Jim added a comment. It should be kept for compatibility. These three options may be used in other projects compiled by gcc. Clang should ignore it. https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2757 // subsequent options conflict then emit warning diagnostic. + // TODO: How should this interact with DenormalFP32Math? if (HonorINFs &

[PATCH] D72825: [NFC] Fix options name typo

MaskRay added a comment. > These three options may be used in other projects compiled by gcc. We can add them on demand. I don't see a rationale to add them preemptively. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72825/new/ https://reviews.llv

[clang] b78e8e0 - Add extra test file forgotten in 45d7080.

Author: Richard Smith Date: 2020-01-16T18:13:49-08:00 New Revision: b78e8e0d79c47a6698a0abc10a37b8a253cb6064 URL: https://github.com/llvm/llvm-project/commit/b78e8e0d79c47a6698a0abc10a37b8a253cb6064 DIFF: https://github.com/llvm/llvm-project/commit/b78e8e0d79c47a6698a0abc10a37b8a253cb6064.diff

Re: [clang] 45d7080 - PR42694 Support explicit(bool) in older language modes as an extension.

Also b78e8e0d79c47a6698a0abc10a37b8a253cb6064 which has an extra test file that I forgot to git add. On Wed, 15 Jan 2020 at 18:52, Richard Smith wrote: > Hans, could this change be ported to the Clang 10 branch? In PR42694 the > MSVC stdlib developers requested that Clang support this because th

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. We previously listed first declared members, then implicit operator=, then implicit operator==, then implicit destructors. Per discussion on https://github.com/it

[PATCH] D72890: [xray] Allow instrumenting only function entry and/or only function exit

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Do you mind adding x86 tests too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72890/new/ https://reviews.llvm.org/D72890 __

[clang] 01a6cd4 - Don't dump IR output from this test to stdout.

Author: Richard Smith Date: 2020-01-16T19:19:45-08:00 New Revision: 01a6cd471f019cfeda057c3b1b6fc6213575217c URL: https://github.com/llvm/llvm-project/commit/01a6cd471f019cfeda057c3b1b6fc6213575217c DIFF: https://github.com/llvm/llvm-project/commit/01a6cd471f019cfeda057c3b1b6fc6213575217c.diff

[PATCH] D50360: [Concepts] Requires Expressions

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Parse/Parser.h:804-807 + bool TryAnnotateTypeOrScopeToken(bool ClassTemplateDeductionContext = true); + bool TryAnnotateTypeOrScopeToken

[PATCH] D69740: [profile] Support counter relocation at runtime

phosek updated this revision to Diff 238689. phosek marked an inline comment as done. phosek added a comment. Addressed the comment and also added a test for Linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69740/new/ https://reviews.llvm.org/D

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rjmccall added a comment. I see two reasonable approaches here: we can rely on the implicit members being added in the right order by Sema, as this patch seems to do, or we can broaden the special treatment of implicit virtual functions in the v-table layout code. The latter is more complex (w

[PATCH] D71566: New checks for fortified sprintf

erik.pilkington added reviewers: aaron.ballman, rsmith. erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:422 + size_t StrLen = + std::min(std::max(TypeSize, size_t(1)) - 1, FormatStrRef.size()); + if (!analyze_format_string::Pa

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

sepavloff added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3031 +The ``#pragma float_control`` pragma allows floating-point precision and +floating-point exception behavior to be specified Floating-point precision refers to the number of bit

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

MadCoder updated this revision to Diff 238698. MadCoder added a comment. Added some more tests to make sure it works along inheritance chains as expected CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72747/new/ https://reviews.llvm.org/D72747 Files: clang/lib/Sema/SemaExprObjC.cpp

[clang-tools-extra] 4df94d5 - Revert "[clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS"

Author: Kadir Cetinkaya Date: 2020-01-17T08:51:13+01:00 New Revision: 4df94d5b513c20842f5eeeb1e0d059bfa6741d91 URL: https://github.com/llvm/llvm-project/commit/4df94d5b513c20842f5eeeb1e0d059bfa6741d91 DIFF: https://github.com/llvm/llvm-project/commit/4df94d5b513c20842f5eeeb1e0d059bfa6741d91.dif

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

kadircet added a comment. Hi @jkorous, reverting this as d54d71b67e60 should've fixed this. Please let us know if that's not the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 created this revision. kkwli0 added reviewers: ABataev, RaviNarayanaswamy, jdoerfert. Herald added a subscriber: guansong. Add missing OMP5.0 features. https://reviews.llvm.org/D72901 Files: clang/docs/OpenMPSupport.rst Index: clang/docs/OpenMPSupport.rst

<    1   2   3