[PATCH] D71082: Allow system header to provide their own implementation of some builtin

george.burgess.iv added a comment. (It's interesting to me if gcc doesn't warn about that libcxx code, since the whole point of the gnuc 5.0 check there was "the compiler should check this for us now"...) If a glibc-side fix for this does materialize, IMO `-fgnuc-version=5.0` isn't a good path

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a project: clang. User can select the version of SYCL the compiler will use via the flag -sycl-std, similar to -cl-std. The flag defines the LangOpts.SYCLVersion option to the version of SYCL. The

[PATCH] D72825: [NFC] Fix options name typo

MaskRay added a comment. Can we just delete the options? The misspelled options were added in rC214906 to work around https://clang.debian.net/status.php?version=3.4.2&key=UNKNOWN_ARG . Actually the `-ftree*` options were not used. Apparently our option name

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

rjmccall added a comment. > Didn't we work this out already when John added the alignment tracking stuff? > I remember this bug involving libjpegturbo standalone assembly receiving a > 32-bit argument, and then using the full 64-bit RDI register to read it, but > clang stopped zero extending it

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev updated this revision to Diff 238541. kbobyrev added a comment. Avoid duplicate references by filtering out destructor calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72638/new/ https://reviews.llvm.org/D72638 Files: clang-tools-ext

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() rnk wrote: > rjmccall wrote: > > rnk

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

yaxunl added a comment. What's the use case of this change? Normally clang needs to call opt/llc/lld from the same directory of clang. Why do we need to find them in other directories? Where is TOOLS_BINARY_DIR defined? Also we cannot let the build fail because of lld not found, since users ma

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

rnk added a comment. I agree, raising -fgnuc-version is not an acceptable workaround, and we can't ship a clang that doesn't work with old versions of glibc. I think we need a different workaround. The simplest one I can think of is to make `__warn_memset_zero_len` a recognized builtin that gen

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

rogeeff marked 3 inline comments as done. rogeeff added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.cpp:43-44 + + if (!LocAtFault.isValid()) +return; + aaron.ballman wrote: > rogeeff wrote: > > lebedev.ri wro

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev marked 3 inline comments as done. kbobyrev added a comment. The patch should probably be correct now. I've submitted the issue I encountered while trying to add more tests for this patch since it seems to be a separate issue (hopefully, I'm doing everything correctly while setting up t

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. In D71082#1824563 , @rnk wrote: > The simplest one I can think of is to make `__warn_memset_zero_len` a > recognized builtin that generates no code. +1, simple and easy. > I believe we also branched 10.0 between this

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 added a comment. Great! In that case, I'll need help committing this, as well as the thing it depends on, https://reviews.llvm.org/D72284 (which has also been LGTM'd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72378/new/ https://review

[clang-tools-extra] a881fca - [clangd] Make define outline code action visible

Author: Kadir Cetinkaya Date: 2020-01-16T19:55:02+01:00 New Revision: a881fcafaa5af545b049c5fd69ccaf9c93196640 URL: https://github.com/llvm/llvm-project/commit/a881fcafaa5af545b049c5fd69ccaf9c93196640 DIFF: https://github.com/llvm/llvm-project/commit/a881fcafaa5af545b049c5fd69ccaf9c93196640.dif

[clang-tools-extra] 0474fe4 - [clangd] Print underlying type for decltypes in hover

Author: Kadir Cetinkaya Date: 2020-01-16T19:56:54+01:00 New Revision: 0474fe465d8feebcfd54a16d93ad8518b5625972 URL: https://github.com/llvm/llvm-project/commit/0474fe465d8feebcfd54a16d93ad8518b5625972 DIFF: https://github.com/llvm/llvm-project/commit/0474fe465d8feebcfd54a16d93ad8518b5625972.dif

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

mcberg2017 added a comment. I should do the other DAG combiner fma changes after this is wrapped up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72675/new/ https://reviews.llvm.org/D72675 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D72786: [clang] Set function attributes on SEH filter functions correctly.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, just some test comment tweaks. Comment at: clang/test/CodeGen/exceptions-seh-finally.c:3 +// RUN: %clang_cc1 %s -triple i686-pc-win32 -fms-extensions -emit-llvm -O1 -disable

[PATCH] D72840: [clangd] Make define outline code action visible

This revision was automatically updated to reflect the committed changes. Closed by commit rGa881fcafaa5a: [clangd] Make define outline code action visible (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72840/new/ https://revi

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

tra added a reviewer: beanz. tra added a subscriber: beanz. tra added a comment. LGTM. Added @beanz for the review of CMake file changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72806/new/ https://reviews.llvm.org/D72806 _

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

This revision was automatically updated to reflect the committed changes. Closed by commit rG0474fe465d8f: [clangd] Print underlying type for decltypes in hover (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72498/new/ https:/

[PATCH] D68720: Support -fstack-clash-protection for x86

craig.topper added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:243 + + def warn_fe_stack_clash_protection_inline_asm : Warning< + "Unable to protect inline asm that clobbers stack pointer against stack clash">; Remove "f

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

wristow added a comment. This all sounds good to me. So to make sure we're all on the same page, my understanding is that the plan forward is: 1. Make the Clang change first (including adding another pair of tests for `-ffp-contract=on`). 2. Update the LLVM tests illustrating the current basel

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 238552. tmsriram added a comment. Updated to top of trunk, bug fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGe

[PATCH] D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables

tejohnson updated this revision to Diff 238561. tejohnson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71907/new/ https://reviews.llvm.org/D71907 Files: clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CodeGenModule.c

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

vsapsai created this revision. vsapsai added reviewers: bruno, dexonsmith. Herald added subscribers: cfe-commits, ributzka, jkorous. Herald added a project: clang. Partially reverts 0a2be46cfdb698fefcc860a56b47dde0884d5335 as it turned out to cause redundant module rebuilds in multi-process increm

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson updated this revision to Diff 238565. tejohnson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 Files: clang/test/CodeGenCXX/vcall-visibility-metadata.cpp llvm/include/

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381 + Addend->getType()), +{MulOp0, MulOp1, Addend, MulOp->getOperand(2), MulOp->getOperand(3)}); + else You shouldn't just assume that Mul

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 238569. tejohnson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://reviews.llvm.org/D71913 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CGClass.cpp

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

vsapsai marked an inline comment as done. vsapsai added a comment. Anecdotal build time measurements before and after the change. First row is a clean build, subsequent rows are incremental builds. | Revision | Before change | After change | Change (after - before) | Relative change | | ---

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

spatel added a comment. In D72675#1824659 , @wristow wrote: > This all sounds good to me. > > So to make sure we're all on the same page, my understanding is that the plan > forward is: > > 1. Make the Clang change first (including adding another pair of

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61863 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBu

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

vvereschaka added a comment. Hi Sergej, as far as I understood '--param enable_filesystem=False' argument is libc++ specific, but we pass those parameters to all the library tests. I think it is optimal to pass this parameter directly in the builder configuration only for libcxx as '-DLLVM_LIT_

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

vvereschaka added a comment. May be just keep a note in the comments that this lit parameter is required for the remote libcxx tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72717/new/ https://reviews.llvm.org/D72717 _

[PATCH] D72850: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache

vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72850/new/ https://reviews.llvm.org/D72850 _

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kbobyrev updated this revision to Diff 238586. kbobyrev added a comment. Remove duplicated testt Clangd

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev updated this revision to Diff 238586. kbobyrev added a comment. Remove duplicated testt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72867/new/ https://reviews.llvm.org/D72867 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tool

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

wristow added a comment. > One commit for the clang changes should be ok; it's a very small diff. But > I'm still not sure if the driver change induces frontend diffs that we should > make visible via tests. The only thing I can think of is that it changes whether/when `__FAST_MATH__` is defin

[clang-tools-extra] 40514a7 - [clangd] Add workaround for GCC5 host compilers. NFC.

Author: Michael Liao Date: 2020-01-16T16:05:22-05:00 New Revision: 40514a7d7a3b745ba43c2d014e54a0d78d65d957 URL: https://github.com/llvm/llvm-project/commit/40514a7d7a3b745ba43c2d014e54a0d78d65d957 DIFF: https://github.com/llvm/llvm-project/commit/40514a7d7a3b745ba43c2d014e54a0d78d65d957.diff

[PATCH] D72304: [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim updated this revision to Diff 238591. fghanim marked 9 inline comments as done. fghanim added a comment. Addressing reviewer's comments - fixed styling and naming according to llvm conventions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille added a comment. @akhuang can you confirm this fixes your issue? I've tested locally and it works fine on my side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 __

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. Hmm, we still need to find some basic decl to remap it successfully at the codegen. Not sure that we'll be able to support it in full. It would be good to investigate how we can handle them at the codegen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. >> The simplest one I can think of is to make `__warn_memset_zero_len` a >> recognized builtin that generates no code. > > +1, simple and easy. See https://reviews.llvm.org/D72869 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille created this revision. serge-sans-paille added reviewers: rnk, george.burgess.iv, akhuang. Herald added a project: clang. Herald added a subscriber: cfe-commits. serge-sans-paille added a comment. @akhuang can you confirm this fixes your issue? I've tested locally and it works f

[PATCH] D72304: [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim marked an inline comment as done and an inline comment as not done. fghanim added a comment. Thanks for reviewing this. After I address the last two comments below, How do I merge with llvm using phab? I'd appreciate an llvm specific link if possible. Comment at: llvm

[PATCH] D72867: [clangd] Support renaming designated initializers

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61928 tests passed, 1 failed and 783 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_sharedtimedmutex_requirements/thread_sharedtimedmutex_class/try_lock.pass.cpp {icon que

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun updated this revision to Diff 238592. xazax.hun added a comment. - Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72380/new/ https://reviews.llvm.org/D72380 Files: clang/include/clang/Analysis/FlowSensitive/DataflowValues.h clang/include/clang/Analysis/FlowSensit

[PATCH] D72867: [clangd] Support renaming designated initializers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61929 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

efriedma added a comment. This is very hacky, but it might be the least-bad alternative. I mean, we could change D71082 so it doesn't allow system headers to define memset, but that seems worse. Please add a testcase. Repository: rG LLVM Github Monorepo C

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai created this revision. vsapsai added reviewers: erik.pilkington, ahatanak. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. When a category/extension doesn't repeat a type bound, corresponding type parameter is substituted with `id` when used as a typ

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61933 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow updated this revision to Diff 238595. wristow retitled this revision from "Fix -ffast-math/-ffp-contract interaction" to "[Clang][Driver] Fix -ffast-math/-ffp-contract interaction". wristow added a comment. Changing this to address only the Clang driver aspect, as discussed in the commen

[clang-tools-extra] d5c6b84 - Factor out renaming logic from readability-identifier-naming

Author: Logan Smith Date: 2020-01-16T16:34:56-05:00 New Revision: d5c6b8407c12d39a78f42a216369407cb2d7b511 URL: https://github.com/llvm/llvm-project/commit/d5c6b8407c12d39a78f42a216369407cb2d7b511 DIFF: https://github.com/llvm/llvm-project/commit/d5c6b8407c12d39a78f42a216369407cb2d7b511.diff L

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

ianlevesque updated this revision to Diff 238600. ianlevesque added a comment. fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72873/new/ https://reviews.llvm.org/D72873 Files: clang/include/clang/Basic/CodeGenOptions.def clang/

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

aaron.ballman added a comment. In D72378#1824586 , @logan-5 wrote: > Great! In that case, I'll need help committing this, as well as the thing it > depends on, https://reviews.llvm.org/D72284 (which has also been LGTM'd). Great, can you rebase this patc

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch, I've commit on your behalf in d5c6b8407c12d39a78f42a216369407cb2d7b511 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

ianlevesque created this revision. ianlevesque added a reviewer: dberris. Herald added a project: clang. Herald added a subscriber: cfe-commits. ianlevesque updated this revision to Diff 238600. ianlevesque added a comment. fix clang-format XRay allows tuning by minimum function size, but also a

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This facilitates performing go-to-definition inside comments, strings, invalid code, and dependen

[clang] 8b32192 - [OPENMP]Avoid string concat where possible and use standard name

Author: Alexey Bataev Date: 2020-01-16T16:39:45-05:00 New Revision: 8b321929483ee3c4070a10c457733c1bddd10b51 URL: https://github.com/llvm/llvm-project/commit/8b321929483ee3c4070a10c457733c1bddd10b51 DIFF: https://github.com/llvm/llvm-project/commit/8b321929483ee3c4070a10c457733c1bddd10b51.diff

[PATCH] D69878: Consoldiate internal denormal flushing controls

andrew.w.kaylor added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2311 + bool TrappingMath = true; // overriden by ffp-exception-behavior? bool RoundingFPMath = false; arsenm wrote: > cameron.mcinall

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar created this revision. tstellar added reviewers: rsmith, aaron.ballman, beanz, smeenai, phosek, compnerd. Herald added subscribers: llvm-commits, mgorny. Herald added projects: clang, LLVM. This is an attempt to simply the process of building the clang documentation, which should help av

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61930 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[clang] 202446c - Add BuiltinsHexagonDep.def to clang module map

Author: Krzysztof Parzyszek Date: 2020-01-16T15:54:24-06:00 New Revision: 202446c639fdd27a54c3be268154a7c66af4f36d URL: https://github.com/llvm/llvm-project/commit/202446c639fdd27a54c3be268154a7c66af4f36d DIFF: https://github.com/llvm/llvm-project/commit/202446c639fdd27a54c3be268154a7c66af4f36d

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

cameron.mcinally added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + I don't think it's safe to fuse a FMUL and FADD if the intermediate rounding isn't exactly the same as those individual operations. FMULADD doesn't guarant

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

cameron.mcinally added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + cameron.mcinally wrote: > I don't think it's safe to fuse a FMUL and FADD if the intermediate rounding > isn't exactly the same as those individual operatio

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

cameron.mcinally added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + cameron.mcinally wrote: > cameron.mcinally wrote: > > I don't think it's safe to fuse a FMUL and FADD if the intermediate > > rounding isn't exactly the sam

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61850 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61925 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille updated this revision to Diff 238614. serge-sans-paille added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 Files: clang/include/clang/Basic/Builtins.def cla

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille added a comment. In D72869#1824951 , @efriedma wrote: > This is very hacky, Yeah, I know... > but it might be the least-bad alternative. I mean, we could change D71082 > so it doesn't allow system he

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman created this revision. mwyman added reviewers: stephanemoore, benhamilton. mwyman added projects: clang-tools-extra, clang. Herald added subscribers: cfe-commits, mgehre, mgorny. Such implementations may override the class's own implementation, and even be a danger in case someone later co

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

ABataev added a comment. In D69585#1823969 , @llunak wrote: > In D69585#1821831 , @aganea wrote: > > > What is the error? > > > I take that part back, actually. I don't quite remember anymore what exactly > I did i

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

dmaclach requested changes to this revision. dmaclach added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/docs/clang-tidy/checks/objc-dealloc-in-categories.rst:10 + +Classes implement ``-dealloc` to perform important actions just b

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + cameron.mcinally wrote: > cameron.mcinally wrote: > > cameron.mcinally wrote: > > > I don't think it's safe to fuse a FMUL and FADD if the intermediate > > >

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 ___

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 238620. tmsriram added a comment. clang-formatted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

akhuang added a comment. In D72869#1824927 , @serge-sans-paille wrote: > @akhuang can you confirm this fixes your issue? I've tested locally and it > works fine on my side. Yes, this fixes the __warn_memset_zero_len issue, thanks! Repository: rG LL

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman updated this revision to Diff 238621. mwyman added a comment. Fixed missing end quote pointed out in review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876 Files: clang-tools-extra/clang-tidy/objc/CMakeLists.txt clang-tools-e

[PATCH] D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13347 case SystemZ::BI__builtin_s390_vfnmadb: { llvm::Type *ResultType = ConvertType(E->getType()); Value *X = EmitScalarExpr(E->getArg(0)); What are the semantics of vfn

[PATCH] D72635: Add "context" capability to Thread Safety Analysis

aaronpuchert added a comment. Hmm, I have been wondering about this as well. The way I see it, all of these things are what we call //capabilities//, and we treat them all the same. The names are just meant to make warning messages more readable, because what the analysis considers a capability

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61934 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. In D69585#1825133 , @ABataev wrote: > I thought you were going to add an option or a flag to control the behavior? > If so, just provide an option in tests to avoid triggering of the new > behavior (except for declare_target... te

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

ABataev added a comment. In D69585#1825252 , @llunak wrote: > In D69585#1825133 , @ABataev wrote: > > > I thought you were going to add an option or a flag to control the > > behavior? If so, just provide an option

[clang-tools-extra] 42b3c38 - [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

Author: Jan Korous Date: 2020-01-16T15:07:08-08:00 New Revision: 42b3c38903c9c80e129ce678db7f522967e91eeb URL: https://github.com/llvm/llvm-project/commit/42b3c38903c9c80e129ce678db7f522967e91eeb DIFF: https://github.com/llvm/llvm-project/commit/42b3c38903c9c80e129ce678db7f522967e91eeb.diff LO

[clang] 9b549f2 - AMDGPU: Update clang test

Author: Matt Arsenault Date: 2020-01-16T18:10:29-05:00 New Revision: 9b549f26fab6900b5328c0c6239fd77c7527159c URL: https://github.com/llvm/llvm-project/commit/9b549f26fab6900b5328c0c6239fd77c7527159c DIFF: https://github.com/llvm/llvm-project/commit/9b549f26fab6900b5328c0c6239fd77c7527159c.diff

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 updated this revision to Diff 238640. logan-5 added a comment. Should be good now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72378/new/ https://reviews.llvm.org/D72378 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.c

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG42b3c38903c9: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when… (authored by jkorous). Hera

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte added a comment. In D72806#1824560 , @yaxunl wrote: > What's the use case of this change? > > Normally clang needs to call opt/llc/lld from the same directory of clang. > Why do we need to find them in other directories? My motivation is

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

sammccall added a comment. kadir has a pending (or landed?) fix for this. It's just a usual fragile test - it's asserting the order, but findExplicitReferences just returns the order given by targetDecls which isn't stable. We settled on defining a stable (but arbitrary) order for targetDecl a

[clang] 25b542c - [OPENMP]Do not emit RTTI descriptor for NVPTX devices.

Author: Alexey Bataev Date: 2020-01-16T18:12:50-05:00 New Revision: 25b542c61fe364fa86163723b9e35cb7db28bcb4 URL: https://github.com/llvm/llvm-project/commit/25b542c61fe364fa86163723b9e35cb7db28bcb4 DIFF: https://github.com/llvm/llvm-project/commit/25b542c61fe364fa86163723b9e35cb7db28bcb4.diff

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte updated this revision to Diff 238645. DieGoldeneEnte added a comment. The build doesn't fail anymore if lld is not present, also one can set LLD_BINARY_DIR manually. I also exchanged TOOLS_BINARY_DIR with LLVM_TOOLS_BINARY_DIR, since it is better readable and if compiled with llvm

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

sammccall added a comment. Please revert this, it was already fixed by d54d71b67e60 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72883/new/ https://reviews.llvm.org/D72883 _

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

tra added a comment. In D72806#1825333 , @DieGoldeneEnte wrote: > In D72806#1824560 , @yaxunl wrote: > > > What's the use case of this change? > > > > Normally clang needs to call opt/llc/lld from the same director

[clang] 65eb74e - PointerLikeTypeTraits: Standardize NumLowBitsAvailable on static constexpr rather than anonymous enum

Author: David Blaikie Date: 2020-01-16T15:30:50-08:00 New Revision: 65eb74e94b414fcde6bfa810d1c30c7fcb136b77 URL: https://github.com/llvm/llvm-project/commit/65eb74e94b414fcde6bfa810d1c30c7fcb136b77 DIFF: https://github.com/llvm/llvm-project/commit/65eb74e94b414fcde6bfa810d1c30c7fcb136b77.diff

[PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:81 +set(LLVM_APPEND_VC_REV "@LLVM_APPEND_VC_REV@") + This here should make the standalone build configs w

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte added a comment. In D72806#1825362 , @tra wrote: > In D72806#1825333 , @DieGoldeneEnte > wrote: > > > In D72806#1824560 , @yaxunl wrote: > > > > > What's the

[PATCH] D71469: [AArch64] Add sq(r)dmulh_lane(q) LLVM IR intrinsics

efriedma added a comment. > This makes it impossible to do a neat trick when using NEON intrinsics: one > can load a number of constants using a single vector load, which are then > repeatedly used to multiply whole vectors by one of the constants. This trick > is used for a nice performance up

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

tra added a comment. In D72806#1825400 , @DieGoldeneEnte wrote: > > Even in case we don't add the extra directories for llvm and lld, it would be > a good idea to use the getProgramPath function instead of building it > manually (so only the changes

[clang] fb5fafb - Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

Author: Nico Weber Date: 2020-01-16T19:04:08-05:00 New Revision: fb5fafb23cc2d8613f8be2487afe94d8594a88ce URL: https://github.com/llvm/llvm-project/commit/fb5fafb23cc2d8613f8be2487afe94d8594a88ce DIFF: https://github.com/llvm/llvm-project/commit/fb5fafb23cc2d8613f8be2487afe94d8594a88ce.diff LO

[PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb5fafb23cc2: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well. (authored by thakis). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

<    1   2   3   >