[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

RKSimon added a comment. FMA4 tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

pengfei updated this revision to Diff 238425. pengfei added a comment. Add FMA4 tests. Thanks @RKSimon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 Files: llvm/lib/Target/X86/X86ISelLowering.cpp llv

[PATCH] D72825: [NFC] Fix options name typo

Jim created this revision. Jim added reviewers: efriedma, MaskRay. Herald added a project: clang. Herald added a subscriber: cfe-commits. Jim edited the summary of this revision. 1. -ftree_loop_im -> -ftree-loop-im 2. -ftree_loop_ivcanon -> -ftree-loop-ivcanon 3. -ftree_loop_linear -> -ftree-loop-

[PATCH] D72769: Replace CLANG_SPAWN_CC1 env var with a driver mode flag

sammccall added a comment. Thanks for fixing this. As I understand, the original patch made the new behaviour on-by-default and will make the release, so we want this flag on the release branch too, right? (Happy to file a bug, just want to check first) CHANGES SINCE LAST ACTION https://rev

[PATCH] D72304: [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM with some minor things you should address before the merge. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:90 +// extern ArrayType *KmpCriticalNameTy

[PATCH] D72769: Replace CLANG_SPAWN_CC1 env var with a driver mode flag

hans added a comment. In D72769#1823473 , @sammccall wrote: > As I understand, the original patch made the new behaviour on-by-default and > will make the release, so we want this flag on the release branch too, right? Yes, this is on my list. Thanks fo

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. In D71082#1822925 , @akhuang wrote: > This caused a linker error in chromium: > > ld.lld: error: undefined symbol: __warn_memset_zero_len > > > Apparently now that the glibc memset is being used, __warn_memset_zero_len

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

evgeny777 added a comment. I think this has to be rebased - I see multiple failures when trying to apply Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 ___ cfe

[PATCH] D72761: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

MarkMurrayARM marked an inline comment as done. MarkMurrayARM added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:3658 +// Unpredicated v(max|min)nma +def : Pat<(VTI.Vec (unpred_op (VTI.Vec MQPR:$Qd), (fabs (VTI.Vec MQPR:$Qm, + (VTI.Vec

[clang] ed181ef - [HIP][AMDGPU] expand printf when compiling HIP to AMDGPU

Author: Sameer Sahasrabuddhe Date: 2020-01-16T15:15:38+05:30 New Revision: ed181efa175d3e0acc134e6cd161914e64c7195e URL: https://github.com/llvm/llvm-project/commit/ed181efa175d3e0acc134e6cd161914e64c7195e DIFF: https://github.com/llvm/llvm-project/commit/ed181efa175d3e0acc134e6cd161914e64c7195

[PATCH] D72786: [clang] Set function attributes on SEH filter functions correctly.

sanwou01 updated this revision to Diff 238431. sanwou01 added a comment. Fix tests, thanks rnk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72786/new/ https://reviews.llvm.org/D72786 Files: clang/lib/CodeGen/CGException.cpp clang/test/CodeGen

[PATCH] D71365: expand printf when compiling HIP to AMDGPU

This revision was automatically updated to reflect the committed changes. Closed by commit rGed181efa175d: [HIP][AMDGPU] expand printf when compiling HIP to AMDGPU (authored by sameerds). Herald added a subscriber: kerbowa. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

hans added a comment. It seems that while this commit got pushed to GitHub, it's not actually part of master or any other branches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72630/new/ https://reviews.llvm.org/D72630 ___

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

evgeny777 added a comment. Thanks, I'm still in process of testing (now fixing issue which however is most likely related to devirtualization itself, not to this patch). Meanwhile some of my comments below. Comment at: llvm/test/Transforms/WholeProgramDevirt/import-indir.ll:2

[clang] 736a380 - clang-format: [JS] tests for async wrapping.

Author: Martin Probst Date: 2020-01-16T11:23:11+01:00 New Revision: 736a3802124b57490fa1e67538415a2a77fa731c URL: https://github.com/llvm/llvm-project/commit/736a3802124b57490fa1e67538415a2a77fa731c DIFF: https://github.com/llvm/llvm-project/commit/736a3802124b57490fa1e67538415a2a77fa731c.diff

[PATCH] D70377: clang-format: [JS] tests for async wrapping.

This revision was automatically updated to reflect the committed changes. Closed by commit rG736a3802124b: clang-format: [JS] tests for async wrapping. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70377/new/ https://reviews.l

[PATCH] D71469: [AArch64] Add sq(r)dmulh_lane(q) LLVM IR intrinsics

sanwou01 added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71469/new/ https://reviews.llvm.org/D71469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Makes use of insertion order to stabilize output for multiple decls. Fixes https://bugs.llvm.o

[PATCH] D72777: [clangd] Dont display `` kinds in hover board

This revision was automatically updated to reflect the committed changes. Closed by commit rGb08e8353a89f: [clangd] Dont display `` kinds in hover board (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72777/new/ https:

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. @akhuang : I've reported https://sourceware.org/bugzilla/show_bug.cgi?id=25399 to glibc. According to me this is more of a glibc problem than this patch, and as we have a workaround with `-fgnuc-version=5.0` I think we could apply the patch back. Repository:

[clang-tools-extra] b08e835 - [clangd] Dont display `` kinds in hover board

Author: Kadir Cetinkaya Date: 2020-01-16T11:47:00+01:00 New Revision: b08e8353a89f682861ef947fdb6e229b3de2e37d URL: https://github.com/llvm/llvm-project/commit/b08e8353a89f682861ef947fdb6e229b3de2e37d DIFF: https://github.com/llvm/llvm-project/commit/b08e8353a89f682861ef947fdb6e229b3de2e37d.dif

[PATCH] D72827: clang-format: [JS] Handle keyword-named methods.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. Including `do`, `for`, and `while`, in addition to the previously handled fields. The unit test explicitly uses methods, but this code path handles both fields and methods. Repository: rG LLVM Git

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61895 tests passed, 0 failed and 782 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, hfinkel. Herald added subscribers: llvm-commits, cfe-commits, haicheng, hiraditya, eraman. Herald added projects: clang, LLVM. serge-sans-paille added a comment. @MaskRay no example yet, I'd like your opinion on

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @craig.topper up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. @MaskRay no example yet, I'd like your opinion on the approach first. It has the advantage of being non intrusive to the code base... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille added a comment. @erik.pilkington up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindTarget.cpp:202 +private: + llvm::SmallDenseMap InsertionOrder; llvm::SmallDenseMap Decls; why two maps

[PATCH] D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates

kmclaughlin updated this revision to Diff 238445. kmclaughlin added a comment. - Replace PatLeaf with ImmLeaf & TImmLeaf in the VectorIndex multiclass CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72612/new/ https://reviews.llvm.org/D72612 Files: llvm/include/llvm/IR/IntrinsicsAArch6

[PATCH] D72830: [ARM][MVE][Intrinsics] Take abs() of VMINNMAQ, VMAXNMAQ intrinsics' first arguments.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: dmgreen, simon_tatham. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Fix VMINNMAQ, VMAXNMAQ intrinsics; BOTH arguments have the absolute values taken. Reposit

[PATCH] D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates

kmclaughlin marked an inline comment as done. kmclaughlin added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1108 + def "" : AsmVectorIndexOpnd, PatLeaf<(ty imm), pred>; + def _timm : AsmVectorIndexOpnd, PatLeaf<(ty timm), pred>; +} --

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-initialization-list

baloghadamsoftware updated this revision to Diff 238449. baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 Files: clang-tools-extra/clang-tidy/cppc

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61912 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham abandoned this revision. simon_tatham added a comment. I ended up solving this problem a completely different way, in D72518 . Instead of controlling the behavior I need based on the target architecture, I made it depend on a type attribute on the v

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware updated this revision to Diff 238451. baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71001/new/ https://reviews.llvm.org/D71001 Files: clang-tools-extra/clang-tidy/bugp

[clang] 8a34467 - [Concepts] Fix ConceptSpecializationExpr profiling crash

Author: Saar Raz Date: 2020-01-16T13:39:30+02:00 New Revision: 8a3446746098ba29348bb8f85357dd0b466a6d6e URL: https://github.com/llvm/llvm-project/commit/8a3446746098ba29348bb8f85357dd0b466a6d6e DIFF: https://github.com/llvm/llvm-project/commit/8a3446746098ba29348bb8f85357dd0b466a6d6e.diff LOG:

[PATCH] D72830: [ARM][MVE][Intrinsics] Take abs() of VMINNMAQ, VMAXNMAQ intrinsics' first arguments.

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. Hmm. Somewhere in the back of my head is a worry that we may miss an optimization opportunity in cases such as `max(a, abs(b))` where value-range analysis tells us that `a` is know

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

kadircet updated this revision to Diff 238456. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72826/new/ https://reviews.llvm.org/D72826 Files: clang-tools-extra/clangd/FindTarget.cpp Index: clang-too

[clang] 00c74d0 - Remove release note about in-process-cc1

Author: Hans Wennborg Date: 2020-01-16T13:24:22+01:00 New Revision: 00c74d0b644b9ad31b377d0a07012c090af834e2 URL: https://github.com/llvm/llvm-project/commit/00c74d0b644b9ad31b377d0a07012c090af834e2 DIFF: https://github.com/llvm/llvm-project/commit/00c74d0b644b9ad31b377d0a07012c090af834e2.diff

[PATCH] D72769: Replace CLANG_SPAWN_CC1 env var with a driver mode flag

hans added a comment. Oh, and removed the release note from trunk in 00c74d0b644 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72769/new/ https://reviews.llvm.org/D72769 ___

[PATCH] D72769: Replace CLANG_SPAWN_CC1 env var with a driver mode flag

hans added a comment. In D72769#1823488 , @hans wrote: > In D72769#1823473 , @sammccall wrote: > > > As I understand, the original patch made the new behaviour on-by-default > > and will make the release, so we wan

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61912 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72072: [AST] Respect shouldTraversePostOrder when traversing type locs

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. A test would be nice, but we don't have infrastructure for checking call ordering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72072/n

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:224 +using ValTy = std::pair; +llvm::SmallVector Result; +for (const auto &Elem : Decls) no need for lookups I think ``` Result.resi

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61894 tests passed, 0 failed and 782 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

ychen added a comment. There are some interesting failures that need to be investigated. https://reviews.llvm.org/rG647c3f4e47de8a850ffcaa897db68702d8d2459a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67847/new/ https://reviews.llvm.org/D67847

[clang] 19c5057 - Fix "pointer is null" static analyzer warnings. NFCI.

Author: Simon Pilgrim Date: 2020-01-16T13:02:40Z New Revision: 19c5057e8df62e75b26e881dfc8f8f32686fe75c URL: https://github.com/llvm/llvm-project/commit/19c5057e8df62e75b26e881dfc8f8f32686fe75c DIFF: https://github.com/llvm/llvm-project/commit/19c5057e8df62e75b26e881dfc8f8f32686fe75c.diff LOG:

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

spatel added a comment. In D72675#1823227 , @mcberg2017 wrote: > We crossed that bridge internally at Apple a while ago, meaning I have some > code debt for cleaning up open source for fma formation that uses contract > and reassoc differently than we do

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

kadircet updated this revision to Diff 238469. kadircet marked 3 inline comments as done. kadircet added a comment. - Get rid of redundant sorting step Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72826/new/ https://reviews.llvm.org/D72826 Files:

[clang-tools-extra] d54d71b - [clangd] Make output order of allTargetDecls deterministic

Author: Kadir Cetinkaya Date: 2020-01-16T14:47:28+01:00 New Revision: d54d71b67e602674a255e299a22fe31dee1f3619 URL: https://github.com/llvm/llvm-project/commit/d54d71b67e602674a255e299a22fe31dee1f3619 DIFF: https://github.com/llvm/llvm-project/commit/d54d71b67e602674a255e299a22fe31dee1f3619.dif

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:224 +using ValTy = std::pair; +llvm::SmallVector Result; +for (const auto &Elem : Decls) sammccall wrote: > no need for lookups I think > ``` > Result.resize(Decls.siz

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

This revision was automatically updated to reflect the committed changes. Closed by commit rGd54d71b67e60: [clangd] Make output order of allTargetDecls deterministic (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72826/new/ ht

[PATCH] D72826: [clangd] Make output order of allTargetDecls deterministic

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61912 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

aganea added a comment. Herald added a reviewer: nicolasvasilache. Herald added a subscriber: liufengdb. Ping! Any further comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71775/new/ https://reviews.llvm.org/D71775 ___ cfe-commits ma

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-misplaced-pointer-arithmetic-in-alloc.rst:15 + +void bad_malloc(int n) { + char *p = (char*) malloc(n) + 10; Identification. I think 2 character should b

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-initialization-list

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-prefer-member-initializer.rst:72 + +C(int nn, int mm) : n(nn) { + if (dice()) Please make indentation 2 characters, same as in above code snippe

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson added a comment. In D71911#1823497 , @evgeny777 wrote: > I think this has to be rebased - I see multiple failures when trying to apply I'll rebase it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D72827: clang-format: [JS] Handle keyword-named methods.

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. How about `if` and `try`? Is there a list somewhere for all such valid identifiers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72827/new/

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! In D72373#1809080 , @AlexanderLanin wrote: > FIX-IT isn't quite that obvious. Some options: > > - look for other typedef which con

[PATCH] D72827: clang-format: [JS] Handle keyword-named methods.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM thanks for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72827/new/ https://reviews.llvm.org/D72827 ___ cfe-commits

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

kadircet updated this revision to Diff 238474. kadircet added a comment. - Handle return and parameter types as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72498/new/ https://reviews.llvm.org/D72498 Files: clang-tools-extra/clangd/Hover.c

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

AlexanderLanin added a comment. Thanks for the review! Could someone commit this? As I can not. Alexander Lanin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72373/new/ https://reviews.llvm.org/D72373 ___ cfe-commits mailing list cfe-comm

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61913 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

saar.raz updated this revision to Diff 238478. saar.raz marked 21 inline comments as done. saar.raz added a comment. Address CR comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65042/new/ https://reviews.llvm.org/D65042 Files: .gitignore

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak updated this revision to Diff 238477. llunak added a comment. In D69585#1821831 , @aganea wrote: > What is the error? I take that part back, actually. I don't quite remember anymore what exactly I did in October, but if I now revert the PCH tweak

[PATCH] D72840: [clangd] Make define outline code action visible

kadircet created this revision. kadircet added reviewers: sammccall, usaxena95. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This got forgotten during the process. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D72484: [clang-tidy] Fix check for Abseil internal namespace access

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/NoInternalDependenciesCheck.cpp:43-44 + + if (!LocAtFault.isValid()) +return; + rogeeff wrote: > lebedev.ri wrote: > > Is there test coverage for this? When does/can this h

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc created this revision. mibintc added reviewers: andrew.w.kaylor, kpn, rjmccall, sepavloff. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Intel would like to support #pragma float_control which allows control over precision and exception behavior

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Given that the compiler already has `-Wsign-conversion`, I'm not certain what value is added by this check. Can you explain a bit about why this is the correct approach

[PATCH] D72840: [clangd] Make define outline code action visible

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61913 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] cbaa326 - Removed an unused include from TypeLocVisitor.h

Author: Dmitri Gribenko Date: 2020-01-16T15:57:44+01:00 New Revision: cbaa32650a0b5b17b42fc123de068de69b290bf5 URL: https://github.com/llvm/llvm-project/commit/cbaa32650a0b5b17b42fc123de068de69b290bf5 DIFF: https://github.com/llvm/llvm-project/commit/cbaa32650a0b5b17b42fc123de068de69b290bf5.dif

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp:27-34 +static const char NonReservedMessage[] = +"declaration uses iden

[PATCH] D72089: [Syntax] Build declarator nodes

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:395 } + /// FIXME: use custom iterator instead of 'vector'. + std::vector declarators(); s/iterator/container/ ? Also unclear why a custom one should be used. I also t

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

sammccall accepted this revision. sammccall added a comment. Still LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72498/new/ https://reviews.llvm.org/D72498 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a few nits. Comment at: clang-tools-extra/clang-tidy/cert/NonTrivialTypesLibcMemoryCallsCheck.cpp:71-74 + if (!getLangOpts().CPlusPlus) +return;

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ebevhan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13384 case Stmt::MemberExprClass: { expr = cast(expr)->getBase(); break; ilya wrote: > rsmith wrote: > > ilya wrote: > > > rsmith wrote: > > > > Hmm, don't we need

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

aaron.ballman added a comment. In D71707#1821903 , @jankratochvil wrote: > In D71707#1796671 , @aaron.ballman > wrote: > > > Have you considered language extensions like `__ptr32`, `__ptr64`, > > `__sptr`, and `_

[PATCH] D72848: Remove some SVN-specific code.

thakis created this revision. thakis added a reviewer: hans. $URL$ is an SVN keyword substitution enabled via `svn propset svn:keywords "URL" tools/clang/lib/Basic/Version.cpp`. Now that we no longer use SVN, it's no longer being replaced by anything, and we no longer offer svn exports. So remove

[PATCH] D72850: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache

broadwaylamb created this revision. broadwaylamb added reviewers: vvereschaka, aorlov, andreil99. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. Herald added a project: clang. Depends on D72847 Repository: rG LLVM Github Monorepo https://review

[clang] 237fd94 - [Hexagon] Remove unnecessary case in StringSwitch, NFC

Author: Krzysztof Parzyszek Date: 2020-01-16T10:00:57-06:00 New Revision: 237fd94312526c7aef55f929b51696bba451dab8 URL: https://github.com/llvm/llvm-project/commit/237fd94312526c7aef55f929b51696bba451dab8 DIFF: https://github.com/llvm/llvm-project/commit/237fd94312526c7aef55f929b51696bba451dab8

[clang] fb9413c - Remove some SVN-specific code.

Author: Nico Weber Date: 2020-01-16T11:02:52-05:00 New Revision: fb9413cb84cc422426c81f6464083795e781566b URL: https://github.com/llvm/llvm-project/commit/fb9413cb84cc422426c81f6464083795e781566b DIFF: https://github.com/llvm/llvm-project/commit/fb9413cb84cc422426c81f6464083795e781566b.diff LO

[PATCH] D72848: Remove some SVN-specific code.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb9413cb84cc: Remove some SVN-specific code. (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72848/new/ h

[clang] 7f5f6ff - [Hexagon] Add preprocessor test for hexagonv66

Author: Krzysztof Parzyszek Date: 2020-01-16T10:18:58-06:00 New Revision: 7f5f6ff5476b6dafb5be2f9c102d9b324a313717 URL: https://github.com/llvm/llvm-project/commit/7f5f6ff5476b6dafb5be2f9c102d9b324a313717 DIFF: https://github.com/llvm/llvm-project/commit/7f5f6ff5476b6dafb5be2f9c102d9b324a313717

[PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

thakis added a comment. A very late follow-up to my question in D37272 :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72855/new/ https://reviews.llvm.org/D72855 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

thakis created this revision. thakis added a reviewer: rnk. Herald added a subscriber: mgorny. Herald added a project: LLVM. thakis added a comment. A very late follow-up to my question in D37272 :) When LLVM_APPEND_VC_REV=OFF is set, the current git hash is no

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. I am experimenting with somewhat other check algorithm for this problem, the review of this code can be suspended for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 __

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 238513. tnorth added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Thanks for your time and feedback. - Update diff with context, - remove public declaration of LoadConfigFile, - change prototype of LoadConfigFile and simpli

[clang] bc413da - [Hexagon] Fix alignment info for __builtin_circ_lduh

Author: Krzysztof Parzyszek Date: 2020-01-16T10:54:45-06:00 New Revision: bc413da0865d6c0dba1c39f185298806c60890e3 URL: https://github.com/llvm/llvm-project/commit/bc413da0865d6c0dba1c39f185298806c60890e3 DIFF: https://github.com/llvm/llvm-project/commit/bc413da0865d6c0dba1c39f185298806c60890e3

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7709-7712 isa(Next->getAssociatedExpression()) || isa(Next->getAssociatedExpression()) || -isa(Next->getAssocia

[clang] 7acfda6 - [llvm] Make new pass manager's OptimizationLevel a class

Author: Mircea Trofin Date: 2020-01-16T09:00:56-08:00 New Revision: 7acfda633f1378344efde22bfed242dd56c26cdd URL: https://github.com/llvm/llvm-project/commit/7acfda633f1378344efde22bfed242dd56c26cdd DIFF: https://github.com/llvm/llvm-project/commit/7acfda633f1378344efde22bfed242dd56c26cdd.diff

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

This revision was automatically updated to reflect the committed changes. Closed by commit rG7acfda633f13: [llvm] Make new pass manager's OptimizationLevel a class (authored by mtrofin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72547/new/ https

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. Not sure that we need to dig that deep. Maybe just keep thw original analysis for the known expressions and map all other lvalues without some extra analysis, just like DeclRefExpr nodes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson marked 2 inline comments as done. tejohnson added inline comments. Comment at: llvm/test/Transforms/WholeProgramDevirt/import-indir.ll:2 ; Test that we correctly import an indir resolution for type identifier "typeid1". -; RUN: opt -S -wholeprogramdevirt -wholeprogram

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware updated this revision to Diff 238527. baloghadamsoftware retitled this revision from "[clang-tidy] New check cppcoreguidelines-prefer-initialization-list" to "[clang-tidy] New check cppcoreguidelines-prefer-initializer". baloghadamsoftware added a comment. Indentation of the c

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev planned changes to this revision. kbobyrev added a comment. Going to investigate few interesting cases of `findExplicitReferences` not working as intended and opting out for a clean approach that prevents duplicates from getting into the reference set. Comment at: cl

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware updated this revision to Diff 238528. baloghadamsoftware added a comment. Indentation of the code fixed in the documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71001/new/ https://reviews.llvm.org/D71001 Files: clang-tools-extra/clang-tidy/bugprone/Bugpr

[PATCH] D72635: Add "context" capability to Thread Safety Analysis

aaron.ballman added reviewers: aaronpuchert, delesley. aaron.ballman added a comment. In D72635#1822686 , @eti-p-doray wrote: > I added an example in the description. > > From doc https://clang.llvm.org/docs/ThreadSafetyAnalysis.html, > it sounds like we

[PATCH] D72848: Remove some SVN-specific code.

Eugene.Zelenko added inline comments. Comment at: clang/lib/Basic/Version.cpp:33 #else - StringRef URL(""); + return ""; #endif return {} should be better. Comment at: clang/lib/Basic/Version.cpp:42 #else - StringRef URL(""); + return ""

[clang] cebba7c - [SystemZ] Avoid unnecessary conversions in vecintrin.h

Author: Ulrich Weigand Date: 2020-01-16T18:58:14+01:00 New Revision: cebba7ce3952c8f37a923fa3a10360fd4c463775 URL: https://github.com/llvm/llvm-project/commit/cebba7ce3952c8f37a923fa3a10360fd4c463775 DIFF: https://github.com/llvm/llvm-project/commit/cebba7ce3952c8f37a923fa3a10360fd4c463775.diff

[PATCH] D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement

uweigand added a comment. A few comments (see inline) -- otherwise this looks good to me, thanks! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13354 + return Builder.CreateFNeg(Builder.CreateConstrainedFPCall(F, {X, Y, Z}), "neg"); + +} else { Spuriou

  1   2   3   >