[PATCH] D72334: [Syntax] Build nodes for template declarations.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:190 + // Set role for the node that may or may not be delayed. Node must span + // exactly \p Range. + void

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

jyknight added a comment. In D67847#1693694 , @rnk wrote: > In D67847#1691898 , @jyknight wrote: > > > The `abort()` function raises SIGABRT, for which the default behavior is to > > trigger a coredump. Do we actua

[PATCH] D72073: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

gribozavr2 added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5556 + SourceLocation StarLoc = Tok.getLocation(); SourceLocation Loc = ConsumeToken(); D.SetRangeEnd(Loc); ConsumeToken() returns Tok.getLocation(), so why do we need

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

ychen added a comment. Apologies that it takes so long. I'll fix the test and land it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67847/new/ https://reviews.llvm.org/D67847 ___ cfe-commits mai

[PATCH] D72635: Add "context" capability to Thread Safety Analysis

eti-p-doray added a comment. I added an example in the description. From doc https://clang.llvm.org/docs/ThreadSafetyAnalysis.html, it sounds like we should be allowed to declare our class with CAPABILITY("context"), but it turns out that only "mutex" and "role" are allowed. I could otherwise

[clang] 388eaa1 - Work around PR43337: don't try to use the vec_sel overloads for vector long long, since clang's doesn't provide it yet!

Author: Richard Smith Date: 2020-01-15T13:14:57-08:00 New Revision: 388eaa1270c2762d61b756759b6db8cf15bd3a83 URL: https://github.com/llvm/llvm-project/commit/388eaa1270c2762d61b756759b6db8cf15bd3a83 DIFF: https://github.com/llvm/llvm-project/commit/388eaa1270c2762d61b756759b6db8cf15bd3a83.diff

[clang] b72a8c6 - PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

Author: Richard Smith Date: 2020-01-15T13:14:57-08:00 New Revision: b72a8c65e4e34779b6bc9e466203f553f5294486 URL: https://github.com/llvm/llvm-project/commit/b72a8c65e4e34779b6bc9e466203f553f5294486 DIFF: https://github.com/llvm/llvm-project/commit/b72a8c65e4e34779b6bc9e466203f553f5294486.diff

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

emilio added a comment. In D72742#1822554 , @rnk wrote: > +@chandlerc @rjmccall > > Didn't we work this out already when John added the alignment tracking stuff? > I remember this bug involving libjpegturbo standalone assembly receiving a > 32-bit argume

Re: [clang] b72a8c6 - PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

Hi Hans, This flag flip just missed the branch point; can it be applied to the Clang 10 branch? (You'll also need 388eaa1.) Let me know if that's OK, and I'll remove the changes to the release notes from master. (Otherwise the version number in which this applies needs to be bumped.) On Wed, 15 J

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb72a8c65e4e3: PR17164: Change clang's default behavior from -flax-vector-conversions=all to… (authored by Richard Smith , committed by rsmith). Changed prior to commit: http

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

mtrofin updated this revision to Diff 238352. mtrofin marked 4 inline comments as done. mtrofin added a comment. Herald added a subscriber: zzheng. Incorporated feedback: - tests - updated patch description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D50360: [Concepts] Requires Expressions

saar.raz marked 4 inline comments as done. saar.raz added a comment. Addressed comments in latest diff. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2714-2716 + if (RetReq.isTypeConstraint()) +TRY_TO(TraverseTemplateParameterListHelper( +

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte created this revision. DieGoldeneEnte added a reviewer: yaxunl. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. The previous code constructed the executable paths for llvm-link, opt, lld, llc and clang-offload-bundler for the path to the compiler. This

[PATCH] D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with one question Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1108 + def "" : AsmVectorIndexOpnd, PatLeaf<(ty imm), pred>; + def _timm : AsmVectorIn

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

rnk added a comment. In D72742#1822709 , @emilio wrote: > GCC does avoid the zero-extension on the caller sometimes, when not required > by the language and when its optimizer finds it suitable. I believe at the time, faced with ambiguity in the documen

[PATCH] D50360: [Concepts] Requires Expressions

rsmith added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2296 + S.flush(); + if (Buf.find("typename ") != 0) +OS << "typename "; I can see why this is the most straightforward way to implement this, but ... yuck. Please add a FIX

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. @MyDeveloperDay gentle ping for help merging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 ___ cfe-commits mailing list cfe-commits@

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

xazax.hun created this revision. xazax.hun added reviewers: mgehre, ymandel, gribozavr2, aaron.ballman, rsmith, rjmccall. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs, mgorny. This patch corresponds to this RFC: http://lists.llvm.o

Re: [clang] 23058f9 - [OPENMP]Do not use RTTI by default for NVPTX devices.

Alexey, This breaks compilation of our cuda code which happens to transitively include protobuf headers. Can you, please, revert it for now until we figure out how RTTI should be handled? --Artem On Tue, Jan 14, 2020 at 3:15 PM Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote:

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

akhuang added a comment. This caused a linker error in chromium: ld.lld: error: undefined symbol: __warn_memset_zero_len Apparently now that the glibc memset is being used, __warn_memset_zero_len gets called from libc++ code (https://github.com/llvm/llvm-project/blob/b72a8c65e4e34779b6bc9e46

[clang] 6b29aa2 - Revert "[OPENMP]Do not use RTTI by default for NVPTX devices."

Author: Alexey Bataev Date: 2020-01-15T17:42:26-05:00 New Revision: 6b29aa21180cf14bfb619d38fc4826913cabfb66 URL: https://github.com/llvm/llvm-project/commit/6b29aa21180cf14bfb619d38fc4826913cabfb66 DIFF: https://github.com/llvm/llvm-project/commit/6b29aa21180cf14bfb619d38fc4826913cabfb66.diff

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

NoQ added a comment. I'm excited about this effort!~ The change in uninitialized values analysis gives me a bit of anxiety. Could you explain what exactly has changed that caused the change in the stats and why you think it doesn't make a difference, maybe give an example? (an example could be

Re: [clang] 23058f9 - [OPENMP]Do not use RTTI by default for NVPTX devices.

Thank you. In general, RTTI should probably be treated similar to how we deal with inline assembly and ignore errors if they are in the code that we're not going to codegen during this side of compilation. E.g. during host-side compilation we don't complain about GPU-side registers in inline assem

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. In OpenMP 5.0 we allow: int *p; int **p; struct S { int struct *sp; double *d; struct S **sp_ar

[PATCH] D70700: [WebAssembly] Mangle the argc/argv `main` as `__main_argc_argv`

sunfish added a comment. @sbc100 Friendly ping :-). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70700/new/ https://reviews.llvm.org/D70700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D50360: [Concepts] Requires Expressions

rsmith added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:144-148 + struct SubstitutionDiagnostic { +StringRef SubstitutedEntity; +SourceLocation DiagLoc; +StringRef DiagMessage; + }; Please add a FIXME to store the diagnostic

[clang] 3d210ed - Revert "Allow system header to provide their own implementation of some builtin"

Author: Amy Huang Date: 2020-01-15T15:03:45-08:00 New Revision: 3d210ed3d1880c615776b07d1916edb400c245a6 URL: https://github.com/llvm/llvm-project/commit/3d210ed3d1880c615776b07d1916edb400c245a6 DIFF: https://github.com/llvm/llvm-project/commit/3d210ed3d1880c615776b07d1916edb400c245a6.diff LOG

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

akhuang added a comment. Reverted in 3d210ed3d1880c615776b07d1916edb400c245a6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 ___

Re: [clang] 23058f9 - [OPENMP]Do not use RTTI by default for NVPTX devices.

On Wed, Jan 15, 2020 at 2:52 PM Alexey Bataev wrote: > 1. The problem is that it does not produce errors, > ATM, it does produce errors when it's disabled. > it leads to the emission of some declaration that cannot be resolved by > the linker. This what I was trying to avoid. > I'm OK with disab

[PATCH] D70700: [WebAssembly] Mangle the argc/argv `main` as `__main_argc_argv`

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5589 + // alias for "main" in the no-argument case so that libc can detect when + // new-style no-argument main is in us

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7709-7712 isa(Next->getAssociatedExpression()) || isa(Next->getAssociatedExpression()) || -isa(Next->getAssociatedExpression())) && +

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun added a comment. In D72380#1822927 , @NoQ wrote: > The change in uninitialized values analysis gives me a bit of anxiety. Could > you explain what exactly has changed that caused the change in the stats and > why you think it doesn't make a dif

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun added a comment. In D72380#1823019 , @xazax.hun wrote: > In D72380#1822927 , @NoQ wrote: > > > The change in uninitialized values analysis gives me a bit of anxiety. > > Could you explain what exactly has

[clang] b841b9e - [OPENMP]Use regular processing of vtable used when TU is a prefix.

Author: Alexey Bataev Date: 2020-01-15T18:42:23-05:00 New Revision: b841b9e96e605bed5a1f9b846a07aae88c65ce02 URL: https://github.com/llvm/llvm-project/commit/b841b9e96e605bed5a1f9b846a07aae88c65ce02 DIFF: https://github.com/llvm/llvm-project/commit/b841b9e96e605bed5a1f9b846a07aae88c65ce02.diff

[clang] 4456076 - Revert "Further implement CWG 2292"

Author: Amy Huang Date: 2020-01-15T15:46:07-08:00 New Revision: 44560762c62d72a103bdceff49ffa70451efd5f8 URL: https://github.com/llvm/llvm-project/commit/44560762c62d72a103bdceff49ffa70451efd5f8 DIFF: https://github.com/llvm/llvm-project/commit/44560762c62d72a103bdceff49ffa70451efd5f8.diff LOG

Re: [clang] 23058f9 - [OPENMP]Do not use RTTI by default for NVPTX devices.

On Wed, Jan 15, 2020 at 3:09 PM Alexey Bataev wrote: > And I disabled it only for device side, which is NVPTX, no? Can host side > target class report that the target is NVPTX? If you look at the patch, it > disable RTTI only if current triple is NVPTX. Can it be true for the host? > You are corr

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun added a comment. Here is an example: void f() { int i; while (i < 42 && i) { if (i) &i; } } This takes 17 visits before, 16 after. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72380/new/ https://reviews.llvm.org/D72380 __

[PATCH] D44352: [Concepts] Type Constraints

ychen added a comment. I saw a null pointer dereference for the `p3-2a.cpp` file added here. It is not always reproducible for me, I was able to reproduce it once offline. Any idea? Crash stack is here: https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-1220/console-log.txt From D

[clang] e8f198d - Fix pack deduction to only deduce the arity of packs that are actually

Author: Richard Smith Date: 2020-01-15T16:21:08-08:00 New Revision: e8f198dd9e9dabed8d50276465906e7c8827cada URL: https://github.com/llvm/llvm-project/commit/e8f198dd9e9dabed8d50276465906e7c8827cada DIFF: https://github.com/llvm/llvm-project/commit/e8f198dd9e9dabed8d50276465906e7c8827cada.diff

Re: [clang] e8f198d - Fix pack deduction to only deduce the arity of packs that are actually

Hi Hans, Please consider this bugfix for the Clang 10 release branch. On Wed, 15 Jan 2020 at 16:21, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2020-01-15T16:21:08-08:00 > New Revision: e8f198dd9e9dabed8d50276465906e7c8827cada > > URL: > h

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk added inline comments. Comment at: compiler-rt/lib/ubsan/ubsan_value.cpp:29 +const char *__ubsan::getObjCClassName(ValueHandle Pointer) { +#if defined(__APPLE__) + // We need to query the ObjC runtime for some information, but do not want delcypher wrote: >

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk updated this revision to Diff 238393. vsk marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 Files: clang/docs/UndefinedBehaviorSanitizer.rst clang/include/clang/Basic/Sanitizers.def clang/lib/CodeGen/CGObj

[PATCH] D69868: Allow "callbr" to return non-void values

void marked an inline comment as done. void added inline comments. Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:701 + } else if (MBB->succ_size() == LandingPadSuccs.size() || + MBB->succ_size() == IndirectPadSuccs.size()) { // It's possible that

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

wristow marked an inline comment as done. wristow added inline comments. Comment at: llvm/test/CodeGen/PowerPC/fmf-propagation.ll:201-203 ; fma(X, 7.0, X * 42.0) --> X * 49.0 -; This is the minimum FMF needed for this transform - the FMA allows reassociation. +; This is the min

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

mcberg2017 added a comment. We crossed that bridge internally at Apple a while ago, meaning I have some code debt for cleaning up open source for fma formation that uses contract and reassoc differently than we do today, both together and separately, case by case. CHANGES SINCE LAST ACTION

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

tycho added a comment. I did some local work to make this build and pass almost all tests on Linux as well, not to make use of the multi-process features but just to avoid having a separate "for Windows only" branch, and to ensure tests pass across platforms. Unfortunately my change is not at a

[clang] 45d7080 - PR42694 Support explicit(bool) in older language modes as an extension.

Author: Richard Smith Date: 2020-01-15T18:38:23-08:00 New Revision: 45d70806f4386adfb62b0d75949a8aad58e0576f URL: https://github.com/llvm/llvm-project/commit/45d70806f4386adfb62b0d75949a8aad58e0576f DIFF: https://github.com/llvm/llvm-project/commit/45d70806f4386adfb62b0d75949a8aad58e0576f.diff

Re: [clang] 45d7080 - PR42694 Support explicit(bool) in older language modes as an extension.

Hans, could this change be ported to the Clang 10 branch? In PR42694 the MSVC stdlib developers requested that Clang support this because their standard library will soon rely on it. On Wed, 15 Jan 2020 at 18:50, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richa

[PATCH] D72820: Add pragma FP_CONTRACT support.

pengfei created this revision. pengfei added reviewers: craig.topper, andrew.w.kaylor, uweigand, RKSimon, LiuChen3. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, hiraditya. Herald added projects: clang, LLVM. Support pragma FP_CONTRACT. Repository: rG LLVM Github Monorepo h

[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

rsmith added a comment. I think this might work out more cleanly if we represented a constrained auto type as a `ConstrainedType` node wrapping an `AutoType` node rather than putting both things into the same object. (This will become more pressing if/when C++ starts allowing, for example, cons

[PATCH] D72820: Add pragma FP_CONTRACT support.

pengfei updated this revision to Diff 238408. pengfei added a comment. Remove dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72820/new/ https://reviews.llvm.org/D72820 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGen/cons

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

aganea added a comment. Hi @tycho ! Sorry for not getting back earlier. I implemented an alternate approach last year, which proved to be better (in terms of build times) than what I proposed in this demo patch. That is, using a thread pool instead of the process pool as implemented here. This m

[PATCH] D72820: Add pragma FP_CONTRACT support.

craig.topper added a comment. The title of this review is misleading. It should at least mention FPEnv, constrained intrinsics, or strict fp or something. Right now it sounds like FP_CONTRACT isn't supported at all. Can we split most of the X86 changes into a separate patch? Most of it can be

[PATCH] D72820: Add pragma FP_CONTRACT support.

craig.topper added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7064 + + auto pushOutChain = [&]() { +assert(Result.getNode()->getNumValues() == 2); Can you make the SDValue Result an argument of this and only capture 't

[PATCH] D50360: [Concepts] Requires Expressions

saar.raz marked an inline comment as done. saar.raz added a comment. Addressed comments in latest diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50360/new/ https://reviews.llvm.org/D50360 ___ cfe-

[PATCH] D72820: Add pragma FP_CONTRACT support.

pengfei updated this revision to Diff 238414. pengfei marked an inline comment as done. pengfei added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72820/new/ https://reviews.llvm.org/D72820 Files: clang/lib/C

[PATCH] D72820: Add pragma FP_CONTRACT support.

craig.topper added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7061 + auto pushOutChain = [this](auto &Result, auto EB) { +assert(Result.getNode()->getNumValues() == 2); Why is Result a reference? It's not modified is

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

pengfei created this revision. pengfei added reviewers: craig.topper, andrew.w.kaylor, uweigand, RKSimon, LiuChen3. pengfei added a project: LLVM. X86 has instructions to calculate fma and fneg at the same time. But we combine the fneg and fma only when fneg is the source operand under strict FP

[PATCH] D72820: Add pragma FP_CONTRACT support.

pengfei updated this revision to Diff 238417. pengfei marked an inline comment as done. pengfei added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72820/new/ https://reviews.llvm.org/D72820 Files: clang/lib/Co

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM One thing to consider changing/removing in the summary is this comment: "For example, (enum) "Level > 1" captures not only O2 and O3

<    1   2