[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill added a comment. In D62686#1820816 , @apazos wrote: > Lewis, your latest patch looks good, we just had another run with no new > failures. But we know it will have issues with -g. So I think we should not > merge it yet. Do you have a versio

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-initialization-list

baloghadamsoftware updated this revision to Diff 238192. baloghadamsoftware retitled this revision from "[clang-tidy][WIP] New check readability-prefer-initialization-list" to "[clang-tidy][WIP] New check cppcoreguidelines-prefer-initialization-list". baloghadamsoftware added a comment. Herald ad

[PATCH] D72755: [RISCV] Pass target-abi via module flag metadata

khchen created this revision. khchen added reviewers: lenary, asb. khchen added a project: clang. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zz

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

lebedev.ri added a comment. > Sign-extension is not guaranteed by the ABI, and thus the callee cannot > assume it. This is a bit too vague. Can you quote specific parts of the appropriate standard/document? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates

kmclaughlin updated this revision to Diff 238199. kmclaughlin added a comment. - Removed shiftimm patterns and reused tvecshiftR8, etc - Removed complex patterns used by AsmVectorIndexOpnd and instead created a multiclass (VectorIndex) to create a PatLeaf with timm if "_timm" is appended CHANGE

[clang] cbe681b - Revert "[RISCV] Add Clang frontend support for Bitmanip extension"

Author: Scott Egerton Date: 2020-01-15T10:43:42Z New Revision: cbe681bd8339d3a018d25441a5f4ef9da2bd017d URL: https://github.com/llvm/llvm-project/commit/cbe681bd8339d3a018d25441a5f4ef9da2bd017d DIFF: https://github.com/llvm/llvm-project/commit/cbe681bd8339d3a018d25441a5f4ef9da2bd017d.diff LOG:

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton added a comment. Good point. It's reverted now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

lenary reopened this revision. lenary added a comment. This revision is now accepted and ready to land. @s.egerton Thank you. Sorry again for the confusion. Reverted in rGcbe681bd8339d3a018d25441a5f4ef9da2bd017d Repository:

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-initialization-list

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:52 +static bool isUnaryExprOfLiteral(const Expr *E) { + if (const auto *UnOp = dyn_cast(E)) { +return isLiteral(UnOp->getSubExpr()); ---

[clang] a90ea38 - [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.

Author: Scott Egerton Date: 2020-01-15T11:28:57Z New Revision: a90ea386981f4fa3c7cb7f62c6900069764b05a8 URL: https://github.com/llvm/llvm-project/commit/a90ea386981f4fa3c7cb7f62c6900069764b05a8 DIFF: https://github.com/llvm/llvm-project/commit/a90ea386981f4fa3c7cb7f62c6900069764b05a8.diff LOG:

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:36 + // one below. + Implicit = 1 << 3, + All = Declaration | Definition | Reference | Implicit, instead of doing that, could we rather de-couple two enums completely and have a

[PATCH] D72390: [www] Remove stale text about default c++ standard from cxx_status.html

russell.gallop added a comment. Ping. Is this okay to land, or have I missed something? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72390/new/ https://reviews.llvm.org/D72390 ___ cfe-commits

[PATCH] D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa90ea386981f: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using… (authored by s.egerton). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:36 + // one below. + Implicit = 1 << 3, + All = Declaration | Definition | Reference | Implicit, kadircet wrote: > instead of doing that, could we rather de-couple two enums compl

[PATCH] D72755: [RISCV] Pass target-abi via module flag metadata

lenary added a comment. Please can you also add code for ensuring that the `target-abi` module flag matches the `-target-abi` command line flag in llvm? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72755/new/ https://reviews.llvm.org/D72755 __

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-initialization-list

baloghadamsoftware updated this revision to Diff 238219. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.tx

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-initialization-list

baloghadamsoftware marked 6 inline comments as done. baloghadamsoftware added a comment. Thank you for the comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +- The 'readability-prefer-member-initializer' check was renamed to :doc:`cppcoreguidelines-prefer-memb

[PATCH] D72401: Fixes for spaces around C# object initializers

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2870 +if (Left.is(TT_Unknown) && Right.is(tok::l_brace) && Left.Previous && +Left.Previous->is(tok::kw_new)) + return true; krasimir wrote: > The `TT_Unknown` i

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak updated this revision to Diff 238217. llunak edited the summary of this revision. llunak removed a project: OpenMP. llunak added a comment. In order to simplify this, I've updated the patch to remove any reference to OpenMP and I've moved that part to https://reviews.llvm.org/D72759 . Thi

[clang-tools-extra] 5852475 - Bump the trunk major version to 11

Author: Hans Wennborg Date: 2020-01-15T13:38:01+01:00 New Revision: 5852475e2c049ce29dcb1f0da3ac33035f8c9156 URL: https://github.com/llvm/llvm-project/commit/5852475e2c049ce29dcb1f0da3ac33035f8c9156 DIFF: https://github.com/llvm/llvm-project/commit/5852475e2c049ce29dcb1f0da3ac33035f8c9156.diff

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

emilio added a comment. The relevant discussion is here . From the "Parameter Passing" section in https://github.com/hjl-tools/x86-psABI/wiki/x86-64-psABI-1.0.pdf, there's no mention of sign-extension requirements for arguments. > The onl

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:620 + if (llvm::dyn_cast(E->getMemberDecl())) +NameLocation = E->getEndLoc(); Refs.push_back(ReferenceLoc{E->getQualifierLoc(), instead of patching the source

[PATCH] D72761: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

MarkMurrayARM created this revision. MarkMurrayARM added reviewers: simon_tatham, miyuki, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics and unit tests. Repository: rG

[PATCH] D68115: Zero initialize padding in unions

aaron.ballman added a comment. In D68115#1820622 , @vitalybuka wrote: > In D68115#1820579 , @aaron.ballman > wrote: > > > In D68115#1820462 , @vitalybuka > > wrote: > > > >

[clang] ee0f1f1 - Further implement CWG 2292

Author: Soumi Manna Date: 2020-01-15T08:49:44-05:00 New Revision: ee0f1f1edc3ec0d4e698d50cc3180217448802b7 URL: https://github.com/llvm/llvm-project/commit/ee0f1f1edc3ec0d4e698d50cc3180217448802b7 DIFF: https://github.com/llvm/llvm-project/commit/ee0f1f1edc3ec0d4e698d50cc3180217448802b7.diff L

[PATCH] D72518: [clang] New __attribute__((arm_mve_strict_polymorphism)).

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from changing the attribute name back to what it was (sorry about that), this LGTM! Comment at: clang/include/clang/Basic/Attr.td:1474 +def ArmMveStrictP

[PATCH] D71365: expand printf when compiling HIP to AMDGPU

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71365/new/ https://reviews.llvm.org/D71365 ___

[PATCH] D72635: Add "context" capability to Thread Safety Analysis

aaron.ballman added a comment. Can you give some examples of code where you think the diagnostics are inappropriate? One of the goals of role-based capabilities is for you to name the capabilities as you see fit, so it's possible that there is a different way for us to surface those diagnostics

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. In D71467#1820589 , @rjmccall wrote: > I think I have a slight preference for the second option, where there's a > single method that does all the work for the two cases. OK, now checked in as 870137d

[PATCH] D72500: [clangd] Show hover info for expressions

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG4d14bfaa2cb1: [clangd] Show hower info for expressions (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D72761: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

simon_tatham added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:289 + def vmaxaq: Intrinsic $a, $b)>; } I wonder if we should implement at least the simple case (integer and unpredicated) using standard IR nodes instead of an IR intrinsic?

[PATCH] D72500: [clangd] Show hover info for expressions

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:519 + // + // expression : `int` // Note that we are making use of a level-3 heading because VSCode renders sammccall wrote: > nit: this is just "expression" not yet, it will be a

[PATCH] D72622: [clangd] Add a ruler after header in hover

kadircet updated this revision to Diff 238243. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72622/new/ https://reviews.llvm.org/D72622 Files: clang-tools-ex

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

This revision was automatically updated to reflect the committed changes. Closed by commit rG44f9c7a820c1: [clangd] Rearrange type, returntype and parameters in hover card (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72623/ne

[PATCH] D72622: [clangd] Add a ruler after header in hover

This revision was automatically updated to reflect the committed changes. Closed by commit rGd74a3d470c31: [clangd] Add a ruler after header in hover (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72622/new/ https://reviews.ll

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

kadircet added a comment. In D72623#1819153 , @lh123 wrote: > I think the character "🡺" should be avoided, as it may not display properly > in some environments. I believe most of the editors should be able to display unicode characters, please let us

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

kadircet updated this revision to Diff 238245. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72498/new/ https://reviews.llvm.org/D72498 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unitt

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

kadircet updated this revision to Diff 238244. kadircet marked 3 inline comments as done. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72623/new/ https://reviews.llvm.org/D72623 Files: clang-tools-extra/clangd

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

aganea added a comment. I'm glad you're fixing this, this problem has came up in our profile traces as well. > The only way this breaks things that I've managed to find is if a .cpp file > using the PCH adds another template specialization that's not mentioned in > the PCH What is the error?

[clang] ada01d1 - [clang] New __attribute__((__clang_arm_mve_strict_polymorphism)).

Author: Simon Tatham Date: 2020-01-15T15:04:10Z New Revision: ada01d1b869763f7d5d3438dcfce02066b06ab0a URL: https://github.com/llvm/llvm-project/commit/ada01d1b869763f7d5d3438dcfce02066b06ab0a DIFF: https://github.com/llvm/llvm-project/commit/ada01d1b869763f7d5d3438dcfce02066b06ab0a.diff LOG:

[PATCH] D72622: [clangd] Add a ruler after header in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61885 tests passed, 0 failed and 782 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72755: [RISCV] Pass target-abi via module flag metadata

khchen added a comment. In D72755#1821540 , @lenary wrote: > Please can you also add code for ensuring that the `target-abi` module flag > matches the `-target-abi` command line flag in llvm? please see D72768 , thanks!

[PATCH] D72518: [clang] New __attribute__((arm_mve_strict_polymorphism)).

This revision was automatically updated to reflect the committed changes. Closed by commit rGada01d1b8697: [clang] New __attribute__((__clang_arm_mve_strict_polymorphism)). (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D72518?vs=237999&id=238253#toc Repository:

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61885 tests passed, 0 failed and 782 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D72500: [clangd] Show hover info for expressions

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/5837/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72500/new/ https://reviews.llvm.org/D72500 ___ cfe-commits mai

[clang-tools-extra] 60adfb8 - [clangd] Fix windows buildbots

Author: Kadir Cetinkaya Date: 2020-01-15T16:22:36+01:00 New Revision: 60adfb83cda883d9fc1079c89d2feaa681a41b90 URL: https://github.com/llvm/llvm-project/commit/60adfb83cda883d9fc1079c89d2feaa681a41b90 DIFF: https://github.com/llvm/llvm-project/commit/60adfb83cda883d9fc1079c89d2feaa681a41b90.dif

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

jyknight added inline comments. Herald added a project: clang. Comment at: lib/Headers/__stddef_max_align_t.h:44 +#endif } max_align_t; #endif EricWF wrote: > rsmith wrote: > > I don't want to hold up the immediate fix in this patch for this, but... we > > sho

[clang] 24a00ef - Restore "[ThinLTO] Add additional ThinLTO pipeline testing with new PM"

Author: Teresa Johnson Date: 2020-01-15T07:33:08-08:00 New Revision: 24a00ef2404104e9ca6fbd7eb523a8a340be9d99 URL: https://github.com/llvm/llvm-project/commit/24a00ef2404104e9ca6fbd7eb523a8a340be9d99 DIFF: https://github.com/llvm/llvm-project/commit/24a00ef2404104e9ca6fbd7eb523a8a340be9d99.diff

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil updated this revision to Diff 238260. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71707/new/ https://reviews.llvm.org/D71707 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugpron

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 __

[PATCH] D71707: clang-tidy: new bugprone-pointer-cast-widening

jankratochvil marked 8 inline comments as done. jankratochvil added a comment. In D71707#1796671 , @aaron.ballman wrote: > I agree that restricting casts to `intptr_t` is too restrictive. Permitted `intptr_t`. But then implemented also checking a cast o

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov updated this revision to Diff 238259. kpyzhov added a reviewer: arsenm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/Basic/Targets/

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Having two subtarget features for the same feature is an issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://review

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov updated this revision to Diff 238263. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/Basic/Targets/AMDGPU.cpp clang/test/CodeGenOpenCL/builtins-amdgcn-mfma.cl clang/tes

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8043 + + Error VisitFunctionTypeLoc(FunctionTypeLoc From) { +auto To = ToL.castAs(); balazske wrote: > martong wrote: > > a_sidorin wrote: > >

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong updated this revision to Diff 238267. martong marked an inline comment as done. martong added a comment. - Move the setting of parameters of FunctionProtoTypeLoc to TypeLocImporter - Add tests for TypeLoc import in case of functions Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D72761: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

MarkMurrayARM updated this revision to Diff 238269. MarkMurrayARM added a comment. Much better impementation after review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72761/new/ https://reviews.llvm.org/D72761 Files: clang/include/cla

[clang] 76b92cc - Fix bot by adjusting wildcard matching

Author: Teresa Johnson Date: 2020-01-15T08:37:15-08:00 New Revision: 76b92cc7c1fafeae2d9e4993e81838b8d9488e45 URL: https://github.com/llvm/llvm-project/commit/76b92cc7c1fafeae2d9e4993e81838b8d9488e45 DIFF: https://github.com/llvm/llvm-project/commit/76b92cc7c1fafeae2d9e4993e81838b8d9488e45.diff

[PATCH] D72761: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM this time. Thanks for the rewrite! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72761/new/ https://reviews.llvm.org/D72761

[PATCH] D72772: [Matrix] Add __builtin_matrix_extract to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72772 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/S

[PATCH] D72772: [Matrix] Add __builtin_matrix_extract to Clang (WIP).

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D72773: [Matrix] Add __builtin_matrix_{add,sub} to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72773 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sem

[PATCH] D72773: [Matrix] Add __builtin_matrix_{add,sub} to Clang (WIP).

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov added a comment. In D72723#1821917 , @arsenm wrote: > Having two subtarget features for the same feature is an issue ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723

[clang-tools-extra] 041650d - [clangd] Extract string literals in macro arguments to unbreak gcc buildbots

Author: Kadir Cetinkaya Date: 2020-01-15T17:59:10+01:00 New Revision: 041650da67051266eb92b5bb07223394fe1bdab1 URL: https://github.com/llvm/llvm-project/commit/041650da67051266eb92b5bb07223394fe1bdab1 DIFF: https://github.com/llvm/llvm-project/commit/041650da67051266eb92b5bb07223394fe1bdab1.dif

[PATCH] D72774: [Matrix] Add __builtin_matrix_multiply to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72774 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sem

[PATCH] D72774: [Matrix] Add __builtin_matrix_multiply to Clang (WIP).

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72778 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/S

[PATCH] D72777: [clangd] Dont display `` kinds in hover board

kadircet created this revision. kadircet added a reviewer: usaxena95. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Currently when hovering over an `auto` or `decltype` that resolve to a builtin-type, clangd would display `` as th

[clang] da9d57d - [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

Author: Mark Murray Date: 2020-01-15T17:20:15Z New Revision: da9d57d2c2dc821979490a425142afde5107066c URL: https://github.com/llvm/llvm-project/commit/da9d57d2c2dc821979490a425142afde5107066c DIFF: https://github.com/llvm/llvm-project/commit/da9d57d2c2dc821979490a425142afde5107066c.diff LOG: [

[clang] 8e5018e - Replace CLANG_SPAWN_CC1 env var with a driver mode flag

Author: Nico Weber Date: 2020-01-15T12:22:40-05:00 New Revision: 8e5018e990b701391e6c33ba85b012343df67272 URL: https://github.com/llvm/llvm-project/commit/8e5018e990b701391e6c33ba85b012343df67272 DIFF: https://github.com/llvm/llvm-project/commit/8e5018e990b701391e6c33ba85b012343df67272.diff LO

[PATCH] D72761: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda9d57d2c2dc: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics. (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72781 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/S

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang (WIP).

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D72777: [clangd] Dont display `` kinds in hover board

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61895 tests passed, 0 failed and 782 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72782 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGBuiltin.cpp clang/lib/S

[PATCH] D72304: [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim updated this revision to Diff 238301. fghanim marked 25 inline comments as done. fghanim added a comment. Addressing reviewer comments - Added regression tests - styling - adding asserts and todo where needed. Also, Now `EmitInlinedRegion` will merge blocks where legal. Repository: r

[PATCH] D72769: Replace CLANG_SPAWN_CC1 env var with a driver mode flag

thakis added a comment. cc cfe-commits for completeness CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72769/new/ https://reviews.llvm.org/D72769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun added a comment. Ping for the other reviewers :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72380/new/ https://reviews.llvm.org/D72380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D72782: [Matrix] Add __builtin_matrix_column_store to Clang (WIP).

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D72781: [Matrix] Add __builtin_matrix_column_load to Clang (WIP).

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D72785: [Matrix] Add __builtin_matrix_scalar_multiply to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72785 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sem

[PATCH] D72786: [clang] Set function attributes on SEH filter functions correctly.

sanwou01 created this revision. sanwou01 added a reviewer: rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. When compiling with -munwind-tables, the SEH filter funclet needs the uwtable function attribute, which gets automatically added if we use SetInternalFunctionAttri

[PATCH] D72785: [Matrix] Add __builtin_matrix_scalar_multiply to Clang (WIP).

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D72761: [ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics.

dmgreen added a comment. Nice one. Good to see codegen changes coming out of these intrinsics. It took a while for me to figure out what the integer instruction was doing. That's a strange one. The fp case I have a question about below. Comment at: llvm/lib/Target/ARM/ARMIns

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-initialization-list

Eugene.Zelenko added a comment. By the word, please rebase, because Release Notes were reset after version 10 branching. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71199/new/ https://reviews.llvm.org/D71199 ___ cfe-commits mailing list

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm added a comment. Herald added a subscriber: kerbowa. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements

timwoj created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff expands the SpacesAroundConditions option added in D68346 to include adding spaces to catch statements. Repository: rG LLVM Github Monorepo https:/

[PATCH] D72786: [clang] Set function attributes on SEH filter functions correctly.

rnk added a comment. Thanks, the code change looks good, but please adjust the tests a bit. Comment at: clang/test/CodeGen/exceptions-seh-finally.c:284-286 -// Look for the absence of noinline. Enum attributes come first, so check that -// a string attribute is the first to ver

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. >> I'd be curious to the answer to David's questions. If the size increase is >> because of unused extern variables coming in from libc or something then it >> doesn't seem worth the cost. For above case clang size is increase because ,it is difference between clang bu

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

logan-5 marked 2 inline comments as done. logan-5 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:29 +public: + RenamerClangTidyCheck(StringRef CheckName, ClangTidyContext *Context); + ~RenamerClangTidyCheck(); loga

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

spatel added inline comments. Comment at: llvm/test/CodeGen/PowerPC/fmf-propagation.ll:201-203 ; fma(X, 7.0, X * 42.0) --> X * 49.0 -; This is the minimum FMF needed for this transform - the FMA allows reassociation. +; This is the minimum FMF needed for this transform - the 'c

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 238328. logan-5 added a comment. Added TODO comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72282/new/ https://reviews.llvm.org/D72282 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.c

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

dblaikie added a comment. In D71451#1822497 , @Jac1494 wrote: > >> I'd be curious to the answer to David's questions. If the size increase is > >> because of unused extern variables coming in from libc or something then > >> it doesn't seem worth the cos

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61892 tests passed, 2 failed and 782 were skipped. failed: Clang.CXX/temp/temp_arg/temp_arg_template/p3-2a.cpp failed: LLVM.CodeGen/SystemZ/mverify-optypes.mir {icon question-circle color=gray} clang-tidy: unk

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

rnk added subscribers: rjmccall, chandlerc. rnk added a comment. +@chandlerc @rjmccall Didn't we work this out already when John added the alignment tracking stuff? I remember this bug involving libjpegturbo standalone assembly receiving a 32-bit argument, and then using the full 64-bit RDI reg

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

rnk added a comment. I'm still in favor of this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67847/new/ https://reviews.llvm.org/D67847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72334: [Syntax] Build nodes for template declarations.

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:930 +Builder.markChildToken(TemplateKW, syntax::NodeRole::IntroducerKeyword); +Builder.markMaybeDelayedChild( +TemplatedDeclaration, Why is this range maybe-delay

  1   2   >