[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

sammccall added a comment. In D72498#1814286 , @lh123 wrote: > In D72498#1814008 , @sammccall wrote: > > > I think i'm also comfortable with marking the linked bug as wontfix. > > > The previous example is just mini

[clang-tools-extra] 4c5a451 - [clangd] Fix targetDecl() on certain usage of ObjC properties.

Author: Sam McCall Date: 2020-01-10T18:07:24+01:00 New Revision: 4c5a4514d14537cae5459e03d1fea422664b3bc2 URL: https://github.com/llvm/llvm-project/commit/4c5a4514d14537cae5459e03d1fea422664b3bc2 DIFF: https://github.com/llvm/llvm-project/commit/4c5a4514d14537cae5459e03d1fea422664b3bc2.diff LO

[PATCH] D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties.

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG4c5a4514d145: [clangd] Fix targetDecl() on certain usage of ObjC properties. (authored by sammccall). Changed prior to

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from nits Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:83 +return llvm::None; + } else if (TypeSpecifier.getEnd()

[PATCH] D72518: [clang] New __attribute__((__clang_arm_mve_strict_polymorphism)).

simon_tatham created this revision. simon_tatham added reviewers: aaron.ballman, dmgreen. Herald added subscribers: cfe-commits, JDevlieghere, kristof.beyls. Herald added a project: clang. This is applied to the vector types defined in for use with the intrinsics for the ARM MVE vector architectu

[clang] cdc9592 - Fix "pointer is null" static analyzer warning. NFCI.

Author: Simon Pilgrim Date: 2020-01-10T17:21:20Z New Revision: cdc9592bf1acb6d8012a4867d2a22458945dcceb URL: https://github.com/llvm/llvm-project/commit/cdc9592bf1acb6d8012a4867d2a22458945dcceb DIFF: https://github.com/llvm/llvm-project/commit/cdc9592bf1acb6d8012a4867d2a22458945dcceb.diff LOG:

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70524/new/ https://reviews.llvm.org/D70524 ___ cfe-commits mailin

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong added a comment. In D71612#1814225 , @NoQ wrote: > In D71612#1813937 , @martong wrote: > > > I am going to execute the analysis on LLVM/Clang as you suggested, so then > > we'll see what the experiment will

[clang] fd8ded9 - Fix "pointer is null" static analyzer warning. NFCI.

Author: Simon Pilgrim Date: 2020-01-10T17:41:26Z New Revision: fd8ded99fe6e9fcae2c98ccad25d6562c5fa8a14 URL: https://github.com/llvm/llvm-project/commit/fd8ded99fe6e9fcae2c98ccad25d6562c5fa8a14 DIFF: https://github.com/llvm/llvm-project/commit/fd8ded99fe6e9fcae2c98ccad25d6562c5fa8a14.diff LOG:

[PATCH] D71612: [analyzer] Add PlacementNewChecker

NoQ added a comment. In D71612#1814410 , @martong wrote: > Ups, I am sorry. Now I am creating another commit which moves it to alpha. > (So then, If I understand it correctly then the `cplusplus` is enabled by > default, but `alpha` is not.) Aha, yup.

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 updated this revision to Diff 237363. njames93 added a comment. Herald added a subscriber: mgorny. Tweaked a few documentation issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72448/new/ https://reviews.llvm.org/D72448 Files: clang-

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 237367. njames93 added a comment. Tweaked a few documentation issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 Files: clang-tools-extra/clang-tidy/cert/CERTTid

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 updated this revision to Diff 237368. njames93 added a comment. Undid my oopsie sending the wrong patch here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72448/new/ https://reviews.llvm.org/D72448 Files: clang-tools-extra/clang-tidy/re

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2254 +CGM.getDiags().Report(S.getAsmLoc(), + diag::warn_fe_stack_clash_protection_inline_asm); + } -

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno marked an inline comment as done. bruno added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:11007 + // Issue any pending ODR-failure diagnostics. + for (auto &Merge : RecordOdrMergeFailures) { rtrieu wrote: > Is this just a copy of

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

njames93 added a comment. whoops typo in arc, will fix, this is another patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72448/new/ https://reviews.llvm.org/D72448 ___ cfe-commits mailing list cfe-c

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/NotTrivialTypesLibcMemoryCallsCheck.cpp:75 +MatchFinder *Finder) { + + if (!getLangOpts().CPlusPlus) Unnecessary empty line. Comment at: clang-tools-extra

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68923/new/ https://reviews.llvm.org/D68923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D72221: Support function attribute patchable_function_entry

This revision was automatically updated to reflect the committed changes. Closed by commit rGa44c434b68e5: Support function attribute patchable_function_entry (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72221/new/ https://re

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

This revision was automatically updated to reflect the committed changes. Closed by commit rGf17ae668a96e: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0] (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https:/

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang marked 2 inline comments as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4516 void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) { - assert(DebugKind >= codegenoptions::LimitedDebugInfo); + assert(CGM.g

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 237377. njames93 marked 4 inline comments as done. njames93 added a comment. reformat/lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files: clang-tools-extra/c

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4516 void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) { - assert(DebugKind >= codegenoptions::LimitedDebugInfo); + assert(CGM.getCodeGenOpts().isFullDebug()); if (VD-

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 237378. njames93 marked 2 inline comments as done. njames93 added a comment. - Update docs to use backticks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files: cl

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

xur created this revision. xur added a reviewer: tejohnson. Herald added subscribers: dexonsmith, steven_wu, hiraditya, mehdi_amini. For IR input files, we currently use LLVM diagnostic handler even the compilation is from clang. As a result, we are not able to use -Rpass to get the transformation

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:99 + QualType Pointee = + dyn_cast(QType->getPointeeType().getTypePtr())->desugar(); + assert(!Pointee.isNull() && "can't have a null Pointee"); aar

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3692 + Args.getLastArg(options::OPT_flimit_debug_info_constructor), Args, D, TC) && +DebugInfoKind == codegenoptions::LimitedDebugInfo) + DebugInfoKind = codegenoptions::Debug

[PATCH] D72414: Add new AST matcher `hasAnyCapture`

rhiro updated this revision to Diff 237389. rhiro added a comment. Fixed the condition for the varDecl case and made the cxxThisExpr more concise. - Condition on `capturesVariable` instead of `capturesThis` and switch the loop in the cxxThisExpr overload to use llvm::any_of instead of an explici

[clang] 13ec473 - [analyzer] Move PlacementNewChecker to alpha

Author: Gabor Marton Date: 2020-01-10T19:35:25+01:00 New Revision: 13ec473b9d4bd4f7a558272932b7c0806171c666 URL: https://github.com/llvm/llvm-project/commit/13ec473b9d4bd4f7a558272932b7c0806171c666 DIFF: https://github.com/llvm/llvm-project/commit/13ec473b9d4bd4f7a558272932b7c0806171c666.diff

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 237390. njames93 marked 3 inline comments as done. njames93 added a comment. - Fix format of options docs and remove unnecessary empty line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://revi

[PATCH] D72414: Add new AST matcher `hasAnyCapture`

rhiro marked 2 inline comments as done. rhiro added a comment. I addressed the inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72414/new/ https://reviews.llvm.org/D72414 ___ cfe-commits

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong added a comment. Related commit that moves to alpha: https://github.com/llvm/llvm-project/commit/13ec473b9d4bd4f7a558272932b7c0806171c666 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71612/new/ https://reviews.llvm.org/D71612 __

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:14 + + Specify extra functions to flag on that act similarily to memset. + Default is an empty string Please enclose memset in double back-ticks. Sam

[PATCH] D69878: Consoldiate internal denormal flushing controls

cameron.mcinally added inline comments. Comment at: llvm/docs/LangRef.rst:1837 + are present, this overrides ``"denormal-fp-math"``. Not all targets + support separately setting the denormal mode per type. + andrew.w.kaylor wrote: > arsenm wrote: > > andrew.w

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 237393. njames93 marked 3 inline comments as done. njames93 added a comment. - Fixed more documentation nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 Files: c

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:16 + Default is an empty string. + The check will detect the following memory setting function: + ``memset`` This repeats first sentence in docume

[PATCH] D69878: Consoldiate internal denormal flushing controls

andrew.w.kaylor added inline comments. Comment at: llvm/docs/LangRef.rst:1837 + are present, this overrides ``"denormal-fp-math"``. Not all targets + support separately setting the denormal mode per type. + cameron.mcinally wrote: > andrew.w.kaylor wrote: > >

[PATCH] D71124: [RISCV] support clang driver to select cpu

evandro added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:164 + +static constexpr llvm::StringLiteral ValidRV32CPUNames[] = {{"generic-rv32"}, +{"rocket-rv32"}}; Strange formatting...

[clang] f28972f - [clang] Fix out-of-bounds memory access in ComputeLineNumbers

Author: Jan Korous Date: 2020-01-10T11:22:41-08:00 New Revision: f28972facc1fce9589feab9803e3e8cfad01891c URL: https://github.com/llvm/llvm-project/commit/f28972facc1fce9589feab9803e3e8cfad01891c DIFF: https://github.com/llvm/llvm-project/commit/f28972facc1fce9589feab9803e3e8cfad01891c.diff LO

[PATCH] D72409: [clang] Fix out-of-bounds memory access in ComputeLineNumbers

This revision was automatically updated to reflect the committed changes. Closed by commit rGf28972facc1f: [clang] Fix out-of-bounds memory access in ComputeLineNumbers (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https:/

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: aaron.ballman, alexfh, hokein. Eugene.Zelenko added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a project: clang. I added subsubsections for typical Clang-tidy entries in Release Notes, so no

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang marked 5 inline comments as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4516 void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) { - assert(DebugKind >= codegenoptions::LimitedDebugInfo); + assert(CGM.g

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:1837 + are present, this overrides ``"denormal-fp-math"``. Not all targets + support separately setting the denormal mode per type. + andrew.w.kaylor wrot

[clang] ba91dff - [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver

Author: Fangrui Song Date: 2020-01-10T11:43:17-08:00 New Revision: ba91dffafe4d348b469d8ae2b7b1cd00754f72f1 URL: https://github.com/llvm/llvm-project/commit/ba91dffafe4d348b469d8ae2b7b1cd00754f72f1 DIFF: https://github.com/llvm/llvm-project/commit/ba91dffafe4d348b469d8ae2b7b1cd00754f72f1.diff

[PATCH] D72433: [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGba91dffafe4d: [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72433/new/ htt

[PATCH] D72433: [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver

jhibbits accepted this revision. jhibbits added a comment. This revision is now accepted and ready to land. Fine with me. I just wanted -target powerpcspe-... to work with D72014 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] 55d7b22 - [ASTMatchers] Make test more clear about what it is verifying

Author: Stephen Kelly Date: 2020-01-10T19:47:12Z New Revision: 55d7b22277e1c5e710bac7d4d4dc09db3a22dad8 URL: https://github.com/llvm/llvm-project/commit/55d7b22277e1c5e710bac7d4d4dc09db3a22dad8 DIFF: https://github.com/llvm/llvm-project/commit/55d7b22277e1c5e710bac7d4d4dc09db3a22dad8.diff LOG:

[PATCH] D69878: Consoldiate internal denormal flushing controls

cameron.mcinally added inline comments. Comment at: llvm/docs/LangRef.rst:1837 + are present, this overrides ``"denormal-fp-math"``. Not all targets + support separately setting the denormal mode per type. + arsenm wrote: > andrew.w.kaylor wrote: > > cameron.

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72531 Files: clang/unittests/AST/ASTImporterTest.cpp

[PATCH] D72532: Make the ExprMutationAnalyzer explicit about how it traverses the AST

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72532 Files: clang/lib/

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, arphaman, kbarton, nemanjai. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72530 Files: clang-tools-extra/clang-tidy/abseil/Duration

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72534 Files: clang/include/clang/AST/ASTContext.h Index: clang/include/clang/AST/AS

[PATCH] D72414: Add new AST matcher `hasAnyCapture`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72414/new/ https://reviews.llvm.

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang updated this revision to Diff 237411. akhuang added a comment. Address comments - Removed driver option - Simplified test cases - Changed name of limited debug info from isFullDebug to hasReducedDebugInfo, which is maybe slightly less misleading Repository: rG LLVM Github Monorepo

[PATCH] D69868: Allow "callbr" to return non-void values

jyknight added inline comments. Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:701 + } else if (MBB->succ_size() == LandingPadSuccs.size() || + MBB->succ_size() == IndirectPadSuccs.size()) { // It's possible that the block legitimately ends with a

[PATCH] D69868: Allow "callbr" to return non-void values

void marked an inline comment as done. void added inline comments. Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:701 + } else if (MBB->succ_size() == LandingPadSuccs.size() || + MBB->succ_size() == IndirectPadSuccs.size()) { // It's possible that

[PATCH] D72414: Add new AST matcher `hasAnyCapture`

rhiro added a comment. In D72414#1814831 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yes, please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72414/new/ https://review

[PATCH] D72233: Add a new AST matcher 'optionally'.

steveire added a comment. LGTM too. I described a more ad-hoc implementation previously: https://steveire.wordpress.com/2018/11/20/composing-ast-matchers-in-clang-tidy/ but I prefer this implementation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72233/new/ https://reviews.llvm.org/

[PATCH] D72531: Set traversal explicitly where needed in tests

steveire updated this revision to Diff 237418. steveire added a comment. Fix case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://reviews.llvm.org/D72531 Files: clang/unittests/AST/ASTImporterTest.cpp clang/unittests/AST/Sourc

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

steveire updated this revision to Diff 237417. steveire added a comment. Fix case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72530/new/ https://reviews.llvm.org/D72530 Files: clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.cpp cla

[clang] 4ffcec4 - Implement new AST matcher hasAnyCapture to match on LambdaExpr captures.

Author: Reid Date: 2020-01-10T15:49:43-05:00 New Revision: 4ffcec40acebae7161ac7426edc68290bbaca2b8 URL: https://github.com/llvm/llvm-project/commit/4ffcec40acebae7161ac7426edc68290bbaca2b8 DIFF: https://github.com/llvm/llvm-project/commit/4ffcec40acebae7161ac7426edc68290bbaca2b8.diff LOG: Imp

[PATCH] D72414: Add new AST matcher `hasAnyCapture`

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you! I have commit on your behalf in 4ffcec40acebae7161ac7426edc68290bbaca2b8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

njames93 updated this revision to Diff 237422. njames93 added a comment. - Reworked options documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488 Files: clang-tools-extra/clang-tidy/cert/CERTTidyM

[clang-tools-extra] f3db1aa - MakeUniqueCheck.cpp: explicit the fact that there is an autofix for this checker

Author: Sylvestre Ledru Date: 2020-01-10T22:06:03+01:00 New Revision: f3db1aad2796c62f0d188a74f2901c18e51843c2 URL: https://github.com/llvm/llvm-project/commit/f3db1aad2796c62f0d188a74f2901c18e51843c2 DIFF: https://github.com/llvm/llvm-project/commit/f3db1aad2796c62f0d188a74f2901c18e51843c2.dif

[clang-tools-extra] faeeb71 - clang-tidy doc: Refresh the list of checkers and polish the script

Author: Sylvestre Ledru Date: 2020-01-10T22:07:47+01:00 New Revision: faeeb71a17344171f814144213ac4fbc93be28fd URL: https://github.com/llvm/llvm-project/commit/faeeb71a17344171f814144213ac4fbc93be28fd DIFF: https://github.com/llvm/llvm-project/commit/faeeb71a17344171f814144213ac4fbc93be28fd.dif

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:14 + + Specify extra functions to flag that act similarily to memset. + Default is an empty string. Somehow memset is still not in double back-ticks.

[clang-tools-extra] 68cd283 - clang-tidy doc: unbreak the CI

Author: Sylvestre Ledru Date: 2020-01-10T22:25:01+01:00 New Revision: 68cd283f3b074e3b64b9f65e93ceb2de6807c72d URL: https://github.com/llvm/llvm-project/commit/68cd283f3b074e3b64b9f65e93ceb2de6807c72d DIFF: https://github.com/llvm/llvm-project/commit/68cd283f3b074e3b64b9f65e93ceb2de6807c72d.dif

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd added a comment. In D65761#1811097 , @hubert.reinterpretcast wrote: > In D65761#1804302 , > @hubert.reinterpretcast wrote: > > > I have confirmed that the case I mentioned fails with rGd157a9b > >

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson created this revision. tejohnson added a reviewer: wmi. Herald added subscribers: jfb, dexonsmith, steven_wu, hiraditya, inglorion, mehdi_amini. Herald added projects: clang, LLVM. I've added some more extensive ThinLTO pipeline testing with the new PM, motivated by the bug fixed in D72

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson updated this revision to Diff 237427. tejohnson added a comment. Remove some cruft Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72538/new/ https://reviews.llvm.org/D72538 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll llvm/t

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj added a comment. Friendly ping - anything further I need to do here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 ___ cfe-commits mailing list cfe-com

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

Eugene.Zelenko added a comment. Documentation and Release Notes entry are still missing.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 ___ cfe-commits mailin

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 updated this revision to Diff 237433. logan-5 marked 4 inline comments as done. logan-5 added a comment. Added a TODO comment for catching more reserved names. Added links in documentation to CERT guidelines covered by the check. Pulled strings into named constants and made that logic ea

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:377 - if (D.needsDestruction(getContext()) && HaveInsertPoint()) { + if (hasNontrivialDestruction(D.getType()) && HaveInsertPoint()) { // We have a constan

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. Applied the fix-it on one of our smaller (but C++ code bases) and it builds and passes the tests. Comments: 1. I'm still seeing some false positives, where some locals that are const are flagged as could be made const - I'm working to create a minimal reproduction

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

wmi added a comment. The additional pipeline testing will catch any future pass change to the pipeline. A related but separate question is do we have a way to check whether there is any other missing pass in thinlto newpm similar as that in D72386 ? =

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj updated this revision to Diff 237440. sorenj added a comment. - Merge branch 'master' of https://github.com/llvm/llvm-project - Add documentation and release notes, fix spelling error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:106 + + Finds cases where a signed value is subtracted from an unsigned value, + a likely cause of unexpected underflow. Please synchronize with first statement in documen

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:377 - if (D.needsDestruction(getContext()) && HaveInsertPoint()) { + if (hasNontrivialDestruction(D.getType()) && HaveInsertPoint()) { // We have a constant initializer, but a nontrivial destructor. W

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj added a comment. First time so trying to follow similar recent submits. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 ___ cfe-commits mailing lis

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:377 - if (D.needsDestruction(getContext()) && HaveInsertPoint()) { + if (hasNontrivialDestruction(D.getType()) && HaveInsertPoint()) { // We have a constant initializer, but a nontrivial destructor.

[clang] 7a38468 - Only destroy static locals if they have non-trivial destructors.

Author: Richard Smith Date: 2020-01-10T15:18:36-08:00 New Revision: 7a38468e34eeeb59e80b176b97213d205d8d9b41 URL: https://github.com/llvm/llvm-project/commit/7a38468e34eeeb59e80b176b97213d205d8d9b41 DIFF: https://github.com/llvm/llvm-project/commit/7a38468e34eeeb59e80b176b97213d205d8d9b41.diff

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#1815073 , @0x8000- wrote: > Applied the fix-it on one of our smaller (but C++ code bases) and it builds > and passes the tests. Comments: > > 1. I'm still seeing some false positives, where some locals that are con

[PATCH] D72411: [CodeGen] partially revert 2b4fa5348ee157b6b1a1af44d0137ca8c7a71573 to fix Objective-C static variable initialization

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:377 - if (D.needsDestruction(getContext()) && HaveInsertPoint()) { + if (hasNontrivialDestruction(D.getType()) && HaveInsertPoint()) { // We have a constant initializer, but a nontrivial destructor. W

[PATCH] D69868: Allow "callbr" to return non-void values

jyknight added inline comments. Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:701 + } else if (MBB->succ_size() == LandingPadSuccs.size() || + MBB->succ_size() == IndirectPadSuccs.size()) { // It's possible that the block legitimately ends with a

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

pzheng added a comment. I see the following .cfi_offset directives generated using @shiva0217's test case. Any idea why the offset for ra is 536870908? callt0, __riscv_save_0 .cfi_def_cfa_offset 16 .cfi_offset ra, 536870908 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 1b8c84b - Improve precision of documentation comment.

Author: Richard Smith Date: 2020-01-10T15:49:17-08:00 New Revision: 1b8c84b8dd5a4a294943a6a6f0631d2d3a1f9f27 URL: https://github.com/llvm/llvm-project/commit/1b8c84b8dd5a4a294943a6a6f0631d2d3a1f9f27 DIFF: https://github.com/llvm/llvm-project/commit/1b8c84b8dd5a4a294943a6a6f0631d2d3a1f9f27.diff

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#1815121 , @JonasToth wrote: > In D54943#1815073 , @0x8000- > wrote: > > > Applied the fix-it on one of our smaller (but C++ code bases) and it builds > > and passes the t

[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

efriedma updated this revision to Diff 237453. efriedma added a comment. Herald added subscribers: cfe-commits, Petar.Avramovic, dexonsmith, nhaehnle, jvesely, arsenm. Herald added a project: clang. Add more comments, fixed the GlobalISel representation of shuffles, misc other cleanups. Still h

[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

xbolva00 added inline comments. Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4413 unsigned MaxRecurse) { - if (isa(Mask)) + if (all_of(Mask, [](int Elem) { return Elem == -1; })) return UndefValue::get(RetTy); -

[clang] fbf915f - Add a FIXME and corresponding test coverage for some suspicious behavior

Author: Richard Smith Date: 2020-01-10T16:12:00-08:00 New Revision: fbf915f01d46e005146f01553a5d7c6619d19597 URL: https://github.com/llvm/llvm-project/commit/fbf915f01d46e005146f01553a5d7c6619d19597 DIFF: https://github.com/llvm/llvm-project/commit/fbf915f01d46e005146f01553a5d7c6619d19597.diff

[clang] f4df7f4 - Remove redundant implicit cast creation.

Author: Richard Smith Date: 2020-01-10T16:12:00-08:00 New Revision: f4df7f4701d80ce6a2f5674db50f87fbd2dad82f URL: https://github.com/llvm/llvm-project/commit/f4df7f4701d80ce6a2f5674db50f87fbd2dad82f DIFF: https://github.com/llvm/llvm-project/commit/f4df7f4701d80ce6a2f5674db50f87fbd2dad82f.diff

[clang] 44e0daf - driver: Allow -fdebug-compilation-dir=foo in joined form.

Author: Nico Weber Date: 2020-01-10T19:20:51-05:00 New Revision: 44e0daf16e6985eb44ea9a629402852dbff9cb0b URL: https://github.com/llvm/llvm-project/commit/44e0daf16e6985eb44ea9a629402852dbff9cb0b DIFF: https://github.com/llvm/llvm-project/commit/44e0daf16e6985eb44ea9a629402852dbff9cb0b.diff LO

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

mtrofin created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith, steven_wu, hiraditya, mehdi_amini. Herald added projects: clang, LLVM. mtrofin added reviewers: tejohnson, davidxl. mtrofin added a comment. Another example where there is a discrepancy with the

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson marked 2 inline comments as done. tejohnson added a comment. In D72538#1815074 , @wmi wrote: > The additional pipeline testing will catch any future pass change to the > pipeline. A related but separate question is do we have a way to check > w

[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

mtrofin added a comment. Another example where there is a discrepancy with the old pass manager: in the old pass manager (PassManagerBuilder::addFunctionSimplificationPasses): if (OptLevel > 1) { if (EnableGVNHoist) MPM.add(createGVNHoistPass()); (before this change, new pass ma

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

tejohnson updated this revision to Diff 237462. tejohnson marked an inline comment as done. tejohnson added a comment. Implement suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72538/new/ https://reviews.llvm.org/D72538 Files: clang/te

Buildbot numbers for the week of 12/8/2019 - 12/14/2019

Hello everyone, Below are some buildbot numbers for the week of 12/8/2019 - 12/14/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 12/22/2019 - 12/28/2019

Hello everyone, Below are some buildbot numbers for the week of 12/22/2019 - 12/28/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 12/15/2019 - 12/21/2019

Hello everyone, Below are some buildbot numbers for the week of 12/15/2019 - 12/21/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

<    1   2   3   >