[clang] c5fb73c - [APFloat] Add recoverable string parsing errors to APFloat

Author: Ehud Katz Date: 2020-01-06T10:09:01+02:00 New Revision: c5fb73c5d1b3f1adb77d99fc85c594b48bff08f9 URL: https://github.com/llvm/llvm-project/commit/c5fb73c5d1b3f1adb77d99fc85c594b48bff08f9 DIFF: https://github.com/llvm/llvm-project/commit/c5fb73c5d1b3f1adb77d99fc85c594b48bff08f9.diff LOG

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5fb73c5d1b3: [APFloat] Add recoverable string parsing errors to APFloat (authored by ekatz). Changed prior to commit: https://reviews.llvm.org/D69770?vs=227917&id=236304#toc Repository: rG LLVM Gith

[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat

craig.topper added inline comments. Comment at: llvm/lib/Support/StringRef.cpp:593 + if (!ErrOrStatus) { +assert("Invalid floating point representation"); +return true; This is an invalid assert. lib/Support/StringRef.cpp:593:12: warning: implicit conve

[PATCH] D72247: Add Triple::isX86()

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61250 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72247: Add Triple::isX86()

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72247/new/ https://reviews.llvm.org/D72247 ___ cfe

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen added a comment. I'd like to discuss what is good way to pass target-abi in maillist after I had a try to encoding ABI info into LLVM IR via module flag. any suggestions are welcome, thanks. Repository: rG LLVM Githu

[clang-tools-extra] f3f7dc3 - [APFloat] Fix compilation warnings

Author: Ehud Katz Date: 2020-01-06T11:30:40+02:00 New Revision: f3f7dc3d2990151a78b246a7a1485d0c13a9fb36 URL: https://github.com/llvm/llvm-project/commit/f3f7dc3d2990151a78b246a7a1485d0c13a9fb36 DIFF: https://github.com/llvm/llvm-project/commit/f3f7dc3d2990151a78b246a7a1485d0c13a9fb36.diff LOG

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

svenvh added a comment. This change seems to be causing a problem with the nightly packages from apt.llvm.org. CMake Error at /usr/lib/llvm-10/lib/cmake/llvm/LLVMExports.cmake:1357 (message): The imported target "Bye" references the file "/usr/lib/llvm-10/lib/libBye.a"

[PATCH] D71365: expand printf when compiling HIP to AMDGPU

sameerds updated this revision to Diff 236312. sameerds edited the summary of this revision. sameerds added a comment. Improved the test defined in clang/test/CodeGenHIP/printf.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71365/new/ https://re

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

vingeldal marked an inline comment as done. vingeldal added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:198 cppcoreguidelines-avoid-magic-numbers (redirects to readability-magic-numbers) + cppcoreguidelines-avoid-non-const-global-variabl

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#1805108 , @0x8000- wrote: > In D54943#1804943 , @JonasToth wrote: > > > - Merge branch 'master' into feature_transform_const.patch > > - link clangAnalysis to the cppcoreguid

[clang-tools-extra] 7180d95 - Fix MSVC "not all control paths return a value" warning. NFCI.

Author: Simon Pilgrim Date: 2020-01-06T10:20:20Z New Revision: 7180d9568df7d9198a75cfb5a156d9e60329794a URL: https://github.com/llvm/llvm-project/commit/7180d9568df7d9198a75cfb5a156d9e60329794a DIFF: https://github.com/llvm/llvm-project/commit/7180d9568df7d9198a75cfb5a156d9e60329794a.diff LOG:

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:8043 + + Error VisitFunctionTypeLoc(FunctionTypeLoc From) { +auto To = ToL.castAs(); martong wrote: > a_sidorin wrote: > > Does this import interacts well with type loc import partiall

[PATCH] D72227: Add options for clang to align branches within 32B boundary

skan updated this revision to Diff 236329. skan marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72227/new/ https://reviews.llvm.org/D72227 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/intel-alig

[PATCH] D72227: Add options for clang to align branches within 32B boundary

skan added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2012 + ArgStringList &CmdArgs) { + if (const Arg *A = Args.getLastArg(options::OPT_malign_branch_boundary_EQ)) { +StringRef Value = A->getValue(); M

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. In D61446#1805413 , @svenvh wrote: > This change seems to be causing a problem with the nightly packages from > apt.llvm.org. https://reviews.llvm.org/D72255 should do the trick (?) Repository: rG LLVM Github Monor

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 236339. JonasToth added a comment. - fix false positive with parenListExpr, dont match so narrow for them - try removing more false positives, does not work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

erichkeane added a comment. I'm concerned about just making this fallthrough to 'false'. These ARE integral promotions, we just don't know the type size. What happens if you instantiate this template? Will it still give the correct answer/type/diagnosis? In the case of the crash, I would sus

[clang] d45aafa - [clang-format] fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse

Author: Mitchell Balan Date: 2020-01-06T09:21:41-05:00 New Revision: d45aafa2fbcf66f3dafdc7c5e0a0ce3709914cbc URL: https://github.com/llvm/llvm-project/commit/d45aafa2fbcf66f3dafdc7c5e0a0ce3709914cbc DIFF: https://github.com/llvm/llvm-project/commit/d45aafa2fbcf66f3dafdc7c5e0a0ce3709914cbc.diff

[PATCH] D71939: clang-format: fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse

This revision was automatically updated to reflect the committed changes. Closed by commit rGd45aafa2fbcf: [clang-format] fix conflict between FormatStyle::BWACS_MultiLine and… (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'. (WIP)

balazske updated this revision to Diff 236349. balazske added a comment. - Added variadic functions, improved comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71510/new/ https://reviews.llvm.org/D71510 Files: clang/docs/analyzer/checkers.

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,M]

ostannard added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:77 "invalid unwind library name in argument '%0'">; +def err_drv_incompatible_options : Error<"'%0' and '%1' cannot be used together">; def err_drv_incompatible_unwindlib : Error<

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added a comment. In D69878#1801508 , @cameron.mcinally wrote: > This is looking pretty good to me, but I'm ignoring some of the target > specific code that I'm not familiar with. > > Is `denormal-fp-math` i

[PATCH] D72268: [ARM,MVE] Support -ve offsets in gather-load intrinsics.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, MarkMurrayARM. Herald added subscribers: llvm-commits, cfe-commits, kristof.beyls. Herald added projects: clang, LLVM. The ACLE intrinsics with `gather_base` or `scatter_base` in the name are wrappers on the MVE loa

[PATCH] D72271: [Clang] Handle target-specific builtins returning aggregates.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, rjmccall. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. A few of the ARM MVE builtins directly return a structure type. This causes an assertion failure at code-gen time if you try to

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'. (WIP)

gamesh411 added a comment. Great job, this seems to be progressing nicely! please see my comments inline. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrorReturnChecker.cpp:38 + // See if the result value from the system function (to check) is checked for + // error after a

[PATCH] D72221: Support function attribute patchable_function_entry

ostannard added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3995 +``__attribute__((patchable_function_entry(N,M)))`` is used to generate M NOPs +before the function entry and N-M NOPs after the function entry. This attributes +takes precedence over command

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

tejohnson added a comment. In D70765#1802564 , @dankamongmen wrote: > I hate to bother anyone, but can this go ahead and get merged? :) thanks Typically the author commits the patch, unless they don't have commit access and request the reviewer to comm

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm added a comment. In D69878#1805804 , @arsenm wrote: > In D69878#1801508 , > @cameron.mcinally wrote: > > > This is looking pretty good to me, but I'm ignoring some of the target > > specific code that I'm n

[PATCH] D71365: expand printf when compiling HIP to AMDGPU

arsenm added inline comments. Comment at: clang/test/CodeGenHIP/printf.cpp:18 +} + +// CHECK: [[BEGIN:%.*]] = call i64 @__ockl_printf_begin(i64 0) This could use a lot more testcases. Can you add some half, float, and double as well as pointers (including diff

[PATCH] D72053: [RFC] Handling implementation limits

tahonermann added inline comments. Comment at: clang/docs/ImplementationQuantities.rst:11 +This page lists the limits implemented in the Clang compiler. The available +resources on the system running Clang may imposse other limits. For example, +the system may have insufficient m

[PATCH] D72274: [libTooling] Fix bug in Stencil handling of macro ranges

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. Currently, an attempt to rewrite source code inside a macro expansion succeeds, but results in empty text, rather than failing with an error. This patch restructures to the code to explicitly vali

[PATCH] D72270: [ARM,MVE] Fix many signedness errors in MVE intrinsics.

dmgreen added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:204 let params = T.Float in { - defm vminnmq : VectorVectorArithmetic<"min_predicated">; - defm vmaxnmq : VectorVectorArithmetic<"max_predicated">; + defm vminnmq : VectorVectorArithmetic<"min_pre

[PATCH] D72270: [ARM,MVE] Fix many signedness errors in MVE intrinsics.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:204 let params = T.Float in { - defm vminnmq : VectorVectorArithmetic<"min_predicated">; - defm vmaxnmq : VectorVectorArithmetic<"max_predicated"

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

capn created this revision. capn added a reviewer: clang-format. capn added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation for IndentCaseLabels claimed that the "Switch statement body is always indented one level more than case lab

[PATCH] D72270: [ARM,MVE] Fix many signedness errors in MVE intrinsics.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. OK. LGTM then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72270/new/ https://reviews.llvm.org/D72270 ___

[PATCH] D72268: [ARM,MVE] Support -ve offsets in gather-load intrinsics.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72268/new/ https://reviews.llvm.org/D72268

[clang] 4978296 - [ARM, MVE] Support -ve offsets in gather-load intrinsics.

Author: Simon Tatham Date: 2020-01-06T16:33:07Z New Revision: 4978296cd8e4d10724cfa41f0308d256c0fd490c URL: https://github.com/llvm/llvm-project/commit/4978296cd8e4d10724cfa41f0308d256c0fd490c DIFF: https://github.com/llvm/llvm-project/commit/4978296cd8e4d10724cfa41f0308d256c0fd490c.diff LOG:

[PATCH] D72268: [ARM,MVE] Support -ve offsets in gather-load intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4978296cd8e4: [ARM,MVE] Support -ve offsets in gather-load intrinsics. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72268/new/

[PATCH] D69878: Consoldiate internal denormal flushing controls

cameron.mcinally added a comment. Ok, thanks for the clarifications. Looks good to me, but it would be good to have experts in OpenCL/Cuda/AMDGPU review the target specific changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878

[PATCH] D72053: [RFC] Handling implementation limits

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/docs/ImplementationQuantities.rst:11 +This page lists the limits implemented in the Clang compiler. The available +resources on the system running Clang may imposse other limits. For exam

[PATCH] D72281: [Matrix] Add matrix type to Clang (WIP).

fhahn created this revision. Herald added a reviewer: martong. Herald added subscribers: tschuett, arphaman. Herald added a project: clang. This patch adds a matrix type to Clang as described in "Matrix Support in Clang" on cfe-dev [1]. The patch is not intended for review yet, just to provide an

[PATCH] D72283: [Matrix] Add __builtin_matrix_insert to Clang (WIP).

fhahn created this revision. Herald added a subscriber: tschuett. Herald added a project: clang. This patch adds a __builtin_matrix_insert builtin as described in "Matrix Support in Clang" on cfe-dev [1]. The patch is not intended for review yet, just to provide an idea how the implementation coul

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 created this revision. logan-5 added reviewers: aaron.ballman, hokein, alexfh. logan-5 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This patch adds `bugprone-unintended-adl` which flags uses of ADL that are not

[PATCH] D72283: [Matrix] Add __builtin_matrix_insert to Clang (WIP).

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

nickdesaulniers added a comment. In D68101#1802220 , @bd1976llvm wrote: > Below is the code comment from the new patch explaining the new approach, > please take a look and see if you have any questions/comments: > > // If two globals with differing siz

[PATCH] D69876: Allow output constraints on "asm goto"

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. No, thanks for the work on this @void ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D698

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

This revision was automatically updated to reflect the committed changes. Closed by commit rG350da402ef6b: [clang-tidy] new check: bugprone-signed-char-misuse (authored by ztamas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71174/new/ https://rev

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

logan-5 created this revision. logan-5 added reviewers: alexfh, hokein, aaron.ballman. logan-5 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. Before this patch, `readability-identifier-naming` contained a significant am

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:856 +vals[VD] = MayUninitialized; } Can you walk me through the logic of this function? I would assume for changes to `asm goto`, the above early `return` wo

[PATCH] D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names

logan-5 added a comment. I'm taking @JonasToth's suggestion and splitting this into two patches, one for the refactor, followed by one for the new check. The refactor patch is here: https://reviews.llvm.org/D72284. Thanks everyone for your feedback so far. CHANGES SINCE LAST ACTION https://r

[PATCH] D72271: [Clang] Handle target-specific builtins returning aggregates.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4333 +if (!ReturnValue.isNull() && + ReturnValue.getValue().getType()->getPointerElementType()->isStructTy()) + return RValue::getAggregate(ReturnValue.getValue(), The re

[PATCH] D71848: Allow the discovery of Android NDK's triple-prefixed binaries.

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. Just to clarify, this is needed for the triple-prefixed tools, but the triple-specific directory worked fine before this patch? If I'm understanding that correctly then LGTM, otherwise I

[PATCH] D72281: [Matrix] Add matrix type to Clang (WIP).

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61254 tests passed, 1 failed and 736 were skipped. failed: Clang.CodeGen/pch-dllexport.cpp {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D69876: Allow output constraints on "asm goto"

jyknight accepted this revision. jyknight added a comment. LGTM modulo some minor wording. Comment at: clang/docs/LanguageExtensions.rst:1256-1258 +Clang provides support for the `goto form of GCC's extended +assembly`_ with

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

rjmccall added a comment. In D68101#1806135 , @nickdesaulniers wrote: > In D68101#1802220 , @bd1976llvm > wrote: > > > Below is the code comment from the new patch explaining the new approach, > > please take a l

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

ilya added a comment. Kind ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:351 +const std::string &Fixup) { + if (Fixup.empty()) { +return "; cannot be fixed automatically"; Please elide braces. Same be

[PATCH] D69878: Consoldiate internal denormal flushing controls

andrew.w.kaylor added inline comments. Comment at: llvm/docs/LangRef.rst:1837 + are present, this overrides ``"denormal-fp-math"``. Not all targets + support separately setting the denormal mode per type. + Can you document which targets do support the option

[PATCH] D72221: Support function attribute patchable_function_entry

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4925 + T.getArch() != llvm::Triple::x86_64) { +S.Diag(getAttrLoc(AL), diag::err_attribute_unsupported) << AL; +return; Why is the target arch also checked in `clang/li

[PATCH] D72221: Support function attribute patchable_function_entry

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4925 + T.getArch() != llvm::Triple::x86_64) { +S.Diag(getAttrLoc(AL), diag::err_attribute_unsupported) << AL; +return; ---

[PATCH] D71848: Allow the discovery of Android NDK's triple-prefixed binaries.

brianpl added a comment. > Just to clarify, this is needed for the triple-prefixed tools, but the > triple-specific directory worked fine before this patch? If I'm understanding > that correctly then LGTM, otherwise I'm confused as to why I haven't seen > this problem before. Yes, that's right

[PATCH] D72289: [analyzer] Update help text to reflect sarif support

xazax.hun created this revision. xazax.hun added reviewers: aaron.ballman, NoQ. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Repository: rG LLVM Github Monorepo

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.h:13 +#include "../ClangTidyCheck.h" + +#include Unnecessary empty line. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-

[PATCH] D72221: Support function attribute patchable_function_entry

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:826 + "patchable-function-entry", + (Twine(Attr->getSize()) + "," + Twine(Attr->getStart())).str()); } ostannard wrote: > I think using two function attr

[PATCH] D68720: Support -fstack-clash-protection for x86

craig.topper added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1903 +.. option:: -fstack-clash-protection + Probably need a -fno-stack-class-protection as well. Looks like gcc has it. You'll need to update the handling in the driver t

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:1837 + are present, this overrides ``"denormal-fp-math"``. Not all targets + support separately setting the denormal mode per type. + andrew.w.kaylor wrot

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 236420. logan-5 marked 5 inline comments as done. logan-5 added a comment. Addressed some formatting stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72282/new/ https://reviews.llvm.org/D72282 Files: cla

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11190 /// combination, based on their host/device attributes. - /// \param Caller function which needs address of \p Callee. - /// nullptr in case of global context. - /// \param Callee

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unintended-adl.rst:35 + + If non-zero, ignores calls to overloaded operators using the operator syntax (e.g. `a + b`), but not the function call syntax (e.g. `operator+(a, b)`). Defa

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unintended-adl.rst:39 + + Semicolon-separated list of names that the check ignores. Default is `swap`. logan-5 wrote: > Eugene.Zelenko wrote: > > Indentation. P

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

nickdesaulniers added a comment. In D68101#1806213 , @rjmccall wrote: > In D68101#1806135 , @nickdesaulniers > wrote: > > > In D68101#1802280 , @rjmccall > > wrote: > > > >

[PATCH] D72221: Support function attribute patchable_function_entry

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:686 +def PatchableFunctionEntry : InheritableAttr { + let Spellings = [GCC<"patchable_function_entry">]; Should this be inheriting from `TargetSpecificAttr` as well given that t

[PATCH] D69878: Consoldiate internal denormal flushing controls

andrew.w.kaylor added inline comments. Comment at: llvm/docs/LangRef.rst:1837 + are present, this overrides ``"denormal-fp-math"``. Not all targets + support separately setting the denormal mode per type. + arsenm wrote: > andrew.w.kaylor wrote: > > Can you d

[PATCH] D72233: Add a new AST matcher 'optionally'.

aaron.ballman added a comment. Just to make sure I understand the purpose -- the goal here is to optionally match one or more inner matchers without failing even if none of the inner matchers match anything, and this is a different use case than `anyOf()` because that would fail when none of th

[PATCH] D72289: [analyzer] Update help text to reflect sarif support

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72289/new/ https://reviews.llvm.org/D72289

[PATCH] D70689: [analyzer] Fix SARIF column locations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I think we've had sufficient time for other reviewers to lodge concerns and we can deal with any other issues post-commit. Do you need me to commit on your behalf? =

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. In D70926#1790848 , @MyDeveloperDay wrote: > Thanks for the patch. Happy new year! Could you help landing this diff? I don't know exactly what to do from here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-member-decl-usage.cpp:137 +} +}; // namespace CtorInits I think this is one more test case to add: base class specifiers. e.g., ``` struct f

[PATCH] D72053: [RFC] Handling implementation limits

rsmith added inline comments. Comment at: clang/include/clang/AST/Decl.h:903 /// declared. -unsigned ScopeDepthOrObjCQuals : NumScopeDepthOrObjCQualsBits; +unsigned ScopeDepthOrObjCQuals : IQ::NumScopeDepthOrObjCQualsBits; These bitfields are assum

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

JonasToth added a comment. I guess all the tests run? I think this LGTM after the nits are adressed. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:203 + Decl = Ref.getDecl(); +} + What about the else? If it is unreachable it

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.cpp:43 + Whitelist( + utils::options::parseStringList(Options.get("Whitelist", "swap"))) {} + do you mean `std::swap`? If you it should be fully qu

[clang] b73fea6 - [NFC] Test commit, whitespace change

Author: stevewan Date: 2020-01-06T16:24:27-05:00 New Revision: b73fea6a7cfd87fe07b9c05ba153042198b5d873 URL: https://github.com/llvm/llvm-project/commit/b73fea6a7cfd87fe07b9c05ba153042198b5d873 DIFF: https://github.com/llvm/llvm-project/commit/b73fea6a7cfd87fe07b9c05ba153042198b5d873.diff LOG:

[clang] 02f694b - [NFC] Test commit, revert whitespace change

Author: stevewan Date: 2020-01-06T16:28:13-05:00 New Revision: 02f694b69a8b30db7b5d43670da5ab3b9f31bb81 URL: https://github.com/llvm/llvm-project/commit/02f694b69a8b30db7b5d43670da5ab3b9f31bb81 DIFF: https://github.com/llvm/llvm-project/commit/02f694b69a8b30db7b5d43670da5ab3b9f31bb81.diff LOG:

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72097/new/ https://reviews.llvm.org/D72097 ___ cfe-commits mailing lis

[clang] 7b518dc - [OPENMP50]Support lastprivate conditional updates in inc/dec unary ops.

Author: Alexey Bataev Date: 2020-01-06T16:37:01-05:00 New Revision: 7b518dcb291e740c3e957d93c2b4046bc8a97f00 URL: https://github.com/llvm/llvm-project/commit/7b518dcb291e740c3e957d93c2b4046bc8a97f00 DIFF: https://github.com/llvm/llvm-project/commit/7b518dcb291e740c3e957d93c2b4046bc8a97f00.diff

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

rsmith added a comment. In D71714#1795313 , @ilya wrote: > While I agree with the general notion about the flaws with the current > implementation, I feel that the more major refactoring proposed in this > review is out of the scope of this minor fix.

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13384 case Stmt::MemberExprClass: { expr = cast(expr)->getBase(); break; ilya wrote: > rsmith wrote: > > Hmm, don't we need to do different things for dot and arrow

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

logan-5 updated this revision to Diff 236449. logan-5 marked 3 inline comments as done. logan-5 added a comment. Addressed some nits. If the rest looks good, I'll need someone with commit access to help me wrap this up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:272 + if (const auto *Typedef = + Value->getReturnType().getTypePtr()->getAs()) { +addUsage(NamingCheckFailures, Typedef->getDecl(), --

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 marked an inline comment as done. logan-5 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.cpp:43 + Whitelist( + utils::options::parseStringList(Options.get("Whitelist", "swap"))) {} + JonasToth wro

[clang] f5329bf - [Diagnostic] make Wmisleading-indendation not warn about labels

Author: Tyker Date: 2020-01-06T23:22:27+01:00 New Revision: f5329bfc76bb6fc30a589e8238aabc005c52e5d6 URL: https://github.com/llvm/llvm-project/commit/f5329bfc76bb6fc30a589e8238aabc005c52e5d6 DIFF: https://github.com/llvm/llvm-project/commit/f5329bfc76bb6fc30a589e8238aabc005c52e5d6.diff LOG: [D

[PATCH] D72202: [Diagnostic] make Wmisleading-indendation not warn about labels

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5329bfc76bb: [Diagnostic] make Wmisleading-indendation not warn about labels (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D72053: [RFC] Handling implementation limits

Mordante marked 6 inline comments as done. Mordante added a comment. Thanks for the feedback! Comment at: clang/include/clang/AST/Decl.h:903 /// declared. -unsigned ScopeDepthOrObjCQuals : NumScopeDepthOrObjCQualsBits; +unsigned ScopeDepthOrObjCQuals : IQ::NumScope

[PATCH] D72304: Summary: Add OpenMP Directives (master and critical) to OMPBuilder, and use them in clang.

fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, guansong, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72304 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp ll

[PATCH] D72221: Support function attribute patchable_function_entry

MaskRay updated this revision to Diff 236468. MaskRay marked 13 inline comments as done. MaskRay added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72221/new/ https://reviews.llvm.org/D72221 Files: clang/inclu

[PATCH] D72221: Support function attribute patchable_function_entry

MaskRay added inline comments. Comment at: clang/include/clang/Basic/Attr.td:686 +def PatchableFunctionEntry : InheritableAttr { + let Spellings = [GCC<"patchable_function_entry">]; aaron.ballman wrote: > Should this be inheriting from `TargetSpecificAttr` as

[PATCH] D72306: [PowerPC] FreeBSD >= 13 default ABI is ELFv2

adalava created this revision. adalava added reviewers: dim, MaskRay. adalava added a project: PowerPC. Herald added subscribers: llvm-commits, cfe-commits, steven.zhang, shchenz, jsji, kbarton, hiraditya, krytarowski, arichardson, nemanjai, emaste. Herald added projects: clang, LLVM. FreeBSD for

[PATCH] D72247: Add Triple::isX86()

MaskRay added a comment. @craig.topper Good to go? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72247/new/ https://reviews.llvm.org/D72247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D72247: Add Triple::isX86()

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72247/new/ https://reviews.llvm.org/D72247 ___ cfe-commits mailing list cfe-commits

  1   2   >