[PATCH] D72110: [X86] ABI compat bugfix for MSVC vectorcall

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61177 tests passed, 0 failed and 729 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

xbolva00 added a comment. Ah, true. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71037/new/ https://reviews.llvm.org/D71037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 48ee040 - [clang-tidy] fix linkage with clangSema for FixitHintUtils, undo previous wrong fix

Author: Jonas Toth Date: 2020-01-03T22:32:10+01:00 New Revision: 48ee04033cce2e085fd8909c6ebaa0de68ab65d0 URL: https://github.com/llvm/llvm-project/commit/48ee04033cce2e085fd8909c6ebaa0de68ab65d0 DIFF: https://github.com/llvm/llvm-project/commit/48ee04033cce2e085fd8909c6ebaa0de68ab65d0.diff LO

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

mstorsjo added a comment. In D71037#1803574 , @Tyker wrote: > In D71037#1803361 , @xbolva00 wrote: > > > Can you add a test case for that crash? Otherwise OK. > > > as i said. the bug can only occur for one line fil

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk marked 2 inline comments as done. rnk added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() rjm

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() rnk

[PATCH] D69868: Allow "callbr" to return non-void values

rnk added subscribers: MaskRay, echristo. rnk added a comment. More reviewers: +@echristo @MaskRay Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:133 + /// Indicate that this basic block is the indirect dest of an INLINEASM_BR. + bool IsInlineAsmBrIndirectPad = fal

[PATCH] D72188: [fuchsia] Enable Clang Static Analyzer

xazax.hun created this revision. xazax.hun added a reviewer: phosek. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, a.sidorin, rnkovacs, baloghadamsoftware, mgorny. phosek accepted this revision. phosek added a comment. This revision

[PATCH] D72188: [fuchsia] Enable Clang Static Analyzer

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72188/new/ https://reviews.llvm.org/D72188 ___

[PATCH] D72188: [fuchsia] Enable Clang Static Analyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rG0458e63d28a6: [fuchsia] Enable Clang Static Analyzer (authored by xazax.hun). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72188/new/ https://reviews.llvm.

[clang] 0458e63 - [fuchsia] Enable Clang Static Analyzer

Author: Gabor Horvath Date: 2020-01-03T15:49:32-08:00 New Revision: 0458e63d28a6685dae3d17cc210ef838be533612 URL: https://github.com/llvm/llvm-project/commit/0458e63d28a6685dae3d17cc210ef838be533612 DIFF: https://github.com/llvm/llvm-project/commit/0458e63d28a6685dae3d17cc210ef838be533612.diff

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

xazax.hun updated this revision to Diff 236148. xazax.hun added a comment. - Update the documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72097/new/ https://reviews.llvm.org/D72097 Files: clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

Charusso added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4619 This attribute may be used by analysis tools and has no effect on code -generation. +generation. A ``void`` argument means that the pointer cna point to any type. `cna` typo

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

xazax.hun updated this revision to Diff 236150. xazax.hun added a comment. - Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72097/new/ https://reviews.llvm.org/D72097 Files: clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

xazax.hun marked 2 inline comments as done. xazax.hun added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4619 This attribute may be used by analysis tools and has no effect on code -generation. +generation. A ``void`` argument means that the pointer cna poi

[clang] c4766ca - [Diagnostic] Add test for previous b4b904e19bb356724b2c6aea0199ce05c6f15cdb

Author: Tyker Date: 2020-01-04T01:41:21+01:00 New Revision: c4766cadcb38172c2843d65559060e0ae623b6eb URL: https://github.com/llvm/llvm-project/commit/c4766cadcb38172c2843d65559060e0ae623b6eb DIFF: https://github.com/llvm/llvm-project/commit/c4766cadcb38172c2843d65559060e0ae623b6eb.diff LOG: [D

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

Tyker closed this revision. Tyker added a comment. In D71037#1803704 , @mstorsjo wrote: > In D71037#1803574 , @Tyker wrote: > > > In D71037#1803361 , @xbolva00 > > wrote: >

[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

njames93 updated this revision to Diff 236157. njames93 added a comment. addressed issues. Running the clang-tidy on the whole of lib clang just resulted in errors when compiling due to its dependancy on llvm, but I kind of knew that was going to happen CHANGES SINCE LAST ACTION https://revi

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:91 bool InAllocaSRet : 1;// isInAlloca() + bool InAllocaIndirect : 1;// isInAlloca() bool IndirectByVal : 1; // isIndirect() rnk wrote: > rnk wrote: > > rjmccall

[PATCH] D72140: [clang-tools-extra] NFC: Fix trivial typos in comments

kiszk added a comment. I do not have commit rights to the repository. Could someone commit this change if it is OK? Kazuaki Ishizaki Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72140/new/ https://reviews.llvm.org/D72140 _

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#1803448 , @JonasToth wrote: > In D54943#1800182 , @0x8000- > wrote: > > > F11163406: 0001-Add-extra-tests.patch > > shows a couple of

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

bd1976llvm added a comment. In D68101#1802280 , @rjmccall wrote: > The solution described in that comment is not acceptable. We are not going > to tell users that they cannot assign symbols explicitly to sections because > LLVM is unable to promise not

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. Indicated where the new test code should go. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-const-correctness-values.cpp:608 +} + +template Please insert the this test code here: ``` struct IntWrapper {

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache added a comment. I'm currently working on ensuring that CGSCC optimizations are rerun to optimize coroutine funclets -- the primary feedback I received on this and on D71899 -- but I just realized I didn't respond to one comment on this set of reviews

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

rjmccall added a comment. In D68101#1804006 , @bd1976llvm wrote: > I looked into these today. I think we can do the first of these. I have put a > WIP patch up here: https://reviews.llvm.org/D72194. Could you comment on the > approach taken? Thank you.

<    1   2