[PATCH] D69779: -fmodules-codegen should not emit extern templates

dblaikie added a comment. Hey - thanks for this! Does look like it reproduces in modules: foo.h: #pragma once template struct outer { static void func() { } }; template void func() { } extern template struct outer; extern template void func(); inline void cal

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

gribozavr2 added a comment. Could you provide a more fleshed out example of a case where it is useful? Could you update the documentation for the attribute? I'm forgetting if there's a spec for this attribute -- is this extension part of that spec? Do you foresee any issues or further special c

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

JonasToth added a comment. LG from my side, besides the small nits. Please let @aaron.ballman have a look as well. thanks for the patch :) Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousMemoryComparisonCheck.cpp:45 + + // check if comparing padding in base +

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

xazax.hun added a comment. In D72097#1801777 , @gribozavr2 wrote: > Could you provide a more fleshed out example of a case where it is useful? Sure! The `std::any` could be one example (`std::variant` is similar, but ultimately, we migh want to be able

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. arames added a reviewer: rsmith. This allows specifying `*` for the filename to match any file. For example: // expected-note@*:* {{Match this note in any file at any line.}} // expected-note@

[PATCH] D72103: [Sema] Avoid using an invalid InsertPos

Mordante created this revision. Mordante added reviewers: lvoufo, rsmith. Mordante added a project: clang. The function `Sema::CheckVarTemplateId` tries to find a template specialization. If that fails it gets an `InsertPos` where the specialization should be added in a `FoldingSet`. Then it tri

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames added a comment. This is for example useful to add a catch-all clause like `// expected-note-re@*:* 1+ {{candidate function {{.+` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100 __

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D72103: [Sema] Avoid using an invalid InsertPos

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61175 tests passed, 0 failed and 729 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[clang] 1fcc9b6 - [OPENMP] Restore allowing of braced initializers in the declare reduction

Author: Alexey Bataev Date: 2020-01-02T16:10:17-05:00 New Revision: 1fcc9b6ff8558efed0c1241c72f69d079baeecf8 URL: https://github.com/llvm/llvm-project/commit/1fcc9b6ff8558efed0c1241c72f69d079baeecf8 DIFF: https://github.com/llvm/llvm-project/commit/1fcc9b6ff8558efed0c1241c72f69d079baeecf8.diff

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth marked 6 inline comments as done. JonasToth added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/AddConstTest.cpp:1006 +} + +} // namespace test aaron.ballman wrote: > JonasToth wrote: > > aaron.ballman wrote: > > > Can you also add

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth updated this revision to Diff 235938. JonasToth added a comment. - add proper objc test, that fail mostly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 Files: clang-tools-extra/clang-tidy/perf

[clang] a58da1a - [OPENMP50]Codegen for lastprivate conditional list items.

Author: Alexey Bataev Date: 2020-01-02T16:43:00-05:00 New Revision: a58da1a2ff039dd3bb4c43db3919995cf4a74cc7 URL: https://github.com/llvm/llvm-project/commit/a58da1a2ff039dd3bb4c43db3919995cf4a74cc7 DIFF: https://github.com/llvm/llvm-project/commit/a58da1a2ff039dd3bb4c43db3919995cf4a74cc7.diff

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

CJ-Johnson updated this revision to Diff 235944. CJ-Johnson added a comment. Rebase on head CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def clang/include/clang/Basic/Sanitizers.def clang/includ

[PATCH] D72110: [X86] ABI compat bugfix for MSVC vectorcall

rnk created this revision. rnk added reviewers: erichkeane, craig.topper. Herald added a project: clang. Before this change, X86_32ABIInfo::classifyArgument would be called twice on vector arguments to vectorcall functions. This function has side effects to track GPR register usage, and this would

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

CJ-Johnson updated this revision to Diff 235948. CJ-Johnson edited the summary of this revision. CJ-Johnson added a comment. Herald added a project: clang. Fixing rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.

[PATCH] D72110: [X86] ABI compat bugfix for MSVC vectorcall

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61175 tests passed, 0 failed and 729 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D72057: [docs] Update dead anchor in hacking page

AlexanderLanin marked an inline comment as done. AlexanderLanin added inline comments. Comment at: clang/www/hacking.html:301 - It is also possible to https://llvm.org/docs/GettingStarted.html#sending-patches-with-git";>use git to contribute to Clang. + It is also possible t

[PATCH] D72113: [CMake] clang-scan-deps in Fuchsia distribution

phosek created this revision. phosek added a reviewer: xazax.hun. Herald added subscribers: cfe-commits, tschuett, rnkovacs, mgorny. Herald added a project: clang. We would like to use clang-scan-deps in Fuchsia build so include it in the toolchain distribution. Repository: rG LLVM Github Mono

[PATCH] D72113: [CMake] clang-scan-deps in Fuchsia distribution

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72113/new/ https://reviews.llvm.org/D72113 __

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk created this revision. rnk added reviewers: rjmccall, craig.topper, erichkeane. Herald added a project: clang. MSVC 2013 would refuse to pass highly aligned things (typically vectors and aggregates) by value. Users would receive this error: t.cpp(11) : error C2719: 'w': formal parameter wit

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri added a comment. For future reference, if anyone needs here's the C versions of these builtins: https://godbolt.org/z/oHeAh- ^ looks like we are missing some backend-level folds for round-down variant, filed https://bugs.llvm.org/show_bug.cgi?id=8 Repository: rG LLVM Github Mo

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze updated this revision to Diff 235965. gbencze added a comment. Punctuation in comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71973/new/ https://reviews.llvm.org/D71973 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bu

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze marked 4 inline comments as done. gbencze added a comment. Thanks for all the feedback @JonasToth :) Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-suspicious-memory-comparison.rst:10 +This check corresponds to the CERT C Coding Standard rule +`EXP42-C.

[clang] b63bc64 - [CMake] clang-scan-deps in Fuchsia distribution

Author: Petr Hosek Date: 2020-01-02T16:49:52-08:00 New Revision: b63bc648a489c0f4d78203ae44cc1e9a6f9bcada URL: https://github.com/llvm/llvm-project/commit/b63bc648a489c0f4d78203ae44cc1e9a6f9bcada DIFF: https://github.com/llvm/llvm-project/commit/b63bc648a489c0f4d78203ae44cc1e9a6f9bcada.diff LO

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

nridge updated this revision to Diff 235970. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72066/new/ https://reviews.llvm.org/D72066 Files: clang-tools-ext

[PATCH] D72057: [docs] Remove outdated svn/git information from hacking page

AlexanderLanin updated this revision to Diff 235968. AlexanderLanin retitled this revision from "[docs] Update dead anchor in hacking page" to "[docs] Remove outdated svn/git information from hacking page". AlexanderLanin edited the summary of this revision. AlexanderLanin added a comment. Not su

[PATCH] D72113: [CMake] clang-scan-deps in Fuchsia distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rGb63bc648a489: [CMake] clang-scan-deps in Fuchsia distribution (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72113/new/ https://reviews

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

bd1976llvm added a comment. Sorry for the delay in updating this. I hoped to post an updated patch today for this but I realized that I first need to investigate whether section relative references might interact badly with multiple sections with the same name.. I will be able to update the pat

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61163 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is mostly a workaround for https://bugs.llvm.org/show_bug.cgi?id=42914. Once that is fixed, the handling in VisitDeducedTyped()

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

rjmccall added a comment. The solution described in that comment is not acceptable. We are not going to tell users that they cannot assign symbols explicitly to sections because LLVM is unable to promise not to miscompile if they do. It is LLVM's responsibility to correctly compile valid code

[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

njames93 created this revision. njames93 added a reviewer: aaron.ballman. njames93 added projects: clang, clang-tools-extra. Herald added a subscriber: xazax.hun. Fixes (clang-tidy) readability-identifier-naming misses fixing member variables in destructor

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. LLVM Release Schedule: 10.0.0: Jan 15, 2020: branch, then rc1 It would be nice to get a reply to my mail proposal before the branch.. so we could push the code for LLVM 10. (If it was lost, I can resend it) It can likely upset both sides, but with the proposal in th

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

sdmitriev added inline comments. Comment at: llvm/test/Other/opt-O2-pipeline.ll:1 -; RUN: opt -mtriple=x86_64-- -O2 -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck %s +; RUN: opt -mtriple=x86_64-- -O2 -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck --check-pre

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

nhlubek added a comment. Required change for break after colon: https://github.com/llvm-mirror/clang/pull/67 New unit test shows use case that is not covered currently. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14484/new/ https://reviews.llvm.org/D14484 _

<    1   2