[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

kamleshbhalui updated this revision to Diff 234796. kamleshbhalui added a comment. removed c++11 from the test. I do not have commit access, Can someone commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71619/new/ https://reviews.llvm.org/D71619 Files: clang/lib/Sema/

[PATCH] D69876: Allow output constraints on "asm goto"

nickdesaulniers added a comment. In D69876#1791663 , @void wrote: > I'm not getting the `Undefined temporary symbol` in your example (even with > optimizations): > > [morbo@fawn:llvm-project] clang -o - -S ../bug.c > `-S` is going the AsmPrinter route

[PATCH] D71731: [Format] fix dereference of pointers in co_yeld and co_return statements

sugak created this revision. sugak added reviewers: modocache, sammccall, arthur.j.odwyer. Herald added a project: clang. Herald added a subscriber: cfe-commits. sugak edited the summary of this revision. // Before: co_yield* x; co_return* x; // After: co_yield *x; co_return *x; Add u

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno created this revision. bruno added reviewers: rsmith, arphaman, vsapsai, martong. Herald added subscribers: cfe-commits, ributzka, dexonsmith, jkorous, rnkovacs. Herald added a reviewer: jdoerfert. Herald added a project: clang. Take `struct Z {...}` defined differently and imported from bot

[PATCH] D71731: [Format] fix dereference of pointers in co_yeld and co_return statements

modocache added a comment. Nice! Thanks for this. This looks good to me, but I'll defer to the other reviewers you specified, since I think they're more familiar with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71731/new/ https://r

[PATCH] D59254: [RFC] Implementation of Clang randstruct

xbolva00 added a comment. Re-ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59254/new/ https://reviews.llvm.org/D59254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

MadCoder updated this revision to Diff 234810. MadCoder added a comment. Removed the category from the direct method name mangling as discussed with @aprantl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71694/new/ https://reviews.llvm.org/D71694 Files: clang/include/clang/Basic/Dia

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

efriedma added a comment. To be rigorous, we should perform "pointer" checking for every operation that performs pointer arithmetic. Then we should perform "lvalue" checking (which doesn't allow pointers one past the end) in the following places: 1. When we take the address of an lvalue. 2. Wh

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

jdoerfert created this revision. jdoerfert added reviewers: hfinkel, xbolva00, lebedev.ri, nikic, Tyker, rjmccall, spatel. Herald added subscribers: bollu, hiraditya. Herald added projects: clang, LLVM. NOTE: This is a prototype not a finished patch! NOTE: There is a mailing list discussion on th

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

jdoerfert updated this revision to Diff 234817. jdoerfert added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/alloc-al

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D71686: Fix false positive in magic number checker

0x8000- updated this revision to Diff 234818. 0x8000- edited the summary of this revision. 0x8000- added a comment. Update release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 Files: clang-tools-extra/clang-tidy/readabili

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added a comment. In D59254#1792068 , @xbolva00 wrote: > Re-ping Still under development here: https://github.com/connorkuehl/llvm-project/tree/randstruct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D71686: Fix false positive in magic number checker

0x8000- updated this revision to Diff 234819. 0x8000- added a comment. Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 Files: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp clang-tools-extra/docs/ReleaseNote

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

annita.zhang added a comment. > To be concrete, I propose: > ".autopad", ".noautopad": allow/disallow the assembler to emit padding via > inserting a nop or prefix before any instruction, as needed. > ".align_branch_boundary [N,] [instruction,]": Enable branch-boundary padding > (per previous

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60947 tests passed, 20 failed and 726 were skipped. failed: Clang.CodeGen/align_value.cpp failed: Clang.CodeGen/builtin-assume-aligned.c failed: Clang.CodeGen/builtin-movdir.c failed: Clang.CodeGen/catch-a

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan added a comment. In D70157#1791347 , @reames wrote: > The general question is why a *range* of fragments can't be defined. > Computing the instruction size for the entire range then just requires > walking from first to last fragment in the range s

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen added a comment. In D71387#1790413 , @efriedma wrote: > > But in RISCV clang emits the same IR for different ABI (-mabi), > > This is not true. For simple cases, it does, yes, but there are some weird > edge cases for functions with many arguments

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

rsmith added a comment. In D71714#1792085 , @efriedma wrote: > To be rigorous, we should perform "pointer" checking for every operation that > performs pointer arithmetic. Then we should perform "lvalue" checking (which > doesn't allow pointers one past

[clang] de21704 - CWG2352: Allow qualification conversions during reference binding.

Author: Richard Smith Date: 2019-12-19T18:37:55-08:00 New Revision: de21704ba96fa80d3e9402f12c6505917a3885f4 URL: https://github.com/llvm/llvm-project/commit/de21704ba96fa80d3e9402f12c6505917a3885f4 DIFF: https://github.com/llvm/llvm-project/commit/de21704ba96fa80d3e9402f12c6505917a3885f4.diff

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

rjmccall added inline comments. Comment at: clang/lib/AST/StmtProfile.cpp:777 +if (E) + Profiler->VisitStmt(E); + } Can `E` actually be null here? Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNont

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

MaskRay added inline comments. Comment at: llvm/lib/MC/MCAssembler.cpp:993 + MCBoundaryAlignFragment &BF) { + // The MCBoundaryAlignFragment that doesn't emit NOP should not relax. + if (!BF.canEmitNops()) be relaxed ==

[PATCH] D69876: Allow output constraints on "asm goto"

void added a comment. In D69876#1791989 , @nickdesaulniers wrote: > In D69876#1791663 , @void wrote: > > > I'm not getting the `Undefined temporary symbol` in your example (even with > > optimizations): > > > >

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

rjmccall added a comment. Okay, if this is just handling OpenMP-specific control flow and doesn't need to interact with what a reasonable frontend would do with cleanups, I'm appeased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ http

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen planned changes to this revision. khchen marked an inline comment as done. khchen added a comment. The problem is how `-mcpu` interact with explicitly specified `-march` (or target features). 1. in GCC, -mcpu is only used to chose the pipeline model, 2. I also read this

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan marked an inline comment as done. skan added inline comments. Comment at: llvm/lib/MC/MCAssembler.cpp:1003 + // exists) also marks the end of the branch. + for (auto i = 0U, N = BF.isFused() ? 2U : 1U; + i != N && !isa(F); ++i, F = F->getNextNode()) { ---

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan updated this revision to Diff 234830. skan added a comment. 1. Simplify the test cases. 2. Add some comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 Files: llvm/include/llvm/MC/MCAsmBackend.h llvm/include/llvm/MC/MCAssembler.h

<    1   2