[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) || (A == OMPC_lastprivate && Data.Attr

[PATCH] D70157: Align branches within 32-Byte boundary

jyknight added a comment. > .push_align_branch_boundary [N,] [instruction,]* I'd like to raise again the possibility of using a more general region directive to denote "It is allowable to add prefixes/nops before instructions in this region if the assembler wants to", as I'd started discussing

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) || (A == OMPC_lastprivate && Data.At

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen added a comment. In D71475#1787914 , @ABataev wrote: > Here is more proper fix. We don't need to capture just `k` here, instead, we > need to capture the whole expression. > Linear clause has a little bit different processing rather than all other

[PATCH] D71613: [cmake] Use 'llvm-config --components' to determine components

mgorny created this revision. mgorny added reviewers: dberris, justinkb. Herald added projects: LLVM, Sanitizers. Herald added subscribers: llvm-commits, Sanitizers. Use 'llvm-config --components' to determine available components rather than relying on '--libs' to fail for non-available. This sh

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

mgorny added a comment. I've tried fixing llvm-config but that's non-trivial. If I fix it to correctly recognize which components are included in dylib, and return other libraries directly, it just uncovers other problems. Please see if D71613 fixes your proble

[PATCH] D71612: [analyzer] Add PlacementNewChecker

whisperity added a comment. Are buffers otherwise modelled by the Analyser, such as results of the `malloc` family and `alloca` intentionally not matched, or are there some tests missing regarding this? Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:115-1

[PATCH] D71588: [objc_direct] fix uniquing when re-declaring a readwrite-direct property

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, But we should also have a test in Sema that verifies it works, and also covers class properties in addition to the instance ones. I can add one when committing (@MadCoder still doesn

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan updated this revision to Diff 234312. skan retitled this revision from "Align branches within 32-Byte boundary" to "Align branches within 32-Byte boundary(NOP padding)". skan edited the summary of this revision. skan added a comment. **Simplify** 1. Drop prefix padding support 2. Drop clang

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen added a comment. In D71387#1786518 , @efriedma wrote: > My primary concern with this is that I'm not sure you should be passing this > information separately, as opposed to encoding it into the bitcode. > > On ARM, the ABI for a file is generally d

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

khchen marked an inline comment as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:585 +const llvm::opt::ArgList &Args, +llvm::opt::ArgStringList &CmdArgs) { + // -mabi is

[PATCH] D71615: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir

mgorny created this revision. mgorny added reviewers: arichardson, aaron.ballman, rsmith, compnerd. Use correct directory to put gen_ast_dump_json_test.py instead of LLVM_BINARY_DIR. This fixes attempting to write to /usr when building clang standalone. https://reviews.llvm.org/D71615 Files:

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

riccibruno updated this revision to Diff 234317. riccibruno edited the summary of this revision. riccibruno added a comment. Rebased on top of current master. No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57659/new/ https://reviews.llvm.org

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1128 + (A == OMPC_firstprivate && (Data.Attributes == OMPC_lastprivate || + Data.Attributes == OMPC_linear)) || (A == OMPC_lastprivate && Data.Attr

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno updated this revision to Diff 234320. riccibruno added a comment. Rebased on top of current master and D57659 . No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D

[PATCH] D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

riccibruno updated this revision to Diff 234322. riccibruno added a comment. Rebased on top of current master and D57747 . No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58297/new/ https://reviews.llvm.org/D

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno updated this revision to Diff 234323. riccibruno added a comment. Rebased on top of current master and D58297 . Friendly ping ! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58579/new/ https://reviews.llvm.org/D58579

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille updated this revision to Diff 234327. serge-sans-paille added a comment. Support %% and %c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71566/new/ https://reviews.llvm.org/D71566 Files: clang/include/clang/Basic/DiagnosticSema

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

xbolva00 added a comment. Hello @aaron.ballman / @rsmith, can you please take a look so this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 ___ cfe-commits mailing lis

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

xbolva00 added a comment. Maybe @aaron.ballman / @rsmith could take a look? This patch blocks the whole patch stack. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58579/new/ https://reviews.llvm.org/D58579 ___ cfe-c

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

stella.stamenova added a comment. This broke the windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/11751 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020 __

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno updated this revision to Diff 234326. riccibruno edited the summary of this revision. riccibruno added a comment. I have factored out various NFCs which were present in this patch. This should make review easier. Also addressed some inline comments. Repository: rC Clang CHANGES SI

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { kadircet wrote: > ilya-biryukov wrote: > > What's the purpose o

[PATCH] D69088: [Lex] #pragma clang transform

greened added a comment. In D69088#1772141 , @rjmccall wrote: > This is a major new language feature, and code review is probably not the > right venue for reviewing it; there should be a thread on cfe-dev. My > apologies if that's already been discusse

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno added a comment. In D58579#1788164 , @riccibruno wrote: > In D58579#1788125 , @xbolva00 wrote: > > > Maybe @aaron.ballman / @rsmith could take a look? This patch blocks the > > whole patch stack. > > > I

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. Note that I am not entirely sure that the implementation in `getMemoryLocation`/`MemoryLocation` is the right way to do this; I think that this patch should be considered a work-in-progress. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D71197: llvm premerge: clang format test

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60748 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno added a comment. In D58579#1788125 , @xbolva00 wrote: > Maybe @aaron.ballman / @rsmith could take a look? This patch blocks the whole > patch stack. I rebased it on top of the others already accepted patches. I just need to get back +w acces

[PATCH] D70764: build: reduce CMake handling for zlib

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. I think this is good, and it has been sitting a while. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70764/new/ https://reviews.llvm.org/D70764

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnsignedSubtractionCheck.cpp:21 + +void UnsignedSubtractionCheck::registerMatchers(MatchFinder *Finder) { + const auto UnsignedIntType = hasType(isUnsignedInteger()); The check'

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

ABataev added a comment. The fixed patch. Several codegen tests require some adjustment. diff --git a/clang/lib/Sema/SemaOpenMP.cpp b/clang/lib/Sema/SemaOpenMP.cpp index afe0f1a..ecb0fb2 100644 --- a/clang/lib/Sema/SemaOpenMP.cpp +++ b/clang/lib/Sema/SemaOpenMP.cpp @@ -919,6 +919,11 @@

[PATCH] D71594: testing clang-tidy

Eugene.Zelenko added a comment. Where set of Clang-tidy checks come from? .clang-tidy? Could stricter set of custom rules be used? Comment at: clang/include/clang/Analysis/AnalysisDeclContext.h:527 -#endif // LLVM_CLANG_ANALYSIS_ANALYSISDECLCONTEXT_H +#endif

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1772141 , @rjmccall wrote: > This is a major new language feature, and code review is probably not the > right venue for reviewing it; there should be a thread on cfe-dev. My > apologies if that's already been discu

[PATCH] D71619: [CLANG] Alignment specifier not applied to anonymous structure or union

kamleshbhalui created this revision. kamleshbhalui added reviewers: rsmith, aaron.ballman, dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. Apply attributes on anonymous records. This Fixes https://bugs.llvm.org/show_bug.cgi?id=43983. Repository: rG LLVM Github

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj marked an inline comment as done. sorenj added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnsignedSubtractionCheck.cpp:21 + +void UnsignedSubtractionCheck::registerMatchers(MatchFinder *Finder) { + const auto UnsignedIntType = hasType(isUnsignedIn

[clang] 25ce33a - [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

Author: Alex Lorenz Date: 2019-12-17T10:26:32-08:00 New Revision: 25ce33a6e4f3b13732c0f851e68390dc2acb9123 URL: https://github.com/llvm/llvm-project/commit/25ce33a6e4f3b13732c0f851e68390dc2acb9123 DIFF: https://github.com/llvm/llvm-project/commit/25ce33a6e4f3b13732c0f851e68390dc2acb9123.diff L

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG25ce33a6e4f3: [driver][darwin] Pass -platform_version flag to the linker instead of the… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

thakis added a comment. Looks like this breaks building on Windows in general: http://45.33.8.238/win/4247/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020 _

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Looks good for D/U, but looks like --help and --version options are also supported as combined short args; do you mind adding those too while you're here? Thanks for the patch! =

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

probinson added a comment. > "DW_TAG_unspecified_type auto" should be emitted for the function > declared/defined as auto returnning. Do you have other test cases in mind, > where above points diverges ?? The declaration would have DW_AT_type point to DW_TAG_unspecified_type, but the definitio

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

probinson added a comment. @dblaikie let me reflect this back to make sure I get it: Template members (methods or variables) would never appear in the *metadata* description of the struct; but metadata descriptions of the instances would refer back to that struct (as the scope for the instance).

[clang] 55c55f8 - Revert "[ASTImporter] Friend class decl should not be visible in its context"

Author: Nico Weber Date: 2019-12-17T13:43:50-05:00 New Revision: 55c55f8eb86ba3e77fe73ccdf7c861e2c2c7ae92 URL: https://github.com/llvm/llvm-project/commit/55c55f8eb86ba3e77fe73ccdf7c861e2c2c7ae92 DIFF: https://github.com/llvm/llvm-project/commit/55c55f8eb86ba3e77fe73ccdf7c861e2c2c7ae92.diff LO

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

thakis added a comment. Reverted in 55c55f8eb86ba3e77fe for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

xiaobai added a reviewer: vsk. xiaobai added a subscriber: vsk. xiaobai added a comment. Adding @vsk since he added the code that you're referencing in your summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71585/new/ https://reviews.llvm.org/

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm. Separately, if you have the bandwidth to test out the new '%c%m' mode (https://clang.llvm.org/docs/SourceBasedCodeCoverage.html#running-the-instrumented-program / https://reviews.llvm.org/D68

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnsignedSubtractionCheck.cpp:21 + +void UnsignedSubtractionCheck::registerMatchers(MatchFinder *Finder) { + const auto UnsignedIntType = hasType(isUnsignedInteger()); sorenj wro

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun updated this revision to Diff 234341. xazax.hun added a comment. - Added string argument to specify the handle type. - Only AcquireHandleAttr can be a type attribute and it can only be applied to function types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https:/

[PATCH] D71588: [objc_direct] fix uniquing when re-declaring a readwrite-direct property

arphaman added a comment. I couldn't come up with a reasonable Sema-based test, so I'm going to commit this as it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71588/new/ https://reviews.llvm.org/D71588 _

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

rjmccall resigned from this revision. rjmccall added a comment. I opposed the creation of this library on these terms in the first place, so I'm pretty sure I'm not on the hook to review it. Introducing an IRBuilder-level finalization stack sounds like it's going to be a huge mess if your goal

[clang] a4e1819 - [objc_direct] fix uniquing when re-declaring a readwrite-direct property

Author: Pierre Habouzit Date: 2019-12-17T11:07:48-08:00 New Revision: a4e1819c16836dba928e646024a2406bb2eb3f94 URL: https://github.com/llvm/llvm-project/commit/a4e1819c16836dba928e646024a2406bb2eb3f94 DIFF: https://github.com/llvm/llvm-project/commit/a4e1819c16836dba928e646024a2406bb2eb3f94.dif

[PATCH] D71588: [objc_direct] fix uniquing when re-declaring a readwrite-direct property

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4e1819c1683: [objc_direct] fix uniquing when re-declaring a readwrite-direct property (authored by MadCoder, committed by arphaman). Changed prior to commit: https://reviews.llvm.org/D71588?vs=234215&i

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk added inline comments. Comment at: compiler-rt/lib/ubsan/ubsan_value.cpp:29 +const char *__ubsan::getObjCClassName(ValueHandle Pointer) { +#if defined(__APPLE__) + // We need to query the ObjC runtime for some information, but do not want delcypher wrote: >

[clang] 599d1cc - [Clang FE, SystemZ] Recognize -mpacked-stack CL option

Author: Jonas Paulsson Date: 2019-12-17T11:26:17-08:00 New Revision: 599d1cc07a51e9a556afa2a995930f7ffe0e42cd URL: https://github.com/llvm/llvm-project/commit/599d1cc07a51e9a556afa2a995930f7ffe0e42cd DIFF: https://github.com/llvm/llvm-project/commit/599d1cc07a51e9a556afa2a995930f7ffe0e42cd.diff

[PATCH] D71513: [compiler-rt] [test] Disable MPROTECT on two builtin tests

mgorny updated this revision to Diff 234351. mgorny edited the summary of this revision. mgorny added a comment. Switch to using `%run_nomprotect` instead of extra `%paxctl`. This should be more consistent and should avoid potential issues with `:` on Windows. CHANGES SINCE LAST ACTION https:

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

xinxinw1 added a comment. @vsk Thanks! The %c mode looks pretty cool but yeah, I don't really have the bandwidth to test it right now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71585/new/ https://reviews.llvm.org/D71585 _

[PATCH] D71612: [analyzer] Add PlacementNewChecker

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:22 +ProgramStateRef State) const; + mutable std::unique_ptr BT_Placement; +}; I think now it is safe to have the bugtype by value and

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert added a subscriber: rjmccall. jdoerfert added a comment. In D70258#1788305 , @rjmccall wrote: > I opposed the creation of this library on these terms in the first place, so > I'm pretty sure I'm not on the hook to review it. That's fine with m

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

ilya-biryukov updated this revision to Diff 234359. ilya-biryukov marked 24 inline comments as done. ilya-biryukov added a comment. - Addressed most comments - Rebased onto HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64573/new/ https://revie

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

reames added a comment. In D70157#1787403 , @annita.zhang wrote: > In D70157#1787160 , @MaskRay wrote: > > > > > > > > > There is a precedant: .pushsection/.popsection (MCStreamer::SectionStack). > > With .push_al

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/BuildTree.h:25 +/// Allows to create syntax trees from subtrees not backed by the source code. +class Factory { +public: gribozavr2 wrote: > Why a class to contain static function

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

reames added a comment. In D70157#1788025 , @jyknight wrote: > > .push_align_branch_boundary [N,] [instruction,]* > > I'd like to raise again the possibility of using a more general region > directive to denote "It is allowable to add prefixes/nops before

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

rjmccall added a comment. In D70258#1788396 , @jdoerfert wrote: > In D70258#1788305 , @rjmccall wrote: > > > Introducing an IRBuilder-level finalization stack sounds like it's going to > > be a huge mess if your go

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60958 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[clang] b3f789e - [perf-training] Change profile file pattern string to use %4m instead of %p

Author: Xin-Xin Wang Date: 2019-12-17T12:12:21-08:00 New Revision: b3f789e037cbfdb1439c01a4eefc9ab9bb0d2c64 URL: https://github.com/llvm/llvm-project/commit/b3f789e037cbfdb1439c01a4eefc9ab9bb0d2c64 DIFF: https://github.com/llvm/llvm-project/commit/b3f789e037cbfdb1439c01a4eefc9ab9bb0d2c64.diff

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

reames added a comment. Specifically on the revised patch, I remain confused by the need for multiple subtypes. The need for fragments *between* the potentially fused instructions doesn't make sense to me. What I was expecting to see was the following: BoundaryAlign w/target=the branch fragmen

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. I tested the configurations mentioned at https://groups.google.com/d/topic/polly-dev/vxumPMhrSEs/discussion again and did not find any issues that were not there before. Therefore IMHO

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3f789e037cb: [perf-training] Change profile file pattern string to use %4m instead of %p (authored by xinxinw1, committed by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 3853390 - [Frontend] Fixes -Wrange-loop-analysis warnings

Author: Mark de Wever Date: 2019-12-17T21:52:47+01:00 New Revision: 385339034f08212d95ade89fdbacb014d86be1e2 URL: https://github.com/llvm/llvm-project/commit/385339034f08212d95ade89fdbacb014d86be1e2 DIFF: https://github.com/llvm/llvm-project/commit/385339034f08212d95ade89fdbacb014d86be1e2.diff

[PATCH] D71530: [Frontend] Fixes -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG385339034f08: [Frontend] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71530/new/ https://revie

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

efriedma added a comment. > Unfortunately on RISCV, the ABI info is only derived from -mabi option and > the target triple does not encode ABI info (same to gcc). How does gcc decide the default ABI for a target? Do you explicitly specify it at configure time? > example 1: > What's expected

[PATCH] D71623: [compiler-rt] [test] Add missing %run to fread_fwrite MSAN test

mgorny created this revision. mgorny added reviewers: krytarowski, m.ostapenko, eugenis. Herald added subscribers: llvm-commits, Sanitizers, dberris. Herald added projects: LLVM, Sanitizers. Add a missing %run substitution to fread_fwrite test. This fixes the test on NetBSD where %run disables AS

[clang] 3ec6128 - [Sema] Fixes -Wrange-loop-analysis warnings

Author: Mark de Wever Date: 2019-12-17T21:54:32+01:00 New Revision: 3ec6128daeeaadde7dd2eca8b343a56f60a8364d URL: https://github.com/llvm/llvm-project/commit/3ec6128daeeaadde7dd2eca8b343a56f60a8364d DIFF: https://github.com/llvm/llvm-project/commit/3ec6128daeeaadde7dd2eca8b343a56f60a8364d.diff

[clang] b750486 - [Driver] Avoid copies in range-based for loops

Author: Mark de Wever Date: 2019-12-17T21:56:04+01:00 New Revision: b750486c5d96320daf77a9760166f78b4a0c942e URL: https://github.com/llvm/llvm-project/commit/b750486c5d96320daf77a9760166f78b4a0c942e DIFF: https://github.com/llvm/llvm-project/commit/b750486c5d96320daf77a9760166f78b4a0c942e.diff

[PATCH] D71527: [Driver] Avoid copies in range-based for loops

This revision was automatically updated to reflect the committed changes. Closed by commit rGb750486c5d96: [Driver] Avoid copies in range-based for loops (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71527/new/ https://review

[PATCH] D71529: [Sema] Fixes -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec6128daeea: [Sema] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71529/new/ https://reviews.l

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

epastor updated this revision to Diff 234371. epastor marked 6 inline comments as done. epastor added a comment. - Address refactoring comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71436/new/ https://reviews.llvm.org/D71436 Files: clang

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

epastor added a comment. Thanks for feedback! Comment at: clang/test/CodeGen/ms-inline-asm-64.c:18 // CHECK: call void asm sideeffect inteldialect -// CHECK-SAME: mov [eax], $0 +// CHECK-SAME: mov qword ptr [eax], $0 // CHECK-SAME: "r,~{dirflag},~{fpsr},~{flags}"(i32* %{{.*}}

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

vvereschaka created this revision. vvereschaka added reviewers: aorlov, andreil99, broadwaylamb. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. Herald added a project: clang. Added two confguration argument to provide a host name and SSH user name to run the tests on the remote tar

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

jyknight added a comment. In D70157#1788418 , @reames wrote: > In D70157#1788025 , @jyknight wrote: > > > > .push_align_branch_boundary [N,] [instruction,]* > > > > I'd like to raise again the possibility of using a

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

efriedma added a comment. > Perhaps we can clarify the intent that the non-faulting mode may have > side-effects by renaming the flag to something like > NonFaultingWithSideEffects? We could specify something like that... but that probably requires some changes to target-independent DAGCombine

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60854 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

Mordante added a comment. In D68913#1787784 , @thakis wrote: > Mordante, do you need someone to land this for you? Thanks for the offer, but it's not required. I want to commit it once I fixed all issues that would be introduced by D68912

[PATCH] D71612: [analyzer] Add PlacementNewChecker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:40 +if (const auto *ERegion = dyn_cast(TVRegion)) { + const auto *SRegion = cast(ERegion->getSuperRegion()); + DefinedOrUnknownSVal Extent = SRegion->getExtent(svalBuilder

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

phosek added a comment. I'm not sure if the detection is working correctly, this is failing on our macOS toolchain bots: FAIL: Clang :: Driver/darwin-ld-platform-version-ios.c (5284 of 16450) TEST 'Clang :: Driver/darwin-ld-platform-version-ios.c' FAILED ***

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. @phosek Thanks, I think it reproduces on our macOS bots. I'll start fixing it right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

rnk added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2551 + // actually handle multiple TUs defining the same wrapper. + if (CGM.getTriple().isOSWindows() && CGM.supportsCOMDAT() && + Wrapper->isWeakForLinker()) IMO we should be doing

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

jdenny added a comment. In D71408#1788582 , @thopre wrote: > This is embarrassing. It happens. > I presume ninja check-all includes those 2 tests so I'm not sure how I missed > it. It should. > On a related note, I used to receive mail notification w

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

thopre added a subscriber: nemanjai. thopre added a comment. Herald added a subscriber: wuzish. In D71408#1787959 , @jdenny wrote: > This breaks the lit test suite. `llvm/utils/lit/tests/shtest-format.py` > needs to be updated for the removed tests. Th

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. Looks like `HOST_LINK_VERSION` is influencing the decision. I should specify the version manually in the tests then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579

[clang] be88a20 - [driver][darwin] Use explicit -mlinker-version in the -platform_version tests

Author: Alex Lorenz Date: 2019-12-17T14:25:22-08:00 New Revision: be88a20c900463c4919433109e4c17cd001da580 URL: https://github.com/llvm/llvm-project/commit/be88a20c900463c4919433109e4c17cd001da580 DIFF: https://github.com/llvm/llvm-project/commit/be88a20c900463c4919433109e4c17cd001da580.diff L

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2551 + // actually handle multiple TUs defining the same wrapper. + if (CGM.getTriple().isOSWindows() && CGM.supportsCOMDAT() && + Wrapper->isWeakForL

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. @phosek I fixed the tests in be88a20c900463c4919433109e4c17cd001da580 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2551 + // actually handle multiple TUs defining the same wrapper. + if (CGM.getTriple().isOSWindows() && CGM.supportsCOMDAT() && + Wrapper->isWeakForL

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

dblaikie added a comment. In D70537#1788252 , @probinson wrote: > @dblaikie let me reflect this back to make sure I get it: > Template members (methods or variables) would never appear in the *metadata* > description of the struct; but metadata descripti

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1787566 , @SouraVX wrote: > > It looks like this implementation is a bit buggy in one way and incomplete > > in another: > > > > 1. even if the auto-returning function is defined, that function definition > > doesn't

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

dblaikie added a comment. In D71451#1787729 , @Jac1494 wrote: > In D71451#1786517 , @dblaikie wrote: > > > Do you have any particular users/use case for this? > > > A case when shared library built without debug in

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d3f43ec61a6: [analysis] Discard type qualifiers when casting values retrieved from the Store. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D70836?vs=231473&id=234397#toc

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

broadwaylamb added a comment. LGTM Comment at: clang/cmake/caches/CrossWinToARMLinux.cmake:88-91 +set(LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXXABI OFF CACHE BOOL "") +set(LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXX OFF CACHE BOOL "") +set(LIBCXX_LINK_TESTS_WITH_SHARED_LIBCXX

[clang] 6d3f43e - [analysis] Discard type qualifiers when casting values retrieved from the Store.

Author: Artem Dergachev Date: 2019-12-17T15:00:41-08:00 New Revision: 6d3f43ec61a60c37963ee5f54289cf0759fb5d61 URL: https://github.com/llvm/llvm-project/commit/6d3f43ec61a60c37963ee5f54289cf0759fb5d61 DIFF: https://github.com/llvm/llvm-project/commit/6d3f43ec61a60c37963ee5f54289cf0759fb5d61.dif

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert added a comment. In D70258#1788427 , @rjmccall wrote: > In D70258#1788396 , @jdoerfert wrote: > > > In D70258#1788305 , @rjmccall > > wrote: > > > > > Introducing

<    1   2   3   >