[PATCH] D71576: [c++20] Add deprecation warnings for the expression forms deprecated by P1120R0.

rsmith marked 3 inline comments as done. rsmith added inline comments. Comment at: clang/lib/AST/Type.cpp:1865-1866 // enumeration type in the sense required here. // C++0x: However, if the underlying type of the enum is fixed, it is // considered complete. if (const

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

rsmith added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2522 + if (CGM.getTriple().isOSWindows()) +return llvm::GlobalValue::LinkOnceODRLinkage; return llvm::GlobalValue::WeakODRLinkage; I think the thread wrapper should probably be

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui added a comment. In D71508#1786804 , @dblaikie wrote: > In D71508#1786212 , @kamleshbhalui > wrote: > > > In D71508#1786148 , @probinson > > wrote: > > > > >

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ https://reviews.llvm.org/D70258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui added a comment. In D71508#1786799 , @aprantl wrote: > Are we sure we want to canonicalize *before* applying -fdebug-prefix-map in > `remapDIPath()`? Honest question, the answer could be yes :-) it canonicalizes before apply -fdebug-prefix

[PATCH] D66839: Fix stack address builtin for negative numbers

zoecarver added a comment. @Jim Thanks, I'll move it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/ https://reviews.llvm.org/D66839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

compnerd added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:60 + if (const auto *MD = dyn_cast_or_null(Parent)) +return true; +} Use `isa` rather than `dyn_cast_or_null`. Furthermore, the `dyn_ca

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

Jim added a comment. This patch is only for RISCV. The title should have prefix "[RISCV]". Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:585 +const llvm::opt::ArgList &Args, +llvm::opt::ArgStringList &CmdA

[PATCH] D71541: [Clang]: fix spelling mistake in assert message

Jim added a comment. Could you add "[NFC]" in the title. That means No Function Change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71541/new/ https://reviews.llvm.org/D71541 ___ cfe-commits mailing list cfe-commi

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

gparker42 accepted this revision. gparker42 added a comment. This revision is now accepted and ready to land. Good. `REQUIRES-ANY` was preserved when the boolean expressions were added because libc++ was still using it. libc++ has since changed their tests so removing it should be fine now. (pre

[PATCH] D70157: Align branches within 32-Byte boundary

annita.zhang added a comment. In D70157#1787139 , @reames wrote: > Here are the minutes from our phone call a few minutes ago. Thanks for coordinating the meeting and having a clear summary. It helps a lot to accelerate the patch review. I really apprec

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1786959 , @jdoerfert wrote: > In D71241#1786530 , @ABataev wrote: > > > Most probably, we can use this solution without adding a new expression. > > `DeclRefExpr` class can contai

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

MaskRay added a comment. Renaming `handleDeclOccurence`, `handleMacroOccurence` and `handleModuleOccurence` are definitely not NFC because they are public APIs that can be used by downstream projects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D71588: [objc_direct] fix uniquing when re-declaring a readwrite-direct property

MadCoder created this revision. MadCoder added reviewers: arphaman, rjmccall, dexonsmith. MadCoder added a project: clang. Herald added a subscriber: cfe-commits. MadCoder added a reviewer: liuliu. ObjCMethodDecl::getCanonicalDecl() for re-declared readwrite properties, only looks in the ObjCInter

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1787265 , @hfinkel wrote: > In D71241#1786959 , @jdoerfert wrote: > > > In D71241#1786530 , @ABataev wrote: > > > > > Most probably, we c

<    1   2   3