[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

erichkeane added a comment. In D71467#1786188 , @uweigand wrote: > In D71467#1785943 , @erichkeane > wrote: > > > I did the compare operators that didn't work right, and will do a separate > > patch for the fp-cla

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

steven_wu added a comment. The fix LGTM. Do you have a reproducer that can be used as a testcase? We should really add more tests for libunwind. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69893/new/ https://reviews.llvm.org/D69893 ___

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. In D71467#1786192 , @erichkeane wrote: > __builtin_fpclassify/isfinite/isinf/isinf_sign/isnan/isnormal/signbit are all > implemented the same as the OTHER ones, except there is a strange fixup step > in SEMA that removes the flo

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 234091. lewis-revill added a comment. Rebased and addressed StackSize vs RealStackSize error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 Files: clang/lib/Dr

[clang-tools-extra] 6af1ad2 - Revert "[clangd] Reapply b60896fad926 Fall back to selecting token-before-cursor if token-after-cursor fails."

Author: Sam McCall Date: 2019-12-16T19:07:49+01:00 New Revision: 6af1ad20d60ef8ea23f2cfdb02d299b3b3114b06 URL: https://github.com/llvm/llvm-project/commit/6af1ad20d60ef8ea23f2cfdb02d299b3b3114b06 DIFF: https://github.com/llvm/llvm-project/commit/6af1ad20d60ef8ea23f2cfdb02d299b3b3114b06.diff LO

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui added a comment. In D71508#1786148 , @probinson wrote: > In D71508#1786122 , @kamleshbhalui > wrote: > > > In D71508#1785767 , @probinson > > wrote: > > > > >

[clang] 411e81a - [OPENMP50]Add if clause in target teams idistribute simd directive.

Author: Alexey Bataev Date: 2019-12-16T13:20:57-05:00 New Revision: 411e81a4e391d9e8195e4b2a0a62bc60582e298a URL: https://github.com/llvm/llvm-project/commit/411e81a4e391d9e8195e4b2a0a62bc60582e298a DIFF: https://github.com/llvm/llvm-project/commit/411e81a4e391d9e8195e4b2a0a62bc60582e298a.diff

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui added a comment. In D69893#1786202 , @steven_wu wrote: > The fix LGTM. Do you have a reproducer that can be used as a test case? We > should really add more tests for libunwind. I currently do not have a reproducer test case for this. Re

[clang] ec3854e - [OPENMP][DOCS]Mark if clause on simd done, NFC.

Author: Alexey Bataev Date: 2019-12-16T13:25:58-05:00 New Revision: ec3854e58a62c9f255ae18e5982346f917456d85 URL: https://github.com/llvm/llvm-project/commit/ec3854e58a62c9f255ae18e5982346f917456d85 DIFF: https://github.com/llvm/llvm-project/commit/ec3854e58a62c9f255ae18e5982346f917456d85.diff

[clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

Author: John McCall Date: 2019-12-16T13:33:59-05:00 New Revision: 00bc76edddb5a6cd417610e96289a5dc15245867 URL: https://github.com/llvm/llvm-project/commit/00bc76edddb5a6cd417610e96289a5dc15245867 DIFF: https://github.com/llvm/llvm-project/commit/00bc76edddb5a6cd417610e96289a5dc15245867.diff L

[clang] c82e4ef - Always -I clang/include when tblgen'ing in Clang.

Author: John McCall Date: 2019-12-16T13:33:59-05:00 New Revision: c82e4ef6960b9f09fc77abc10f374417007f5f00 URL: https://github.com/llvm/llvm-project/commit/c82e4ef6960b9f09fc77abc10f374417007f5f00 DIFF: https://github.com/llvm/llvm-project/commit/c82e4ef6960b9f09fc77abc10f374417007f5f00.diff L

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

kparzysz added inline comments. Comment at: clang/test/Driver/hexagon-toolchain-elf.c:560 +// CHECK082-NOT: "-march=hexagon" +// CHECK082-NOT: "-mcpu=hexagon" kparzysz wrote: > I don't think there will ever be `"-mcpu=hexagon"` (including the quotation

[clang] 06a6b0a - [OPENMP][DOCS]Claim simd nontemporal clause, NFC.

Author: Alexey Bataev Date: 2019-12-16T13:38:58-05:00 New Revision: 06a6b0ad6584c16fa85a3e6bbcfd8ab87200baca URL: https://github.com/llvm/llvm-project/commit/06a6b0ad6584c16fa85a3e6bbcfd8ab87200baca DIFF: https://github.com/llvm/llvm-project/commit/06a6b0ad6584c16fa85a3e6bbcfd8ab87200baca.diff

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. In offline discussion, there was an agreement that we needed further coordination to make sure this patch moves forward quickly. For that reason, there will be a call happening today at 4pm Pacific. Interested parties are welcome to attend. Zoom Meeting ID: 507-497-88

Re: [clang] f978ea4 - [clang][clang-scan-deps] Aggregate the full dependency information.

On Mon, Dec 16, 2019 at 7:48 AM Nemanja Ivanovic wrote: > Hi Michael, > this turns out to be an assert failure: > > clang/tools/clang-scan-deps/ClangScanDeps.cpp:340: const > clang::tooling::dependencies::ModuleDeps& FullDeps::lookup > ModuleDeps(clang::tooling::dependencies::ClangModuleDep): Ass

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:189 + setOperationAction(Op, T, Legal); +} + Just curious, what gets a

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 234113. lildmh marked 28 inline comments as done. lildmh added a comment. Rebase and address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files: clang/include/clang/AST/OpenMPClause.h clang/li

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. I'll split the patch into 2 later Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7388 - llvm::Value *getExprTypeSize(const Expr *E) const { + llvm::Value *getExprTypeSize(const Expr *E, bool hasMapper) const { QualType ExprTy = E->getType().getCano

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

tlively marked an inline comment as done. tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:189 + setOperationAction(Op, T, Legal); +} + aheejin wrote: > Just curious, what gets assigned we don't do th

[PATCH] D71476: [OpenCL] Add builtin function extension handling

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/lib/Sema/OpenCLBuiltins.td:51 +// Extension associated to a builtin function. +class FunctionExtension : AbstractExtension<_Ext>; +

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t image, int coord, int lod, float4 color);

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

Hi John, The lldb bot went red after your clang AST changes landed: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4801/changes#detail0 All of the test failures were due to a clang assertion: Assertion fail

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a93756dfbb0: [WebAssembly] Replace SIMD int min/max builtins with patterns (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71500/new/

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

On 16 Dec 2019, at 15:07, Vedant Kumar wrote: Hi John, The lldb bot went red after your clang AST changes landed: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4801/changes#detail0 All of the test failur

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy &Sizes) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, &MapperQualifierLoc, - &MapperIdInfo)

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1783363 , @probinson wrote: > > Hmm, maybe this feature/suggestion is broken or at least not exactly > > awesome when it comes to auto-returning functions that are eventually > > void-returning functions? Now the funct

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked 5 inline comments as done. lildmh added a comment. Alexey, thanks for the review Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy &Sizes) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, &Map

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

efriedma added a comment. I'm not sure it's legal to transform a non-faulting load to a load with a non-faulting flag? At least, we'd need to consider the implications of that very carefully. In particular, I'm concerned about the interaction with intrinsics that read/write FFR. I mean, you

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy &Sizes) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, &MapperQualifierLoc, - &MapperIdInfo)

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

dblaikie added a comment. Do you have any particular users/use case for this? Might be best as two separate patches (one for the LLVM change, one for the Clang change) with tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://r

[clang] b1e542f - [NFC-I] Remove hack for fp-classification builtins

Author: Erich Keane Date: 2019-12-16T12:22:55-08:00 New Revision: b1e542f302c1ed796ad9f703d4d36e010afcb914 URL: https://github.com/llvm/llvm-project/commit/b1e542f302c1ed796ad9f703d4d36e010afcb914 DIFF: https://github.com/llvm/llvm-project/commit/b1e542f302c1ed796ad9f703d4d36e010afcb914.diff L

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang updated this revision to Diff 234125. akhuang marked 8 inline comments as done. akhuang added a comment. - Added docs for __ptr32, __ptr64, __sptr, __utr - Moved some functions into ASTContext - and addressed other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

efriedma added a comment. My primary concern with this is that I'm not sure you should be passing this information separately, as opposed to encoding it into the bitcode. On ARM, the ABI for a file is generally derived from the target triple. For example, "arm-eabi" is soft-float, "arm-eabihf"

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang added inline comments. Comment at: clang/include/clang/AST/Type.h:477-479 + ((isPtrSizeAddressSpace(A) && B == LangAS::Default) || +(isPtrSizeAddressSpace(B) && A == LangAS::Default) || +(isPtrSizeAddressSpace(A) && isPtrSizeAddressSpace(

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

On 16 Dec 2019, at 15:11, John McCall wrote: On 16 Dec 2019, at 15:07, Vedant Kumar wrote: Hi John, The lldb bot went red after your clang AST changes landed: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4801/changes#detail0

[clang] 803403a - Fix a bug in the property-based serialization of

Author: John McCall Date: 2019-12-16T16:08:09-05:00 New Revision: 803403afc83f659be1c620eb1896dcf704b18b0a URL: https://github.com/llvm/llvm-project/commit/803403afc83f659be1c620eb1896dcf704b18b0a DIFF: https://github.com/llvm/llvm-project/commit/803403afc83f659be1c620eb1896dcf704b18b0a.diff L

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. Most probably, we can use this solution without adding a new expression. `DeclRefExpr` class can contain 2 decls: FoundDecl and the Decl being used. You can use FoundDecl to point to the original function and used decl to point to the function being called in this conte

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille created this revision. serge-sans-paille added a reviewer: erik.pilkington. serge-sans-paille added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. Implement a pessimistic evaluator of the minimal required size for a buffer based on the format string, and co

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk updated this revision to Diff 234136. vsk marked 3 inline comments as done. vsk added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 Files: clang/docs/UndefinedBehaviorSanitizer.rst clang/include/clan

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:953 + SanitizerKind::ImplicitConversion | SanitizerKind::Nullability | + SanitizerKind::LocalBounds | SanitizerKind::ObjCCast; if (getTriple().getArch() == llvm::Triple::x86 || del

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk updated this revision to Diff 234139. vsk added a comment. Avoid a static initializer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 Files: clang/docs/UndefinedBehaviorSanitizer.rst clang/include/clang/Basic/Sanitizers.def clang/lib/

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk updated this revision to Diff 234142. vsk added a comment. Ignore an objc-cast report at a given SourceLocation after it's been reported once. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 Files: clang/docs/UndefinedBehaviorSanitizer.rs

[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

sbc100 updated this revision to Diff 234144. sbc100 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71493/new/ https://reviews.llvm.org/D71493 Files: clang/lib/Sema/SemaDeclAttr.cpp clang/test/CodeGen/wasm-export-name.c

[clang] 3f22b47 - Revert "[NFC-I] Remove hack for fp-classification builtins"

Author: Erich Keane Date: 2019-12-16T14:01:51-08:00 New Revision: 3f22b4721e6c9859c392d9891411cbc8d9e10c70 URL: https://github.com/llvm/llvm-project/commit/3f22b4721e6c9859c392d9891411cbc8d9e10c70 DIFF: https://github.com/llvm/llvm-project/commit/3f22b4721e6c9859c392d9891411cbc8d9e10c70.diff L

[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

sunfish added inline comments. Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:725 TOut.emitExportName(WasmSym, ExportName); + Out.EmitSymbolAttribute(WasmSym, MCSA_NoDeadStrip); } It feels like this is a little inconsi

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

rnk added a comment. From auditing the call sites, it seems that almost all of them could be simplified by using the new API: http://llvm-cs.pcc.me.uk/tools/clang/lib/Basic/FileManager.cpp/rgetCanonicalName Comment at: clang/include/clang/Basic/FileManager.h:226 /// The can

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

mstorsjo created this revision. mstorsjo added reviewers: rnk, froydnj, compnerd. Herald added a project: clang. On Windows, weak_odr is a no-op, and thus a weak_odr tls wrapper function can result in linker errors due to multiply defined symbols. Therefore, use linkonce_odr instead of weak_odr

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

rnk added a comment. In D70527#1785552 , @ikudrin wrote: > Personally, I would prefer to see the file name and path to be changed as > little as possible because that would help to recognize the files better. We > cannot use `remove_dots()` on POSIX OSes

[PATCH] D71400: [RFC] [MinGW] Implicitly add .exe suffix if not provided

mstorsjo added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71400/new/ https://reviews.llvm.org/D71400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

mstorsjo added a comment. Actually, this doesn't seem to be enough for the case at hand (used with `-ffunction-sections -fdata-sections`), I'll have to continue looking into it tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71572/new/ ht

[PATCH] D71400: [RFC] [MinGW] Implicitly add .exe suffix if not provided

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71400/new/ https://reviews.llvm.org/D71400 ___ cfe-commits mailing list cfe-commit

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

rnk added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2519-2520 return VarLinkage; + // On Windows, WeakODR is a no-op, boiling down to the same as normal external + // linkage. + if (CGM.getTriple().isOSWindows()) I would say that

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2519-2520 return VarLinkage; + // On Windows, WeakODR is a no-op, boiling down to the same as normal external + // linkage. + if (CGM.getTriple().

[clang] 376cf43 - [coroutines][PR41909] Generalize fix from D62550

Author: Brian Gesiak Date: 2019-12-16T17:43:04-05:00 New Revision: 376cf43729c8025eecbd2969522c5687f2a3919f URL: https://github.com/llvm/llvm-project/commit/376cf43729c8025eecbd2969522c5687f2a3919f DIFF: https://github.com/llvm/llvm-project/commit/376cf43729c8025eecbd2969522c5687f2a3919f.diff

[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

sbc100 marked an inline comment as done. sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:725 TOut.emitExportName(WasmSym, ExportName); + Out.EmitSymbolAttribute(WasmSym, MCSA_NoDeadStrip); } ---

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen added a comment. > It will still crash for something like `target simd`, need to move the code > around a little bit, move it out of `if`. I tried making `target simd ` crash but it seems work (target_simd_ast_print.cpp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen updated this revision to Diff 234157. cchen added a comment. Apply @ABataev's patch, add some code to support the patch and some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71475/new/ https://reviews.llvm.org/D71475 Files: clang/li

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

aprantl added a comment. Thanks. This is good to go! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71201/new/ https://reviews.llvm.org/D71201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

This revision was automatically updated to reflect the committed changes. Closed by commit rG376cf43729c8: [coroutines][PR41909] Generalize fix from D62550 (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://rev

[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

sbc100 updated this revision to Diff 234160. sbc100 added a comment. - revert part Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71493/new/ https://reviews.llvm.org/D71493 Files: clang/lib/Sema/SemaDeclAttr.cpp clang/test/CodeGen/wasm-export-n

[clang] 0a1e349 - [WebAssembly] Setting export_name implies llvm.used

Author: Sam Clegg Date: 2019-12-16T14:48:38-08:00 New Revision: 0a1e349a7933f7880971533175e11b4bfd22bd53 URL: https://github.com/llvm/llvm-project/commit/0a1e349a7933f7880971533175e11b4bfd22bd53 DIFF: https://github.com/llvm/llvm-project/commit/0a1e349a7933f7880971533175e11b4bfd22bd53.diff LOG

[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a1e349a7933: [WebAssembly] Setting export_name implies llvm.used (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71493/new/ https://rev

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

rnk added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2519-2520 return VarLinkage; + // On Windows, WeakODR is a no-op, boiling down to the same as normal external + // linkage. + if (CGM.getTriple().isOSWindows()) mstorsjo wrote:

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

Thanks John, the bot has recovered. > On Dec 16, 2019, at 1:08 PM, John McCall via cfe-commits > wrote: > > On 16 Dec 2019, at 15:11, John McCall wrote: >> On 16 Dec 2019, at 15:07, Vedant Kumar wrote: >>> Hi John, >>> >>> The lldb bot went red after your clang AST changes landed: >>> http://

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

aprantl added a comment. Are we sure we want to canonicalize *before* applying -fdebug-prefix-map in `remapDIPath()`? Honest question, the answer could be yes :-) Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:412 + if (!llvm::sys::path::is_absolute(FileName)) { + FileN

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks great to me. This has the potential to break some existing code, though. I would suggest either landing it early in the day, watching for breakage, and hoping for the best, or you could try b

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

dblaikie added a comment. In D71508#1786212 , @kamleshbhalui wrote: > In D71508#1786148 , @probinson wrote: > > > In D71508#1786122 , @kamleshbhalui > > wrote: > > > > > In

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

dblaikie added a comment. Yeah, this is working around a more fundamental representational issue. Like member function templates, member variable templates shouldn't be pre-emptively built or ever appear in the "members" list of the type (because that list isn't closed - we don't know what inst

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

modocache added a comment. Thanks for the review! Much appreciated :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://reviews.llvm.org/D70579 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D71576: [c++20] Add deprecation warnings for the expression forms deprecated by P1120R0.

rsmith created this revision. rsmith added reviewers: aaron.ballman, rnk. Herald added a project: clang. This covers: - usual arithmetic conversions (comparisons, arithmetic, conditionals) between different enumeration types - usual arithmetic conversions between enums and floating-point types -

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym updated this revision to Diff 234174. sidneym added a comment. Remove quotes. Also add ld.lld file so that configurations that don't enable lld will still pass this test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://re

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. Noting another issue we found in local testing (with an older version of this patch). This interacts badly with the implicit exception mechanism in LLVM. For that mechanism, we end up generating assembly which looks more or less like this: Ltmp: cmp %rsi, (%rdi) j

[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added a comment. Haven't looked into too many details yet but made some suggestions anyway... Comment at: llvm/include/llvm/MC/MCFragment.h:634 + + uint64_t getBoundarySize() const { +return AlignBoundarySize; Store AlignBoundarySize as a shift val

[PATCH] D71503: New warning on for-loops that never run because condition is false on the first iteration

rtrieu added a comment. In D71503#1784697 , @lebedev.ri wrote: > Thank you for working on this! > This seems to be missing tests. My bad, still getting used to git. Updated with a test now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71503/

[PATCH] D71576: [c++20] Add deprecation warnings for the expression forms deprecated by P1120R0.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I have no blocking concerns, just some idle thoughts. Up to you if you want Aaron's feedback before landing. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6235 + "

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman created this revision. arphaman added reviewers: steven_wu, dexonsmith. Herald added subscribers: llvm-commits, ributzka, jkorous. Herald added projects: clang, LLVM. In Xcode 11, ld added a new flag called `-platform_version` that can be used instead of the old `-_version_min` flags. Th

[PATCH] D71503: New warning on for-loops that never run because condition is false on the first iteration

rtrieu updated this revision to Diff 234180. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71503/new/ https://reviews.llvm.org/D71503 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D70157: Align branches within 32-Byte boundary

chandlerc added a comment. Just wanted to say thanks for the performance data! I know it was hard to get, but it is really, really useful to help folks evaluate these kinds of changes with actual data around the options available. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

steven_wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339 // Add the deployment target. - MachOTC.addMinVersionArgs(Args, CmdArgs); + if (!Version[0] || Version[0] >= 520) +MachOTC.addPlatformVersionArgs(Args, CmdArgs); Why

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman marked 2 inline comments as done. arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339 // Add the deployment target. - MachOTC.addMinVersionArgs(Args, CmdArgs); + if (!Version[0] || Version[0] >= 520) +MachOTC.addPlatformVersion

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1786530 , @ABataev wrote: > Most probably, we can use this solution without adding a new expression. > `DeclRefExpr` class can contain 2 decls: FoundDecl and the Decl being used. > You can use FoundDecl to point to th

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

rnk added a comment. Thanks! I made some comments. This code is convoluted. I don't think I can reason through all the edge cases, but this seems like an improvement. I'd suggest adding the recommended tests and any other corner case inputs you can think of, and after another round of review we

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

steven_wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2530 + return "ios"; +// FIXME: Add macCatalyst support here ("\"mac catalyst\""). +llvm_unreachable("macCatalyst isn't yet supported"); arphaman wrote: > steven_wu w

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked 4 inline comments as done. lildmh added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy &Sizes) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, &MapperQualifierLoc, -

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2530 + return "ios"; +// FIXME: Add macCatalyst support here ("\"mac catalyst\""). +llvm_unreachable("macCatalyst isn't yet supported");

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

dblaikie added subscribers: JDevlieghere, aprantl. dblaikie added a comment. Yeah, GCC's debug info for this is... not good. I don't think it's anything we'd need to be inspired by. Here's the tags and names: DW_TAG_compile_unit DW_AT_name ("templ2.cpp") DW_TAG_structure_type D

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. SGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

jdoerfert added a comment. In D71475#1784312 , @cchen wrote: > In D71475#1784284 , @jdoerfert wrote: > > > What is the output when you run the example with `k` in `lastprivate` or > > `reduction`? > > > I actually

[PATCH] D71566: New checks for fortified sprintf

erik.pilkington added a comment. Thanks for working on this! I think this would be a really useful diagnostic to have. Comment at: clang/lib/Sema/SemaChecking.cpp:311 } +class EstimateSizeFormatHandler +: public analyze_format_string::FormatStringHandler { ---

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked an inline comment as done. skan added inline comments. Comment at: llvm/lib/MC/MCFragment.cpp:426 + case MCFragment::FT_MachineDependent: { +const MCMachineDependentFragment *MF = +cast(this); MaskRay wrote: > `const auto *`. The type is

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

delcypher added inline comments. Comment at: compiler-rt/lib/ubsan/ubsan_value.cpp:29 +const char *__ubsan::getObjCClassName(ValueHandle Pointer) { +#if defined(__APPLE__) + // We need to query the ObjC runtime for some information, but do not want vsk wrote: >

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

xinxinw1 created this revision. xinxinw1 added reviewers: beanz, phosek, xiaobai, smeenai. Herald added a project: clang. Herald added a subscriber: cfe-commits. With %p, each test file that we're using to generate profile data will make its own profraw file which is around 60 MB in size. If we h

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. Here are the minutes from our phone call a few minutes ago. Attendees: Andy Kaylor, Craig Topper, Annita Zhang, Tom Stellard, Chandler Carruth, Fedor Sergeev, Philip Reames, Yuanake Luo Status Summary == Performance data has been posted to llvm-dev. We had

[clang] 4e9f137 - If constant evaluation fails due to an unspecified pointer comparison,

Author: Richard Smith Date: 2019-12-16T17:49:45-08:00 New Revision: 4e9f1379b9cd7ddce8cf182707e976ebceb72b05 URL: https://github.com/llvm/llvm-project/commit/4e9f1379b9cd7ddce8cf182707e976ebceb72b05 DIFF: https://github.com/llvm/llvm-project/commit/4e9f1379b9cd7ddce8cf182707e976ebceb72b05.diff

[clang] 4b00299 - [c++20] Add deprecation warnings for the expression forms deprecated by P1120R0.

Author: Richard Smith Date: 2019-12-16T17:49:45-08:00 New Revision: 4b0029995853fe37d1dc95ef96f46697c743fcad URL: https://github.com/llvm/llvm-project/commit/4b0029995853fe37d1dc95ef96f46697c743fcad DIFF: https://github.com/llvm/llvm-project/commit/4b0029995853fe37d1dc95ef96f46697c743fcad.diff

[PATCH] D71576: [c++20] Add deprecation warnings for the expression forms deprecated by P1120R0.

rsmith closed this revision. rsmith marked 4 inline comments as done. rsmith added a comment. Committed as rG4b0029995853fe37d1dc95ef96f46697c743fcad . Comment at: clang/lib/AST/Type.cpp:1865-1866 // enume

[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added a comment. In D70157#1787139 , @reames wrote: > Here are the minutes from our phone call a few minutes ago. > > Attendees: Andy Kaylor, Craig Topper, Annita Zhang, Tom Stellard, Chandler > Carruth, Fedor Sergeev, Philip Reames, Yuanake Luo

[clang] eea8ba0 - Check whether the destination is a complete type in a static_cast (or

Author: Richard Smith Date: 2019-12-16T18:33:35-08:00 New Revision: eea8ba097c4a86632b88291bea51eb710f8ae4fb URL: https://github.com/llvm/llvm-project/commit/eea8ba097c4a86632b88291bea51eb710f8ae4fb DIFF: https://github.com/llvm/llvm-project/commit/eea8ba097c4a86632b88291bea51eb710f8ae4fb.diff

[PATCH] D71586: [clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST

arphaman created this revision. arphaman added reviewers: sammccall, jkorous. Herald added subscribers: usaxena95, ributzka, kadircet, dexonsmith, MaskRay, ilya-biryukov. Herald added a project: clang. This patch adds a test case that verifies that `-fmodules -fimplicit-modules` work in Clangd w

<    1   2   3   >