[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1780597 , @cameron.mcinally wrote: > I don't see a problem with this, but it would be nice to make the > `-f[no-]trapping-math` command line option work. GNU compatibility is good. Thanks Cameron, I'll go that way R

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

rnk marked 2 inline comments as done. rnk added a comment. Thanks, I split off the rename and landed it separately, since it is more mechanical. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71320/new/ https://reviews.llvm.org/D71320 __

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

thakis added a comment. Any reason these are called .h? All our other tablegen outputs are called .inc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71320/new/ https://reviews.llvm.org/D71320 ___ cfe-

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

shiva0217 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1525 unsigned TwoXLenInBytes = (2 * XLen) / 8; if (!IsFixed && ArgFlags.getOrigAlign() == TwoXLenInBytes && DL.getTypeAllocSize(OrigTy) == TwoXLenInBytes) { lena

[clang] 4cfb91f - [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

Author: Gabor Marton Date: 2019-12-12T14:22:52+01:00 New Revision: 4cfb91f1ef1b136f82015b792d6f1fafd47fd437 URL: https://github.com/llvm/llvm-project/commit/4cfb91f1ef1b136f82015b792d6f1fafd47fd437 DIFF: https://github.com/llvm/llvm-project/commit/4cfb91f1ef1b136f82015b792d6f1fafd47fd437.diff

[PATCH] D71413: [OpenMP][Test] Add check for aux-triple predefined macros

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71413/new/ https://reviews.llvm.org/D71413 __

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cfb91f1ef1b: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools (authored by martong). Changed prior to commit: https://reviews.llvm.org/D70439?vs=232540&id=233590#toc Repository: rG LL

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I'll land this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872 __

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

MForster added a comment. In D70872#1781703 , @sammccall wrote: > Thanks! I'll land this for you. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70872/new/ https://reviews.llvm.org/D70872 __

[PATCH] D71414: [clangd] Introduce codeblocks

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Follow-up to the patch D71248 Repository: rG LLVM Github Monorepo

[PATCH] D71414: [clangd] Introduce codeblocks

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , diff.json

[clang] 9c8cfa0 - [Diagnsotics] Small Improvement on -Wmisleading-indentation

Author: Tyker Date: 2019-12-12T14:52:47+01:00 New Revision: 9c8cfa09d762a307bae55b75b621cbc53f4a3b3b URL: https://github.com/llvm/llvm-project/commit/9c8cfa09d762a307bae55b75b621cbc53f4a3b3b DIFF: https://github.com/llvm/llvm-project/commit/9c8cfa09d762a307bae55b75b621cbc53f4a3b3b.diff LOG: [D

[clang-tools-extra] d6417f5 - [clangd] Implement "textDocument/documentLink" protocol support

Author: Michael Forster Date: 2019-12-12T14:55:20+01:00 New Revision: d6417f5584aa7673fa0212029a96cc9cacb1aad5 URL: https://github.com/llvm/llvm-project/commit/d6417f5584aa7673fa0212029a96cc9cacb1aad5 DIFF: https://github.com/llvm/llvm-project/commit/d6417f5584aa7673fa0212029a96cc9cacb1aad5.dif

[PATCH] D70872: [clangd] Implement "textDocument/documentLink" protocol support

This revision was automatically updated to reflect the committed changes. Closed by commit rGd6417f5584aa: [clangd] Implement "textDocument/documentLink" protocol support (authored by MForster, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D71083: [Diagnsotics] Small Improvement on -Wmisleading-indentation

This revision was automatically updated to reflect the committed changes. Tyker marked an inline comment as done. Closed by commit rG9c8cfa09d762: [Diagnsotics] Small Improvement on -Wmisleading-indentation (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D71414: [clangd] Introduce codeblocks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:138 +// No need to pad from previous blocks, as they should end with a new line. +OS << renderCodeBlock(Contents, Language) << '\n'; + } can you inline renderCodeBl

[PATCH] D71414: [clangd] Introduce codeblocks

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Otherwise LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71414/new/ https://reviews.llvm.org/D71414 _

[PATCH] D71414: [clangd] Introduce codeblocks

kadircet updated this revision to Diff 233606. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71414/new/ https://reviews.llvm.org/D71414 Files: clang-tools-ex

[PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, rsmith, compnerd, phosek. Disable the instantiation-depth-default.cpp test on NetBSD since it requires more stack space than we have by default on NetBSD. https://reviews.llvm.org/D71419 Files: clang/test/SemaTemplate/instanti

[PATCH] D71414: [clangd] Introduce codeblocks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:138 +// No need to pad from previous blocks, as they should end with a new line. +OS << renderCodeBlock(Contents, Language) << '\n'; + } sammccall wrote: > can you i

[PATCH] D71420: [Alignment][NFC] Adding Align compatible methods to IntrinsicInst/IRBuilder

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type. See this thread for context: http://lists.llvm.org/pipermail/

[PATCH] D71199: [clang-tidy][WIP] New check readability-prefer-initialization-list

Eugene.Zelenko added a comment. > This check is to enforce C++ core guideline C.49 while the modernize check > enforces guideline C.48. The two must be synchronized, and I think that this > new check should do that: for initializations that should be done using > in-class initializers accordin

[clang] 2d6a5e4 - [OpenMP][Test] Add check for aux-triple predefined macros

Author: Alexey Bader Date: 2019-12-12T14:36:11+03:00 New Revision: 2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d URL: https://github.com/llvm/llvm-project/commit/2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d DIFF: https://github.com/llvm/llvm-project/commit/2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d.diff

[PATCH] D71413: [OpenMP][Test] Add check for aux-triple predefined macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d6a5e4fe45d: [OpenMP][Test] Add check for aux-triple predefined macros (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71413/new/ https:

[PATCH] D71414: [clangd] Introduce codeblocks

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60768 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[clang] 600d123 - [ARM][CMSE] Add CMSE header and builtins

Author: Momchil Velikov Date: 2019-12-12T15:01:14Z New Revision: 600d123c6ff16180a20ebb9b55476257bf69513a URL: https://github.com/llvm/llvm-project/commit/600d123c6ff16180a20ebb9b55476257bf69513a DIFF: https://github.com/llvm/llvm-project/commit/600d123c6ff16180a20ebb9b55476257bf69513a.diff LO

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + jdoerfert wrote: > ABataev wrote: > > jdoerfert wrote: > > > A

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

tejohnson added inline comments. Comment at: clang/test/CodeGen/libcalls-fno-builtin.c:163 -// CHECK: [[ATTR]] = { nobuiltin } +// GLOBAL: #2 = { nobuiltin "no-builtins" } +// INDIVIDUAL: #2 = { nobuiltin "no-builtin-ceil" "no-builtin-copysign" "no-builtin-cos" "no-builtin-fab

[clang] dbc5acf - [Alignment][NFC] Adding Align compatible methods to IntrinsicInst/IRBuilder

Author: Guillaume Chatelet Date: 2019-12-12T16:22:15+01:00 New Revision: dbc5acf8ce8ae7b9adfa61e8133b50f2b82e4cde URL: https://github.com/llvm/llvm-project/commit/dbc5acf8ce8ae7b9adfa61e8133b50f2b82e4cde DIFF: https://github.com/llvm/llvm-project/commit/dbc5acf8ce8ae7b9adfa61e8133b50f2b82e4cde.

[PATCH] D71420: [Alignment][NFC] Adding Align compatible methods to IntrinsicInst/IRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbc5acf8ce8a: [Alignment][NFC] Adding Align compatible methods to IntrinsicInst/IRBuilder (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: clang/test/CodeGen/libcalls-fno-builtin.c:163 -// CHECK: [[ATTR]] = { nobuiltin } +// GLOBAL: #2 = { nobuiltin "no-builtins" } +// INDIVIDUAL: #2 = { nobuiltin "no-builtin-ceil" "no-builtin

[clang-tools-extra] 2b09390 - Fix naming style. NFC.

Author: Alexander Kornienko Date: 2019-12-12T17:00:57+01:00 New Revision: 2b09390c136247b42c1b54f42ce925e31d51062a URL: https://github.com/llvm/llvm-project/commit/2b09390c136247b42c1b54f42ce925e31d51062a DIFF: https://github.com/llvm/llvm-project/commit/2b09390c136247b42c1b54f42ce925e31d51062a

[clang-tools-extra] 65996c3 - [clang-tidy] Use early returns to make the code easier to read and potentially run faster

Author: Alexander Kornienko Date: 2019-12-12T17:00:57+01:00 New Revision: 65996c302a4472e597780c99bd834f9bf8978712 URL: https://github.com/llvm/llvm-project/commit/65996c302a4472e597780c99bd834f9bf8978712 DIFF: https://github.com/llvm/llvm-project/commit/65996c302a4472e597780c99bd834f9bf8978712

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

tejohnson added a comment. In D68213#1781436 , @zapster wrote: > Thanks again for you reviews! Since I do not have commit rights, I would be > grateful if someone could push it for me. The new LTO/X86/embed-bitcode.ll test is failing for me: llvm-lto2:

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

martong marked 2 inline comments as done. martong added a comment. In D70819#1781678 , @martong wrote: > In D70819#170 , @shafik wrote: > > > Apologies for wacky C++ code that follows but will this also work for

[clang] 0508c99 - [clang] Turn -fno-builtin flag into an IR Attribute

Author: Guillaume Chatelet Date: 2019-12-12T17:21:12+01:00 New Revision: 0508c994f0b14144041f2cfd3ba9f9a80f03de08 URL: https://github.com/llvm/llvm-project/commit/0508c994f0b14144041f2cfd3ba9f9a80f03de08 DIFF: https://github.com/llvm/llvm-project/commit/0508c994f0b14144041f2cfd3ba9f9a80f03de08.

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1780715 , @jdoerfert wrote: > In D71241#1779097 , @ABataev wrote: > > > In D71241#1778963 , @jdoerfert > > wrote: > > > > > In D71241#1778

[PATCH] D71193: [clang] Turn -fno-builtin flag into an IR Attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG0508c994f0b1: [clang] Turn -fno-builtin flag into an IR Attribute (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71193/new/ https://

[PATCH] D71422: [clangd] Introduce bulletlists

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71422 Files: clang-tools-extra/clan

[PATCH] D71422: [clangd] Introduce bulletlists

merge_guards_bot added a comment. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt , diff.json

[clang] 25234fd - [ASTImporter] Support functions with placeholder return types ...

Author: Gabor Marton Date: 2019-12-12T17:49:03+01:00 New Revision: 25234fd69e32e51bc800686075265f535d69d990 URL: https://github.com/llvm/llvm-project/commit/25234fd69e32e51bc800686075265f535d69d990 DIFF: https://github.com/llvm/llvm-project/commit/25234fd69e32e51bc800686075265f535d69d990.diff

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG25234fd69e32: [ASTImporter] Support functions with placeholder return types ... (authored by martong). Changed prior to commit: https://reviews.llvm.org/D70819?

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/ExternalASTSource.h:69 - /// Whether this AST source also provides information for - /// semantic analysis. - bool SemaSource =

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas updated this revision to Diff 233638. ztamas added a comment. Update code based on reviewer comments. - Remove spurious semicolon. - Add tests about plain char. - Extend documentation describing how to control char signdness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas updated this revision to Diff 233643. ztamas marked 2 inline comments as done. ztamas added a comment. Add newlines to the end of the files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71174/new/ https://reviews.llvm.org/D71174 Files: c

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + ABataev wrote: >

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, that looks much better. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org/D7 ___ cfe-com

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + jdoerfert wrote: > ABataev wrote: > > jdoerfert wrote: > > > A

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1781955 , @ABataev wrote: > In D71241#1780715 , @jdoerfert wrote: > > > In D71241#1779097 , @ABataev wrote: > > > > > In D71241#1778963 <

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster updated this revision to Diff 233652. zapster added a comment. > The new LTO/X86/embed-bitcode.ll test is failing for me Should be fixed now, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 Files: clang/lib/CodeGen/BackendUtil

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782157 , @jdoerfert wrote: > In D71241#1781955 , @ABataev wrote: > > > In D71241#1780715 , @jdoerfert > > wrote: > > > > > In D71241#1779

[PATCH] D71393: Default to -fuse-init-array

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. +1, the list of exceptions that will use .ctors is smaller than the list of platforms that default to init_array. And in general, I support anything that reduces the length of -cc1 command lines for

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

shafik added a comment. In D71378#1781616 , @teemperor wrote: > I wonder if we have a way to fix this from with LLDB. Having Clang code that > is only tested in LLDB is always a bit weird. > > Otherwise the idea itself LGTM, thanks for working on this (an

[PATCH] D71272: [OpenCL] Pretty print __private addr space

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71272/new/ https://reviews.llvm.org/D71272 ___ cfe-commits mailing list cfe-commits@

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille updated this revision to Diff 233648. serge-sans-paille added a comment. Improve test case portability. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 Files: clang/include/clang/AST/Dec

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

nickdesaulniers added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:651 + continue; +for (const auto &label : as->labels()) { + const LabelStmt *ls = label->getLabel()->getStmt(); Is this

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

rnk added a comment. In D71320#1780805 , @thakis wrote: > Any reason these are called .h? All our other tablegen outputs are called > .inc. Yes, they have header guards, they are not textual. Most other tablegen outputs are intended to be used with som

[clang] b2b5cac - Default to -fuse-init-array

Author: Fangrui Song Date: 2019-12-12T10:32:56-08:00 New Revision: b2b5cac3ec07782b917b2816f175da682723cd49 URL: https://github.com/llvm/llvm-project/commit/b2b5cac3ec07782b917b2816f175da682723cd49 DIFF: https://github.com/llvm/llvm-project/commit/b2b5cac3ec07782b917b2816f175da682723cd49.diff

[PATCH] D71393: Default to -fuse-init-array

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2b5cac3ec07: Default to -fuse-init-array (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D71393?vs=233503&id=233655#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + ABataev wrote: >

[PATCH] D71400: [RFC] [MinGW] Implicitly add .exe suffix if not provided

rnk added inline comments. Comment at: clang/lib/Driver/ToolChains/MinGW.cpp:164 + const char *OutputFile = Output.getFilename(); +#ifdef _WIN32 + if (!llvm::sys::path::filename(OutputFile).contains('.')) Can you add what you wrote in the commit message as a co

[PATCH] D71393: Default to -fuse-init-array

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2786-2799 bool UseInitArrayDefault = getTriple().getArch() == llvm::Triple::aarch64 || getTriple().getArch() == llvm::Triple::aarch64_be ||

[clang] bcae3a7 - [PS4] Predefine the __SCE__ macro for the x86_64-scei-ps4 triple

Author: Warren Ristow Date: 2019-12-12T11:00:09-08:00 New Revision: bcae3a77afd171604d117393d8cb92dfca2da8bb URL: https://github.com/llvm/llvm-project/commit/bcae3a77afd171604d117393d8cb92dfca2da8bb DIFF: https://github.com/llvm/llvm-project/commit/bcae3a77afd171604d117393d8cb92dfca2da8bb.diff

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

hfinkel added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + jdoerfert wrote: > ABataev wrote: > > jdoerfert wrote: > > > A

[PATCH] D71427: Move TypeSourceInfo to Type.h

rnk created this revision. rnk added a reviewer: rsmith. Herald added a project: clang. TypeSourceInfo is a thin wrapper around TypeLocs. Notionally, the best place for it to live would be TypeLoc.h, but Decl.h requires it to be complete, so it needs to be lower in the dependency graph. Type.h see

[clang] 654c0da - Suppress -Wwarn-unused-variables when we don't know the constructor

Author: Erich Keane Date: 2019-12-12T11:34:17-08:00 New Revision: 654c0daef75a41eede06b413a5ecdd8ad2640240 URL: https://github.com/llvm/llvm-project/commit/654c0daef75a41eede06b413a5ecdd8ad2640240 DIFF: https://github.com/llvm/llvm-project/commit/654c0daef75a41eede06b413a5ecdd8ad2640240.diff L

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1782173 , @ABataev wrote: > In D71241#1782157 , @jdoerfert wrote: > > > In D71241#1781955 , @ABataev wrote: > > > > > In D71241#1780715 <

[PATCH] D71428: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES

xinxinw1 created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. I want to pass some CMake cache files in CLANG_BOOTSTRAP_CMAKE_ARGS as `-C .cmake` arguments. I want to be able to use the values of the bootstrap passthrough variables in the cache file

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782317 , @jdoerfert wrote: > In D71241#1782173 , @ABataev wrote: > > > In D71241#1782157 , @jdoerfert > > wrote: > > > > > In D71241#1781

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:51 + /// at the time, and location, the callback is invoked. + using FinalizeCallbackTy = std::function; + hfinkel wrote: >

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. >> In fact, the current solution will disregard the `used` attribute here and >> not emit the function, which is bad. The Sema solution will dispatch the >> right calls and honor the `used` attribute properly. > > Nope, the function is emitted but as an alias to the f

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782317 , @jdoerfert wrote: > In D71241#1782173 , @ABataev wrote: > > > In D71241#1782157 , @jdoerfert > > wrote: > > > > > In D71241#1781

[PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71419/new/ https://reviews.llvm.org/D71419 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar added a comment. After thinking about this more, do we want to even try to support the BUILD_SHARED=ON + CLANG_LINK_CLANG_DYLIB=ON configuration? We don't support this in llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ ht

[clang] 0ee89c1 - [OPENMP50]Improve checks for declare variant functions compatibility.

Author: Alexey Bataev Date: 2019-12-12T15:18:19-05:00 New Revision: 0ee89c1bad8cef81725ef892d60b4aa254d84744 URL: https://github.com/llvm/llvm-project/commit/0ee89c1bad8cef81725ef892d60b4aa254d84744 DIFF: https://github.com/llvm/llvm-project/commit/0ee89c1bad8cef81725ef892d60b4aa254d84744.diff

[clang] c8e0bb3 - [LTO] Support for embedding bitcode section during LTO

Author: Teresa Johnson Date: 2019-12-12T12:34:19-08:00 New Revision: c8e0bb3b2c24ef59556d81a275fb1f5db64899d3 URL: https://github.com/llvm/llvm-project/commit/c8e0bb3b2c24ef59556d81a275fb1f5db64899d3 DIFF: https://github.com/llvm/llvm-project/commit/c8e0bb3b2c24ef59556d81a275fb1f5db64899d3.diff

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

ahatanak created this revision. ahatanak added reviewers: rjmccall, arphaman. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. Copy the block to the heap before passing it to the callee in case the block escapes in the callee. rdar://problem/55683462 Re

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rupprecht added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:444 +def warn_drv_experimental_fp_control_incomplete_opt : Warning< + "Support for floating point control option %0 is incomplete and experimental">, mibintc wrote

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

JonChesterfield added a comment. > Explain that you're replacing the function written by the user on the fly by > another one. If they accept it, go ahead. That's the observational effect of variants. Replacing is very similar to calling + inlining. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782425 , @JonChesterfield wrote: > > Explain that you're replacing the function written by the user on the fly > > by another one. If they accept it, go ahead. > > That's the observational effect of variants. Replacing

[clang] 5ad5258 - [OPENMP50]Fix possible conflict when emitting an alias for the functions

Author: Alexey Bataev Date: 2019-12-12T15:48:33-05:00 New Revision: 5ad52587ec182f03636649e2cb66a0a4d9ffeab2 URL: https://github.com/llvm/llvm-project/commit/5ad52587ec182f03636649e2cb66a0a4d9ffeab2 DIFF: https://github.com/llvm/llvm-project/commit/5ad52587ec182f03636649e2cb66a0a4d9ffeab2.diff

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

JonChesterfield added a comment. In D71241#1782427 , @ABataev wrote: > In D71241#1782425 , @JonChesterfield > wrote: > > > > Explain that you're replacing the function written by the user on the fly > > > by anoth

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782430 , @JonChesterfield wrote: > In D71241#1782427 , @ABataev wrote: > > > In D71241#1782425 , > > @JonChesterfield wrote: > > > > > >

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong marked an inline comment as done. martong added a comment. > Are you going to add any tests in the following patches? I don't have any tests for now, but in a later patch we can create them. Comment at: clang/lib/AST/ASTImporter.cpp:8043 + + Error VisitFunctionTypeLoc

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

george.burgess.iv added a comment. Just a few more nits, and this LGTM. Thanks again! IDK if Eli wanted to have another look at this; please wait until tomorrow before landing to give him time to comment. Comment at: clang/lib/AST/Decl.cpp:3006 +bool FunctionDecl::isInlineB

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

JonChesterfield added a comment. > https://clang.llvm.org/docs/InternalsManual.html#the-ast-library > > Faithfulness¶ > The AST intends to provide a representation of the program that is faithful > to the original source. That's pretty convincing. Repository: rG LLVM Github Monorepo C

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze created this revision. zukatsinadze added a reviewer: NoQ. zukatsinadze added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. This patch introduces a new checker: `alpha

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:334 + FromDC->lookup(FromNamed->getDeclName()); + if (std::find(FromLookup.begin(), FromLookup.end(), FromNamed) != + FromLookup.end()) a_sidorin wrote: >

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

martong updated this revision to Diff 233675. martong marked 4 inline comments as done. martong added a comment. Addressing Alexeis comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020 Files: clang/l

[PATCH] D71434: [Driver] Use .init_array for all gcc installations and simplify Generic_ELF -fno-use-init-array rules

MaskRay created this revision. MaskRay added reviewers: echristo, rnk, thakis. Herald added subscribers: cfe-commits, s.egerton, simoncook, fedor.sergeev, krytarowski, emaste, dschuff. Herald added a project: clang. D39317 made clang use .init_array when no gcc

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

andrew.w.kaylor added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:444 +def warn_drv_experimental_fp_control_incomplete_opt : Warning< + "Support for floating point control option %0 is incomplete and experimental">, rupprec

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1782460 , @JonChesterfield wrote: > > https://clang.llvm.org/docs/InternalsManual.html#the-ast-library > > > > Faithfulness¶ > > The AST intends to provide a representation of the program that is > > faithful to

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added a comment. `unique_ptr` is harder to get to work than it might appear at first blush :) Looking at the gcc 6 libstdc++ implementation as an example: the declared return type is not `T*`, but `unique_ptr::pointer`. The declaration of that is in turn: typedef typename _Pointer::ty

[PATCH] D71428: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES

smeenai added reviewers: beanz, phosek, compnerd, smeenai. smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71428/new/ https://reviews.llvm.

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

lhames added a comment. Side note: This https://reviews.llvm.org/D39111 seems related. The patch has languished as I have been busy with other work, but if it would be useful for you guys I'd be happy to try to land it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1779168 , @JonChesterfield wrote: > Lowering in sema or in codegen seems a standard phase ordering choice. There > will be pros and cons to both. > > I think prior art leans towards sema. Variants are loosely equivalent

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge updated this revision to Diff 233680. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://reviews.llvm.org/D71240 Files: clang-tools-ext

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge updated this revision to Diff 233681. nridge marked an inline comment as done. nridge added a comment. Fix a typo and address one remaining comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://reviews.llvm.org/D71240 Fil

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:278 +}); +for (const NamedDecl *D : Decls) { + Outer.add(D, Flags); sammccall wrote: > sammccall wrote: > > can we make this function return the decls,

[clang-tools-extra] ecaa936 - [clangd] Heuristically resolve dependent method calls

Author: Nathan Ridge Date: 2019-12-12T17:18:00-05:00 New Revision: ecaa9363303e811a051ebb6199e35e43319a699c URL: https://github.com/llvm/llvm-project/commit/ecaa9363303e811a051ebb6199e35e43319a699c DIFF: https://github.com/llvm/llvm-project/commit/ecaa9363303e811a051ebb6199e35e43319a699c.diff

<    1   2   3   >